Re: [edk2-devel] [PATCH v1] OvmfPkg: Use DxeRuntimeCapsuleLib from DxeCapsuleLibFmp in X64 builds
On 24/06/2019 12:15, Ard Biesheuvel wrote: > On Mon, 24 Jun 2019 at 12:33, Tomas Pilar wrote: >> Switching to this library enables capsule support for FMP devices. Simple >> tests show that a capsule with an embedded driver now updates using >> CapsuleApp. >> >> Cc: Jordan Justen >> Cc: Laszlo Ersek >> Cc: Ard Biesheuvel >> Signed-off-by: Tomas Pilar > I don't have a problem with this change unless it affects the code > size considerably. > > However, isn't this only useful for updating the firmware on PCI cards > from within a VM when they are passed through from the host to the > guest? I understand this is a useful test scenario for you, but at > least clarify this in the commit log. The library itself is tiny. The use case you describe is exactly what I am using at the moment. I can imagine that software testing FMP implementation APIs is also something that might be useful. I will clarify in the commit. > >> --- >> OvmfPkg/OvmfPkgX64.dsc | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc >> index 39ac791565..4c41e59a75 100644 >> --- a/OvmfPkg/OvmfPkgX64.dsc >> +++ b/OvmfPkg/OvmfPkgX64.dsc >> @@ -125,7 +125,7 @@ >> >> UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf >>BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf >>FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf >> - CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf >> + CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf >>DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf >> >> DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf >> >> PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf >> -- >> 2.17.2 >> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#42742): https://edk2.groups.io/g/devel/message/42742 Mute This Topic: https://groups.io/mt/32190482/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH v1] OvmfPkg: Use DxeRuntimeCapsuleLib from DxeCapsuleLibFmp in X64 builds
On Mon, 24 Jun 2019 at 12:33, Tomas Pilar wrote: > > Switching to this library enables capsule support for FMP devices. Simple > tests show that a capsule with an embedded driver now updates using > CapsuleApp. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Signed-off-by: Tomas Pilar I don't have a problem with this change unless it affects the code size considerably. However, isn't this only useful for updating the firmware on PCI cards from within a VM when they are passed through from the host to the guest? I understand this is a useful test scenario for you, but at least clarify this in the commit log. > --- > OvmfPkg/OvmfPkgX64.dsc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > index 39ac791565..4c41e59a75 100644 > --- a/OvmfPkg/OvmfPkgX64.dsc > +++ b/OvmfPkg/OvmfPkgX64.dsc > @@ -125,7 +125,7 @@ > > UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf >BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf >FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf > - CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > + CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf >DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf > > DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf > > PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf > -- > 2.17.2 > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#42741): https://edk2.groups.io/g/devel/message/42741 Mute This Topic: https://groups.io/mt/32190482/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
[edk2-devel] [PATCH v1] OvmfPkg: Use DxeRuntimeCapsuleLib from DxeCapsuleLibFmp in X64 builds
Switching to this library enables capsule support for FMP devices. Simple tests show that a capsule with an embedded driver now updates using CapsuleApp. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Signed-off-by: Tomas Pilar --- OvmfPkg/OvmfPkgX64.dsc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc index 39ac791565..4c41e59a75 100644 --- a/OvmfPkg/OvmfPkgX64.dsc +++ b/OvmfPkg/OvmfPkgX64.dsc @@ -125,7 +125,7 @@ UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf FileExplorerLib|MdeModulePkg/Library/FileExplorerLib/FileExplorerLib.inf - CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf + CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf DxeServicesTableLib|MdePkg/Library/DxeServicesTableLib/DxeServicesTableLib.inf PeCoffGetEntryPointLib|MdePkg/Library/BasePeCoffGetEntryPointLib/BasePeCoffGetEntryPointLib.inf -- 2.17.2 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#42740): https://edk2.groups.io/g/devel/message/42740 Mute This Topic: https://groups.io/mt/32190482/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
