Re: [edk2-devel] [PATCH v6 0/5] Build cache enhancement

2019-08-20 Thread Bob Feng
Pushed at  0e7e7a264cd80ab71ea0f9e9da2d0617d4b539c4  ...  
94459080c118049aba927ec0444ba5b750b7d2c9 

Thanks,
Bob

-Original Message-
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Bob Feng
Sent: Friday, August 16, 2019 12:06 PM
To: Shi, Steven ; devel@edk2.groups.io
Cc: Gao, Liming ; Rodriguez, Christian 
; Johnson, Michael ; 
ler...@redhat.com; leif.lindh...@linaro.org; af...@apple.com; Cetola, Stephano 
; Kinney, Michael D 
Subject: Re: [edk2-devel] [PATCH v6 0/5] Build cache enhancement

For this patch set,

Reviewed-by: Bob Feng 

-Original Message-
From: Shi, Steven 
Sent: Thursday, August 15, 2019 10:26 PM
To: devel@edk2.groups.io
Cc: Gao, Liming ; Feng, Bob C ; 
Rodriguez, Christian ; Johnson, Michael 
; ler...@redhat.com; leif.lindh...@linaro.org; 
af...@apple.com; Cetola, Stephano ; Kinney, Michael 
D ; Shi, Steven 
Subject: [PATCH v6 0/5] Build cache enhancement

From: "Shi, Steven" 

This patch set is for the 201908 stable tag

Enhance the edk2 build cache with below patches:
Patch 01/05: Improve the cache hit rate through new cache checkpoint and hash 
algorithm Patch 02/05: Print more info to explain why a module build cache miss 
Patch 03/05: Fix the unsafe [self.Arch][self.Name] key usage in build cache 
Patch 04/05  Add the GenFds multi-thread support in build cache Patch 05/05  
Improve the file saving and copying functions reliability in build cache


You can directly try this patch set in the branch:
https://github.com/shijunjing/edk2/tree/build_cache_improve_v6_3

V6:
In the patch 5, add error handling to skip hash calculation if find module 
cache already crashed

V5:
Fix the method name typo in Misc.py from EdkLogger.quite() to EdkLogger.quiet()

V4:
Change single global lock into two locks, which are cache_lock and file_lock, 
for better cache performance and IO reliability in windows

V3:
Add patch 5. To improve the autogen CopyFileOnChange() and SaveFileOnChange() 
functions reliability for build cache

V2:
Enhance the SaveHashChainFileToCache() function in ModuleAutoGen.py and not 
need to call f.close() in the "with open(xxx) as f:" block. The with block will 
close the file automatically

V1:
Initial patch set

Shi, Steven (5):
  BaseTools: Improve the cache hit in the edk2 build cache
  BaseTools: Print first cache missing file for build cachle
  BaseTools: Change the [Arch][Name] module key in Build cache
  BaseTools: Add GenFds multi-thread support in build cache
  BaseTools: Improve the file saving and copying reliability

 .../Source/Python/AutoGen/AutoGenWorker.py|  27 +-
 BaseTools/Source/Python/AutoGen/CacheIR.py|  29 +
 BaseTools/Source/Python/AutoGen/DataPipe.py   |   6 +
 BaseTools/Source/Python/AutoGen/GenC.py   |   0
 BaseTools/Source/Python/AutoGen/GenMake.py| 233 +++---
 .../Source/Python/AutoGen/ModuleAutoGen.py| 791 --
 BaseTools/Source/Python/Common/GlobalData.py  |  11 +
 BaseTools/Source/Python/Common/Misc.py|  44 +-
 BaseTools/Source/Python/build/build.py| 182 ++--
 9 files changed, 1073 insertions(+), 250 deletions(-)  mode change 100644 => 
100755 BaseTools/Source/Python/AutoGen/AutoGenWorker.py
 create mode 100755 BaseTools/Source/Python/AutoGen/CacheIR.py
 mode change 100644 => 100755 BaseTools/Source/Python/AutoGen/DataPipe.py
 mode change 100644 => 100755 BaseTools/Source/Python/AutoGen/GenC.py
 mode change 100644 => 100755 BaseTools/Source/Python/AutoGen/GenMake.py
 mode change 100644 => 100755 BaseTools/Source/Python/AutoGen/ModuleAutoGen.py
 mode change 100644 => 100755 BaseTools/Source/Python/Common/GlobalData.py
 mode change 100644 => 100755 BaseTools/Source/Python/Common/Misc.py
 mode change 100644 => 100755 BaseTools/Source/Python/build/build.py

--
2.17.1





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#46079): https://edk2.groups.io/g/devel/message/46079
Mute This Topic: https://groups.io/mt/32887324/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



Re: [edk2-devel] [PATCH v6 0/5] Build cache enhancement

2019-08-15 Thread Bob Feng
For this patch set,

Reviewed-by: Bob Feng 

-Original Message-
From: Shi, Steven 
Sent: Thursday, August 15, 2019 10:26 PM
To: devel@edk2.groups.io
Cc: Gao, Liming ; Feng, Bob C ; 
Rodriguez, Christian ; Johnson, Michael 
; ler...@redhat.com; leif.lindh...@linaro.org; 
af...@apple.com; Cetola, Stephano ; Kinney, Michael 
D ; Shi, Steven 
Subject: [PATCH v6 0/5] Build cache enhancement

From: "Shi, Steven" 

This patch set is for the 201908 stable tag

Enhance the edk2 build cache with below patches:
Patch 01/05: Improve the cache hit rate through new cache checkpoint and hash 
algorithm Patch 02/05: Print more info to explain why a module build cache miss 
Patch 03/05: Fix the unsafe [self.Arch][self.Name] key usage in build cache 
Patch 04/05  Add the GenFds multi-thread support in build cache Patch 05/05  
Improve the file saving and copying functions reliability in build cache


You can directly try this patch set in the branch:
https://github.com/shijunjing/edk2/tree/build_cache_improve_v6_3

V6:
In the patch 5, add error handling to skip hash calculation if find module 
cache already crashed

V5:
Fix the method name typo in Misc.py from EdkLogger.quite() to EdkLogger.quiet()

V4:
Change single global lock into two locks, which are cache_lock and file_lock, 
for better cache performance and IO reliability in windows

V3:
Add patch 5. To improve the autogen CopyFileOnChange() and SaveFileOnChange() 
functions reliability for build cache

V2:
Enhance the SaveHashChainFileToCache() function in ModuleAutoGen.py and not 
need to call f.close() in the "with open(xxx) as f:" block. The with block will 
close the file automatically

V1:
Initial patch set

Shi, Steven (5):
  BaseTools: Improve the cache hit in the edk2 build cache
  BaseTools: Print first cache missing file for build cachle
  BaseTools: Change the [Arch][Name] module key in Build cache
  BaseTools: Add GenFds multi-thread support in build cache
  BaseTools: Improve the file saving and copying reliability

 .../Source/Python/AutoGen/AutoGenWorker.py|  27 +-
 BaseTools/Source/Python/AutoGen/CacheIR.py|  29 +
 BaseTools/Source/Python/AutoGen/DataPipe.py   |   6 +
 BaseTools/Source/Python/AutoGen/GenC.py   |   0
 BaseTools/Source/Python/AutoGen/GenMake.py| 233 +++---
 .../Source/Python/AutoGen/ModuleAutoGen.py| 791 --
 BaseTools/Source/Python/Common/GlobalData.py  |  11 +
 BaseTools/Source/Python/Common/Misc.py|  44 +-
 BaseTools/Source/Python/build/build.py| 182 ++--
 9 files changed, 1073 insertions(+), 250 deletions(-)  mode change 100644 => 
100755 BaseTools/Source/Python/AutoGen/AutoGenWorker.py
 create mode 100755 BaseTools/Source/Python/AutoGen/CacheIR.py
 mode change 100644 => 100755 BaseTools/Source/Python/AutoGen/DataPipe.py
 mode change 100644 => 100755 BaseTools/Source/Python/AutoGen/GenC.py
 mode change 100644 => 100755 BaseTools/Source/Python/AutoGen/GenMake.py
 mode change 100644 => 100755 BaseTools/Source/Python/AutoGen/ModuleAutoGen.py
 mode change 100644 => 100755 BaseTools/Source/Python/Common/GlobalData.py
 mode change 100644 => 100755 BaseTools/Source/Python/Common/Misc.py
 mode change 100644 => 100755 BaseTools/Source/Python/build/build.py

--
2.17.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#45783): https://edk2.groups.io/g/devel/message/45783
Mute This Topic: https://groups.io/mt/32887324/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-



[edk2-devel] [PATCH v6 0/5] Build cache enhancement

2019-08-15 Thread Steven Shi
From: "Shi, Steven" 

This patch set is for the 201908 stable tag

Enhance the edk2 build cache with below patches:
Patch 01/05: Improve the cache hit rate through new cache checkpoint and hash 
algorithm
Patch 02/05: Print more info to explain why a module build cache miss
Patch 03/05: Fix the unsafe [self.Arch][self.Name] key usage in build cache
Patch 04/05  Add the GenFds multi-thread support in build cache
Patch 05/05  Improve the file saving and copying functions reliability in build 
cache


You can directly try this patch set in the branch:
https://github.com/shijunjing/edk2/tree/build_cache_improve_v6_3

V6:
In the patch 5, add error handling to skip hash calculation if find module cache
already crashed

V5:
Fix the method name typo in Misc.py from EdkLogger.quite() to EdkLogger.quiet()

V4:
Change single global lock into two locks, which are cache_lock and file_lock,
for better cache performance and IO reliability in windows

V3:
Add patch 5. To improve the autogen CopyFileOnChange() and SaveFileOnChange()
functions reliability for build cache

V2:
Enhance the SaveHashChainFileToCache() function in ModuleAutoGen.py and
not need to call f.close() in the "with open(xxx) as f:" block. The
with block will close the file automatically

V1:
Initial patch set

Shi, Steven (5):
  BaseTools: Improve the cache hit in the edk2 build cache
  BaseTools: Print first cache missing file for build cachle
  BaseTools: Change the [Arch][Name] module key in Build cache
  BaseTools: Add GenFds multi-thread support in build cache
  BaseTools: Improve the file saving and copying reliability

 .../Source/Python/AutoGen/AutoGenWorker.py|  27 +-
 BaseTools/Source/Python/AutoGen/CacheIR.py|  29 +
 BaseTools/Source/Python/AutoGen/DataPipe.py   |   6 +
 BaseTools/Source/Python/AutoGen/GenC.py   |   0
 BaseTools/Source/Python/AutoGen/GenMake.py| 233 +++---
 .../Source/Python/AutoGen/ModuleAutoGen.py| 791 --
 BaseTools/Source/Python/Common/GlobalData.py  |  11 +
 BaseTools/Source/Python/Common/Misc.py|  44 +-
 BaseTools/Source/Python/build/build.py| 182 ++--
 9 files changed, 1073 insertions(+), 250 deletions(-)
 mode change 100644 => 100755 BaseTools/Source/Python/AutoGen/AutoGenWorker.py
 create mode 100755 BaseTools/Source/Python/AutoGen/CacheIR.py
 mode change 100644 => 100755 BaseTools/Source/Python/AutoGen/DataPipe.py
 mode change 100644 => 100755 BaseTools/Source/Python/AutoGen/GenC.py
 mode change 100644 => 100755 BaseTools/Source/Python/AutoGen/GenMake.py
 mode change 100644 => 100755 BaseTools/Source/Python/AutoGen/ModuleAutoGen.py
 mode change 100644 => 100755 BaseTools/Source/Python/Common/GlobalData.py
 mode change 100644 => 100755 BaseTools/Source/Python/Common/Misc.py
 mode change 100644 => 100755 BaseTools/Source/Python/build/build.py

-- 
2.17.1


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#45734): https://edk2.groups.io/g/devel/message/45734
Mute This Topic: https://groups.io/mt/32887324/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-