Thanks David. No more comments for this patch.
> -Original Message-
> From: Wei, David Y
> Sent: Friday, August 23, 2019 10:06 AM
> To: Kubacki, Michael A ;
> devel@edk2.groups.io
> Cc: Wu, Hao A ; Gao, Liming ;
> Sinha, Ankit ; Agyeman, Prince
> ; Desimone, Nathaniel L
> ; Kinney,
Hi Mike,
Please see the updates online below. Please let me know if you have any more
comments.
Thanks
David
-Original Message-
From: Kubacki, Michael A
Sent: Monday, August 19, 2019 6:05 PM
To: Wei, David Y ; devel@edk2.groups.io
Cc: Wu, Hao A ; Gao, Liming ; Sinha,
Ankit ; Agyeman,
You will need to resolve a conflict in build.cfg. When you do so, please keep
the boards under
[PLATFORMS] in lexicographically ascending order for ease of maintenance.
> -Original Message-
> From: Wei, David Y
> Sent: Friday, August 9, 2019 3:47 PM
> To: devel@edk2.groups.io
> Cc: Wu,
Hi David,
This patch no longer applies cleanly on the latest edk2-platforms master
branch. In addition to addressing the review feedback I previously sent, please
rebase your patch.
Thanks,
Nate
-Original Message-
From: Wei, David Y
Sent: Friday, August 9, 2019 3:47 PM
To:
Hi David,
Here are my comments:
1. Please remove " Contributed-under: TianoCore Contribution Agreement 1.0"
from your commit message as it is no longer needed.
2. Please don't add this entry: WhiskeylakeURvp =
WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/build_config.cfg
WhiskeylakeOpenBoardPkg
