Re: [edk2-devel] [edk2-platforms PATCH v3 11/11] SimicsOpenBoardPkg: update the copyright years in file header

2019-08-29 Thread Nate DeSimone 
Hi David,

I would prefer that the contents of this patch be merged into PATCH 4 through 7 
as appropriate.

Thanks,
Nate

-Original Message-
From: Wei, David Y 
Sent: Thursday, August 29, 2019 3:43 PM
To: devel@edk2.groups.io
Cc: Wu, Hao A ; Gao, Liming ; Sinha, 
Ankit ; Agyeman, Prince ; 
Kubacki, Michael A ; Desimone, Nathaniel L 
; Kinney, Michael D 
Subject: [edk2-platforms PATCH v3 11/11] SimicsOpenBoardPkg: update the 
copyright years in file header

update the copyright years in file header and cleanup the codes to follow the 
EDK2 coding style

Cc: Hao Wu 
Cc: Liming Gao 
Cc: Ankit Sinha 
Cc: Agyeman Prince 
Cc: Kubacki Michael A 
Cc: Nate DeSimone 
Cc: Michael D Kinney 

Signed-off-by: David Wei 
---
 .../SimicsOpenBoardPkg/Library/DxeLogoLib/Logo.c   |  8 +--
 .../Library/PciHostBridgeLib/PciHostBridgeLib.c|  2 +-
 .../Library/PeiReportFvLib/PeiReportFvLib.c|  5 +-
 .../Intel/SimicsOpenBoardPkg/SecCore/SecMain.c |  2 +-
 .../Intel/SimicsOpenBoardPkg/SimicsDxe/Platform.c  |  2 +-  
.../SimicsOpenBoardPkg/SimicsDxe/PlatformConfig.c  |  1 +  
.../SimicsOpenBoardPkg/SimicsPei/FeatureControl.c  |  1 +  
.../Intel/SimicsOpenBoardPkg/SimicsPei/Platform.c  |  2 +-
 .../SmbiosPlatformDxe/SmbiosPlatformDxe.c  |  2 +-
 .../BoardX58Ich10/DecomprScratchEnd.fdf.inc|  1 +
 .../BoardX58Ich10/OpenBoardPkg.fdf.inc |  2 +-
 .../BoardX58Ich10/VarStore.fdf.inc |  2 +-
 .../Include/Guid/SimicsBoardConfig.h   |  1 +
 .../Include/IndustryStandard/I440FxPiix4.h |  1 +
 .../Include/IndustryStandard/LinuxBzImage.h|  1 +
 .../Include/Library/SerializeVariablesLib.h|  3 +-
 .../Library/DxeLogoLib/DxeLogoLib.inf  |  2 +-
 .../Library/DxeLogoLib/OemBadging.h| 83 ++
 .../Library/PciHostBridgeLib/PciHostBridgeLib.inf  |  6 +-
 .../Library/PeiReportFvLib/PeiReportFvLib.inf  |  2 +-
 Platform/Intel/SimicsOpenBoardPkg/OpenBoardPkg.dec |  2 +-  
.../Intel/SimicsOpenBoardPkg/SimicsDxe/Platform.h  |  1 +
 .../SimicsOpenBoardPkg/SimicsDxe/Platform.uni  |  2 +-
 .../SimicsOpenBoardPkg/SimicsDxe/PlatformConfig.h  |  3 +-  
.../SimicsOpenBoardPkg/SimicsDxe/PlatformForms.vfr |  2 +-
 .../SimicsOpenBoardPkg/SimicsDxe/SimicsDxe.inf |  2 +-
 .../SmbiosPlatformDxe/SmbiosPlatformDxe.h  |  2 +-
 .../SmbiosPlatformDxe/SmbiosPlatformDxe.inf|  2 +-
 28 files changed, 119 insertions(+), 26 deletions(-)  create mode 100644 
Platform/Intel/SimicsOpenBoardPkg/Library/DxeLogoLib/OemBadging.h

diff --git a/Platform/Intel/SimicsOpenBoardPkg/Library/DxeLogoLib/Logo.c 
b/Platform/Intel/SimicsOpenBoardPkg/Library/DxeLogoLib/Logo.c
index 4a75f3673f..48a718a90d 100644
--- a/Platform/Intel/SimicsOpenBoardPkg/Library/DxeLogoLib/Logo.c
+++ b/Platform/Intel/SimicsOpenBoardPkg/Library/DxeLogoLib/Logo.c
@@ -8,7 +8,7 @@
 
 #include 
 #include 
-#include 
+#include 
 #include 
 #include 
 #include 
@@ -101,7 +101,7 @@ ConvertBmpToGopBlt (
 return EFI_INVALID_PARAMETER;
   }
 
-  if ((BmpHeader->Size != BmpImageSize) || 
+  if ((BmpHeader->Size != BmpImageSize) ||
   (BmpHeader->Size < BmpHeader->ImageOffset) ||
   (BmpHeader->Size - BmpHeader->ImageOffset !=  BmpHeader->PixelHeight * 
DataSizePerLine)) {
 return EFI_INVALID_PARAMETER;
@@ -345,7 +345,7 @@ EnableBootLogo (
   gST->ConOut->EnableCursor (gST->ConOut, FALSE);
 
   Badging = NULL;
-  Status  = gBS->LocateProtocol (, NULL, (VOID **) 
);
+  Status  = gBS->LocateProtocol (, NULL, 
+ (VOID **) );
 
   if (GraphicsOutput != NULL) {
 SizeOfX = GraphicsOutput->Mode->Info->HorizontalResolution;
@@ -581,7 +581,7 @@ Done:
 Status = EFI_SUCCESS;
   } else {
 //
-// More than one Logo displayed, get merged BltBuffer using VideoToBuffer 
operation. 
+// More than one Logo displayed, get merged BltBuffer using VideoToBuffer 
operation.
 //
 if (Blt != NULL) {
   FreePool (Blt);
diff --git 
a/Platform/Intel/SimicsOpenBoardPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c 
b/Platform/Intel/SimicsOpenBoardPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c
index 53c421d40b..3b71c8ae97 100644
--- 
a/Platform/Intel/SimicsOpenBoardPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c
+++ b/Platform/Intel/SimicsOpenBoardPkg/Library/PciHostBridgeLib/PciHost
+++ BridgeLib.c
@@ -2,7 +2,7 @@
   SIMICS QSP's instance of the PCI Host Bridge Library.
 
   Copyright (C) 2016, Red Hat, Inc.
-  Copyright (c) 2016, Intel Corporation. All rights reserved.
+  Copyright (c) 2019, Intel Corporation. All rights reserved.
 
   SPDX-License-Identifier: BSD-2-Clause-Patent  **/ diff --git 
a/Platform/Intel/SimicsOpenBoardPkg/Library/PeiReportFvLib/PeiReportFvLib.c 
b/Platform/Intel/SimicsOpenBoardPkg/Library/PeiReportFvLib/PeiReportFvLib.c
index 1760eb954c..bb5a060b8e 100644
--- a/Platform/Intel/SimicsOpenBoardPkg/Library/PeiReportFvLib/PeiReportFvLib.c
+++ b/Platform/Intel/SimicsOpenBoardPkg/Library/PeiReportFvLib/PeiReport
+++

[edk2-devel] [edk2-platforms PATCH v3 11/11] SimicsOpenBoardPkg: update the copyright years in file header

2019-08-29 Thread David Wei 
update the copyright years in file header and cleanup the codes to follow the 
EDK2 coding style

Cc: Hao Wu 
Cc: Liming Gao 
Cc: Ankit Sinha 
Cc: Agyeman Prince 
Cc: Kubacki Michael A 
Cc: Nate DeSimone 
Cc: Michael D Kinney 

Signed-off-by: David Wei 
---
 .../SimicsOpenBoardPkg/Library/DxeLogoLib/Logo.c   |  8 +--
 .../Library/PciHostBridgeLib/PciHostBridgeLib.c|  2 +-
 .../Library/PeiReportFvLib/PeiReportFvLib.c|  5 +-
 .../Intel/SimicsOpenBoardPkg/SecCore/SecMain.c |  2 +-
 .../Intel/SimicsOpenBoardPkg/SimicsDxe/Platform.c  |  2 +-
 .../SimicsOpenBoardPkg/SimicsDxe/PlatformConfig.c  |  1 +
 .../SimicsOpenBoardPkg/SimicsPei/FeatureControl.c  |  1 +
 .../Intel/SimicsOpenBoardPkg/SimicsPei/Platform.c  |  2 +-
 .../SmbiosPlatformDxe/SmbiosPlatformDxe.c  |  2 +-
 .../BoardX58Ich10/DecomprScratchEnd.fdf.inc|  1 +
 .../BoardX58Ich10/OpenBoardPkg.fdf.inc |  2 +-
 .../BoardX58Ich10/VarStore.fdf.inc |  2 +-
 .../Include/Guid/SimicsBoardConfig.h   |  1 +
 .../Include/IndustryStandard/I440FxPiix4.h |  1 +
 .../Include/IndustryStandard/LinuxBzImage.h|  1 +
 .../Include/Library/SerializeVariablesLib.h|  3 +-
 .../Library/DxeLogoLib/DxeLogoLib.inf  |  2 +-
 .../Library/DxeLogoLib/OemBadging.h| 83 ++
 .../Library/PciHostBridgeLib/PciHostBridgeLib.inf  |  6 +-
 .../Library/PeiReportFvLib/PeiReportFvLib.inf  |  2 +-
 Platform/Intel/SimicsOpenBoardPkg/OpenBoardPkg.dec |  2 +-
 .../Intel/SimicsOpenBoardPkg/SimicsDxe/Platform.h  |  1 +
 .../SimicsOpenBoardPkg/SimicsDxe/Platform.uni  |  2 +-
 .../SimicsOpenBoardPkg/SimicsDxe/PlatformConfig.h  |  3 +-
 .../SimicsOpenBoardPkg/SimicsDxe/PlatformForms.vfr |  2 +-
 .../SimicsOpenBoardPkg/SimicsDxe/SimicsDxe.inf |  2 +-
 .../SmbiosPlatformDxe/SmbiosPlatformDxe.h  |  2 +-
 .../SmbiosPlatformDxe/SmbiosPlatformDxe.inf|  2 +-
 28 files changed, 119 insertions(+), 26 deletions(-)
 create mode 100644 
Platform/Intel/SimicsOpenBoardPkg/Library/DxeLogoLib/OemBadging.h

diff --git a/Platform/Intel/SimicsOpenBoardPkg/Library/DxeLogoLib/Logo.c 
b/Platform/Intel/SimicsOpenBoardPkg/Library/DxeLogoLib/Logo.c
index 4a75f3673f..48a718a90d 100644
--- a/Platform/Intel/SimicsOpenBoardPkg/Library/DxeLogoLib/Logo.c
+++ b/Platform/Intel/SimicsOpenBoardPkg/Library/DxeLogoLib/Logo.c
@@ -8,7 +8,7 @@
 
 #include 
 #include 
-#include 
+#include 
 #include 
 #include 
 #include 
@@ -101,7 +101,7 @@ ConvertBmpToGopBlt (
 return EFI_INVALID_PARAMETER;
   }
 
-  if ((BmpHeader->Size != BmpImageSize) || 
+  if ((BmpHeader->Size != BmpImageSize) ||
   (BmpHeader->Size < BmpHeader->ImageOffset) ||
   (BmpHeader->Size - BmpHeader->ImageOffset !=  BmpHeader->PixelHeight * 
DataSizePerLine)) {
 return EFI_INVALID_PARAMETER;
@@ -345,7 +345,7 @@ EnableBootLogo (
   gST->ConOut->EnableCursor (gST->ConOut, FALSE);
 
   Badging = NULL;
-  Status  = gBS->LocateProtocol (, NULL, (VOID **) 
);
+  Status  = gBS->LocateProtocol (, NULL, (VOID **) 
);
 
   if (GraphicsOutput != NULL) {
 SizeOfX = GraphicsOutput->Mode->Info->HorizontalResolution;
@@ -581,7 +581,7 @@ Done:
 Status = EFI_SUCCESS;
   } else {
 //
-// More than one Logo displayed, get merged BltBuffer using VideoToBuffer 
operation. 
+// More than one Logo displayed, get merged BltBuffer using VideoToBuffer 
operation.
 //
 if (Blt != NULL) {
   FreePool (Blt);
diff --git 
a/Platform/Intel/SimicsOpenBoardPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c 
b/Platform/Intel/SimicsOpenBoardPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c
index 53c421d40b..3b71c8ae97 100644
--- 
a/Platform/Intel/SimicsOpenBoardPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c
+++ 
b/Platform/Intel/SimicsOpenBoardPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c
@@ -2,7 +2,7 @@
   SIMICS QSP's instance of the PCI Host Bridge Library.
 
   Copyright (C) 2016, Red Hat, Inc.
-  Copyright (c) 2016, Intel Corporation. All rights reserved.
+  Copyright (c) 2019, Intel Corporation. All rights reserved.
 
   SPDX-License-Identifier: BSD-2-Clause-Patent
 **/
diff --git 
a/Platform/Intel/SimicsOpenBoardPkg/Library/PeiReportFvLib/PeiReportFvLib.c 
b/Platform/Intel/SimicsOpenBoardPkg/Library/PeiReportFvLib/PeiReportFvLib.c
index 1760eb954c..bb5a060b8e 100644
--- a/Platform/Intel/SimicsOpenBoardPkg/Library/PeiReportFvLib/PeiReportFvLib.c
+++ b/Platform/Intel/SimicsOpenBoardPkg/Library/PeiReportFvLib/PeiReportFvLib.c
@@ -1,8 +1,9 @@
 /** @file
   Source code file for Report Firmware Volume (FV) library
 
-Copyright (c) 2018, Intel Corporation. All rights reserved.
-SPDX-License-Identifier: BSD-2-Clause-Patent
+  Copyright (c) 2019, Intel Corporation. All rights reserved.
+
+  SPDX-License-Identifier: BSD-2-Clause-Patent
 
 **/
 
diff --git a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c 
b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c
index 826fc965c9..5cbb47687b 100644
---