Re: [edk2-devel] [PATCH] OvmfPkg/QemuVideoDxe: Shouldn't assume system in VGA alias mode.

2019-06-05 Thread Marc W Chen
rall ; Marc-André Lureau > ; Stefan Berger > Subject: Re: [edk2-devel] [PATCH] OvmfPkg/QemuVideoDxe: Shouldn't > assume system in VGA alias mode. > > On 06/05/19 13:14, Marc W Chen wrote: > > Query the supported attributes firstly, then AND (&&) both > > VGA_IO and

Re: [edk2-devel] [PATCH] OvmfPkg/QemuVideoDxe: Shouldn't assume system in VGA alias mode.

2019-06-05 Thread Laszlo Ersek
On 06/05/19 14:00, Laszlo Ersek wrote: > On 06/05/19 13:14, Marc W Chen wrote: >> Query the supported attributes firstly, then AND (&&) both >> VGA_IO and VGA_IO_16. > > I don't think you mean "logical AND" above. On second thought, you do mean "logical AND" above, it's just that the wording is

Re: [edk2-devel] [PATCH] OvmfPkg/QemuVideoDxe: Shouldn't assume system in VGA alias mode.

2019-06-05 Thread Laszlo Ersek
On 06/05/19 13:14, Marc W Chen wrote: > Query the supported attributes firstly, then AND (&&) both > VGA_IO and VGA_IO_16. I don't think you mean "logical AND" above. And if you mean "bitwise AND", then "&&" is incorrect. > Since the supported attributes should > only have VGA_IO or VGA_IO_16