Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-21 Thread Donald Kuo
ai, Luke > ; Li, Kevin Y ; > leif.lindh...@linaro.org; af...@apple.com; Kinney, Michael D > > Subject: RE: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by > using CPUID(0x15) TSC leaf > > Done. And, push @30781febe2106cc0d7186e70136120353cd67df2 > > Thanks >

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-21 Thread Liming Gao
Chan, Amy ; Chaganty, > Rangasai V ; Lai, Luke > ; Li, Kevin Y ; > leif.lindh...@linaro.org; af...@apple.com; Kinney, Michael D > ; Zeng, Star > Subject: RE: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by > using CPUID(0x15) TSC leaf > > Remember to add en

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-20 Thread Zeng, Star
Cc: Ni, Ray ; Zeng, Star ; Chan, Amy > ; Chaganty, Rangasai V > ; Lai, Luke ; Li, Kevin Y > ; leif.lindh...@linaro.org; af...@apple.com; Kinney, > Michael D > Subject: RE: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by > using CPUID(0x15) TSC leaf > > Donal

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-20 Thread Liming Gao
Cc: Ni, Ray ; Zeng, Star ; Chan, Amy > ; Chaganty, Rangasai V > ; Lai, Luke ; Li, Kevin Y > ; leif.lindh...@linaro.org; > af...@apple.com; Kinney, Michael D > Subject: RE: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by > using CPUID(0x15) TSC leaf > > Hi

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-20 Thread Donald Kuo
Rangasai V > >; Lai, Luke ; Li, > >Kevin Y ; leif.lindh...@linaro.org; > >af...@apple.com; Kinney, Michael D > >Subject: RE: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library > >by using CPUID(0x15) TSC leaf > > > >Thanks Laszlo help to review

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-20 Thread Liming Gao
ust 17, 2019 4:40 AM >> To: Gao, Liming ; Kuo, Donald >> ; Dong, Eric ; >> devel@edk2.groups.io >> Cc: Ni, Ray ; Zeng, Star ; Chan, >> Amy ; Chaganty, Rangasai V >> ; Lai, Luke ; Li, Kevin >> Y ; leif.lindh...@linaro.org; af...@apple.com; >Kinney, &g

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-19 Thread Donald Kuo
; Chan, > Amy ; Chaganty, Rangasai V > ; Lai, Luke ; Li, Kevin > Y ; leif.lindh...@linaro.org; af...@apple.com; Kinney, > Michael D > Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by > using CPUID(0x15) TSC leaf > > On 08/16/19 18:16, Laszlo Ersek

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-16 Thread Laszlo Ersek
On 08/16/19 18:16, Laszlo Ersek wrote: > On 08/15/19 06:02, Gao, Liming wrote: >> Donald: This change is a new feature. Now, it is not in edk2 feature >> planning list. If you want to catch it into 201908 stable tag, please >> get approve from Stewards first. I have cc this mail to all Stewards. >

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-16 Thread Laszlo Ersek
On 08/15/19 06:02, Gao, Liming wrote: > Donald: This change is a new feature. Now, it is not in edk2 feature > planning list. If you want to catch it into 201908 stable tag, please > get approve from Stewards first. I have cc this mail to all Stewards. - I don't mind adding a new feature, as long

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-16 Thread Vitaly Cheptsov via Groups.Io
evel@edk2.groups.io <mailto:devel@edk2.groups.io>] On Behalf Of > Vitaly Cheptsov via Groups.Io > Sent: Thursday, August 15, 2019 5:10 AM > To: Kuo, Donald mailto:donald....@intel.com>> > Cc: devel@edk2.groups.io <mailto:devel@edk2.groups.io> > Subject: Re: [edk2-devel] [

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-16 Thread Donald Kuo
Lib (default) Thanks, Donald From: vit9696 via [] [mailto:vit9696=protonmail.com<http://protonmail.com/>@[]] Sent: Thursday, August 15, 2019 3:20 PM To: Kuo, Donald mailto:donald@intel.com>>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> Subject: Re: [edk2-devel] [PA

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-15 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Kuo, Donald > Sent: Thursday, August 15, 2019 5:11 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Zeng, Star ; Dong, Eric > ; Chan, Amy ; Chaganty, > Rangasai V > Subject: [PATCH] UefiCpuPkg: Adding a new TSC library by using

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-15 Thread Michael D Kinney
[mailto:devel@edk2.groups.io] On Behalf Of Vitaly Cheptsov via Groups.Io Sent: Thursday, August 15, 2019 5:10 AM To: Kuo, Donald Cc: devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf Hi Donald, Glad to hear it helped a little

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-15 Thread Vitaly Cheptsov via Groups.Io
ted should still use AcpiTimerLib (default) > > Thanks, > Donald >   <> > <>From: vit9696 via [] [mailto:vit9696=protonmail.com > <http://protonmail.com/>@[]] > Sent: Thursday, August 15, 2019 3:20 PM > To: Kuo, Donald mailto:donald....@intel.com>>; > de

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-15 Thread Donald Kuo
: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf Hello, Thank you for the patch! I reviewed the code and noticed select issues explained below. 1. The following construction: if (RegEbx == 0) { DEBUG ((DEBUG_ERROR, "The CPU is not capble for Core Cr

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-15 Thread Vitaly Cheptsov via Groups.Io
Hello, Thank you for the patch! I reviewed the code and noticed select issues explained below. 1. The following construction: if (RegEbx == 0) { DEBUG ((DEBUG_ERROR, "The CPU is not capble for Core Crystal Clock Frequency !!\n")); ASSERT (RegEbx != 0); } Does not look good to me, and in my

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-14 Thread Donald Kuo
Chaganty, Rangasai V > ; Lai, Luke ; Li, Kevin > Y ; Laszlo Ersek (ler...@redhat.com) > ; leif.lindh...@linaro.org; af...@apple.com; Kinney, > Michael D > Subject: RE: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by > using CPUID(0x15) TSC leaf > >

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-14 Thread Liming Gao
Lai, Luke ; Li, Kevin Y > > Subject: RE: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by > using CPUID(0x15) TSC leaf > > Hi Liming, > > As we plan to add new TimerLib to use CPUID Leaf 0x15 (CPU XTAL clock > frequency) to calculate TSC to resolve performa

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-14 Thread Donald Kuo
. Thanks, Donald > -Original Message- > From: Dong, Eric > Sent: Thursday, August 15, 2019 10:46 AM > To: devel@edk2.groups.io; Kuo, Donald > Cc: Ni, Ray ; Zeng, Star ; Chan, > Amy ; Chaganty, Rangasai V > > Subject: RE: [edk2-devel] [PATCH] UefiCpuPkg:

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-14 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Donald Kuo > Sent: Tuesday, August 13, 2019 6:53 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Zeng, Star ; Dong, Eric > ; Chan, Amy ; Chaganty, > Rangasai V > Subject:

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-12 Thread Dong, Eric
Hi Donald, Thanks for your explanation. In this case, Reviewed-by: Eric Dong Thanks, Eric > -Original Message- > From: Kuo, Donald > Sent: Tuesday, August 13, 2019 11:26 AM > To: Dong, Eric ; devel@edk2.groups.io > Cc: Ni, Ray ; Zeng, Star ; Chan, > Amy ; Chaganty, Rangasai V > >

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-12 Thread Donald Kuo
Hi Eric, The CPUID Leaf 0x1:EDX.TSC[bit 4] is to check capability for IA32_TIME_STAMP_COUNTER MSR and RDTSC instruction which defined in IA32 SDM chapter 17.17 And what we implement is based on IA32 SDM Chapter 18.7 for CPU core XTAL clock frequency which is from CPUID Leaf 0x15 and new TSC

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-12 Thread Dong, Eric
Hi Donald, Do you think it's necessary to check the TIME_STAMP_COUNTER capability before using it? I see SDM has CPUID(0x01) which return the capability of TIME_STAMP_COUNTER. Thanks, Eric > -Original Message- > From: Kuo, Donald > Sent: Monday, August 12, 2019 7:23 PM > To:

Re: [edk2-devel] [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) TSC leaf

2019-08-12 Thread Zeng, Star
Some comments below. > -Original Message- > From: Kuo, Donald > Sent: Monday, August 12, 2019 1:57 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Zeng, Star ; Dong, Eric > > Subject: [PATCH] UefiCpuPkg: Adding a new TSC library by using CPUID(0x15) > TSC leaf > > REF: