Re: [edk2-devel] [PATCH 6/9] SecurityPkg/DxeImageVerificationLib: Differentiate error and search result in IsCertHashFoundInDatabase(CVE-2019-14575)

2020-02-13 Thread Yao, Jiewen
Fine. Thanks for the update. > -Original Message- > From: Wang, Jian J > Sent: Friday, February 14, 2020 11:32 AM > To: Yao, Jiewen ; devel@edk2.groups.io > Cc: Zhang, Chao B ; Laszlo Ersek > > Subject: RE: [PATCH 6/9] SecurityPkg/DxeImageVerificationLib: Differentiate > error and

Re: [edk2-devel] [PATCH 6/9] SecurityPkg/DxeImageVerificationLib: Differentiate error and search result in IsCertHashFoundInDatabase(CVE-2019-14575)

2020-02-13 Thread Wang, Jian J
Jiewen, > -Original Message- > From: Yao, Jiewen > Sent: Friday, February 14, 2020 8:54 AM > To: Wang, Jian J ; devel@edk2.groups.io > Cc: Zhang, Chao B ; Laszlo Ersek > > Subject: RE: [PATCH 6/9] SecurityPkg/DxeImageVerificationLib: Differentiate > error and search result in

Re: [edk2-devel] [PATCH 6/9] SecurityPkg/DxeImageVerificationLib: Differentiate error and search result in IsCertHashFoundInDatabase(CVE-2019-14575)

2020-02-13 Thread Wang, Jian J
Jiewen, Thanks for the comments. 1) You're right. IsCertHashFoundInDatabase is quite general and cause confusions between db and dbx situation. Since it's not newly introduced in this patch series, do you think it's ok to fix it in separate patch series later? Or do you prefer fix it in this

Re: [edk2-devel] [PATCH 6/9] SecurityPkg/DxeImageVerificationLib: Differentiate error and search result in IsCertHashFoundInDatabase(CVE-2019-14575)

2020-02-13 Thread Yao, Jiewen
Comment below: 1) I think the function name - IsCertHashFoundInDatabase() and the implementation { DbxList = SignatureList; DbxSize = SignatureListSize; } bring some confusion to me. If this is a *generic* database search function, I recommend we use a generic name - not use