Jian, thanks a lot your analysis. The intention was very much to constrain the
flow of information
from SMM to the non-SMM environment and not vice versa during runtime cache
operation.
I agree that the buffers pointed to in
SMM_VARIABLE_COMMUNICATE_RUNTIME_VARIABLE_CACHE_CONTEXT
should be
>
> Again, I would like to ask for help from other reviewers to look at this patch
> (patch 7/10) and the next one (patch 8/10) (at least from the security
> perspective). Any help will be appreciated, thanks in advance.
>
I'm trying to do a simple analysis below from security perspective.
October 17, 2019 9:25 AM
> To: Wang, Jian J ; devel@edk2.groups.io
> Cc: Bi, Dandan ; Ard Biesheuvel
> ; Dong, Eric ; Laszlo Ersek
> ; Gao, Liming ; Kinney, Michael D
> ; Ni, Ray ; Wu, Hao A
> ; Yao, Jiewen
> Subject: RE: [edk2-devel] [PATCH V4 07/10] MdeModulePkg/Variable: Ad
g,
> Jian
> > J
> > Sent: Wednesday, October 16, 2019 2:46 PM
> > To: Kubacki, Michael A ;
> devel@edk2.groups.io
> > Cc: Bi, Dandan ; Ard Biesheuvel
> > ; Dong, Eric ; Laszlo
> Ersek
> > ; Gao, Liming ; Kinney,
> Michael D
> > ; Ni, Ray ;
AtRuntime () is implemented in VariableSmmRuntimeDxe.c because it is called by
VariableParsing.c
which is linked to both VariableSmmRuntimeDxe and VariableSmm. VariableSmm
cannot directly
invoke EfiAtRuntime (), so prior to this change, VariableSmm stores the runtime
status in the global
Again, I would like to ask for help from other reviewers to look at this patch
(patch 7/10) and the next one (patch 8/10) (at least from the security
perspective). Any help will be appreciated, thanks in advance.
One comment inherited from the feedback on the V2 series:
I saw AtRuntime() is
vel
> ; Dong, Eric ; Laszlo Ersek
> ; Gao, Liming ; Kinney, Michael D
> ; Ni, Ray ; Wu, Hao A
> ; Yao, Jiewen
> Subject: Re: [edk2-devel] [PATCH V4 07/10] MdeModulePkg/Variable: Add RT
> GetVariable() cache support
>
> Hi Michael,
>
> Please see my inline comments.
>
Hi Michael,
Please see my inline comments.
> -Original Message-
> From: Kubacki, Michael A
> Sent: Tuesday, October 15, 2019 7:30 AM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan ; Ard Biesheuvel
> ; Dong, Eric ; Laszlo Ersek
> ; Gao, Liming ; Kinney, Michael D
> ; Ni, Ray ; Wang, Jian J
