Re: [edk2-devel] [PATCH v1 03/11] ShellPkg: acpiview: FADT: Validate global pointer before use

2019-08-16 Thread Krzysztof Koch
Hi Zhichao, I think you're right. I will submit a v2 patch that minimizes the amount of pointer validation required for parsing the remaining tables. Kind regards, Krzysztof -Original Message- From: Gao, Zhichao Sent: Friday, August 16, 2019 8:35 To: Krzysztof Koch ;

Re: [edk2-devel] [PATCH v1 03/11] ShellPkg: acpiview: FADT: Validate global pointer before use

2019-08-16 Thread Gao, Zhichao
For FadtMinorRevision and X_DsdtAddress, I don't think they are required section. Maybe we should consider check the length before check them. As I know, the OVMF's FACP table doesn't have the section after flag. Thanks, Zhichao > -Original Message- > From: Krzysztof Koch