: [edk2-devel] [PATCH v2] UefiCpuPkg/MpInitLib DXE: Add PCD to
>> control AP status check interval
>>
>> Mike, Hao,
>> I searched all edk2 code using regex pattern "Pcd.*Timeout.*",
>> "Pcd.*Timer.*",
>> "Pcd.*Delay.*"
>> and fo
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, March 25, 2020 9:37 AM
> To: Kinney, Michael D; Ni, Ray; Zeng, Star; Wu, Hao A; devel@edk2.groups.io
> Cc: Dong, Eric; Brian J . Johnson
> Subject: Re: [edk2-devel] [PATCH v2] UefiCp
On 03/24/20 16:59, Kinney, Michael D wrote:
> How was the milliseconds units selected?
I suggested msecs for continuity with the pre-patch unit:
#define AP_CHECK_INTERVAL (EFI_TIMER_PERIOD_MILLISECONDS (100))
> We have other PCDs that provide timer intervals in
> 100ns unit and my microsec
many different units for time
> > intervals.
> >
> > Mike
> >
> > > -Original Message-
> > > From: Ni, Ray
> > > Sent: Tuesday, March 24, 2020 12:53 AM
> > > To: Zeng, Star ; Wu, Hao A
> > > ; devel@edk2.groups.io
> > >
ao A
> ;
> devel@edk2.groups.io; Kinney, Michael D
> Cc: Dong, Eric ; Laszlo Ersek ; Brian
> J . Johnson
> Subject: RE: [edk2-devel] [PATCH v2] UefiCpuPkg/MpInitLib DXE: Add PCD to
> control AP status check interval
>
> How was the milliseconds units selected?
>
>
; From: Ni, Ray
> Sent: Tuesday, March 24, 2020 12:53 AM
> To: Zeng, Star ; Wu, Hao A
> ; devel@edk2.groups.io
> Cc: Dong, Eric ; Laszlo Ersek
> ; Kinney, Michael D
> ; Brian J . Johnson
>
> Subject: RE: [edk2-devel] [PATCH v2]
> UefiCpuPkg/MpInitLib DXE: Add PCD to c
, Hao A ; devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Laszlo
> Ersek ; Kinney, Michael D
> ; Brian J . Johnson ;
> Zeng, Star
> Subject: RE: [edk2-devel] [PATCH v2] UefiCpuPkg/MpInitLib DXE: Add PCD to
> control AP status check interval
>
> > -Original Mes
> -Original Message-
> From: Wu, Hao A
> Sent: Tuesday, March 24, 2020 3:12 PM
> To: Zeng, Star ; devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Laszlo
> Ersek ; Kinney, Michael D
> ; Brian J . Johnson
> Subject: RE: [edk2-devel] [PATCH v2] UefiCpuPkg/M
> -Original Message-
> From: Zeng, Star
> Sent: Tuesday, March 24, 2020 3:02 PM
> To: devel@edk2.groups.io; Wu, Hao A
> Cc: Dong, Eric; Ni, Ray; Laszlo Ersek; Kinney, Michael D; Brian J . Johnson;
> Zeng,
> Star
> Subject: RE: [edk2-devel] [PATCH v2] UefiCpuPkg/M
The code logic is good to me.
Only minor concern, do we really need the PCD to be UINT64 type? :)
Thanks,
Star
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Wu, Hao A
> Sent: Tuesday, March 24, 2020 2:33 PM
> To: devel@edk2.groups.io
> Cc:
10 matches
Mail list logo
