Re: [edk2-devel] [Patch] BaseTools: Fixed a typo in Trim.py

2019-08-01 Thread Liming Gao 
push@ 83d6207f99021ac9b2990fc9d66bab3cb3ae5f26

> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Liming 
> Gao
> Sent: Friday, August 2, 2019 12:13 AM
> To: Carsey, Jaben ; devel@edk2.groups.io; Feng, Bob C 
> 
> Subject: Re: [edk2-devel] [Patch] BaseTools: Fixed a typo in Trim.py
> 
> Reviewed-by: Liming Gao 
> 
> > -Original Message-
> > From: Carsey, Jaben
> > Sent: Thursday, August 1, 2019 10:45 PM
> > To: devel@edk2.groups.io; Feng, Bob C 
> > Cc: Gao, Liming 
> > Subject: RE: [edk2-devel] [Patch] BaseTools: Fixed a typo in Trim.py
> >
> > Reviewed-by: Jaben Carsey 
> >
> > Thanks
> > -Jaben
> >
> >
> > > -Original Message-
> > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > > Bob Feng
> > > Sent: Thursday, August 01, 2019 6:24 AM
> > > To: devel@edk2.groups.io
> > > Cc: Gao, Liming ; Feng, Bob C
> > > 
> > > Subject: [edk2-devel] [Patch] BaseTools: Fixed a typo in Trim.py
> > >
> > > This is a regression issue introduced
> > > by commit 307e1650be267b67db7be1089e0979ace460d83
> > >
> > > This patch is to fix this issue.
> > >
> > > Cc: Liming Gao 
> > > Signed-off-by: Bob Feng 
> > > ---
> > >  BaseTools/Source/Python/Trim/Trim.py | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/BaseTools/Source/Python/Trim/Trim.py
> > > b/BaseTools/Source/Python/Trim/Trim.py
> > > index 8767b67f7e..24c3fafa76 100644
> > > --- a/BaseTools/Source/Python/Trim/Trim.py
> > > +++ b/BaseTools/Source/Python/Trim/Trim.py
> > > @@ -73,11 +73,11 @@ def TrimPreprocessedFile(Source, Target,
> > > ConvertHex, TrimLong):
> > >  try:
> > >  with open(Source, "r") as File:
> > >  Lines = File.readlines()
> > >  except IOError:
> > >  EdkLogger.error("Trim", FILE_OPEN_FAILURE, ExtraData=Source)
> > > -expect:
> > > +except:
> > >  EdkLogger.error("Trim", AUTOGEN_ERROR, "TrimPreprocessedFile: 
> > > Error
> > > while processing file", File=Source)
> > >
> > >  PreprocessedFile = ""
> > >  InjectedFile = ""
> > >  LineIndexOfOriginalFile = None
> > > --
> > > 2.18.0.windows.1
> > >
> > >
> > >
> 
> 
> 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#44802): https://edk2.groups.io/g/devel/message/44802
Mute This Topic: https://groups.io/mt/32678944/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch] BaseTools: Fixed a typo in Trim.py

2019-08-01 Thread Liming Gao 
Reviewed-by: Liming Gao 

> -Original Message-
> From: Carsey, Jaben
> Sent: Thursday, August 1, 2019 10:45 PM
> To: devel@edk2.groups.io; Feng, Bob C 
> Cc: Gao, Liming 
> Subject: RE: [edk2-devel] [Patch] BaseTools: Fixed a typo in Trim.py
> 
> Reviewed-by: Jaben Carsey 
> 
> Thanks
> -Jaben
> 
> 
> > -Original Message-
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Bob Feng
> > Sent: Thursday, August 01, 2019 6:24 AM
> > To: devel@edk2.groups.io
> > Cc: Gao, Liming ; Feng, Bob C
> > 
> > Subject: [edk2-devel] [Patch] BaseTools: Fixed a typo in Trim.py
> >
> > This is a regression issue introduced
> > by commit 307e1650be267b67db7be1089e0979ace460d83
> >
> > This patch is to fix this issue.
> >
> > Cc: Liming Gao 
> > Signed-off-by: Bob Feng 
> > ---
> >  BaseTools/Source/Python/Trim/Trim.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/BaseTools/Source/Python/Trim/Trim.py
> > b/BaseTools/Source/Python/Trim/Trim.py
> > index 8767b67f7e..24c3fafa76 100644
> > --- a/BaseTools/Source/Python/Trim/Trim.py
> > +++ b/BaseTools/Source/Python/Trim/Trim.py
> > @@ -73,11 +73,11 @@ def TrimPreprocessedFile(Source, Target,
> > ConvertHex, TrimLong):
> >  try:
> >  with open(Source, "r") as File:
> >  Lines = File.readlines()
> >  except IOError:
> >  EdkLogger.error("Trim", FILE_OPEN_FAILURE, ExtraData=Source)
> > -expect:
> > +except:
> >  EdkLogger.error("Trim", AUTOGEN_ERROR, "TrimPreprocessedFile: Error
> > while processing file", File=Source)
> >
> >  PreprocessedFile = ""
> >  InjectedFile = ""
> >  LineIndexOfOriginalFile = None
> > --
> > 2.18.0.windows.1
> >
> >
> > 


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#44801): https://edk2.groups.io/g/devel/message/44801
Mute This Topic: https://groups.io/mt/32678944/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [Patch] BaseTools: Fixed a typo in Trim.py

2019-08-01 Thread Philippe Mathieu-Daudé 
On 8/1/19 3:23 PM, Bob Feng wrote:
> This is a regression issue introduced
> by commit 307e1650be267b67db7be1089e0979ace460d83
> 
> This patch is to fix this issue.
> 
> Cc: Liming Gao 
> Signed-off-by: Bob Feng 
> ---
>  BaseTools/Source/Python/Trim/Trim.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/BaseTools/Source/Python/Trim/Trim.py 
> b/BaseTools/Source/Python/Trim/Trim.py
> index 8767b67f7e..24c3fafa76 100644
> --- a/BaseTools/Source/Python/Trim/Trim.py
> +++ b/BaseTools/Source/Python/Trim/Trim.py
> @@ -73,11 +73,11 @@ def TrimPreprocessedFile(Source, Target, ConvertHex, 
> TrimLong):
>  try:
>  with open(Source, "r") as File:
>  Lines = File.readlines()
>  except IOError:
>  EdkLogger.error("Trim", FILE_OPEN_FAILURE, ExtraData=Source)
> -expect:
> +except:
>  EdkLogger.error("Trim", AUTOGEN_ERROR, "TrimPreprocessedFile: Error 
> while processing file", File=Source)
>  
>  PreprocessedFile = ""
>  InjectedFile = ""
>  LineIndexOfOriginalFile = None
> 

Reviewed-by: Philippe Mathieu-Daude 

-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.

View/Reply Online (#44800): https://edk2.groups.io/g/devel/message/44800
Mute This Topic: https://groups.io/mt/32678944/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub  [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-