Re: [edk2-devel] [edk2-platforms] [PATCH V1 04/13] CoffeeLakeSiliconPkg: Move TcoWdtHob.h
I understand we are moving the header file around but can we take this
opportunity to cleanup this file? (Maybe in a different patch).
The TcoWdtHob.h is redefining HOB structures that are already defined in MdePkg
(e.g. EFI_HOB_GENERIC_HEADER)
Regards,
Sai
-Original Message-
From: Desimone, Nathaniel L
Sent: Wednesday, November 13, 2019 10:07 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Kubacki, Michael A
; Chaganty, Rangasai V
Subject: [edk2-platforms] [PATCH V1 04/13] CoffeeLakeSiliconPkg: Move
TcoWdtHob.h
Moves TcoWdtHob.h from WhiskeylakeOpenBoardPkg to CoffeelakeSiliconPkg.
Oddly, gTcoWdtHobGuid was defined in CoffeelakeSiliconPkg/SiPkg.dec while the
HOB definition itself was in WhiskeylakeOpenBoardPkg, this change cleans up the
disparity.
Cc: Chasel Chiu
Cc: Michael Kubacki
Cc: Sai Chaganty
Signed-off-by: Nate DeSimone
---
.../Intel/CoffeelakeSiliconPkg}/Include/Guid/TcoWdtHob.h | 0
1 file changed, 0 insertions(+), 0 deletions(-) rename
{Platform/Intel/WhiskeylakeOpenBoardPkg =>
Silicon/Intel/CoffeelakeSiliconPkg}/Include/Guid/TcoWdtHob.h (100%)
diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/Include/Guid/TcoWdtHob.h
b/Silicon/Intel/CoffeelakeSiliconPkg/Include/Guid/TcoWdtHob.h
similarity index 100%
rename from Platform/Intel/WhiskeylakeOpenBoardPkg/Include/Guid/TcoWdtHob.h
rename to Silicon/Intel/CoffeelakeSiliconPkg/Include/Guid/TcoWdtHob.h
--
2.23.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#50827): https://edk2.groups.io/g/devel/message/50827
Mute This Topic: https://groups.io/mt/57059551/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms] [PATCH V1 04/13] CoffeeLakeSiliconPkg: Move TcoWdtHob.h
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Wednesday, November 13, 2019 10:07 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Kubacki, Michael A
> ; Chaganty, Rangasai V
>
> Subject: [edk2-platforms] [PATCH V1 04/13] CoffeeLakeSiliconPkg: Move
> TcoWdtHob.h
>
> Moves TcoWdtHob.h from WhiskeylakeOpenBoardPkg to
> CoffeelakeSiliconPkg.
> Oddly, gTcoWdtHobGuid was defined in CoffeelakeSiliconPkg/SiPkg.dec
> while the HOB definition itself was in WhiskeylakeOpenBoardPkg, this
> change cleans up the disparity.
>
> Cc: Chasel Chiu
> Cc: Michael Kubacki
> Cc: Sai Chaganty
> Signed-off-by: Nate DeSimone
> ---
> .../Intel/CoffeelakeSiliconPkg}/Include/Guid/TcoWdtHob.h | 0
> 1 file changed, 0 insertions(+), 0 deletions(-) rename
> {Platform/Intel/WhiskeylakeOpenBoardPkg =>
> Silicon/Intel/CoffeelakeSiliconPkg}/Include/Guid/TcoWdtHob.h (100%)
>
> diff --git
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/Include/Guid/TcoWdtHob.h
> b/Silicon/Intel/CoffeelakeSiliconPkg/Include/Guid/TcoWdtHob.h
> similarity index 100%
> rename from
> Platform/Intel/WhiskeylakeOpenBoardPkg/Include/Guid/TcoWdtHob.h
> rename to Silicon/Intel/CoffeelakeSiliconPkg/Include/Guid/TcoWdtHob.h
> --
> 2.23.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#50807): https://edk2.groups.io/g/devel/message/50807
Mute This Topic: https://groups.io/mt/57059551/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [edk2-platforms] [PATCH V1 04/13] CoffeeLakeSiliconPkg: Move TcoWdtHob.h
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Thursday, November 14, 2019 2:07 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Kubacki, Michael A
> ; Chaganty, Rangasai V
>
> Subject: [edk2-platforms] [PATCH V1 04/13] CoffeeLakeSiliconPkg: Move
> TcoWdtHob.h
>
> Moves TcoWdtHob.h from WhiskeylakeOpenBoardPkg to
> CoffeelakeSiliconPkg.
> Oddly, gTcoWdtHobGuid was defined in CoffeelakeSiliconPkg/SiPkg.dec while
> the HOB definition itself was in WhiskeylakeOpenBoardPkg, this change
> cleans up the disparity.
>
> Cc: Chasel Chiu
> Cc: Michael Kubacki
> Cc: Sai Chaganty
> Signed-off-by: Nate DeSimone
> ---
> .../Intel/CoffeelakeSiliconPkg}/Include/Guid/TcoWdtHob.h | 0
> 1 file changed, 0 insertions(+), 0 deletions(-) rename
> {Platform/Intel/WhiskeylakeOpenBoardPkg =>
> Silicon/Intel/CoffeelakeSiliconPkg}/Include/Guid/TcoWdtHob.h (100%)
>
> diff --git
> a/Platform/Intel/WhiskeylakeOpenBoardPkg/Include/Guid/TcoWdtHob.h
> b/Silicon/Intel/CoffeelakeSiliconPkg/Include/Guid/TcoWdtHob.h
> similarity index 100%
> rename from
> Platform/Intel/WhiskeylakeOpenBoardPkg/Include/Guid/TcoWdtHob.h
> rename to Silicon/Intel/CoffeelakeSiliconPkg/Include/Guid/TcoWdtHob.h
> --
> 2.23.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#50677): https://edk2.groups.io/g/devel/message/50677
Mute This Topic: https://groups.io/mt/57059551/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
