Thanks for all feedback received so far. As the review and feedback period is
over, moving forward to fix the bugs and announce first official release of EDK
II Python Development Process specification.
Thank you all.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to
Thanks for the feedback and your view points Bob. I totally agree on your
points and the base tools issues.
I think together we can fix the issues you mentioned and apply best software
design principles to base tools .
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to
Hi Kondal ,
I agree the coding guidelines and tools can help improve the python code
quality, but I think these guidelines in this spec are too general for
BaseTools. Besides the coding style, BaseTools has many specific code issues,
such as the high coupling between modules, not clear module
Thanks for feedback so far. Reminder to get more valuable feedback if any, to
address before enforcing this spec next week.
Plan is to make initial version of spec along with other specifications and
start working on Sean feedback and how to start enforcing the specification.
Thank you so much Rebecca. Will fix it.
--Kondal.
From: devel@edk2.groups.io On Behalf Of Rebecca Cran
Sent: Tuesday, March 10, 2020 1:06 PM
To: devel@edk2.groups.io; Purma, Kondal R
Subject: Re: [edk2-devel] EDK II Python development process specification -draft
I just noticed a typo
I just noticed a typo on the page about python tools: the heading says Falke8
instead of Flake8.
—
Rebecca Cran
>> On Mar 6, 2020, at 5:27 PM, Purma, Kondal R wrote:
>
> Hi,
>
> The draft specification for EDK II Python development process for
> presentation made earlier now available .
Thanks for feedback an your are exactly right. This applies for new
module/project and every point you mentioned is valid.
We should also make sure these rules applies to bug fixes, or code adding as
feature in existing files.
I raised all these question my self and taken initial step.
As a
This looks fine but it seems focused on writing a new module/project. Most
python work going into edk2 is part of existing code.
I would like to see additional documentation about how this applies to edk2
basetools.
* A flake8 config file could be added to basetools python.
* Documentation of
