RE: PATCH: Fix use of uninitialized variable (mysql port) in sqlbox

Patch committed. Van: devel [mailto:devel-boun...@kannel.org] Namens Vyronas Tsingaras Verzonden: maandag 9 november 2015 16:41 Aan: spameden <spame...@gmail.com> CC: kannel_dev_mailinglist devel@kannel.org <devel@kannel.org> Onderwerp: Re: PATCH: Fix use of uninitialized variable

Re: PATCH: Fix use of uninitialized variable (mysql port) in sqlbox

Amended. sqlbox would try to connect to random ports on the mysql host if no port was defined due to an uninitialized variable use. Index: sqlbox_mysql.c === --- sqlbox_mysql.c (revision 55) +++ sqlbox_mysql.c (working copy) @@

Re: PATCH: Fix use of uninitialized variable (mysql port) in sqlbox

Hi, I recall that bearerbox and sqlbox use unix socket when no port was specified in the config. Using unix socket is usually a bit faster than TCP but of course the database must be installed on the same machine. Perhaps the behaviour is different with more recent library versions and I'm

PATCH: Fix use of uninitialized variable (mysql port) in sqlbox

sqlbox would try to connect to random ports on the mysql host if no port was defined due to an uninitialized variable use. Index: sqlbox_mysql.c === --- sqlbox_mysql.c (revision 55) +++ sqlbox_mysql.c (working copy) @@ -396,6 +396,9

Re: PATCH: Fix use of uninitialized variable (mysql port) in sqlbox

Yes and even then, well the signature of mysql_real_connect that is used in dbpool_mysql:101 is MYSQL *mysql_real_connect(MYSQL *mysql, const char *host, const char *user, const char *passwd, const char *db, unsigned int port, const char *unix_socket, unsigned long client_flag). You have to

Re: PATCH: Fix use of uninitialized variable (mysql port) in sqlbox

That's correct, host should be 'localhost'. 2015-11-09 18:31 GMT+03:00 Vyronas Tsingaras : > But according to > https://dev.mysql.com/doc/refman/5.7/en/mysql-real-connect.html only when > host is either NULL or "localhost" will mysql_real_connect do UNIX socket >

Re: PATCH: Fix use of uninitialized variable (mysql port) in sqlbox

If port wasn't specified that means kannel will use socket instead, so no need to specify default port. 2015-11-09 17:23 GMT+03:00 Vyronas Tsingaras : > sqlbox would try to connect to random ports on the mysql host if no port > was defined due to an uninitialized

Re: PATCH: Fix use of uninitialized variable (mysql port) in sqlbox

But according to https://dev.mysql.com/doc/refman/5.7/en/mysql-real-connect.html only when host is either NULL or "localhost" will mysql_real_connect do UNIX socket connection. The 'port' argument only applies to TCP/IP connections and thus should default to 0 if not specified. Kind Regards,