Re: GCC 8 ABI change on x86_64

2018-03-08 Thread Jakub Jelinek
On Thu, Mar 08, 2018 at 05:52:05PM +, Sérgio Basto wrote: > On Thu, 2018-03-08 at 10:25 +0100, Marek Polacek wrote: > > On Wed, Mar 07, 2018 at 07:20:18PM +, Sérgio Basto wrote: > > > On Wed, 2018-03-07 at 19:50 +0100, Marek Polacek wrote: > > > > I did another mass rebuild with a

Re: GCC 8 ABI change on x86_64

2018-03-08 Thread Sérgio Basto
On Thu, 2018-03-08 at 10:25 +0100, Marek Polacek wrote: > On Wed, Mar 07, 2018 at 07:20:18PM +, Sérgio Basto wrote: > > On Wed, 2018-03-07 at 19:50 +0100, Marek Polacek wrote: > > > I did another mass rebuild with a specially-tweaked gcc in order > > > to > > > find out > > > which packages

Re: GCC 8 ABI change on x86_64

2018-03-08 Thread Marek Polacek
On Wed, Mar 07, 2018 at 09:19:15PM -0800, Adam Williamson wrote: > On Wed, 2018-03-07 at 19:50 +0100, Marek Polacek wrote: > > Recently we discovered a serious bug in the compiler whereby we miscompiled > > several packages. The problem started with my ABI-changing patch which > > changed > >

Re: GCC 8 ABI change on x86_64

2018-03-08 Thread Marek Polacek
On Wed, Mar 07, 2018 at 09:36:29PM +0100, Jakub Jelinek wrote: > On Wed, Mar 07, 2018 at 12:27:34PM -0800, Adam Williamson wrote: > > On Wed, 2018-03-07 at 19:50 +0100, Marek Polacek wrote: > > > Recently we discovered a serious bug in the compiler whereby we > > > miscompiled > > > several

Re: GCC 8 ABI change on x86_64

2018-03-08 Thread Marek Polacek
On Wed, Mar 07, 2018 at 07:20:18PM +, Sérgio Basto wrote: > On Wed, 2018-03-07 at 19:50 +0100, Marek Polacek wrote: > > I did another mass rebuild with a specially-tweaked gcc in order to > > find out > > which packages need to be rebuild with patched gcc-8.0.1-0.16. > > How we find out the

Re: GCC 8 ABI change on x86_64

2018-03-07 Thread Adam Williamson
On Wed, 2018-03-07 at 19:50 +0100, Marek Polacek wrote: > Recently we discovered a serious bug in the compiler whereby we miscompiled > several packages. The problem started with my ABI-changing patch which > changed > how empty classes are passed, as per the x86_64 psABI (so this bug only >

Re: GCC 8 ABI change on x86_64

2018-03-07 Thread Jakub Jelinek
On Wed, Mar 07, 2018 at 12:27:34PM -0800, Adam Williamson wrote: > On Wed, 2018-03-07 at 19:50 +0100, Marek Polacek wrote: > > Recently we discovered a serious bug in the compiler whereby we miscompiled > > several packages. The problem started with my ABI-changing patch which > > changed > >

Re: GCC 8 ABI change on x86_64

2018-03-07 Thread Adam Williamson
On Wed, 2018-03-07 at 19:50 +0100, Marek Polacek wrote: > Recently we discovered a serious bug in the compiler whereby we miscompiled > several packages. The problem started with my ABI-changing patch which > changed > how empty classes are passed, as per the x86_64 psABI (so this bug only >

Re: GCC 8 ABI change on x86_64

2018-03-07 Thread Sérgio Basto
On Wed, 2018-03-07 at 19:50 +0100, Marek Polacek wrote: > I did another mass rebuild with a specially-tweaked gcc in order to > find out > which packages need to be rebuild with patched gcc-8.0.1-0.16. How we find out the same problem in packages from external repos ? Thanks, -- Sérgio M. B.

GCC 8 ABI change on x86_64

2018-03-07 Thread Marek Polacek
Recently we discovered a serious bug in the compiler whereby we miscompiled several packages. The problem started with my ABI-changing patch which changed how empty classes are passed, as per the x86_64 psABI (so this bug only affects x86_64). The problem could arise when the code contained