Re: %py3_build should accept options

[Richard Shaw]

On Sun, Feb 10, 2019 at 11:28 AM Miro Hrončok  wrote:

> On 09. 02. 19 14:51, Richard Shaw wrote:
> > On Sat, Feb 9, 2019 at 7:48 AM Igor Gnatenko <
> ignatenkobr...@fedoraproject.org
> > > wrote:
> >
> > You can do "%py3_build -- --some-cool-option".
> >
> >
> > I'll see about trying that.. I'm trying to build PySide2 but it's not
> passing
> > --verbose or -j12 to the cmake builds so it looks like it doesn't matter
> anyway.
>
> Try defining %py_setup_args.
>

I finally had an occasion to try this but it still doesn't help because the
arguments are injected after setup.py and not after the install command,
which is what I needed.

That forced me to use the:

%py2_install -- --option1 --option2

method Igor suggested.

Thanks,
Richard
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: %py3_build should accept options

[Richard Shaw]

On Sun, Feb 10, 2019 at 11:28 AM Miro Hrončok  wrote:

> On 09. 02. 19 14:51, Richard Shaw wrote:
> > On Sat, Feb 9, 2019 at 7:48 AM Igor Gnatenko <
> ignatenkobr...@fedoraproject.org
> > > wrote:
> >
> > You can do "%py3_build -- --some-cool-option".
> >
> >
> > I'll see about trying that.. I'm trying to build PySide2 but it's not
> passing
> > --verbose or -j12 to the cmake builds so it looks like it doesn't matter
> anyway.
>
> Try defining %py_setup_args.
>

I see that in the packaging guidelines now but it could be made more
prominent.

Thanks,
Richard
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: %py3_build should accept options

[Miro Hrončok]

On 09. 02. 19 14:51, Richard Shaw wrote:
On Sat, Feb 9, 2019 at 7:48 AM Igor Gnatenko > wrote:


You can do "%py3_build -- --some-cool-option".


I'll see about trying that.. I'm trying to build PySide2 but it's not passing 
--verbose or -j12 to the cmake builds so it looks like it doesn't matter anyway.


Try defining %py_setup_args.

--
Miro Hrončok
--
Phone: +420777974800
IRC: mhroncok
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: %py3_build should accept options

[Richard Shaw]

On Sat, Feb 9, 2019 at 7:48 AM Igor Gnatenko <
ignatenkobr...@fedoraproject.org> wrote:

> You can do "%py3_build -- --some-cool-option".
>

I'll see about trying that.. I'm trying to build PySide2 but it's not
passing --verbose or -j12 to the cmake builds so it looks like it doesn't
matter anyway.

Thanks,
Richard
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Re: %py3_build should accept options

[Igor Gnatenko]

You can do "%py3_build -- --some-cool-option".

On Sat, Feb 9, 2019, 14:40 Richard Shaw  Just want to get others opinions before filing a bug...
>
> Currently %py3_build expands to:
>
> $ rpm -E %py3_build
> \
>   CFLAGS="${CFLAGS:-${RPM_OPT_FLAGS}}"
> LDFLAGS="${LDFLAGS:-${RPM_LD_FLAGS}}"\
>   /usr/bin/python3 setup.py  build --executable="/usr/bin/python3 -s"
>   sleep 1
>
> This does not allow passing of any options that I can tell... For now I'll
> just paste this into my spec file.
>
> Thanks,
> Richard
> ___
> devel mailing list -- devel@lists.fedoraproject.org
> To unsubscribe send an email to devel-le...@lists.fedoraproject.org
> Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
> List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
> List Archives:
> https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
>
___
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org