Re: QMake equivalent of CMake flag -DCMAKE_INSTALL_LIBDIR:PATH=%{_libdir}

2018-03-18 Thread Germano Massullo
2018-03-18 1:38 GMT+01:00 Kevin Kofler : > Upstream should probably add LIBPATH=$(LIBPATH) to their qmake invocation in > the makefile so that their makefile variable actually works without > requiring you to touch the qmake invocation directly. I pointed that out to > them

Re: QMake equivalent of CMake flag -DCMAKE_INSTALL_LIBDIR:PATH=%{_libdir}

2018-03-17 Thread Kevin Kofler
Germano Massullo wrote: > Are you sure? Line 43 is in the middle of a sed command arguments > https://src.fedoraproject.org/rpms/webextension-token-signing/blob/f27/f/webextension-token-signing.spec#_43 Yes, I am sure! That sed sets the command line arguments for qmake. > I tried to set LIBPATH

Re: QMake equivalent of CMake flag -DCMAKE_INSTALL_LIBDIR:PATH=%{_libdir}

2018-03-17 Thread Germano Massullo
2018-03-16 4:48 GMT+01:00 Kevin Kofler : > Germano Massullo wrote: >> upstream made a patch >> https://github.com/open-eid/chrome-token-signing/issues/80#issuecomment-373545367 >> but it looks like it does not work. >> Could you please check if I made any mistake in

Re: QMake equivalent of CMake flag -DCMAKE_INSTALL_LIBDIR:PATH=%{_libdir}

2018-03-15 Thread Kevin Kofler
Germano Massullo wrote: > upstream made a patch > https://github.com/open-eid/chrome-token-signing/issues/80#issuecomment-373545367 > but it looks like it does not work. > Could you please check if I made any mistake in applying the patch in > the RPM? The patch should be fine, but you also need

Re: QMake equivalent of CMake flag -DCMAKE_INSTALL_LIBDIR:PATH=%{_libdir}

2018-03-15 Thread Germano Massullo
upstream made a patch https://github.com/open-eid/chrome-token-signing/issues/80#issuecomment-373545367 but it looks like it does not work. Could you please check if I made any mistake in applying the patch in the RPM? failed build https://koji.fedoraproject.org/koji/taskinfo?taskID=25733909

Re: QMake equivalent of CMake flag -DCMAKE_INSTALL_LIBDIR:PATH=%{_libdir}

2018-03-13 Thread Germano Massullo
Il 11/03/2018 01:56, Kevin Kofler ha scritto: > The upstream makefile hardcodes /usr/lib here: > https://github.com/open-eid/chrome-token-signing/blob/master/host-linux/chrome-token-signing.pro#L22 > The easiest fix is probably to just change: > ffconf.path =

Re: QMake equivalent of CMake flag -DCMAKE_INSTALL_LIBDIR:PATH=%{_libdir}

2018-03-10 Thread Kevin Kofler
PS: I see one similar package in Fedora: https://src.fedoraproject.org/cgit/rpms/chrome-gnome-shell.git/tree/chrome-gnome-shell.spec but they chickened out of shipping the browser extensions entirely and ship only the native-messaging-host part. So you have to install the package AND install the

Re: QMake equivalent of CMake flag -DCMAKE_INSTALL_LIBDIR:PATH=%{_libdir}

2018-03-10 Thread Kevin Kofler
Germano Massullo wrote: > Package webextension-token-signing[2] is affected by the same problem, > but it uses QMake rather than CMake, so I am investing on how to > implement the same instruction. I also think that a brand new *make file > could be the better solution, but I did not yet have the