Re: cmocka update to version 2.0.1

2026-03-06 Thread Michel Lind
On Fri, 2026-03-06 at 08:14 +0100, Andreas Schneider wrote:
> On Thursday, 5 March 2026 22:17:01 Central European Standard Time
> Michel Lind 
> wrote:
> > On Thu, 2026-03-05 at 20:46 +, Michel Lind wrote:
> > > On Wed, 2026-01-07 at 11:32 +0100, Andreas Schneider wrote:
> > > > Hi,
> 
> Hi Michael,
> 
> > > > I plan to update cmocka in Fedora Rawhide to version 2.0.1.
> > > > I've
> > > > submitted it
> > > > first to openSUSE Tumbleweed. The package is staged and
> > > > everything
> > > > depending
> > > > on it gets automatically rebuilt. This allows you to figure out
> > > > what
> > > > might
> > > > break.
> > > > There was only one package which was failing and that was
> > > > multipath-
> > > > tools. The
> > > > Fedora package of multipath-tools doesn't have a %check
> > > > sections so
> > > > it doesn't
> > > > depend on cmocka and will not run into any issues.
> > > 
> > > Hi Andreas,
> > > 
> > > Looks like this is causing the bpfilter FTBFS now. Still looking
> > > at
> > > how
> > > to fix it - its testing code has been refactored significantly
> > > since
> > > the last release so if the changes required are significant we
> > > might
> > > end up just disabling tests for now.
> > > 
> > > https://bugzilla.redhat.com/show_bug.cgi?id=2433890
> > 
> > Looks like bpfilter uses internal functions, so this is not a
> > cmocka
> > bug (or unforeseen API breakage0 - given the latest trunk no longer
> > uses any will_return functionality I'm just carrying a downward
> > patch
> > for now
> 
> cmocka 2.0.1 should not break existing projects unless they use
> functions 
> instead of the macros.
> 
Agreed. I pointed out to upstream that well, that function is clearly
not meant for external use. We have a bit of a philosophical difference
about whether this is an API break or not (I'm on the "no" camp)

> 
> 
> That looks good. Please also submit it upstream.
> 
Upstream trunk no longer uses _will_return, so I think we're good to
go. Just waiting for them to cut a new release so I can drop the patch.


Best regards,


-- 
 _o) Michel Lind
_( ) https://keyoxide.org/5dce2e7e9c3b1cffd335c1d78b229d2f7ccc04f2
 README:https://fedoraproject.org/wiki/User:Salimma#README


signature.asc
Description: This is a digitally signed message part
-- 
___
devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new


Re: cmocka update to version 2.0.1

2026-03-06 Thread Andreas Schneider
On Thursday, 5 March 2026 22:17:01 Central European Standard Time Michel Lind 
wrote:
> On Thu, 2026-03-05 at 20:46 +, Michel Lind wrote:
> > On Wed, 2026-01-07 at 11:32 +0100, Andreas Schneider wrote:
> > > Hi,

Hi Michael,

> > > I plan to update cmocka in Fedora Rawhide to version 2.0.1. I've
> > > submitted it
> > > first to openSUSE Tumbleweed. The package is staged and everything
> > > depending
> > > on it gets automatically rebuilt. This allows you to figure out
> > > what
> > > might
> > > break.
> > > There was only one package which was failing and that was
> > > multipath-
> > > tools. The
> > > Fedora package of multipath-tools doesn't have a %check sections so
> > > it doesn't
> > > depend on cmocka and will not run into any issues.
> > 
> > Hi Andreas,
> > 
> > Looks like this is causing the bpfilter FTBFS now. Still looking at
> > how
> > to fix it - its testing code has been refactored significantly since
> > the last release so if the changes required are significant we might
> > end up just disabling tests for now.
> > 
> > https://bugzilla.redhat.com/show_bug.cgi?id=2433890
> 
> Looks like bpfilter uses internal functions, so this is not a cmocka
> bug (or unforeseen API breakage0 - given the latest trunk no longer
> uses any will_return functionality I'm just carrying a downward patch
> for now

cmocka 2.0.1 should not break existing projects unless they use functions 
instead of the macros.

> https://src.fedoraproject.org/rpms/bpfilter/pull-request/2#request_diff
> 

That looks good. Please also submit it upstream.


Thanks

Andreas



-- 
___
devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new


Re: cmocka update to version 2.0.1

2026-03-05 Thread Michel Lind
On Thu, 2026-03-05 at 20:46 +, Michel Lind wrote:
> On Wed, 2026-01-07 at 11:32 +0100, Andreas Schneider wrote:
> > Hi,
> > 
> > I plan to update cmocka in Fedora Rawhide to version 2.0.1. I've
> > submitted it 
> > first to openSUSE Tumbleweed. The package is staged and everything
> > depending 
> > on it gets automatically rebuilt. This allows you to figure out
> > what
> > might 
> > break.
> > There was only one package which was failing and that was
> > multipath-
> > tools. The 
> > Fedora package of multipath-tools doesn't have a %check sections so
> > it doesn't 
> > depend on cmocka and will not run into any issues.
> > 
> Hi Andreas,
> 
> Looks like this is causing the bpfilter FTBFS now. Still looking at
> how
> to fix it - its testing code has been refactored significantly since
> the last release so if the changes required are significant we might
> end up just disabling tests for now.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=2433890
> 
Looks like bpfilter uses internal functions, so this is not a cmocka
bug (or unforeseen API breakage0 - given the latest trunk no longer
uses any will_return functionality I'm just carrying a downward patch
for now

https://src.fedoraproject.org/rpms/bpfilter/pull-request/2#request_diff


Best regards,


-- 
 _o) Michel Lind
_( ) https://keyoxide.org/5dce2e7e9c3b1cffd335c1d78b229d2f7ccc04f2
 README:https://fedoraproject.org/wiki/User:Salimma#README


signature.asc
Description: This is a digitally signed message part
-- 
___
devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new


Re: cmocka update to version 2.0.1

2026-03-05 Thread Michel Lind
On Wed, 2026-01-07 at 11:32 +0100, Andreas Schneider wrote:
> Hi,
> 
> I plan to update cmocka in Fedora Rawhide to version 2.0.1. I've
> submitted it 
> first to openSUSE Tumbleweed. The package is staged and everything
> depending 
> on it gets automatically rebuilt. This allows you to figure out what
> might 
> break.
> There was only one package which was failing and that was multipath-
> tools. The 
> Fedora package of multipath-tools doesn't have a %check sections so
> it doesn't 
> depend on cmocka and will not run into any issues.
> 
Hi Andreas,

Looks like this is causing the bpfilter FTBFS now. Still looking at how
to fix it - its testing code has been refactored significantly since
the last release so if the changes required are significant we might
end up just disabling tests for now.

https://bugzilla.redhat.com/show_bug.cgi?id=2433890

Best regards,


-- 
 _o) Michel Lind
_( ) https://keyoxide.org/5dce2e7e9c3b1cffd335c1d78b229d2f7ccc04f2
 README:https://fedoraproject.org/wiki/User:Salimma#README


signature.asc
Description: This is a digitally signed message part
-- 
___
devel mailing list -- [email protected]
To unsubscribe send an email to [email protected]
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/[email protected]
Do not reply to spam, report it: 
https://forge.fedoraproject.org/infra/tickets/issues/new