Re: qt4 rebuild

2019-02-28 Thread Stephen John Smoogen
On Wed, 27 Feb 2019 at 16:27, Richard Shaw wrote: > > On Wed, Feb 27, 2019 at 10:18 AM Rex Dieter wrote: >> >> Richard Shaw wrote: >> >> > So I'm pretty much out of my league at this point. I can commit the >> > Q_FOREACH patch if needed. >> >> please do commit (or at least submit pull request).

Re: qt4 rebuild

2019-02-27 Thread Richard Shaw
On Wed, Feb 27, 2019 at 10:18 AM Rex Dieter wrote: > Richard Shaw wrote: > > > So I'm pretty much out of my league at this point. I can commit the > > Q_FOREACH patch if needed. > > please do commit (or at least submit pull request). > Pull request submitted, but it looks like pagure is having

Re: qt4 rebuild

2019-02-27 Thread Rex Dieter
Richard Shaw wrote: > So I'm pretty much out of my league at this point. I can commit the > Q_FOREACH patch if needed. please do commit (or at least submit pull request). -- Rex ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe

Re: qt4 rebuild

2019-02-26 Thread Rob Crittenden
Richard Shaw wrote: > Ok, I updated the patch the COMPILER_VERSION issue (committed) and have > a local patch for the Q_FOREACH problem based on a qt 5 commit: > > https://github.com/qt/qtbase/commit/c35a3f519007af44c3b364b9af86f6a336f6411b > > With both of those problems fixed the build still

Re: qt4 rebuild

2019-02-26 Thread Richard Shaw
Ok, I updated the patch the COMPILER_VERSION issue (committed) and have a local patch for the Q_FOREACH problem based on a qt 5 commit: https://github.com/qt/qtbase/commit/c35a3f519007af44c3b364b9af86f6a336f6411b With both of those problems fixed the build still fails probably due to gcc 9 being

Re: qt4 rebuild

2019-02-26 Thread Richard Shaw
On Tue, Feb 26, 2019 at 10:27 AM Rex Dieter wrote: > Richard Shaw wrote: > > > I'm troubleshooting why apiextractor tests segfault during package > > building. I have not been able to attribute it to any change in build > > flags so I started looking at qt4 which appears to still be FTBFS for

Re: qt4 rebuild

2019-02-26 Thread Rex Dieter
Richard Shaw wrote: > I'm troubleshooting why apiextractor tests segfault during package > building. I have not been able to attribute it to any change in build > flags so I started looking at qt4 which appears to still be FTBFS for F30 > rebuild. > > There's a check in the spec file which

qt4 rebuild

2019-02-26 Thread Richard Shaw
I'm troubleshooting why apiextractor tests segfault during package building. I have not been able to attribute it to any change in build flags so I started looking at qt4 which appears to still be FTBFS for F30 rebuild. There's a check in the spec file which fails: + grep '^#define QT_BUILD_KEY