Re: [Devel] Fixed a bug in mmsbox (patch included)... [wrong credits in ChangeLog]
Hello, it seems that the credits in the ChangeLog are not correct: 006-08-28 Paul A. Bagyenda <[EMAIL PROTECTED]> * Minor fix: MM7 DeliverRsp should not have message ID parameter I think it's because it is generated via script from CVS and user "bagyenda" checked it in... As I am currently preparing to supply some more patches, I would suggest a) giving me a CVS account (register me as an auther) OR b) posting at least "(supplied by [EMAIL PROTECTED])" when patches are checked into CVS Maybee you could patch the message in the CVS-Root-Files... Sincerely yours, Stefan Koenig Paul Bagyenda schrieb: Updated CVS accordingly. Many thanks P. On Aug 25, 2006, at 11:10, Stefan König wrote: Hi there... I just found / fixed a bug in the mmsbox: mbuni-1.1.0/mmsbox$ diff bearerbox.c.old bearerbox.c -- CUT HERE - 188c188 < mresp = mm7_make_resp(mreq, status, msgid); --- mresp = mm7_make_resp(mreq, status, NULL); -- CUT HERE - Description: The Response-XML generated here is the DeliverRsp for a DeliverReq... ...according to the standard there should be no "MessageID"-Field in the SOAP-body. You may look it up in SPEC: http://www.3gpp.org/ftp/Specs/archive/23_series/23.140/23140-6d0.zip (Page 148) It is also not allowed in MM7Version 5.3.0... Hint: mm7_make_resp(..); generates a MessageID, if the last parameter isnt "false"... ...see "mmlib/mms_mm7soap.c" (lines 1007-1038): MSoapMsg_t *mm7_make_resp(MSoapMsg_t *mreq, int status, Octstr *msgid) { . . if (msgid) http_header_add(mresp->envelope, "MessageID", octstr_get_cstr(msgid)); . . } Hint#2: the method call at "mmsbox/bearerbox.c:201" uses "NULL" as last parameter: mresp = mm7_make_resp(mreq, status, NULL); So "msgid" should _not_ be checked for empty-string-value instead... ___ Devel mailing list Devel@mbuni.org http://mbuni.org/mailman/listinfo/devel_mbuni.org ___ Devel mailing list Devel@mbuni.org http://mbuni.org/mailman/listinfo/devel_mbuni.org -- Stefan König Mobile Applications - Core Software Developer DIMOCO Direct Mobile Communications GmbH Campus 21 - Businesspark Wien Süd Liebermannstr. A01/405 A-2345 Brunn/Gebirge Tel: +43/1/86670-21534 Fax: +43/1/86670-21451 Mobil: +43/676-88 66 77 95 Email: [EMAIL PROTECTED] Web: www.dimoco.at ___ Devel mailing list Devel@mbuni.org http://lists.mbuni.org/mailman/listinfo/devel
Re: [Devel] Fixed a bug in mmsbox (patch included)...
Updated CVS accordingly. Many thanks P. On Aug 25, 2006, at 11:10, Stefan König wrote: > Hi there... > > I just found / fixed a bug in the mmsbox: > > mbuni-1.1.0/mmsbox$ diff bearerbox.c.old bearerbox.c > -- CUT HERE - > 188c188 > < mresp = mm7_make_resp(mreq, status, msgid); > --- >> mresp = mm7_make_resp(mreq, status, NULL); > -- CUT HERE - > > Description: > The Response-XML generated here is the DeliverRsp for a DeliverReq... > ...according to the standard there should be no "MessageID"-Field > in the > SOAP-body. > You may look it up in SPEC: > http://www.3gpp.org/ftp/Specs/archive/23_series/23.140/23140-6d0.zip > (Page 148) > It is also not allowed in MM7Version 5.3.0... > > > Hint: > mm7_make_resp(..); generates a MessageID, if the last parameter isnt > "false"... > ...see "mmlib/mms_mm7soap.c" (lines 1007-1038): > > MSoapMsg_t *mm7_make_resp(MSoapMsg_t *mreq, int status, Octstr *msgid) > { > . > . > if (msgid) > http_header_add(mresp->envelope, "MessageID", > octstr_get_cstr(msgid)); > . > . > } > > Hint#2: > > the method call at "mmsbox/bearerbox.c:201" uses "NULL" as last > parameter: > mresp = mm7_make_resp(mreq, status, NULL); > > So "msgid" should _not_ be checked for empty-string-value instead... > > > ___ > Devel mailing list > Devel@mbuni.org > http://mbuni.org/mailman/listinfo/devel_mbuni.org ___ Devel mailing list Devel@mbuni.org http://mbuni.org/mailman/listinfo/devel_mbuni.org
[Devel] Fixed a bug in mmsbox (patch included)...
Hi there... I just found / fixed a bug in the mmsbox: mbuni-1.1.0/mmsbox$ diff bearerbox.c.old bearerbox.c -- CUT HERE - 188c188 < mresp = mm7_make_resp(mreq, status, msgid); --- > mresp = mm7_make_resp(mreq, status, NULL); -- CUT HERE - Description: The Response-XML generated here is the DeliverRsp for a DeliverReq... ...according to the standard there should be no "MessageID"-Field in the SOAP-body. You may look it up in SPEC: http://www.3gpp.org/ftp/Specs/archive/23_series/23.140/23140-6d0.zip (Page 148) It is also not allowed in MM7Version 5.3.0... Hint: mm7_make_resp(..); generates a MessageID, if the last parameter isnt "false"... ...see "mmlib/mms_mm7soap.c" (lines 1007-1038): MSoapMsg_t *mm7_make_resp(MSoapMsg_t *mreq, int status, Octstr *msgid) { . . if (msgid) http_header_add(mresp->envelope, "MessageID", octstr_get_cstr(msgid)); . . } Hint#2: the method call at "mmsbox/bearerbox.c:201" uses "NULL" as last parameter: mresp = mm7_make_resp(mreq, status, NULL); So "msgid" should _not_ be checked for empty-string-value instead... ___ Devel mailing list Devel@mbuni.org http://mbuni.org/mailman/listinfo/devel_mbuni.org