[Devel] Re: [PATCH] cgroup: remove duplicate code in allocate_cg_link()

2008-07-30 Thread Paul Menage
On Sun, Jul 27, 2008 at 7:20 PM, Li Zefan [EMAIL PROTECTED] wrote: - just call free_cg_links() in allocate_cg_links() - the list will get initialized in allocate_cg_links(), so don't init it twice Signed-off-by: Li Zefan [EMAIL PROTECTED] (Belatedly) Acked-by: Paul Menage [EMAIL PROTECTED]

[Devel] Re: [PATCH] cgroup: uninline cgroup_has_css_refs()

2008-07-30 Thread Paul Menage
On Sun, Jul 27, 2008 at 7:21 PM, Li Zefan [EMAIL PROTECTED] wrote: It's not small enough, and has 2 call sites. textdata bss dec hex filename 1281316764832 193214b79 cgroup.o.orig 1277516764832 192834b53 cgroup.o Signed-off-by: Li Zefan [EMAIL

[Devel] Re: [RFC][PATCH 2/4] res_counter check usage under val

2008-07-30 Thread Paul Menage
On Tue, Jul 29, 2008 at 7:09 PM, Pavel Emelyanov [EMAIL PROTECTED] wrote: I get your point. Logically this lock is unnecessary. (And seems this patch itself is buggy..(maybe refresh miss)) BTW, I'm sorry if I misunderstand. unsigned long long (on x86-32) can be compared safely ? Oops...

[Devel] Re: [RFC][PATCH 2/4] res_counter check usage under val

2008-07-30 Thread Pavel Emelyanov
Paul Menage wrote: On Tue, Jul 29, 2008 at 7:09 PM, Pavel Emelyanov [EMAIL PROTECTED] wrote: I get your point. Logically this lock is unnecessary. (And seems this patch itself is buggy..(maybe refresh miss)) BTW, I'm sorry if I misunderstand. unsigned long long (on x86-32) can be compared

[Devel] Re: [RFC][PATCH 2/2] CR: handle a single task with private memory maps

2008-07-30 Thread Serge E. Hallyn
This list is getting on my nerves. Louis, I'm sorry the threading is going to get messed up. - Forwarded message from [EMAIL PROTECTED] - Subject: Content filtered message notification From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Date: Wed, 30 Jul 2008 09:16:12 -0700 The attached

[Devel] Re: [RFC][PATCH 2/2] CR: handle a single task with private memory maps

2008-07-30 Thread Dave Hansen
On Wed, 2008-07-30 at 11:52 -0500, Serge E. Hallyn wrote: This list is getting on my nerves. Louis, I'm sorry the threading is going to get messed up. I think I just cleared out the mime type filtering. -- Dave ___ Containers mailing list [EMAIL

[Devel] Re: [RFC][PATCH 2/2] CR: handle a single task with private memory maps

2008-07-30 Thread Oren Laadan
KOSAKI Motohiro wrote: Hi Expand the template sys_checkpoint and sys_restart to be able to dump and restore a single task. The task's address space may consist of only private, simple vma's - anonymous or file-mapped. This big patch adds a mechanism to transfer data between kernel or

[Devel] Re: [RFC][PATCH 2/2] CR: handle a single task with private memory maps

2008-07-30 Thread Oren Laadan
Louis Rilling wrote: Hi Oren, On Tue, Jul 29, 2008 at 11:27:17PM -0400, Oren Laadan wrote: Expand the template sys_checkpoint and sys_restart to be able to dump and restore a single task. The task's address space may consist of only private, simple vma's - anonymous or file-mapped. This

[Devel] [RFC][PATCH] kernel-based memory checkpoint/restart

2008-07-30 Thread Dave Hansen
The following is the necessary code to checkpoint and restart a single process's memory, with no shared memory. This is a portion of patches posted to the [EMAIL PROTECTED] list. If you want to play with this, you can get the rest of the code there. At the containers mini-conference before OLS,

[Devel] Re: [RFC][PATCH 0/2] CR: save/restore a single, simple task

2008-07-30 Thread Serge E. Hallyn
Quoting Oren Laadan ([EMAIL PROTECTED]): In the recent mini-summit at OLS 2008 and the following days it was agreed to tackle the checkpoint/restart (CR) by beginning with a very simple case: save and restore a single task, with simple memory layout, disregarding other task state such as

[Devel] Re: [RFC][PATCH 0/2] CR: save/restore a single, simple task

2008-07-30 Thread Dave Hansen
On Wed, 2008-07-30 at 16:35 -0500, Serge E. Hallyn wrote: So task 5 created its mm_struct, task 6 is supposed to use the same mm_struct, so it finds that out from the context? I wonder whether that would start to become complicated when checkpointing nested containers. It also doesn't fit

[Devel] Re: [RFC][PATCH 2/2] CR: handle a single task with private memory maps

2008-07-30 Thread Serge E. Hallyn
Quoting Oren Laadan ([EMAIL PROTECTED]): +int do_checkpoint(struct cr_ctx *ctx) +{ + int ret; + + /* FIX: need to test whether container is checkpointable */ + + ret = cr_write_hdr(ctx); + if (!ret) + ret = cr_write_task(ctx, current); + if (!ret) +

[Devel] Re: [RFC][PATCH 0/2] CR: save/restore a single, simple task

2008-07-30 Thread Serge E. Hallyn
Quoting Oren Laadan ([EMAIL PROTECTED]): In the recent mini-summit at OLS 2008 and the following days it was agreed to tackle the checkpoint/restart (CR) by beginning with a very simple case: save and restore a single task, with simple memory layout, disregarding other task state such as

[Devel] Re: [RFC][PATCH 2/2] CR: handle a single task with private memory maps

2008-07-30 Thread Oren Laadan
Serge E. Hallyn wrote: Quoting Oren Laadan ([EMAIL PROTECTED]): +int do_checkpoint(struct cr_ctx *ctx) +{ +int ret; + +/* FIX: need to test whether container is checkpointable */ + +ret = cr_write_hdr(ctx); +if (!ret) +ret = cr_write_task(ctx, current); +

[Devel] Re: [RFC][PATCH 2/2] CR: handle a single task with private memory maps

2008-07-30 Thread Dave Hansen
On Tue, 2008-07-29 at 23:27 -0400, Oren Laadan wrote: Expand the template sys_checkpoint and sys_restart to be able to dump and restore a single task. The task's address space may consist of only private, simple vma's - anonymous or file-mapped. So, can we all agree that this is a good

[Devel] Re: [RFC][PATCH 0/2] CR: save/restore a single, simple task

2008-07-30 Thread Oren Laadan
Disclaimer: long reply :) Serge E. Hallyn wrote: Quoting Oren Laadan ([EMAIL PROTECTED]): In the recent mini-summit at OLS 2008 and the following days it was agreed to tackle the checkpoint/restart (CR) by beginning with a very simple case: save and restore a single task, with simple memory

[Devel] Re: [RFC][PATCH 0/2] CR: save/restore a single, simple task

2008-07-30 Thread Oren Laadan
Dave Hansen wrote: On Wed, 2008-07-30 at 16:35 -0500, Serge E. Hallyn wrote: So task 5 created its mm_struct, task 6 is supposed to use the same mm_struct, so it finds that out from the context? I wonder whether that would start to become complicated when checkpointing nested containers.