It's great, Thanks!
Lai Jiangshan.
Reviewed-by: Lai Jiangshan <[EMAIL PROTECTED]>
Paul Menage wrote:
> - allocate an array of single pages rather than a single kmalloc() region
I will send a patch for it in few days.
> +
> +static void *cgroup_tasks_start(struct seq_file *s, loff_t *
Hello,
> Hi both,
>
> Fernando is off this week, so may not be able to reply soon, sorry.
>
> Vivek Goyal wrote:
> > On Fri, Sep 05, 2008 at 09:00:17PM +0900, Hirokazu Takahashi wrote:
> >> Hi, fernando,
> >>
> IMHO, optimizing the synchronous path alone would justify the addition
> of
Alexey Dobriyan wrote:
> Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]>
I have exactly the same patch to be submitted :)
Acked-by: Daniel Lezcano <[EMAIL PROTECTED]>
By the way, you are posting patches related to netns. As some of us are
working in this area too, do you mind to sync with us
Hi, Vivek,
> > > > IMHO, optimizing the synchronous path alone would justify the addition
> > > > of io_context in bio. There is more to this though.
> > > >
> > > > As you point out, it would seem that aio and buffered IO would not
> > > > benefit from caching the io context in the bio itself, b
On a system with nfs mounts, if a task unshares its mount namespace,
a oops can occur when the system is rebooted if the task is the last
to unreference the nfs mount. It will try to create a rpc request
using utsname() which has been invalidated by free_nsproxy().
The patch fixes the issue by usi
Quoting Cedric Le Goater ([EMAIL PROTECTED]):
> On a system with nfs mounts, if a task unshares its mount namespace,
> a oops can occur when the system is rebooted if the task is the last
> to unreference the nfs mount. It will try to create a rpc request
> using utsname() which has been invalidate
Quoting Serge E. Hallyn ([EMAIL PROTECTED]):
> Quoting Cedric Le Goater ([EMAIL PROTECTED]):
> > On a system with nfs mounts, if a task unshares its mount namespace,
> > a oops can occur when the system is rebooted if the task is the last
> > to unreference the nfs mount. It will try to create a rp
Serge E. Hallyn wrote:
> Quoting Cedric Le Goater ([EMAIL PROTECTED]):
>> On a system with nfs mounts, if a task unshares its mount namespace,
>> a oops can occur when the system is rebooted if the task is the last
>> to unreference the nfs mount. It will try to create a rpc request
>> using utsnam
On Mon, Sep 8, 2008 at 1:19 AM, Lai Jiangshan <[EMAIL PROTECTED]> wrote:
>
>> + while (index < end) {
>> + int mid = (index + end) / 2;
>> + if (cgrp->tasks_pids[mid] == pid) {
>> + index = mid;
>> +
Quoting Cedric Le Goater ([EMAIL PROTECTED]):
> Serge E. Hallyn wrote:
> > Quoting Cedric Le Goater ([EMAIL PROTECTED]):
> >> On a system with nfs mounts, if a task unshares its mount namespace,
> >> a oops can occur when the system is rebooted if the task is the last
> >> to unreference the nfs mo
On Sat, 2008-09-06 at 21:54 -0400, Oren Laadan wrote:
> The length of the array may be tunable, or even adaptive (e.g. based
> on statistics from recent checkpoints), in the future.
I'm not sure "tuning" it to make those arrays longer than PAGE_SIZE will
ever be a good idea. Seems like we should
Cedric Le Goater <[EMAIL PROTECTED]> writes:
> On a system with nfs mounts, if a task unshares its mount namespace,
> a oops can occur when the system is rebooted if the task is the last
> to unreference the nfs mount. It will try to create a rpc request
> using utsname() which has been invalidate
>>> --- /dev/null
>>> +++ b/checkpoint/sys.c
>>> @@ -0,0 +1,35 @@
>>> +/*
>>> + * Generic container checkpoint-restart
>>> + *
>>> + * Copyright (C) 2008 Oren Laadan
>>> + *
>>> + * This file is subject to the terms and conditions of the GNU General
>>> Public + * License. See the file COPYING
On Sun, 2008-09-07 at 00:52 -0400, Oren Laadan wrote:
> >> + for (i = 0; i < fdt->max_fds; i++) {
> >> + if (!fcheck_files(files, i)
> >>continue;
> >>if (n == max) {
> >> + spin_unlock(&files->file_lock);
> >> + kfree(fdli
On Sat, 2008-09-06 at 23:09 -0400, Oren Laadan wrote:
> >> + ret = cr_kread(ctx, pgarr->addrs, nr * sizeof(unsigned long));
> >> + if (ret < 0)
> >> + return ret;
> >> + pgarr->nleft -= nr;
> >> + pgarr->nused += nr;
> >> + npages -= nr;
As I've said before, I really don't like the model you're
using for multicasting here (if I understand correctly, and
I shamelessly admit I haven't looked at this code in detail).
As I understand it, you're modelling the multiple virtual interfaces
as different pieces of hardware on the same physi
On Thu, 04 Sep 2008 22:34:47 -0700
Paul Menage <[EMAIL PROTECTED]> wrote:
> npids = cgroup_task_count(cgrp);
> + pidarray = kmalloc(npids * sizeof(pid_t), GFP_KERNEL);
kmalloc becomes more unreliable above 32 kbytes and 100% unreliable
above MAX_ORDER.
_
Hello,
I hope that this patch (from 4.7.08) was not forgetten... I don't see
it for example in linux-net (I have an up-to-date linux-next git
tree).
Regards,
Mark
On Wed, Aug 27, 2008 at 6:18 PM, Benjamin Thery <[EMAIL PROTECTED]> wrote:
> Eric W. Biederman wrote:
>>
>> The problem. When implem
Patrick McHardy wrote:
> Alexey Dobriyan wrote:
>> On Thu, Sep 04, 2008 at 06:54:16PM +0200, Patrick McHardy wrote:
>>> [EMAIL PROTECTED] wrote:
Make untracked conntrack per-netns. Compare conntracks with relevant
untracked one.
The following code you'll start laughing at this c
On Sunday 31 August 2008 21:34 Cedric Le Goater wrote:
> Oren Laadan wrote:
> > Dave, Serge:
> >
> > I'm currently away so I must keep this short. I think we have so far
> > more discussion than an actual problem. I'm happy to coordinate with
> > every interested party to eventually see this work g
Hi all,
We would like to ask you a few questions about your use of the Git
version control system. This survey is mainly to understand who is
using Git, how and why.
The results will be published on the Git Wiki
http://git.or.cz/gitwiki/GitSurvey2008
and discussed on the git mailing list.
The
On Sat, 6 Sep 2008 10:44:08 +0400
Alexey Dobriyan <[EMAIL PROTECTED]> wrote:
> Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]>
> ---
>
> net/bridge/br.c | 22 --
> net/bridge/br_if.c |4 ++--
> net/bridge/br_private.h |2 +-
> 3 files changed, 19 ins
Bridge as netdevice doesn't cross netns boundaries.
Bridge ports and bridge itself live in same netns.
Notifiers are fixed.
netns propagated from userspace socket for setup and teardown.
Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]>
---
net/bridge/br_device.c |3 ++-
net/bridge/br_
On Thursday 04 September 2008 18:42 Serge E. Hallyn wrote:
> Quoting Oren Laadan ([EMAIL PROTECTED]):
> > Create trivial sys_checkpoint and sys_restore system calls. They will
> > enable to checkpoint and restart an entire container, to and from a
> > checkpoint image file descriptor.
> >
> > The s
Signed-off-by: Alexey Dobriyan <[EMAIL PROTECTED]>
---
net/bridge/br.c | 22 --
net/bridge/br_if.c |4 ++--
net/bridge/br_private.h |2 +-
3 files changed, 19 insertions(+), 9 deletions(-)
--- a/net/bridge/br.c
+++ b/net/bridge/br.c
@@ -28,6 +28,10 @@ s
Hi,
Well, I believe that again it was somehow forgotten or was not applied for
other reasons, since polling the following URL several times in last
days did not
show this patch (url:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/patches.git)
Regards,
MR
On Thu, Sep 4, 2008 at 9:44 AM, B
Hi,
>go into my tree this week,
I am also interested in this patch; may I ask - what do you mean by
"my tree" ?I am a little newbie in the kernel, as you might understand.
I looked into http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/
for candidates for this git tree you are talk
Andrey Mirkin a écrit :
> Add functions for context allocation/destroy.
> Introduce functions to read/write image.
> Introduce image header and object header.
>
> Signed-off-by: Andrey Mirkin <[EMAIL PROTECTED]>
> ---
> cpt/cpt.h | 37
> cpt/cpt_image.h | 63
On Sat, Sep 06, 2008 at 06:38:21PM -0700, Stephen Hemminger wrote:
> overall, this is fine, but you might want to think about making
> pernet_operations const if possible in future.
pernet_operations are kept in list, so are modified.
___
Containers mai
On Wednesday 03 September 2008 15:44 Cedric Le Goater wrote:
> Andrey Mirkin wrote:
> > Right now they just return -ENOSYS. Later they will provide functionality
> > to checkpoint and restart a container.
> >
> > Both syscalls take as arguments a file descriptor and flags.
> > Also sys_checkpoint t
On Mon, Sep 8, 2008 at 2:16 PM, Andrew Morton <[EMAIL PROTECTED]> wrote:
> On Thu, 04 Sep 2008 22:34:47 -0700
> Paul Menage <[EMAIL PROTECTED]> wrote:
>
>> npids = cgroup_task_count(cgrp);
>> + pidarray = kmalloc(npids * sizeof(pid_t), GFP_KERNEL);
>
> kmalloc becomes more unreliable abov
Alexey Dobriyan wrote:
> It does "kfree(list_head)" which looks wrong because entity that was
> allocated is definitely not list_head.
>
> However, this all works because list_head is first item in
> struct nf_ct_gre_keymap .
The first three patches are already in Linus' tree.
___
Alexey Dobriyan wrote:
> Take netns from skb->dst->dev. It should be safe because, they are called
> from LOCAL_OUT hook where dst is valid (though, I'm not exactly sure about
> IPVS and queueing packets to userspace).
Its safe in all cases since they already expect to only get
called when skb->ds
Alexey Dobriyan wrote:
> Make per-netns a) expectation hash and b) expectations count.
>
> Expectations always belongs to netns to which it's master conntrack belong.
> This is natural and doesn't bloat expectation.
>
> Proc files and leaf users are stubbed to init_net, this is temporary.
Looks
Alexey Dobriyan wrote:
> What is confirmed connection in one netns can very well be unconfirmed
> in another one.
Applied, thanks.
___
Containers mailing list
[EMAIL PROTECTED]
https://lists.linux-foundation.org/mailman/listinfo/containers
_
Alexey Dobriyan wrote:
> It's deducible from skb->dev or skb->dst->dev, but we know netns at
> the moment of call, so pass it down and use for finding and creating
> conntracks.
Applied, thanks.
___
Containers mailing list
[EMAIL PROTECTED]
https://lists
Alexey Dobriyan wrote:
> Again, it's deducible from skb, but we're going to use it for
> nf_conntrack_checksum and statistics, so just pass it from upper layer.
Applied, thanks.
___
Containers mailing list
[EMAIL PROTECTED]
https://lists.linux-foundation
Alexey Dobriyan wrote:
Applied, thanks.
___
Containers mailing list
[EMAIL PROTECTED]
https://lists.linux-foundation.org/mailman/listinfo/containers
___
Devel mailing list
Devel@openvz.org
https://openvz.org/
Alexey Dobriyan wrote:
Applied, thanks.
___
Containers mailing list
[EMAIL PROTECTED]
https://lists.linux-foundation.org/mailman/listinfo/containers
___
Devel mailing list
Devel@openvz.org
https://openvz.org/m
Dave Hansen wrote:
> On Sat, 2008-09-06 at 23:09 -0400, Oren Laadan wrote:
[...]
+ if (writable && !(vma->vm_flags & VM_WRITE))
+ flags = vma->vm_flags | VM_WRITE;
+ else if (!writable && (vma->vm_flags & VM_WRITE))
+ flags = vma->vm_flags & ~VM_WRITE;
>>
Alexey Dobriyan wrote:
Applied, thanks.
___
Containers mailing list
[EMAIL PROTECTED]
https://lists.linux-foundation.org/mailman/listinfo/containers
___
Devel mailing list
Devel@openvz.org
https://openvz.org/m
Alexey Dobriyan wrote:
Applied, thanks.
___
Containers mailing list
[EMAIL PROTECTED]
https://lists.linux-foundation.org/mailman/listinfo/containers
___
Devel mailing list
Devel@openvz.org
https://openvz.org/m
Alexey Dobriyan wrote:
> Conntrack code will use it for
> a) removing expectations and helpers when corresponding module is removed, and
> b) removing conntracks when L3 protocol conntrack module is removed.
Applied, thanks.
___
Containers mailing list
[
Alexey Dobriyan wrote:
Applthanks.
___
Containers mailing list
[EMAIL PROTECTED]
https://lists.linux-foundation.org/mailman/listinfo/containers
___
Devel mailing list
Devel@openvz.org
https://openvz.org/mailma
Alexey Dobriyan wrote:
> This is cleaner, we already know conntrack to which event is relevant.
Applied, thanks.
___
Containers mailing list
[EMAIL PROTECTED]
https://lists.linux-foundation.org/mailman/listinfo/containers
___
Alexey Dobriyan wrote:
> Heh, last minute proof-reading of this patch made me think,
> that this is actually unneeded, simply because "ct" pointers will be
> different for different conntracks in different netns, just like they
> are different in one netns.
>
> Not so sure anymore.
Its necessary
46 matches
Mail list logo
