On Tue, Feb 13, 2007 at 04:05:30PM +0300, Alexey Dobriyan wrote:
On Mon, Feb 12, 2007 at 01:36:34PM -0800, Roland McGrath wrote:
2. The following proggie renders box unusable in ~10 seconds (but not
mainline kernel where Ctrl+C will kill process).
I haven't been able to reproduce
PROTECTED]
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
arch/ia64/ia32/sys_ia32.c | 10 +++---
arch/parisc/kernel/sys_parisc32.c | 10 --
2 files changed, 15 insertions(+), 5 deletions(-)
--- a/arch/ia64/ia32/sys_ia32.c
+++ b/arch/ia64/ia32/sys_ia32.c
@@ -1267,6
[Apply after:
lutimesat-simplify-utime2.patch
lutimesat-extend-do_utimes-with-flags.patch
lutimesat-actual-syscall-and-wire-up-on-i386.patch
Tweak compat syscall number to match normal syscall number if needed.]
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
arch/x86_64/ia32
On Tue, Feb 27, 2007 at 02:06:24PM +1100, Stephen Rothwell wrote:
On Mon, 26 Feb 2007 19:50:24 +0300 Alexey Dobriyan [EMAIL PROTECTED] wrote:
+asmlinkage long compat_sys_lutimesat(int dfd, char __user *filename,
struct compat_timespec __user *utimes)
+{
+ struct timespec ts[2
);
[find PDE with refcount 0]
[check refcount and free PDE]
spin_unlock(proc_subdir_lock);
proc_get_inode:
de_get(de); /* boom */
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED
, ...
[de_put on error path --adobriyan]
Signed-off-by: Darrick J. Wong [EMAIL PROTECTED]
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
fs/proc/generic.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
--- a/fs/proc/generic.c
+++ b/fs/proc/generic.c
@@ -478,14 +478,21
, or not?
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
fs/proc/inode.c |2 --
1 file changed, 2 deletions(-)
--- a/fs/proc/inode.c
+++ b/fs/proc/inode.c
@@ -418,8 +418,6 @@ struct inode *proc_get_inode(struct supe
{
struct inode * inode;
- WARN_ON(de de-deleted
ANK says: It is rarely used, that's wy it was not noticed.
But in the places, where it is used, it should be disaster.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
net/core/skbuff.c |1 +
1 file changed, 1 insertion(+)
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -463,6
:d30b8e78
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
fs/proc/base.c|7 +++
kernel/time/timer_list.c |6 ++
kernel/time/timer_stats.c |6 ++
mm/slab.c |3 +++
4 files changed, 22 insertions(+)
--- a/fs/proc/base.c
+++ b/fs/proc/base.c
On Thu, Mar 15, 2007 at 04:53:59PM +, Paulo Marques wrote:
Alexey Dobriyan wrote:
[cc'ing folks whose proc files are affected]
kallsyms_lookup() can call module_address_lookup() which iterates over
modules list without module_mutex taken. Comment at the top of
module_address_lookup
On Thu, Mar 15, 2007 at 05:53:04PM -0800, Andrew Morton wrote:
My, what a lot of code you have here. I note that nobody can be assed even
reviewing it. Now why is that?
I hope, Al could find some time again.
On Sun, 11 Mar 2007 20:04:56 +0300 Alexey Dobriyan [EMAIL PROTECTED] wrote:
Fix
4d 85 ed 7f f1 e9 b9 00 00 00 8b 0f 81 f9 ff
0f 00 00 b8 ea 45 36 c0 0f 46 c8 8b 54 24 30 89 c8 eb 06 80 38 00 74 07 40 4a
83 fa ff 75 f4 29 c8 89 c3 89 e8 f6 44 24
EIP: [c01dc361] vsnprintf+0x2af/0x48c SS:ESP 0068:dbe2bec4
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
include/linux
:d30b8e78
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
fs/proc/base.c|7 +++
kernel/time/timer_list.c |6 ++
kernel/time/timer_stats.c |6 ++
mm/slab.c |3 +++
4 files changed, 22 insertions(+)
--- a/fs/proc/base.c
+++ b/fs/proc/base.c
On Fri, Mar 16, 2007 at 08:27:29PM +, Paulo Marques wrote:
Andrew Morton wrote:
On Fri, 16 Mar 2007 17:16:39 + Paulo Marques [EMAIL PROTECTED]
wrote:
Does freeze_processes() / unfreeze_processes() solve this by only
freezing processes that have voluntarily scheduled (opposed to
On Fri, Mar 16, 2007 at 03:50:30AM -0800, Andrew Morton wrote:
On Fri, 16 Mar 2007 12:16:13 +0300 Alexey Dobriyan [EMAIL PROTECTED] wrote:
On Thu, Mar 15, 2007 at 05:53:04PM -0800, Andrew Morton wrote:
My, what a lot of code you have here. I note that nobody can be assed
even
Dances with cpumasks go away.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
arch/i386/kernel/cpu/cpufreq/p4-clockmod.c | 31 +
1 file changed, 6 insertions(+), 25 deletions(-)
--- a/arch/i386/kernel/cpu/cpufreq/p4-clockmod.c
+++ b/arch/i386/kernel/cpu
eb 06 80 38 00 74 07 40 4a
83 fa ff 75 f4 29 c8 89 c6 8b 44 24 28 89
EIP: [c01cefa7] vsnprintf+0x3a4/0x5fc SS:ESP 0068:f31f5e68
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
drivers/char/tty_io.c |9 -
fs/proc/proc_tty.c |3 +++
include/linux/tty_driver.h
On Thu, Mar 22, 2007 at 09:29:05AM -0800, Andrew Morton wrote:
On Thu, 22 Mar 2007 14:25:42 +0300 Alexey Dobriyan [EMAIL PROTECTED] wrote:
Additions and removal from tty_drivers list were just done as well as
iterating on it for /proc/tty/drivers generation.
--- a/drivers/char/tty_io.c
* d_alloc() in sock_attach_fd() fails leaving -f_dentry of new file NULL
* bail out to out_fd label, doing fput()/__fput() on new file
* but __fput() assumes valid -f_dentry and dereferences it
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
net/socket.c |7 ++-
1 file changed, 6
Now that cpuid_on_cpu() is in core, cpuid driver can be shrinked.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
arch/i386/kernel/cpuid.c | 41 +
1 file changed, 1 insertion(+), 40 deletions(-)
--- a/arch/i386/kernel/cpuid.c
+++ b/arch/i386
They will be used by cpuid driver and powernow-k8 cpufreq driver.
With these changes powernow-k8 driver could run correctly on OpenVZ kernels
with virtual cpus enabled (SCHED_VCPU).
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
arch/i386/lib/Makefile |2 -
arch/i386/lib
Remove changes and restoring of allowed cpu masks as they aren't needed now.
Tested on 2-way Opteron.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
arch/i386/kernel/cpu/cpufreq/powernow-k8.c | 102 -
1 file changed, 29 insertions(+), 73 deletions
Several kallsyms_lookup() pass dummy arguments but only need, say,
module's name. Make kallsyms_lookup() accept NULLs where possible.
Also, makes picture clearer about what interfaces are needed for all
symbol resolving business.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
arch/parisc
On Mon, Apr 02, 2007 at 02:10:29PM +0200, Andi Kleen wrote:
On Monday 02 April 2007 13:38, Alexey Dobriyan wrote:
They will be used by cpuid driver and powernow-k8 cpufreq driver.
With these changes powernow-k8 driver could run correctly on OpenVZ kernels
with virtual cpus enabled
On Tue, Apr 03, 2007 at 03:42:50PM +0200, Andi Kleen wrote:
Both powernow-k8 and cpuid attempt to schedule
to the target CPU so they should already run there. But it is some other
CPU,
but when they ask your _on_cpu() functions they suddenly get a real CPU?
Where is the difference
After
cat /proc/self/pagemap
BUG: sleeping function called from invalid context at include/asm/uaccess.h:453
in_atomic():1, irqs_disabled():0
1 lock held by cat/14183:
#0: (mm-mmap_sem){}, at: [c017d17b] pagemap_read+0x11f/0x21b
[c01b7bc7] copy_to_user+0x37/0x4c
[c017cf92]
pcd_lock and pf_spin_lock are passed to blk_init_queue() which,
seeing them as valid lock pointer, sets it as -queue_lock.
The problem is that pcd_lock and pf_spin_lock aren't initialized
anywhere.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
drivers/block/paride/pcd.c |2
[double freeing of struct utrace leading to oops in
__rcu_process_callbacks]
Hi, Roland,
utrace debugging you've put into 2.6.21-rc6-mm1 helped. Two double-frees
reproduced:
1) BUG at kernel/utrace.c:176
rcu_utrace_free
utrace_reap
utrace_release_task
message and double frees on
2-way P3, 8-way ia64, Core 2 Duo boxes. Testcase is at the first link.
I _think_ it adds leak if utrace_reap() takes branch without freeing
but, well, I hope Roland will give me some clue on how to fix it too.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
kernel
On Tue, Apr 24, 2007 at 01:10:23PM +0400, Alexey Dobriyan wrote:
ยน But I see whole can of other bugs! I think they were already lurking
but weren't easily reproducable without hitting double-free first.
FWIW, it's
BUG_ON(!list_empty(tsk-ptracees));
mmm, pretty easily reproduced
still happen
NOTE: most certainly some locking is still missed and I need to test
on a couple more boxes.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
include/linux/sched.h |7
include/linux/tracehook.h | 15 -
include/linux/utrace.h| 39 ++-
kernel/fork.c
On Mon, May 21, 2007 at 09:47:31AM +0200, Christian Kaiser2 wrote:
I did some testing with the LTP Regression Test Suite
(http://ltp.sourceforge.net) inside a VE the last days. When I enable all
capabilites except setpcap I get one warning and three failures. When I
run the tests native (in
On Wed, May 23, 2007 at 04:41:03PM +0400, Kirill Korotaev wrote:
Christian Kaiser2 wrote:
[EMAIL PROTECTED] vzctl-3.0.16]# /etc/init.d/vz start
Starting OpenVZ: [ OK ]
Bringing up interface venet0: [ OK ]
I ran ltp-full-20070430 and utstest.c forgot to restore original
hostname from serge2. ;-)
___
Devel mailing list
Devel@openvz.org
https://openvz.org/mailman/listinfo/devel
On Wed, May 23, 2007 at 09:49:44AM -0500, Serge E. Hallyn wrote:
Quoting Alexey Dobriyan ([EMAIL PROTECTED]):
I ran ltp-full-20070430 and utstest.c forgot to restore original
hostname from serge2. ;-)
Oh that's just me taking over the world, one workstation at a time.
Hopefully
All manipulations with struct seq_file::version are done under
struct seq_file::lock except one introduced in commit
d6b7a781c51c91dd054e5c437885205592faac21
aka [PATCH] Speed up /proc/pid/maps
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
fs/seq_file.c |2 +-
1 file changed, 1
On Tue, May 29, 2007 at 05:16:23PM -0700, Andrew Morton wrote:
On Mon, 28 May 2007 17:41:57 +0400
Alexey Dobriyan [EMAIL PROTECTED] wrote:
--- a/fs/proc/base.c
+++ b/fs/proc/base.c
@@ -204,12 +204,17 @@ static int proc_pid_environ(struct task_
int res = 0;
struct mm_struct *mm
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
drivers/block/loop.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -521,7 +521,7 @@ static int loop_make_request(request_queue_t *q, struct bio
*old_bio
line of first object every time it's called, until enough
objects are added to -f_pos return in bounds.
Fix is to update -index only after we're sure we saw enough objects down
the road.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
fs/seq_file.c | 16 ++--
1 file changed, 10
Wrong pointer was used as kmem_cache pointer.
[Here /proc/slab_allocators appears as empty file, but it's just me, probably]
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
mm/slab.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -4401,7
On Sat, Jun 09, 2007 at 12:10:25PM +0400, Pavel Emelianov wrote:
* definitely better results for suka's patchset. suka's patchset is
also getting better results with unixbench on a 2.6.22-rc1-mm1 but
the values are really dispersed. can you confirm ?
* suka's patchset would benefit
On Wed, Jun 20, 2007 at 02:41:48PM -0700, Roland McGrath wrote:
What's the purpose of the change?
Chopping small bits of utrace to mainline.
regset stuff looks reasonable and self-contained enough to start with.
However, regset part in utrace contain quite a few unused things, so
I'm leaving
sparse now warns about
arch/x86_64/mm/mmap.c:15:3: warning: returning void-valued expression
Generated code looks correct: there is jump to the end of
arch_pick_mmap_layout() after ia32_pick_mmap_layout(), but this should be fixed
regardless.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED
Adding -W -Wno-stupid-warnings results in the following warning:
mm/filemap.c: In function 'generic_file_buffered_write':
mm/filemap.c:2179: warning: comparison of unsigned expression = 0 is always
true
if (likely(copied = 0)) {
if (!status)
about this driver.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
drivers/media/video/se401.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/media/video/se401.c
+++ b/drivers/media/video/se401.c
@@ -1280,7 +1280,7 @@ static int se401_init(struct usb_se401 *se401
list_del() hardly can fail, so checking for return value is pointless
(and current code always return 0).
Nobody really cared that return value anyway.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
arch/ia64/ia32/binfmt_elf32.c |2 +-
fs/exec.c |3
These aren't modular, so SLAB_PANIC is OK.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
fs/proc/inode.c |4 +---
kernel/posix-timers.c |3 ++-
mm/shmem.c|4 +---
3 files changed, 4 insertions(+), 7 deletions(-)
--- a/fs/proc/inode.c
+++ b/fs/proc/inode.c
On every open/close one struct seq_operations leaks.
Kudos to /proc/slab_allocators.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
fs/proc/base.c|2 +-
kernel/sched_debug.c |2 +-
kernel/time/timer_list.c |2 +-
kernel/time/timer_stats.c |2 +-
4 files
There is separate notifier header, but no separate notifier .c file.
Extract notifier code out of kernel/sys.c which will remain for
misc syscalls I hope. Merge kernel/die_notifier.c into kernel/notifier.c.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
include/linux/notifier.h |2
On Thu, Jul 19, 2007 at 02:48:59PM -0700, Andrew Morton wrote:
On Thu, 19 Jul 2007 20:46:11 +0400
Alexey Dobriyan [EMAIL PROTECTED] wrote:
There is separate notifier header, but no separate notifier .c file.
Extract notifier code out of kernel/sys.c which will remain for
misc syscalls
the flow of new CTL_ numbers,
because most of sysctls are copy-pasted. CTL_UNNUMBERED doesn't solve
this problem at all.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
Documentation/sysctl/ctl_unnumbered.txt| 15 ++-
arch/ia64/kernel/crash.c |1 -
arch
On Thu, Jul 26, 2007 at 11:24:12AM -0600, Eric W. Biederman wrote:
Alexey Dobriyan [EMAIL PROTECTED] writes:
CTL_UNNUMBERED is unneeded, because it expands to
.ctl_name = 0
The same effect can be achieved by skipping .ctl_name initialization,
saving one line per sysctl
commit eab03ac7bd3e0da99eb9dc068772a85a5e3f3577 aka
[PATCH] Get rid of /proc/sys/proc was good commit except strace(1) compile
breakage it introduced:
system.c:1581: error: 'CTL_PROC' undeclared here (not in a function)
So, add dummy enum back.
Signed-off-by: Alexey Dobriyan [EMAIL
[c010248e] sysenter_past_esp+0x5f/0x85
===
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
fs/seq_file.c| 25 -
include/linux/seq_file.h |1 +
2 files changed, 21 insertions(+), 5 deletions(-)
--- a/fs/seq_file.c
+++ b/fs
=245735
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
kernel/ptrace.c | 42 +-
1 file changed, 21 insertions(+), 21 deletions(-)
--- a/kernel/ptrace.c
+++ b/kernel/ptrace.c
@@ -327,6 +327,8 @@ static int ptrace_attach(struct task_struct *task
in
such cases.
Please, apply.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
drivers/char/ipmi/ipmi_msghandler.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/char/ipmi/ipmi_msghandler.c
+++ b/drivers/char/ipmi/ipmi_msghandler.c
@@ -4136,7 +4136,7 @@ static __exit void
kernel.sched_domain hierarchy is under CTL_UNNUMBERED and thus
unreachable to sysctl(2). Generating .ctl_number's in such situation is
not useful.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
kernel/sched.c | 38 +-
1 file changed, 21 insertions
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
kernel/user_namespace.c |1 +
1 file changed, 1 insertion(+)
--- a/kernel/user_namespace.c
+++ b/kernel/user_namespace.c
@@ -81,6 +81,7 @@ void free_user_ns(struct kref *kref)
struct user_namespace *ns;
ns = container_of
'
hostname = 'aa'
Hostname is sometimes corrupted.
Yes, even _the_ simplest namespace activity had bug in it. :-(
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
kernel/utsname.c |2 ++
1 file changed, 2 insertions(+)
--- a/kernel/utsname.c
+++ b
for those who deselect POSIX message queues.
Reduces SLAB size of user_struct from 64 to 32 bytes here,
SLUB size -- from 40 bytes to 32 bytes.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
include/linux/sched.h |2 ++
kernel/user.c |2 --
2 files changed, 2 insertions
Save some space because uid_hash_find() has 3 callsites.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
kernel/user.c |7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
--- a/kernel/user.c
+++ b/kernel/user.c
@@ -55,17 +55,17 @@ struct user_struct root_user
Quite a few fields are zeroed during user_struct creation, so use
kmem_cache_zalloc() -- save a few lines and #ifdef. Also will help avoid
#ifdef CONFIG_POSIX_MQUEUE in next patch.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
kernel/user.c | 13 +
1 file changed, 1
Modular puppyvisor started giving linking errors
MODPOST 1 modules
ERROR: kasprintf [drivers/lguest/lg.ko] undefined!
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
lib/Makefile |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/lib/Makefile
+++ b/lib
tests on 2-way Opteron 246.
Sml degradation on UP P4 (within errors).
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
kernel/exit.c |6 +++---
kernel/fork.c | 20 ++--
2 files changed, 13 insertions(+), 13 deletions(-)
--- a/kernel/exit.c
+++ b/kernel/exit.c
On Thu, Oct 04, 2007 at 05:54:11PM +0400, Pavel Emelyanov wrote:
With the net namespaces many code leaved the __init section,
thus making the kernel occupy more memory than it did before.
Since we have a config option that prohibits the namespace
creation, the functions that
I plan to kill -get_info which means killing proc_net_create().
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
net/ipv4/netfilter/ip_queue.c | 36 +++-
net/ipv6/netfilter/ip6_queue.c | 36 +++-
2 files changed, 38
printing eip: f881b9f3 *pdpt = 3001 1*pde = 0480a067 *pte
=
^^^
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
arch/x86/mm/fault_32.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/arch
Code is using knowledge that nf_sockopt_ops::list list_head is first
field in structure by using casts. Switch to list_for_each_entry()
itetators while I am at it.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
net/netfilter/nf_sockopt.c | 12
1 file changed, 4 insertions
On Mon, Oct 22, 2007 at 04:33:33PM +0400, Pavel Emelyanov wrote:
And add the forward declaration for br_handle_frame_hook in
include/linux/if_bridge.h
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -699,8 +699,10 @@ struct net_device
/* Network namespace this
On Wed, Oct 24, 2007 at 12:33:18PM +0200, Ingo Molnar wrote:
* Pekka Enberg [EMAIL PROTECTED] wrote:
- printk(KERN_ALERT *pde = %016Lx , page);
+ printk(*pde = %016Lx , page);
Use the new KERN_CONT annotation here?
indeed - i changed
Some watchdog drivers initialize global spinlocks in module's init function
which is tolerable, but some do it in PCI probe function. So, switch to
static initialization to fix theoretical bugs and, more importantly, stop
giving people bad examples.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED
/0x3f SS:ESP 0068:c587bf1c
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
net/core/neighbour.c |2 ++
1 file changed, 2 insertions(+)
--- a/net/core/neighbour.c
+++ b/net/core/neighbour.c
@@ -1435,6 +1435,8 @@ int neigh_table_clear(struct neigh_table *tbl)
kfree(tbl-phash_buckets
On Thu, Nov 01, 2007 at 06:48:25PM +0300, Pavel Emelyanov wrote:
Eric W. Biederman wrote:
It appears we overlooked support for removing generic proc files
when we added support for multiple proc super blocks. Handle
that now.
Signed-off-by: Eric W. Biederman [EMAIL PROTECTED]
AFAIS
This removes last proc_net_create() user. Kudos to Benjamin Thery and
Stephen Hemminger for comments on previous version.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
net/ipv6/route.c | 91 +--
1 file changed, 29 insertions(+), 62
proc_net_create() stands on the way of shrinking the number of
interfaces one can use for /proc files, namely, it uses -get_info
hook which will be converted, deprecated and deleted on its own
schedule.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
Documentation/feature-removal
* it already statically initialized
* reinitializing live global spinlock every time netns is
setup is also wrong
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
net/core/dev.c |1 -
1 file changed, 1 deletion(-)
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -4330,7 +4330,6 @@ static
proc is not modular, so MODULE_LICENSE just expands to empty space. proc
without doubts remains GPLed.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
fs/proc/inode.c |1 -
1 file changed, 1 deletion(-)
--- a/fs/proc/inode.c
+++ b/fs/proc/inode.c
@@ -476,4 +476,3 @@ out_no_root
It's much more visible that some printk. I still has an unexplained oops
in proc, so let's leave it for a while.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
fs/proc/inode.c |7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
--- a/fs/proc/inode.c
+++ b/fs/proc/inode.c
kernel
We can get rid of LOCK/UNLOCK pair after getting inode simply by jumping
to unlock_kernel() directly.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
fs/proc/generic.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/fs/proc/generic.c
+++ b/fs/proc/generic.c
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
fs/proc/generic.c | 18 ++
fs/proc/proc_tty.c |3 ---
2 files changed, 6 insertions(+), 15 deletions(-)
--- a/fs/proc/generic.c
+++ b/fs/proc/generic.c
@@ -25,12 +25,6 @@
#include internal.h
-static ssize_t
proc symlinks always have valid -data containing destination of symlink.
No need to check it on removal -- proc_symlink() already done it.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
fs/proc/generic.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/fs/proc/generic.c
Before proc_register() all PDEs are created by proc_create() which
doesn't set -proc_iops and -proc_fops -- they're NULL. So those
branches in proc_register() always taken.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
fs/proc/generic.c | 15 +--
1 file changed, 5
fix can be found here:
http://bugzilla.kernel.org/show_bug.cgi?id=8798
[\n fixlet and no undescriptive variable usage --adobriyan]
Signed-off-by: Zhang Rui [EMAIL PROTECTED]
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
fs/proc/generic.c | 10 ++
1 file changed, 10 insertions
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
fs/proc/generic.c | 37 -
fs/proc/internal.h |2 --
fs/proc/root.c |2 +-
3 files changed, 1 insertion(+), 40 deletions(-)
--- a/fs/proc/generic.c
+++ b/fs/proc/generic.c
@@ -544,41 +544,6
more undestandable:
* original looks like a loop, however, it's a loop with unconditional
trailing break; -- not loop at all.
* more explicit statement that proc_subdir_lock protects only -subdir lists.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
fs/proc/generic.c | 67
:f380be44
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
fs/proc/generic.c |9 ++---
fs/proc/inode.c |9 ++---
fs/proc/root.c |1 +
include/linux/proc_fs.h |1 -
4 files changed, 5 insertions(+), 15 deletions(-)
--- a/fs/proc/generic.c
+++ b/fs/proc
On Fri, Nov 16, 2007 at 01:46:42PM -0800, Andrew Morton wrote:
On Thu, 15 Nov 2007 19:12:49 +0300
Alexey Dobriyan [EMAIL PROTECTED] wrote:
It's much more visible that some printk. I still has an unexplained oops
in proc, so let's leave it for a while.
--- a/fs/proc/inode.c
+++ b/fs
On Tue, Nov 20, 2007 at 08:08:42PM -0800, Andrew Morton wrote:
On Fri, 16 Nov 2007 18:10:15 +0300 Alexey Dobriyan [EMAIL PROTECTED] wrote:
We can take proc_subdir_lock for duration of list searching and removing
from lists only. It can't hurt -- we can gather any amount of looked up
PDEs
On Wed, Nov 28, 2007 at 11:37:48PM +0100, Josip Rodin wrote:
Is there a known problem with checkpointing in OpenVZ kernel 2.6.22?
Yes. Hopefully CPT will be back in 2.6.24 branch.
I'm getting the following errors:
CC [M] kernel/cpt/cpt_dump.o
kernel/cpt/cpt_dump.c: In function
continues to work.
Patch survives many hours of modprobe/rmmod/cat loops without new bugs
which can be attributed to refcounting.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
fs/proc/generic.c |9 ++---
fs/proc/inode.c |9 ++---
fs/proc/root.c |1
On Thu, Dec 13, 2007 at 05:18:42PM +0300, Denis V. Lunev wrote:
There are to many spaces between type and function name in the declaration
of fib rules manipulation routines. Eat them and save a couple of lines.
If this patch is going in, it would be nice to get rid of extern as
well.
.
Code: 75 21 68 e1 1a 19 c1 68 87 00 00 00 68 b8 e8 1f c1 68 25 73 1f c1 e8 84
06 e9 ff e8 52 b8 e7 ff 83 c4 10 9c 5f fa e8 28 89 ea ff f0 fe 4e 04 79 0a f3
90 80 7e 04 00 7e f8 eb f0 39 76 34 74 33
EIP: [c1188c1b] mutex_lock_nested+0x75/0x25d SS:ESP 0068:e8ea1ef8
Signed-off-by: Alexey Dobriyan
[PATCH -mm 2/4] hifn_795x: fixup container_of() usage
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
drivers/crypto/hifn_795x.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/crypto/hifn_795x.c
+++ b/drivers/crypto/hifn_795x.c
@@ -664,7 +664,7 @@ struct
commit c064c4811b3e87ff8202f5a966ff4eea0bc54575
Author: Daniel Lezcano [EMAIL PROTECTED]
Date: Thu Jan 10 02:56:03 2008 -0800
[NETNS][IPV6]: Make ip6_frags per namespace.
The ip6_frags is moved to the network namespace structure. Because
there can be multiple instances
On Thu, Jan 17, 2008 at 11:40:42AM +0100, Daniel Lezcano wrote:
Alexey Dobriyan wrote:
commit c064c4811b3e87ff8202f5a966ff4eea0bc54575
Author: Daniel Lezcano [EMAIL PROTECTED]
Date: Thu Jan 10 02:56:03 2008 -0800
[NETNS][IPV6]: Make ip6_frags per namespace.
The ip6_frags
On Thu, Jan 17, 2008 at 01:01:11PM +0100, Daniel Lezcano wrote:
Alexey Dobriyan wrote:
On Thu, Jan 17, 2008 at 11:40:42AM +0100, Daniel Lezcano wrote:
Alexey Dobriyan wrote:
commit c064c4811b3e87ff8202f5a966ff4eea0bc54575
Author: Daniel Lezcano [EMAIL PROTECTED]
Date: Thu Jan 10 02:56:03
of table modules is done.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
include/linux/netfilter_arp/arp_tables.h |4 ++--
include/linux/netfilter_ipv4/ip_tables.h |5 +++--
include/linux/netfilter_ipv6/ip6_tables.h |4 ++--
net/ipv4/netfilter/arp_tables.c | 22
In fact all we want is per-netns set of rules, however doing that will
unnecessary complicate routines such as ipt_hook()/ipt_do_table, so
make full xt_table array per-netns.
Every user stubbed with init_net for a while.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
include/linux
.. all the way down to table searching functions.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
net/ipv4/netfilter/ip_tables.c | 46 -
1 file changed, 23 insertions(+), 23 deletions(-)
--- a/net/ipv4/netfilter/ip_tables.c
+++ b/net/ipv4
the effect.
Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED]
---
include/net/netns/ipv4.h|5
net/ipv4/netfilter/iptable_filter.c | 41 ---
net/ipv4/netfilter/iptable_mangle.c | 41 ---
net/ipv4/netfilter
1 - 100 of 455 matches
Mail list logo
