[Devel] [patch 2.6.21-rc3] [smbfs] double free memory corruption in smbfs

2007-03-14 Thread Vasily Averin
but last smb_rput still tries to free it again. To prevent this issue rq_trans2buffer pointer should be set to NULL after kfree. Signed-off-by: Vasily Averin [EMAIL PROTECTED] --- 2.6.21-rc3/fs/smbfs/request.c 2007-03-13 14:22:53.0 +0300 +++ 2.6.21-rc3/fs/smbfs/request.c 2007-03-14

[Devel] dead code: EXT3_IOC_WAIT_FOR_READONLY?

2007-03-16 Thread Vasily Averin
)-turn_ro_timer that nobody uses in kernel. I do not understand the function of this ioctl and believe this code is dead long time ago. From my POV it makes sense to remove it from kernel instead of fixing it. Has somebody any objections? Thank you, Vasily Averin

[Devel] [PATCH 2.6.21-rc5] [I2O] block IO errors on i2o disk

2007-03-26 Thread Vasily Averin
any drawbacks and restores the normal driver's work. Signed-off-by: Vasily Averin [EMAIL PROTECTED] --- 2.6.21-rc5/drivers/message/i2o/i2o_block.c 2007-02-04 21:44:54.0 +0300 +++ 2.6.21-rc5/drivers/message/i2o/i2o_block.c 2007-03-26 11:03:52.0 +0400 @@ -390,13 +390,6

[Devel] [PATCH 2.6.21-rc6] [netfilter] early_drop imrovement

2007-04-06 Thread Vasily Averin
bucket may be empty but the neighbour ones can have the number of conntracks that can be freed. With the following patch early_drop() will search conntracks in all hash buckets. Signed-off-by: Vasily Averin [EMAIL PROTECTED] --- 2.6.21-rc6/net/ipv4/netfilter/ip_conntrack_core.c.erdrp +++ 2.6.21

[Devel] [PATCH 2.6.21-rc6] [netfilter] early_drop imrovement

2007-04-06 Thread Vasily Averin
bucket may be empty but the neighbour ones can have the number of conntracks that can be freed. With the following patch early_drop() will search conntracks in all hash buckets. Signed-off-by: Vasily Averin [EMAIL PROTECTED] --- 2.6.21-rc6/net/ipv4/netfilter/ip_conntrack_core.c.erdrp +++ 2.6.21

[Devel] Re: [PATCH 2.6.21-rc6] [netfilter] early_drop imrovement

2007-04-06 Thread Vasily Averin
Eric Dumazet wrote: On Fri, 06 Apr 2007 12:00:29 +0400 Vasily Averin [EMAIL PROTECTED] wrote: When the number of conntracks is reached ip_conntrack_max limit, early_drop() is called and tries to free one of already used conntracks in one of the hash buckets. If it does not find any

[Devel] [PATCH nf-2.6.22] [netfilter] early_drop imrovement

2007-04-07 Thread Vasily Averin
bucket and allows to search conntracks in other hash buckets. Signed-off-by: Vasily Averin [EMAIL PROTECTED] diff --git a/net/netfilter/nf_conntrack_core.c b/net/netfilter/nf_conntrack_core.c index e132c8a..d0b5794 100644 --- a/net/netfilter/nf_conntrack_core.c +++ b/net/netfilter

[Devel] Re: [PATCH nf-2.6.22] [netfilter] early_drop imrovement

2007-04-07 Thread Vasily Averin
Eric Dumazet wrote: Vasily Averin a e'crit : When the number of conntracks is reached nf_conntrack_max limit, early_drop() is called and tries to free one of already used conntracks in one of the hash buckets. If it does not find any conntracks that may be freed, it leads to transmission

[Devel] [NETFILTER] early_drop() imrovement (v3)

2007-05-09 Thread Vasily Averin
bucket (NF_CT_PER_BUCKET) and allows to search conntracks in other hash buckets. As result in any case the search will have the same chances to free one of the conntracks and the check will not lead to long delays. Signed-off-by: Vasily Averin [EMAIL PROTECTED] diff --git a/net/netfilter

[Devel] [patch i2o] i2o layer cleanup

2007-05-15 Thread Vasily Averin
5/6] i2o_proc files permission [patch i2o 6/6] i2o debug output cleanup However because of Markus Lidel is not i2o maintainer now, I do not understand who should agree the following patches. Thank you, Vasily Averin ___ Devel mailing list Devel

[Devel] [patch i2o 2/6] wrong memory access in i2o_block_device_lock()

2007-05-15 Thread Vasily Averin
This patch fixes access to memory that has not been allocated: i2o_msg_get_wait() can returns errors different from I2O_QUEUE_EMPTY. But the result is checked only against this code. If it is not I2O_QUEUE_EMPTY then we dereference the error code as the pointer later. Signed-off-by: Vasily Averin

[Devel] [patch i2o 3/6] i2o message leak in i2o_msg_post_wait_mem()

2007-05-15 Thread Vasily Averin
We need to free i2o msg in case of error. Signed-off-by: Vasily Averin [EMAIL PROTECTED] --- lk2.6/drivers/message/i2o/exec-osm.c +++ lk2.6/drivers/message/i2o/exec-osm.c @@ -131,8 +131,10 @@ int i2o_msg_post_wait_mem(struct i2o_con int rc = 0; wait = i2o_exec_wait_alloc

[Devel] [patch i2o 4/6] i2o proc reading oops

2007-05-15 Thread Vasily Averin
fixed oops on reading from some i2o proc files (i2o_seq_show_driver_store() and other) because their handlers uses exec field in struct i2o_controller Signed-off-by: Vasily Averin [EMAIL PROTECTED] --- lk2.6/drivers/message/i2o/exec-osm.c +++ lk2.6/drivers/message/i2o/exec-osm.c @@ -339,6

[Devel] [patch i2o 5/6] i2o_proc files permission

2007-05-15 Thread Vasily Averin
Reading from some i2o related proc files can lead to the i2o controller hang due unknown reasons. As a workaround this patch changes the permission of these files to root-only accessible. Signed-off-by: Vasily Averin [EMAIL PROTECTED] --- lk2.6/drivers/message/i2o/i2o_proc.c +++ lk2.6/drivers

Re: [Devel] [patch i2o 5/6] i2o_proc files permission

2007-05-15 Thread Vasily Averin
to the controller, but this one couldn't handle it and instead of just aborting the command panic's. IIRC it's only Adaptec related, the Promise controllers doesn't show this behaviour. Thank you, Vasily Averin Vasily Averin wrote: Reading from some i2o related proc files can lead to the i2o

[Devel] Re: [patch i2o 5/6] i2o_proc files permission

2007-05-15 Thread Vasily Averin
Alan Cox wrote: On Tue, 15 May 2007 16:47:05 +0400 Vasily Averin [EMAIL PROTECTED] wrote: Reading from some i2o related proc files can lead to the i2o controller hang due unknown reasons. As a workaround this patch changes the permission of these files to root-only accessible. I guess

[Devel] [PATCH netdev] wrong timeout value in sk_wait_data()

2007-05-23 Thread Vasily Averin
values (sets 0 instead) and outputs ratelimited information message about such attempts. Signed-Off-By: Vasily Averin [EMAIL PROTECTED] diff --git a/net/core/sock.c b/net/core/sock.c index 22183c2..27d7a46 100644 --- a/net/core/sock.c +++ b/net/core/sock.c @@ -206,7 +206,19 @@ static int

[Devel] [PATCH netdev] wrong timeout value in sk_wait_data() v2

2007-05-23 Thread Vasily Averin
values (sets 0 instead) and outputs ratelimited information message about such attempts. Signed-Off-By: Vasily Averin [EMAIL PROTECTED] diff --git a/net/core/sock.c b/net/core/sock.c index 22183c2..7e51d3a 100644 --- a/net/core/sock.c +++ b/net/core/sock.c @@ -206,7 +206,19 @@ static int

[Devel] [PATCH ext3/ext4] lost brelse in ext3_read_inode

2007-06-02 Thread Vasily Averin
From: Kirill Korotaev [EMAIL PROTECTED] One of error path in ext3_read_inode() leaks bh since brelse is forgoten. Signed-Off-By: Kirill Korotaev [EMAIL PROTECTED] Acked-by: Vasily Averin [EMAIL PROTECTED] diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c index a6cb617..2a85dde 100644

[Devel] [PATCH ext3/ext4] orphan list check on destroy_inode

2007-06-03 Thread Vasily Averin
Customers claims to ext3-related errors, investigation showed that ext3 orphan list has been corrupted and have the reference to non-ext3 inode. The following debug helps to understand the reasons of this issue. Signed-off-by: Vasily Averin [EMAIL PROTECTED] diff --git a/fs/ext3/super.c b/fs

[Devel] [RFC PATCH ext3/ext4] orphan list corruption due bad inode

2007-06-03 Thread Vasily Averin
for me how to fix this issue correctly. As far as i see is_bad_inode() is called after iget() in all places excluding ext3_lookup() and ext3_get_parent(). I believe it makes sense to add bad inode check to these functions too and call iput if bad inode detected. Signed-off-by: Vasily Averin

[Devel] Re: [RFC PATCH ext3/ext4] orphan list corruption due bad inode

2007-06-05 Thread Vasily Averin
Andrew Morton wrote: On Mon, 04 Jun 2007 09:19:10 +0400 Vasily Averin [EMAIL PROTECTED] wrote: diff --git a/fs/ext3/namei.c b/fs/ext3/namei.c index 9bb046d..e3ac8c3 100644 --- a/fs/ext3/namei.c +++ b/fs/ext3/namei.c @@ -1019,6 +1019,11 @@ static struct dentry *ext3_lookup(struct inode * dir

[Devel] Re: [RFC PATCH ext3/ext4] orphan list corruption due bad inode

2007-06-05 Thread Vasily Averin
Christoph Hellwig wrote: On Tue, Jun 05, 2007 at 10:11:12AM +0400, Vasily Averin wrote: return d_splice_alias(inode, dentry); } Seems reasonable. So this prevents the bad inodes from getting onto the orphan list in the first place? make_bad_inode() is called from ext3_read_inode

[Devel] [PATCH] [RESEND] ext[34] orphan list check on destroy_inode

2007-06-05 Thread Vasily Averin
Customers claims to ext3-related errors, investigation showed that ext3 orphan list has been corrupted and have the reference to non-ext3 inode. The following debug helps to understand the reasons of this issue. Signed-off-by: Vasily Averin [EMAIL PROTECTED] diff --git a/fs/ext3/super.c b/fs

[Devel] Re: VIA VT6420: SATA disconnects

2007-06-19 Thread Vasily Averin
Jeff Garzik wrote: Vasily Averin wrote: Jeff, Tejun, Our RHEL5-based OpenVZ linux kernel reports about SATA-related issues: VIA VT6420 SATA RAID Controller on MSI motherboard, x86_64 kernel based on latest RHEL5 kernel, On booting hardware initialized properly and all works fine some time

[Devel] Re: [NETFILTER] early_drop() imrovement (v3)

2007-06-26 Thread Vasily Averin
strongly that anybody will want to change this value. Do you think it is really required? thank you, Vasily Averin ___ Devel mailing list Devel@openvz.org https://openvz.org/mailman/listinfo/devel

[Devel] Re: [NETFILTER] early_drop() imrovement (v4)

2007-06-27 Thread Vasily Averin
count the number of hash buckets. I.e i should be incremented/checked inside the nested loop. Thank you, Vasily Averin ___ Devel mailing list Devel@openvz.org https://openvz.org/mailman/listinfo/devel

[Devel] Re: [NETFILTER] early_drop() imrovement (v4)

2007-06-27 Thread Vasily Averin
Patrick McHardy wrote: Vasily Averin wrote: it is incorrect, We should count the number of checked _conntracks_, but you count the number of hash buckets. I.e i should be incremented/checked inside the nested loop. I misunderstood your patch then. This one should be better. +static int

[Devel] Re: [NETFILTER] early_drop() imrovement (v4)

2007-06-27 Thread Vasily Averin
Patrick McHardy wrote: Vasily Averin wrote: Patrick McHardy wrote: -static int early_drop(struct hlist_head *chain) +static int early_drop(unsigned int hash) { /* Use oldest entry, which is roughly LRU */ struct nf_conntrack_tuple_hash *h; struct nf_conn *ct = NULL, *tmp

[Devel] unexpected scsi timeout

2007-07-20 Thread Vasily Averin
buffer and go to sleep again. Could you please confirm that it is expected behavior? It's a bit strange for me, IMHO other scsi drivers requests sense buffer without EH thread. Thank you, Vasily Averin Jul 20 13:20:15 ts28 cdrom: entering cdrom_open Jul 20 13:20:15 ts28

[Devel] Re: unexpected scsi timeout

2007-07-25 Thread Vasily Averin
Albert Lee wrote: Vasily Averin wrote: I've noticed that some scsi commands for DVD-drive attached to pata_via successfully finishes without any delays but reports about TIMEOUT condition. It happens because of ATA_ERR bit is set in status register. As result for each command Error

[Devel] [Fwd: [2.6.22] negative time jump]

2007-07-29 Thread Vasily Averin
[EMAIL PROTECTED] ~]# echo q /proc/sysrq-trigger Jul 30 06:25:47 ts28 now at 25322820465391 nsecs Full serial console logs are attached, The other hardware details can be found in http://bugzilla.kernel.org/show_bug.cgi?id=8650 Thank you, Vasily Averin Jul 27 13:58:10 ts28 Linux version

[Devel] Re: [2.6.22] negative time jump

2007-07-30 Thread Vasily Averin
Groundhog Day? Vasily Averin wrote: [EMAIL PROTECTED] ~]# echo 1 /proc/timer_stats [EMAIL PROTECTED] ~]# cat /proc/timer_stats Timer Stats Version: v0.1 Sample period: 17.992 s 0 total events [EMAIL PROTECTED] ~]# cat /proc/timer_stats Timer Stats Version: v0.1 Sample period: -4366.278 s

[Devel] Re: [2.6.22] negative time jump

2007-07-30 Thread Vasily Averin
john stultz wrote: On 7/29/07, Vasily Averin [EMAIL PROTECTED] wrote: I've investigated why my testnode freezes. When I found that node is freezed again I've started to press Sysrq keys and noticed the following negative time jump. Could anybody please help me to understand the reasons

[Devel] broken timer on VIA K8T800 chipset?

2007-08-02 Thread Vasily Averin
Vasily Averin wrote: john stultz wrote: On 7/29/07, Vasily Averin [EMAIL PROTECTED] wrote: I've investigated why my testnode freezes. When I found that node is freezed again I've started to press Sysrq keys and noticed the following negative time jump. I've found the reason of timer-related

[Devel] irq0 stops working

2007-10-08 Thread Vasily Averin
no ideas how to continue the investigation of this problem. Could please anybody advise me any new ways for investigation of this issue? Thank you, Vasily Averin OpenVZ Linux Kernel Team ___ Devel mailing list Devel@openvz.org https://openvz.org

[Devel] Re: irq0 stops working

2007-10-09 Thread Vasily Averin
Jan Engelhardt wrote: On Oct 9 2007 09:26, Vasily Averin wrote: On one of our servers timer interrupts (i.e irq0) are stops working. As result any kernel timers do not triggers and tasks waiting some signals from timers hangs forever. What kernel.. and tried CONFIG_NO_HZ=n? Originally

[Devel] How Inactive may be much greather than cached?

2007-10-18 Thread Vasily Averin
holds the references to these pages? thank you, Vasily Averin ___ Devel mailing list Devel@openvz.org https://openvz.org/mailman/listinfo/devel

[Devel] Re: How Inactive may be much greather than cached?

2007-10-18 Thread Vasily Averin
Nick Piggin wrote: Hi, On Thursday 18 October 2007 16:24, Vasily Averin wrote: Hi all, could anybody explain how inactive may be much greater than cached? stress test (http://weather.ou.edu/~apw/projects/stress/) that writes into removed files in cycle puts the node to the following state

[Devel] Re: How Inactive may be much greather than cached?

2007-10-18 Thread Vasily Averin
Nick Piggin wrote: Some filesystems, including I believe, ext3 with data=ordered, can leave orphaned pages around after they have been truncated out of the pagecache. These pages get left on the LRU and vmscan reclaims them pretty easily. Try ext3 data=writeback, or even ext2. thanks,

[Devel] dm: bounce_pfn limit added

2007-10-28 Thread Vasily Averin
direct IO requests are addressed to dm-over-i2o device. Signed-off-by: Vasily Averin [EMAIL PROTECTED] --- a/drivers/md/dm-table.c +++ b/drivers/md/dm-table.c @@ -102,6 +102,8 @@ static void combine_restrictions_low(struct io_restrictions lhs-seg_boundary_mask = min_not_zero

[Devel] i2o: debug messages corrected

2007-10-28 Thread Vasily Averin
max_phys_segments and max_sectors were swapped Signed-off-by: Vasily Averin [EMAIL PROTECTED] --- a/drivers/message/i2o/i2o_block.c +++ b/drivers/message/i2o/i2o_block.c @@ -1076,8 +1076,8 @@ static int i2o_block_probe(struct device *dev) blk_queue_max_sectors(queue, max_sectors

[Devel] i2o: CONFIG_DEBUG_SG compilation fixed

2007-10-28 Thread Vasily Averin
i2o crashed when CONFIG_DEBUG_SG is enabled because i2o_block_request structure includes array of scatterlists that should be initialised Signed-off-by: Vasily Averin [EMAIL PROTECTED] --- a/drivers/message/i2o/i2o_block.c +++ b/drivers/message/i2o/i2o_block.c @@ -1137,6 +1137,18 @@ static

[Devel] oops in khelper

2007-11-09 Thread Vasily Averin
was reproduced several times on several nodes, but every time it was occurred after the following message: CIFS VFS: Invalid size SMB length 4 pdu_length 4 Is it probably known issue for you? Thank you, Vasily Averin Virtuozzo/OpenVZ linux kernel Team Unable to handle kernel NULL pointer

[Devel] Re: [linux-cifs-client] oops in khelper

2007-11-09 Thread Vasily Averin
Jeff Layton wrote: On Fri, 09 Nov 2007 14:17:38 +0300 Vasily Averin [EMAIL PROTECTED] wrote: Hello Steve, Could you please take a look at the following oops? It looks like it is related to cifs: 1) Code line is corrupted (21 byte?!?), It looks like part of CIFS smb_hdr with CIFS magic

[Devel] forcedeth hangs on loading

2007-11-29 Thread Vasily Averin
00 00 00 00 00 00 00 00 00 00 00 00 c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 f0: 00 00 00 00 11 00 00 00 42 01 00 00 00 00 00 00 Thank you, Vasily Averin

[Devel] cifs_partialpagewrite() cleanup

2007-12-18 Thread Vasily Averin
rc cannot be -EBADF now and condition is always true Signed-off-by: Vasily Averin [EMAIL PROTECTED] --- a/fs/cifs/file.c2007-12-18 16:46:53.0 +0300 +++ b/fs/cifs/file.c2007-12-18 16:49:25.0 +0300 @@ -1181,10 +1181,8 @@ static int cifs_partialpagewrite(struct

[Devel] netlink compat for ipt_ULOG

2007-12-19 Thread Vasily Averin
details? thank you, Vasily Averin ___ Devel mailing list Devel@openvz.org https://openvz.org/mailman/listinfo/devel

Re: [Devel] vmalloc size (trobles with nvidia-glx)

2008-04-21 Thread Vasily Averin
should override default limit in OpenVZ patch? For now I used vmalloc=256m in kernel's command line, but this is not trivial to found out the problem for normal not skilled user. Could You please tell me a bit more details about Your node/kernel? thank you, Vasily Averin

Re: [Devel] To install OpenVZ in an Oracle installed system

2008-04-21 Thread Vasily Averin
: http://wiki.openvz.org/Oracle_10g_VE thank you, Vasily Averin ___ Devel mailing list Devel@openvz.org https://openvz.org/mailman/listinfo/devel

Re: [Devel] To install OpenVZ in an Oracle installed system

2008-04-22 Thread Vasily Averin
Hi Shawn, To use Oracle inside Virtual private server You should install OpenVZ, create new Container (i.e. new Virtual Private server), then install Oracle inside this container as described in our article. thank you, Vasily Averin Vasily Averin wrote: Hi Shawn, duyuyang wrote: Hi

Re: [Devel] suspend/resume instead of stop/start from vz init script

2008-05-15 Thread Vasily Averin
, Vasily Averin ___ Devel mailing list Devel@openvz.org https://openvz.org/mailman/listinfo/devel

Re: [Devel] Can a VE contain the root filesystem?

2008-05-15 Thread Vasily Averin
. thank you, Vasily Averin ___ Devel mailing list Devel@openvz.org https://openvz.org/mailman/listinfo/devel

Re: [Devel] [patch] ext: prevent panic inside of containers

2011-01-24 Thread Vasily Averin
Vasily, Solar Designer, first of all thank you very much for your report! For me it looks like security issue, however it do not affect default containers, because of neither loopback nor real devices cannot be mounted without additional permission. thank you, Vasily Averin On 01/24

Re: [Devel] atl1 (Attansic L1 Gigabit Ethernet) driver TCP weirdness

2011-01-29 Thread Vasily Averin
On 01/29/2011 06:52 PM, Solar Designer wrote: Hi, It appears that linux-2.6.18-atl1-1.0.41.0.patch in RHEL5 branch OpenVZ kernels is your addition, not Red Hat's, correct? yes, it's our patch, prepared 4 years ago, sources were taken from http://atl1.sourceforge.net/ I have a machine with

Re: [Devel] atl1 (Attansic L1 Gigabit Ethernet) driver TCP weirdness

2011-01-30 Thread Vasily Averin
On 01/29/2011 08:50 PM, Solar Designer wrote: On Sat, Jan 29, 2011 at 07:08:25PM +0300, Vasily Averin wrote: On 01/29/2011 06:52 PM, Solar Designer wrote: It appears that linux-2.6.18-atl1-1.0.41.0.patch in RHEL5 branch OpenVZ kernels is your addition, not Red Hat's, correct? yes, it's our

Re: [Devel] atl1 (Attansic L1 Gigabit Ethernet) driver TCP weirdness

2011-01-30 Thread Vasily Averin
On 01/30/2011 11:08 AM, Vasily Averin wrote: On 01/29/2011 08:50 PM, Solar Designer wrote: On Sat, Jan 29, 2011 at 07:08:25PM +0300, Vasily Averin wrote: On 01/29/2011 06:52 PM, Solar Designer wrote: It appears that linux-2.6.18-atl1-1.0.41.0.patch in RHEL5 branch OpenVZ kernels is your

Re: [Devel] atl1 (Attansic L1 Gigabit Ethernet) driver TCP weirdness

2011-01-31 Thread Vasily Averin
just FYI: I've found this hardware locally, node is free for investigation. I'm reinstalling Centos to this node right now and then I will try to reproduce reported issue. thank you, Vasily Averin On 01/30/2011 11:28 AM, Solar Designer wrote: On 01/30/2011 11:08 AM, Vasily Averin

Re: [Devel] atl1 (Attansic L1 Gigabit Ethernet) driver TCP weirdness

2011-01-31 Thread Vasily Averin
On 01/31/2011 11:29 AM, Vasily Averin wrote: just FYI: I've found this hardware locally, node is free for investigation. I'm reinstalling Centos to this node right now and then I will try to reproduce reported issue. I can confirm this issue, upload to this node is normal, but download is slow

Re: [Devel] atl1 (Attansic L1 Gigabit Ethernet) driver TCP weirdness

2011-01-31 Thread Vasily Averin
On 01/31/2011 01:05 PM, Vasily Averin wrote: On 01/31/2011 11:29 AM, Vasily Averin wrote: just FYI: I've found this hardware locally, node is free for investigation. I'm reinstalling Centos to this node right now and then I will try to reproduce reported issue. I can confirm this issue

Re: [Devel] atl1 (Attansic L1 Gigabit Ethernet) driver TCP weirdness

2011-01-31 Thread Vasily Averin
and greatest Solar Designer! :) On Mon, Jan 31, 2011 at 06:55:27PM +0300, Vasily Averin wrote: I've recompiled driver from sources (atl1-1.2.40.3) and it works well on 2.6.18-028stab083.1 kernel. Do you mean that the problem went away with this recompile? No, I've used sources taken from vendor. I

Re: [Devel] atl1 (Attansic L1 Gigabit Ethernet) driver TCP weirdness

2011-02-02 Thread Vasily Averin
Alexander, thank you very much for reporting and testing. Pavel, this is one more remainder: please do not forget to replace patches in new kernels. :) On 02/03/2011 03:09 AM, Solar Designer wrote: On Tue, Feb 01, 2011 at 04:53:47PM +0300, Vasily Averin wrote: I've prepared new patch from

[Devel] [PATCH] bridge: Reset IPCB on forward non-local packets in br_handle_frame_finish()

2011-11-02 Thread Vasily Averin
if dst is not local br_handle_frame_finish() does not clone original skb and forgets to reset IPCB before return to IP stack. it can lead to stack corruption in icmp_send() Signed-off-by: Vasily Averin v...@sw.ru --- net/bridge/br_input.c |5 +++-- 1 files changed, 3 insertions(+), 2

[Devel] Re: [PATCH] bridge: Reset IPCB on forward non-local packets in br_handle_frame_finish()

2011-11-02 Thread Vasily Averin
On 11/02/2011 11:08 PM, Vasily Averin wrote: if dst is not local br_handle_frame_finish() does not clone original skb and forgets to reset IPCB before return to IP stack. it can lead to stack corruption in icmp_send() example of stack corruption http://bugzilla.openvz.org/show_bug.cgi?id

[Devel] [PATCH v2] bridge: Reset IPCB on forward non-local packets in br_handle_frame_finish()

2011-11-02 Thread Vasily Averin
v2: extra bracket was removed if dst is not local br_handle_frame_finish() does not clone original skb and forgets to reset IPCB before return to IP stack. it can lead to stack corruption in icmp_send() Signed-off-by: Vasily Averin v...@sw.ru --- net/bridge/br_input.c |5 +++-- 1 files

[Devel] Re: [PATCH] bridge: Reset IPCB on forward non-local packets in br_handle_frame_finish()

2011-11-02 Thread Vasily Averin
On 11/02/2011 11:31 PM, Stephen Hemminger wrote: On Wed, 02 Nov 2011 23:08:57 +0400 Vasily Averin v...@parallels.com wrote: if dst is not local br_handle_frame_finish() does not clone original skb and forgets to reset IPCB before return to IP stack. it can lead to stack corruption

[Devel] Remote processing of core dump

2011-12-07 Thread Vasily Averin
. Is it possible to use gdbserver-like functionality with crash? IMHO it would be great to start crash utility locally, with debug symbols but without core dump file, and then connect to gdbserver on remote node attached to core dump file. Thank you, Vasily Averin

Re: [Devel] [PATCH 1/6] slab: cleanup kmem_cache_create_memcg()

2013-12-19 Thread Vasily Averin
() can return positive value. Probably it's better to check (err 0) in caller ? Thank you, Vasily Averin ___ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel

Re: [Devel] [PATCH 1/6] slab: cleanup kmem_cache_create_memcg()

2013-12-19 Thread Vasily Averin
On 12/19/2013 12:39 PM, Vladimir Davydov wrote: On 12/19/2013 12:17 PM, Vasily Averin wrote: On 12/18/2013 05:16 PM, Vladimir Davydov wrote: --- a/mm/slab_common.c +++ b/mm/slab_common.c @@ -176,8 +176,9 @@ kmem_cache_create_memcg(struct mem_cgroup *memcg, const char *name, size_t size

[Devel] [patch] incorrect pid_ns check

2014-09-19 Thread Vasily Averin
in pid_hash array. Attached patch fix this problem. Thank you, Vasily Averin diff -up crash-7.0.8/task.c.pidns crash-7.0.8/task.c --- crash-7.0.8/task.c.pidns2014-09-11 11:08:25.0 -0400 +++ crash-7.0.8/task.c 2014-09-19 06:15:42.0 -0400 @@ -2033,7 +2033,7 @@ do_chained

[Devel] [RFC patch crash 0/2] namespace support for net command

2014-12-03 Thread Vasily Averin
. Vasily Averin (2): net -n option renamed to -N namespace support for net command defs.h| 1 + help.c| 9 ++--- net.c | 48 ++-- symbols.c | 2 ++ 4 files changed, 43 insertions(+), 17 deletions(-) -- 1.9.1

[Devel] [RFC patch crash 1/2] net -n option renamed to -N

2014-12-03 Thread Vasily Averin
ipcs and mount commands uses -n key as namespace pointer clear place for similar option in net command Signed-off-by: Vasily Averin v...@openvz.org --- help.c | 6 +++--- net.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/help.c b/help.c index 6aa3e20..780966b 100644

[Devel] [RFC patch crash 2/2] namespace support for net command

2014-12-03 Thread Vasily Averin
now net -n pid|task should show list of network devices in specifed network namespace Signed-off-by: Vasily Averin v...@openvz.org --- defs.h| 1 + help.c| 5 - net.c | 46 +- symbols.c | 2 ++ 4 files changed, 40 insertions(+), 14

[Devel] [patch crash v2 0/2]

2014-12-04 Thread Vasily Averin
-based OpenVZ kernel Vasily Averin (2): net -n option renamed to -N namespace support for net command defs.h| 1 + help.c| 14 +++--- net.c | 58 ++ symbols.c | 2 ++ 4 files changed, 56 insertions(+), 19 deletions

[Devel] [patch crash v2 1/2] net -n option renamed to -N

2014-12-04 Thread Vasily Averin
ipcs and mount commands uses -n key as namespace pointer here we clear the place for similar option in net command Signed-off-by: Vasily Averin v...@openvz.org --- help.c | 6 +++--- net.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/help.c b/help.c index 6aa3e20

[Devel] [patch crash v2 2/2] namespace support for net command

2014-12-04 Thread Vasily Averin
net without arguments shows network devices in init_net net -n -- in network namespace of current task net -n pid|taskp -- in network namespace of specified task Signed-off-by: Vasily Averin v...@openvz.org --- defs.h| 1 + help.c| 10 +- net.c | 56

[Devel] [patch crash v3 1/2] net -n option renamed to -N

2014-12-04 Thread Vasily Averin
ipcs and mount commands uses -n key as namespace pointer. Here we clear the place for similar option in net command Signed-off-by: Vasily Averin v...@openvz.org --- help.c | 6 +++--- net.c | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/help.c b/help.c index 6aa3e20

[Devel] [patch crash v3 2/2] namespace support for net command

2014-12-04 Thread Vasily Averin
net without arguments shows network devices in init_net net -n -- in network namespace of current task net -n pid|taskp -- in network namespace of specified task Signed-off-by: Vasily Averin v...@openvz.org --- defs.h| 1 + help.c| 10 +- net.c | 56

Re: [Devel] [Q rh7] ve.legacy_veid

2015-05-05 Thread Vasily Averin
On 05.05.2015 15:48, Vladimir Davydov wrote: The problem is some data looked up by VEID can outlive the corresponding container. An example is /proc/vz/venetstat, whose entries live until container destruction. Since we currently remove all cgroups, including the VE cgroup, on container stop,

[Devel] [PATCH] cmd_ps message cleanup

2015-05-05 Thread Vasily Averin
ps -L no longer exists Signed-off-by: Vasily Averin v...@parallels.com --- task.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/task.c b/task.c index c875bb9..bc7911b 100644 --- a/task.c +++ b/task.c @@ -2843,7 +2843,7 @@ task_struct_member(struct task_context *tc, unsigned

[Devel] crash: vz extension for OpenVZ kernels

2015-05-05 Thread Vasily Averin
8801ce134ff0 saslauthd 121 248691 88040e2ee9c0 httpd ctid -- shows ContainerID for given task crash ctid 99614 CTIDPID TASKCOMM 121 99614 8803fb26cf70 xfs Thank you, Vasily Averin ___ Devel mailing

[Devel] [PATCH RFC] vz extension: vzlist, ctid, vzps commands

2015-05-05 Thread Vasily Averin
vz extension contains OpenVZ specific commands: vzlistshows list of OpenVZ containers, vzps shows all tasks executed inside of specified container, ctid shows ContainerID of given task. Signed-off-by: Vasily Averin v...@parallels.com --- extensions/vz.c | 345

Re: [Devel] crash: vz extension for OpenVZ kernels

2015-05-05 Thread Vasily Averin
? Thank you, Vasily Averin ___ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel

[Devel] [PATCH rh7] num_cgroups in /proc/cgroups output

2015-05-14 Thread Vasily Averin
like in rh6-based kernels, /proc/cgroups output inside container shows 1 in 'num_cgroups' column https://jira.sw.ru/browse/PSBM-33400 Signed-off-by: Vasily Averin v...@openvz.org diff --git a/kernel/cgroup.c b/kernel/cgroup.c index f881f69..f897042 100644 --- a/kernel/cgroup.c +++ b/kernel

[Devel] [PATCH rh7 0/2] ve_printk for nf_conntrack: table full

2015-05-14 Thread Vasily Averin
This patch set is port of rh6 diff-ve-printk-conntrack-tables-full. Thank you, Vasily Averin ___ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel

[Devel] [PATCH rh7 2/2] ve_printk for nf_conntrack: table full

2015-05-14 Thread Vasily Averin
port of diff-ve-printk-conntrack-tables-full from rh6-based kernels nf_conntrack: table full, dropping packet message should be visible both in CT and on HN and should contain CTID for reading simplicity. https://bugzilla.openvz.org/show_bug.cgi?id=2940 Signed-off-by: Vasily Averin v

Re: [Devel] [PATCH rh7] ve, net: Fix unbalanced double spin_unlock() in tcp_v4_kill_ve_sockets()

2015-05-19 Thread Vasily Averin
1) how about rh6? 2) how about spin_unlock(lock) ? On 19.05.2015 17:43, Kirill Tkhai wrote: Double loop is here, break works is not as expected. Signed-off-by: Kirill Tkhai ktk...@odin.com --- net/ipv4/tcp_ipv4.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [Devel] [PATCH] ve: Kill tcp_v4_kill_ve_sockets()

2015-06-01 Thread Vasily Averin
On 01.06.2015 14:31, Kirill Tkhai wrote: В Пт, 29/05/2015 в 17:20 +0300, Andrew Vagin пишет: Acked-by: Andrew Vagin ava...@odin.com I'm agree that we need to remove this function, but I don't know how it fixes the bug. tcp_v4_kill_ve_sockets() is called when all processes are killed, and

Re: [Devel] [PATCH] ve: Kill tcp_v4_kill_ve_sockets()

2015-06-01 Thread Vasily Averin
On 01.06.2015 15:46, Kirill Tkhai wrote: В Пн, 01/06/2015 в 15:16 +0300, Vasily Averin пишет: On 01.06.2015 14:31, Kirill Tkhai wrote: В Пт, 29/05/2015 в 17:20 +0300, Andrew Vagin пишет: Acked-by: Andrew Vagin ava...@odin.com I'm agree that we need to remove this function, but I don't know

[Devel] [PATCH RH7] idr: print a stack dump after ida_remove warning

2015-05-25 Thread Vasily Averin
-off-by: Andrew Morton a...@linux-foundation.org Signed-off-by: Linus Torvalds torva...@linux-foundation.org https://bugzilla.openvz.org/show_bug.cgi?id=3117 Signed-off-by: Vasily Averin v...@virtuozzo.com --- lib/idr.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git

Re: [Devel] [PATCH rh7 02/11] ub: zap show_ub_mem

2015-05-25 Thread Vasily Averin
On 22.05.2015 22:07, Konstantin Khorenko wrote: On 05/20/2015 12:00 PM, Vladimir Davydov wrote: It is called by the showmem sysctl. Hell knows why it was added and who would ever used it. It's not about sysctl, but about sysrq and we used it heavily until we start getting crash dumps from

[Devel] [PATCH rh7 3/3] ipv4: take rtnl_lock and mark mrt table as freed on namespace cleanup

2015-07-07 Thread Vasily Averin
-by: Hannes Frederic Sowa han...@stressinduktion.org Signed-off-by: Cong Wang xiyou.wangc...@gmail.com Signed-off-by: David S. Miller da...@davemloft.net Signed-off-by: Vasily Averin v...@virtuozzo.com --- net/ipv4/ipmr.c | 5 + 1 file changed, 5 insertions(+) diff --git a/net/ipv4

[Devel] [PATCH rh7 2/3] missing rtnl_unlock in igb_sriov_reinit()

2015-07-07 Thread Vasily Averin
Signed-off-by: Vasily Averin v...@virtuozzo.com --- drivers/net/ethernet/intel/igb/igb_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c index 421f3f1..38d56c4 100644 --- a/drivers/net/ethernet/intel

Re: [Devel] [PATCH rh7 0/3] rtnl_lock fixes

2015-07-18 Thread Vasily Averin
On 17.07.2015 23:21, Konstantin Khorenko wrote: On 07/07/2015 08:10 PM, Vasily Averin wrote: found during investigation of possible reasons of net_todo_list corruption on rhel6 based OpenVZ kernel. reported to Red Hat https://bugzilla.redhat.com/show_bug.cgi?id=1240747 Vasya, are you

Re: [Devel] [PATCH rh7 1/2] ixgbe: cleanup ixgbe_enumerate_functions

2015-11-10 Thread Vasily Averin
I think we can just notify Red Hat about this problem On 10.11.2015 11:06, Andrey Ryabinin wrote: > From: Jacob Keller > > This function previously had the same check as used by the > ixgbe_pcie_from_parent. As the hardcode is due to the device having an > internal >

[Devel] [PATCH rh7] rtnl_lock is called twice in i40e_pci_error_resume()

2015-07-08 Thread Vasily Averin
one more rtnl_lock-related bug in mainline http://patchwork.ozlabs.org/patch/492877/ https://bugzilla.redhat.com/show_bug.cgi?id=1241027 Signed-off-by: Vasily Averin v...@virtuozzo.com --- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [Devel] [PATCH rh7] ploop: use GFP_NOIO in ploop_make_request

2015-09-01 Thread Vasily Averin
On 31.08.2015 16:59, Konstantin Khorenko wrote: > Maxim, please review. > > Do we need the same in PCS6? yes, backport to rh6 is required because of https://bugs.openvz.org/browse/OVZ-6293 1294400.800014] INFO: task jbd2/ploop27926:1692 blocked for more than 120 seconds. [1294400.800121] Not

[Devel] [patch rh7] RDS: verify the underlying transport exists before creating a connection

2015-09-15 Thread Vasily Averin
ype -1 Acked-by: Santosh Shilimkar <santosh.shilim...@oracle.com> Signed-off-by: Sasha Levin <sasha.le...@oracle.com> Signed-off-by: David S. Miller <da...@davemloft.net> Signed-off-by: Vasily Averin <v...@virtuozzo.com> fix for CVE-2015-6937 commit 74e98eb085889b0d2

Re: [Devel] [PATCH rhel6 2/3] cpt: dump dentry alias path for UNIX socket

2015-09-28 Thread Vasily Averin
On 28.09.2015 19:21, Stanislav Kinsburskiy wrote: > 28.09.2015 17:57, Vasily Averin пишет: >> Stas, >> please see my comment below. >> >>> --- a/include/linux/cpt_image.h >>> +++ b/include/linux/cpt_image.h >>> @@ -963,6 +963,11 @@ stru

Re: [Devel] [PATCH rhel6 2/3] cpt: dump dentry alias path for UNIX socket

2015-09-28 Thread Vasily Averin
Stas, please see my comment below. On 28.09.2015 16:16, Stanislav Kinsburskiy wrote: > From: Stanislav Kinsburskiy > > There could be a unix socket (thanks to supervisord), which was unlinked, but > also a hardlink to it was created prior to unlink. > This basically

  1   2   3   4   5   6   7   8   >