Re: [Devel] [PATCH] ext4: Discard preallocated block before swap_extents

2016-09-23 Thread Maxim Patlasov
Dima, The patch looks fine and it works in my tests, but it slightly changes user-visible behavior: before patch, if ioctl(MOVE) failed, the user always saw moved_len=0. Now, with the patch applied, it can be !=0. (because ext4_ioctl() copies "me" back to user even if err != 0) I understan

Re: [Devel] [PATCH] ext4: Discard preallocated block before swap_extents

2016-09-20 Thread Dmitry Monakhov
Dmitry Monakhov writes: TEST_LOG: http://autotest.qa.sw.ru/avocado/bob.qa.sw.ru/job-results/job-2016-09-20T20.37-9107ed4/html/results.html > Inode preallocation consists of two parts (used and unused) fully controlled > by inode, so it must be discarded before swap extents. > Currently we may s