Re: [ovirt-devel] [VDSM] New network test failure - ctypes.ArgumentError: argument 3: : wrong type

2016-09-22 Thread Nir Soffer
And here: http://jenkins.ovirt.org/job/vdsm_master_check-patch-fc24-x86_64/2337/console On Thu, Sep 22, 2016 at 5:34 PM, Piotr Kliczewski wrote: > > > On Thu, Sep 22, 2016 at 9:58 AM, Dan Kenigsberg wrote: > >> On Wed, Sep 21, 2016 at 12:18:37AM +0300,

Re: [ovirt-devel] [VDSM] New network test failure - ctypes.ArgumentError: argument 3: : wrong type

2016-09-22 Thread Nir Soffer
I think we should get rid of the ctypes code, it is very hard to understand, unsafe, and slow. If we need to call C we should use proper python extensions. On Thu, Sep 22, 2016 at 5:34 PM, Piotr Kliczewski wrote: > > > On Thu, Sep 22, 2016 at 9:58 AM, Dan Kenigsberg

Re: [ovirt-devel] [VDSM] New network test failure - ctypes.ArgumentError: argument 3: : wrong type

2016-09-22 Thread Piotr Kliczewski
On Thu, Sep 22, 2016 at 9:58 AM, Dan Kenigsberg wrote: > On Wed, Sep 21, 2016 at 12:18:37AM +0300, Nir Soffer wrote: > > On Tue, Sep 20, 2016 at 8:18 PM, Nir Soffer wrote: > > > Failed only one patch when building 4, so this looks like > > > a random

Re: [ovirt-devel] [VDSM] Improving vdsm logging format

2016-09-22 Thread Roman Hodain
Hi, I agree with Michal. The Thread is very important for the debugging. Obviously you can highlight what you need, but still the thread is jumping there and back which make is less readable. It would be ok if that would be on the third place as the log level is aligned. It makes huge difference

Re: [ovirt-devel] [VDSM] New network test failure - ctypes.ArgumentError: argument 3: : wrong type

2016-09-22 Thread Dan Kenigsberg
On Wed, Sep 21, 2016 at 12:18:37AM +0300, Nir Soffer wrote: > On Tue, Sep 20, 2016 at 8:18 PM, Nir Soffer wrote: > > Failed only one patch when building 4, so this looks like > > a random failure, but the error is disturbing. Petr, could you look into it? Could it be that

Re: [ovirt-devel] [VDSM] New network test failure - ctypes.ArgumentError: argument 3: : wrong type

2016-09-22 Thread Thomas Haller
On Thu, 2016-09-22 at 18:14 +0300, Dan Kenigsberg wrote: > On Thu, Sep 22, 2016 at 05:38:48PM +0300, Nir Soffer wrote: > > > > I think we should get rid of the ctypes code, it is very hard to > > understand, unsafe, and slow. > > > > If we need to call C we should use proper python extensions. >

Re: [ovirt-devel] [VDSM] New network test failure - ctypes.ArgumentError: argument 3: : wrong type

2016-09-22 Thread Dan Kenigsberg
On Thu, Sep 22, 2016 at 05:38:48PM +0300, Nir Soffer wrote: > I think we should get rid of the ctypes code, it is very hard to > understand, unsafe, and slow. > > If we need to call C we should use proper python extensions. Correct.