[ovirt-devel] Re: [VDSM] check-merged failing for years - remove it?

2018-12-06 Thread Marcin Sobczyk 

Disabling 'check-merged' for 'ovirt-4.2':

https://gerrit.ovirt.org/96033

On 12/6/18 11:11 AM, Barak Korren wrote:



On Thu, 6 Dec 2018 at 12:10, Marcin Sobczyk > wrote:


Hi Eyal,

removal of V1 is on the way:

https://gerrit.ovirt.org/#/c/96031/
https://gerrit.ovirt.org/#/c/96027/
https://gerrit.ovirt.org/#/c/95774/

and here's a patch that disables 'check-merged' on master:

https://gerrit.ovirt.org/#/c/96032/

Do we want to also disable it on 'ovirt-4.2'?


Ether, disable, or make sure it passes

Marcin

On 12/6/18 10:50 AM, Eyal Edri wrote:

Guys,
The check-merged job is causing lot of noise and failures in CI
and CQ.
Can we drop it ASAP? and continue to discuss offline if you want
to move that functionality to check-patch as part of V2?

Also, if we could drop the V1 jobs that would be great so we'll
reduce noise from failures there.

On Thu, Nov 29, 2018 at 8:39 AM Barak Korren mailto:bkor...@redhat.com>> wrote:



On Thu, 29 Nov 2018 at 00:29, Nir Soffer mailto:nsof...@redhat.com>> wrote:

On Wed, Nov 28, 2018 at 11:30 PM Nir Soffer
mailto:nsof...@redhat.com>> wrote:

On Wed, Nov 28, 2018 at 12:03 PM Edward Haas
mailto:edwa...@redhat.com>> wrote:



On Wed, Nov 28, 2018 at 11:28 AM Marcin Sobczyk
mailto:msobc...@redhat.com>> wrote:

How much value does it add comparing to
check-patch?

If we can hold for a while with pulling the
plug, I can try to split it into substages in
stdci v2 and see if things stabilize a bit.


I would prefer we first work with stdci v2 in
order to move the functional tests there (or at
least play with it).
Then we can remove it.


Turns out that this worth with stdci v2 - if
check-merged fail, the change queue
will reject the patch.

See this mail from in...@ovirt.org
 mailing list:

Change 95559,13 (vdsm) is probably the reason
behind recent system test
failures in the "ovirt-master" change queue and
needs to be fixed.

This change had been removed from the testing
queue. Artifacts build from this
change will not be released until it is fixed.

For further details about the change see:
https://gerrit.ovirt.org/#/c/95559/13


According to Dafna and Barak, change queue require
that all jobs pass, so we cannot
have flaky job in the build.

I hopefully removed it from stdci v2 here:
https://gerrit.ovirt.org/c/95845/

I don't think we should even enable check-merged
again. All tests must run *before* we
merge. When cannot work with a job that will randomly
fail after merge.


Here is another failure:

A system test invoked by the "ovirt-master" change queue
including change
95817,2 (vdsm) failed. However, this change seems not to
be the root cause for
this failure. Change 95559,13 (vdsm) that this change
depends on or is based
on, was detected as the cause of the testing failures.

This change had been removed from the testing queue.
Artifacts built from this
change will not be released until either change 95559,13
(vdsm) is fixed and
this change is updated to refer to or rebased on the
fixed version, or this
change is modified to no longer depend on it.

For further details about the change see:
https://gerrit.ovirt.org/#/c/95817/2

For further details about the change that seems to be the
root cause behind the
testing failures see:
https://gerrit.ovirt.org/#/c/95559/13

For failed test results see:
http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/11719/



We are going to see more failures, since we merged
yesterday several
patches after the stdci v2 patch:

8e4df87a5 storage: blocksd_test refactored to use pytest
monkeypatching
ede08ad53 storage: blocksd_test refactore to use pytest.xfail
46aad2375 storage: blocksd_test convertet to pytest
b4f2809c0 storage: Improved SD.create() docstring
30b1423e0 virt: use log.warning(), not log.warn()
224ebf092

[ovirt-devel] Re: [VDSM] check-merged failing for years - remove it?

2018-12-06 Thread Barak Korren 
On Thu, 6 Dec 2018 at 12:10, Marcin Sobczyk  wrote:

> Hi Eyal,
>
> removal of V1 is on the way:
> https://gerrit.ovirt.org/#/c/96031/
> https://gerrit.ovirt.org/#/c/96027/
> https://gerrit.ovirt.org/#/c/95774/
>
> and here's a patch that disables 'check-merged' on master:
>
> https://gerrit.ovirt.org/#/c/96032/
>
> Do we want to also disable it on 'ovirt-4.2'?
>

Ether, disable, or make sure it passes



> Marcin
> On 12/6/18 10:50 AM, Eyal Edri wrote:
>
> Guys,
> The check-merged job is causing lot of noise and failures in CI and CQ.
> Can we drop it ASAP? and continue to discuss offline if you want to move
> that functionality to check-patch as part of V2?
>
> Also, if we could drop the V1 jobs that would be great so we'll reduce
> noise from failures there.
>
> On Thu, Nov 29, 2018 at 8:39 AM Barak Korren  wrote:
>
>>
>>
>> On Thu, 29 Nov 2018 at 00:29, Nir Soffer  wrote:
>>
>>> On Wed, Nov 28, 2018 at 11:30 PM Nir Soffer  wrote:
>>>
 On Wed, Nov 28, 2018 at 12:03 PM Edward Haas 
 wrote:

>
>
> On Wed, Nov 28, 2018 at 11:28 AM Marcin Sobczyk 
> wrote:
>
>> How much value does it add comparing to check-patch?
>>
>> If we can hold for a while with pulling the plug, I can try to split
>> it into substages in stdci v2 and see if things stabilize a bit.
>>
>
> I would prefer we first work with stdci v2 in order to move the
> functional tests there (or at least play with it).
> Then we can remove it.
>

 Turns out that this worth with stdci v2 - if check-merged fail, the
 change queue
 will reject the patch.

 See this mail from in...@ovirt.org mailing list:

 Change 95559,13 (vdsm) is probably the reason behind recent system test
> failures in the "ovirt-master" change queue and needs to be fixed.
>
> This change had been removed from the testing queue. Artifacts build
> from this
> change will not be released until it is fixed.
>
> For further details about the change see:
> https://gerrit.ovirt.org/#/c/95559/13


 According to Dafna and Barak, change queue require that all jobs pass,
 so we cannot
 have flaky job in the build.

 I hopefully removed it from stdci v2 here:
 https://gerrit.ovirt.org/c/95845/

 I don't think we should even enable check-merged again. All tests must
 run *before* we
 merge. When cannot work with a job that will randomly fail after merge.

>>>
>>> Here is another failure:
>>>
>>> A system test invoked by the "ovirt-master" change queue including change
>>> 95817,2 (vdsm) failed. However, this change seems not to be the root
>>> cause for
>>> this failure. Change 95559,13 (vdsm) that this change depends on or is
>>> based
>>> on, was detected as the cause of the testing failures.
>>>
>>> This change had been removed from the testing queue. Artifacts built
>>> from this
>>> change will not be released until either change 95559,13 (vdsm) is fixed
>>> and
>>> this change is updated to refer to or rebased on the fixed version, or
>>> this
>>> change is modified to no longer depend on it.
>>>
>>> For further details about the change see:
>>> https://gerrit.ovirt.org/#/c/95817/2
>>>
>>> For further details about the change that seems to be the root cause
>>> behind the
>>> testing failures see:
>>> https://gerrit.ovirt.org/#/c/95559/13
>>>
>>> For failed test results see:
>>> http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/11719/
>>>
>>>
>>> We are going to see more failures, since we merged yesterday several
>>> patches after the stdci v2 patch:
>>>
>>> 8e4df87a5 storage: blocksd_test refactored to use pytest monkeypatching
>>> ede08ad53 storage: blocksd_test refactore to use pytest.xfail
>>> 46aad2375 storage: blocksd_test convertet to pytest
>>> b4f2809c0 storage: Improved SD.create() docstring
>>> 30b1423e0 virt: use log.warning(), not log.warn()
>>> 224ebf092 ci: Added 'stdciv2' configuration file
>>>
>>
>> Hold on, since you also have V1 jobs now, patches are being submitted
>> twice into the queue, and there are actually passing when submitted by the
>> v1 jobs like they did before:
>>
>> https://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/11713/execution/node/85/log/
>>
>> So yeah, you should fix check-merged or disable it, but as long as you
>> have the v1 jobs these failures are not causing any real harm, just noise.
>>
>> --
>> Barak Korren
>> RHV DevOps team , RHCE, RHCi
>> Red Hat EMEA
>> redhat.com | TRIED. TESTED. TRUSTED. | redhat.com/trusted
>> ___
>> Devel mailing list -- devel@ovirt.org
>> To unsubscribe send an email to devel-le...@ovirt.org
>> Privacy Statement: https://www.ovirt.org/site/privacy-policy/
>> oVirt Code of Conduct:
>> https://www.ovirt.org/community/about/community-guidelines/
>> List Archives:
>> https://lists.ovirt.org/archives/list/devel@ovirt.org/message/RVTPRQURXCVCPLFZUS7TOUDU3A3BMGEJ/

[ovirt-devel] Re: [VDSM] check-merged failing for years - remove it?

2018-12-06 Thread Marcin Sobczyk 

Hi Eyal,

removal of V1 is on the way:

https://gerrit.ovirt.org/#/c/96031/
https://gerrit.ovirt.org/#/c/96027/
https://gerrit.ovirt.org/#/c/95774/

and here's a patch that disables 'check-merged' on master:

https://gerrit.ovirt.org/#/c/96032/

Do we want to also disable it on 'ovirt-4.2'?

Marcin

On 12/6/18 10:50 AM, Eyal Edri wrote:

Guys,
The check-merged job is causing lot of noise and failures in CI and CQ.
Can we drop it ASAP? and continue to discuss offline if you want to 
move that functionality to check-patch as part of V2?


Also, if we could drop the V1 jobs that would be great so we'll reduce 
noise from failures there.


On Thu, Nov 29, 2018 at 8:39 AM Barak Korren > wrote:




On Thu, 29 Nov 2018 at 00:29, Nir Soffer mailto:nsof...@redhat.com>> wrote:

On Wed, Nov 28, 2018 at 11:30 PM Nir Soffer
mailto:nsof...@redhat.com>> wrote:

On Wed, Nov 28, 2018 at 12:03 PM Edward Haas
mailto:edwa...@redhat.com>> wrote:



On Wed, Nov 28, 2018 at 11:28 AM Marcin Sobczyk
mailto:msobc...@redhat.com>> wrote:

How much value does it add comparing to check-patch?

If we can hold for a while with pulling the plug,
I can try to split it into substages in stdci v2
and see if things stabilize a bit.


I would prefer we first work with stdci v2 in order to
move the functional tests there (or at least play with
it).
Then we can remove it.


Turns out that this worth with stdci v2 - if check-merged
fail, the change queue
will reject the patch.

See this mail from in...@ovirt.org
 mailing list:

Change 95559,13 (vdsm) is probably the reason behind
recent system test
failures in the "ovirt-master" change queue and needs
to be fixed.

This change had been removed from the testing queue.
Artifacts build from this
change will not be released until it is fixed.

For further details about the change see:
https://gerrit.ovirt.org/#/c/95559/13


According to Dafna and Barak, change queue require that
all jobs pass, so we cannot
have flaky job in the build.

I hopefully removed it from stdci v2 here:
https://gerrit.ovirt.org/c/95845/

I don't think we should even enable check-merged again.
All tests must run *before* we
merge. When cannot work with a job that will randomly fail
after merge.


Here is another failure:

A system test invoked by the "ovirt-master" change queue
including change
95817,2 (vdsm) failed. However, this change seems not to be
the root cause for
this failure. Change 95559,13 (vdsm) that this change depends
on or is based
on, was detected as the cause of the testing failures.

This change had been removed from the testing queue. Artifacts
built from this
change will not be released until either change 95559,13
(vdsm) is fixed and
this change is updated to refer to or rebased on the fixed
version, or this
change is modified to no longer depend on it.

For further details about the change see:
https://gerrit.ovirt.org/#/c/95817/2

For further details about the change that seems to be the root
cause behind the
testing failures see:
https://gerrit.ovirt.org/#/c/95559/13

For failed test results see:
http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/11719/



We are going to see more failures, since we merged yesterday
several
patches after the stdci v2 patch:

8e4df87a5 storage: blocksd_test refactored to use pytest
monkeypatching
ede08ad53 storage: blocksd_test refactore to use pytest.xfail
46aad2375 storage: blocksd_test convertet to pytest
b4f2809c0 storage: Improved SD.create() docstring
30b1423e0 virt: use log.warning(), not log.warn()
224ebf092 ci: Added 'stdciv2' configuration file


Hold on, since you also have V1 jobs now, patches are being
submitted twice into the queue, and there are actually passing
when submitted by the v1 jobs like they did before:

https://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/11713/execution/node/85/log/

So yeah, you should fix check-merged or disable it, but as long as
you have the v1 jobs these failures are not causing any real harm,
just noise.

-- 
Barak Korren

RHV DevOps team , RHCE, RHCi
Red Hat EMEA
redhat.com  | TRIED. TESTED. TRUSTED.

[ovirt-devel] Re: [VDSM] check-merged failing for years - remove it?

2018-12-06 Thread Eyal Edri 
Guys,
The check-merged job is causing lot of noise and failures in CI and CQ.
Can we drop it ASAP? and continue to discuss offline if you want to move
that functionality to check-patch as part of V2?

Also, if we could drop the V1 jobs that would be great so we'll reduce
noise from failures there.

On Thu, Nov 29, 2018 at 8:39 AM Barak Korren  wrote:

>
>
> On Thu, 29 Nov 2018 at 00:29, Nir Soffer  wrote:
>
>> On Wed, Nov 28, 2018 at 11:30 PM Nir Soffer  wrote:
>>
>>> On Wed, Nov 28, 2018 at 12:03 PM Edward Haas  wrote:
>>>


 On Wed, Nov 28, 2018 at 11:28 AM Marcin Sobczyk 
 wrote:

> How much value does it add comparing to check-patch?
>
> If we can hold for a while with pulling the plug, I can try to split
> it into substages in stdci v2 and see if things stabilize a bit.
>

 I would prefer we first work with stdci v2 in order to move the
 functional tests there (or at least play with it).
 Then we can remove it.

>>>
>>> Turns out that this worth with stdci v2 - if check-merged fail, the
>>> change queue
>>> will reject the patch.
>>>
>>> See this mail from in...@ovirt.org mailing list:
>>>
>>> Change 95559,13 (vdsm) is probably the reason behind recent system test
 failures in the "ovirt-master" change queue and needs to be fixed.

 This change had been removed from the testing queue. Artifacts build
 from this
 change will not be released until it is fixed.

 For further details about the change see:
 https://gerrit.ovirt.org/#/c/95559/13
>>>
>>>
>>> According to Dafna and Barak, change queue require that all jobs pass,
>>> so we cannot
>>> have flaky job in the build.
>>>
>>> I hopefully removed it from stdci v2 here:
>>> https://gerrit.ovirt.org/c/95845/
>>>
>>> I don't think we should even enable check-merged again. All tests must
>>> run *before* we
>>> merge. When cannot work with a job that will randomly fail after merge.
>>>
>>
>> Here is another failure:
>>
>> A system test invoked by the "ovirt-master" change queue including change
>> 95817,2 (vdsm) failed. However, this change seems not to be the root
>> cause for
>> this failure. Change 95559,13 (vdsm) that this change depends on or is
>> based
>> on, was detected as the cause of the testing failures.
>>
>> This change had been removed from the testing queue. Artifacts built from
>> this
>> change will not be released until either change 95559,13 (vdsm) is fixed
>> and
>> this change is updated to refer to or rebased on the fixed version, or
>> this
>> change is modified to no longer depend on it.
>>
>> For further details about the change see:
>> https://gerrit.ovirt.org/#/c/95817/2
>>
>> For further details about the change that seems to be the root cause
>> behind the
>> testing failures see:
>> https://gerrit.ovirt.org/#/c/95559/13
>>
>> For failed test results see:
>> http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/11719/
>>
>>
>> We are going to see more failures, since we merged yesterday several
>> patches after the stdci v2 patch:
>>
>> 8e4df87a5 storage: blocksd_test refactored to use pytest monkeypatching
>> ede08ad53 storage: blocksd_test refactore to use pytest.xfail
>> 46aad2375 storage: blocksd_test convertet to pytest
>> b4f2809c0 storage: Improved SD.create() docstring
>> 30b1423e0 virt: use log.warning(), not log.warn()
>> 224ebf092 ci: Added 'stdciv2' configuration file
>>
>
> Hold on, since you also have V1 jobs now, patches are being submitted
> twice into the queue, and there are actually passing when submitted by the
> v1 jobs like they did before:
>
> https://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/11713/execution/node/85/log/
>
> So yeah, you should fix check-merged or disable it, but as long as you
> have the v1 jobs these failures are not causing any real harm, just noise.
>
> --
> Barak Korren
> RHV DevOps team , RHCE, RHCi
> Red Hat EMEA
> redhat.com | TRIED. TESTED. TRUSTED. | redhat.com/trusted
> ___
> Devel mailing list -- devel@ovirt.org
> To unsubscribe send an email to devel-le...@ovirt.org
> Privacy Statement: https://www.ovirt.org/site/privacy-policy/
> oVirt Code of Conduct:
> https://www.ovirt.org/community/about/community-guidelines/
> List Archives:
> https://lists.ovirt.org/archives/list/devel@ovirt.org/message/RVTPRQURXCVCPLFZUS7TOUDU3A3BMGEJ/
>


-- 

Eyal edri


MANAGER

RHV/CNV DevOps

EMEA VIRTUALIZATION R


Red Hat EMEA 
 TRIED. TESTED. TRUSTED. 
phone: +972-9-7692018
irc: eedri (on #tlv #rhev-dev #rhev-integ)
___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives:

[ovirt-devel] Re: [VDSM] check-merged failing for years - remove it?

2018-11-28 Thread Barak Korren 
On Thu, 29 Nov 2018 at 00:29, Nir Soffer  wrote:

> On Wed, Nov 28, 2018 at 11:30 PM Nir Soffer  wrote:
>
>> On Wed, Nov 28, 2018 at 12:03 PM Edward Haas  wrote:
>>
>>>
>>>
>>> On Wed, Nov 28, 2018 at 11:28 AM Marcin Sobczyk 
>>> wrote:
>>>
 How much value does it add comparing to check-patch?

 If we can hold for a while with pulling the plug, I can try to split it
 into substages in stdci v2 and see if things stabilize a bit.

>>>
>>> I would prefer we first work with stdci v2 in order to move the
>>> functional tests there (or at least play with it).
>>> Then we can remove it.
>>>
>>
>> Turns out that this worth with stdci v2 - if check-merged fail, the
>> change queue
>> will reject the patch.
>>
>> See this mail from in...@ovirt.org mailing list:
>>
>> Change 95559,13 (vdsm) is probably the reason behind recent system test
>>> failures in the "ovirt-master" change queue and needs to be fixed.
>>>
>>> This change had been removed from the testing queue. Artifacts build
>>> from this
>>> change will not be released until it is fixed.
>>>
>>> For further details about the change see:
>>> https://gerrit.ovirt.org/#/c/95559/13
>>
>>
>> According to Dafna and Barak, change queue require that all jobs pass, so
>> we cannot
>> have flaky job in the build.
>>
>> I hopefully removed it from stdci v2 here:
>> https://gerrit.ovirt.org/c/95845/
>>
>> I don't think we should even enable check-merged again. All tests must
>> run *before* we
>> merge. When cannot work with a job that will randomly fail after merge.
>>
>
> Here is another failure:
>
> A system test invoked by the "ovirt-master" change queue including change
> 95817,2 (vdsm) failed. However, this change seems not to be the root cause
> for
> this failure. Change 95559,13 (vdsm) that this change depends on or is
> based
> on, was detected as the cause of the testing failures.
>
> This change had been removed from the testing queue. Artifacts built from
> this
> change will not be released until either change 95559,13 (vdsm) is fixed
> and
> this change is updated to refer to or rebased on the fixed version, or this
> change is modified to no longer depend on it.
>
> For further details about the change see:
> https://gerrit.ovirt.org/#/c/95817/2
>
> For further details about the change that seems to be the root cause
> behind the
> testing failures see:
> https://gerrit.ovirt.org/#/c/95559/13
>
> For failed test results see:
> http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/11719/
>
>
> We are going to see more failures, since we merged yesterday several
> patches after the stdci v2 patch:
>
> 8e4df87a5 storage: blocksd_test refactored to use pytest monkeypatching
> ede08ad53 storage: blocksd_test refactore to use pytest.xfail
> 46aad2375 storage: blocksd_test convertet to pytest
> b4f2809c0 storage: Improved SD.create() docstring
> 30b1423e0 virt: use log.warning(), not log.warn()
> 224ebf092 ci: Added 'stdciv2' configuration file
>

Hold on, since you also have V1 jobs now, patches are being submitted twice
into the queue, and there are actually passing when submitted by the v1
jobs like they did before:
https://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/11713/execution/node/85/log/

So yeah, you should fix check-merged or disable it, but as long as you have
the v1 jobs these failures are not causing any real harm, just noise.

-- 
Barak Korren
RHV DevOps team , RHCE, RHCi
Red Hat EMEA
redhat.com | TRIED. TESTED. TRUSTED. | redhat.com/trusted
___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/RVTPRQURXCVCPLFZUS7TOUDU3A3BMGEJ/

[ovirt-devel] Re: [VDSM] check-merged failing for years - remove it?

2018-11-28 Thread Nir Soffer 
On Wed, Nov 28, 2018 at 11:30 PM Nir Soffer  wrote:

> On Wed, Nov 28, 2018 at 12:03 PM Edward Haas  wrote:
>
>>
>>
>> On Wed, Nov 28, 2018 at 11:28 AM Marcin Sobczyk 
>> wrote:
>>
>>> How much value does it add comparing to check-patch?
>>>
>>> If we can hold for a while with pulling the plug, I can try to split it
>>> into substages in stdci v2 and see if things stabilize a bit.
>>>
>>
>> I would prefer we first work with stdci v2 in order to move the
>> functional tests there (or at least play with it).
>> Then we can remove it.
>>
>
> Turns out that this worth with stdci v2 - if check-merged fail, the change
> queue
> will reject the patch.
>
> See this mail from in...@ovirt.org mailing list:
>
> Change 95559,13 (vdsm) is probably the reason behind recent system test
>> failures in the "ovirt-master" change queue and needs to be fixed.
>>
>> This change had been removed from the testing queue. Artifacts build from
>> this
>> change will not be released until it is fixed.
>>
>> For further details about the change see:
>> https://gerrit.ovirt.org/#/c/95559/13
>
>
> According to Dafna and Barak, change queue require that all jobs pass, so
> we cannot
> have flaky job in the build.
>
> I hopefully removed it from stdci v2 here:
> https://gerrit.ovirt.org/c/95845/
>
> I don't think we should even enable check-merged again. All tests must run
> *before* we
> merge. When cannot work with a job that will randomly fail after merge.
>

Here is another failure:

A system test invoked by the "ovirt-master" change queue including change
95817,2 (vdsm) failed. However, this change seems not to be the root cause
for
this failure. Change 95559,13 (vdsm) that this change depends on or is based
on, was detected as the cause of the testing failures.

This change had been removed from the testing queue. Artifacts built from
this
change will not be released until either change 95559,13 (vdsm) is fixed and
this change is updated to refer to or rebased on the fixed version, or this
change is modified to no longer depend on it.

For further details about the change see:
https://gerrit.ovirt.org/#/c/95817/2

For further details about the change that seems to be the root cause behind
the
testing failures see:
https://gerrit.ovirt.org/#/c/95559/13

For failed test results see:
http://jenkins.ovirt.org/job/ovirt-master_change-queue-tester/11719/


We are going to see more failures, since we merged yesterday several
patches after the stdci v2 patch:

8e4df87a5 storage: blocksd_test refactored to use pytest monkeypatching
ede08ad53 storage: blocksd_test refactore to use pytest.xfail
46aad2375 storage: blocksd_test convertet to pytest
b4f2809c0 storage: Improved SD.create() docstring
30b1423e0 virt: use log.warning(), not log.warn()
224ebf092 ci: Added 'stdciv2' configuration file
___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/GRWCO36ETSGMU2MTGISOSQ3ZJ2TJ2NWU/

[ovirt-devel] Re: [VDSM] check-merged failing for years - remove it?

2018-11-28 Thread Nir Soffer 
On Wed, Nov 28, 2018 at 12:03 PM Edward Haas  wrote:

>
>
> On Wed, Nov 28, 2018 at 11:28 AM Marcin Sobczyk 
> wrote:
>
>> How much value does it add comparing to check-patch?
>>
>> If we can hold for a while with pulling the plug, I can try to split it
>> into substages in stdci v2 and see if things stabilize a bit.
>>
>
> I would prefer we first work with stdci v2 in order to move the functional
> tests there (or at least play with it).
> Then we can remove it.
>

Turns out that this worth with stdci v2 - if check-merged fail, the change
queue
will reject the patch.

See this mail from in...@ovirt.org mailing list:

Change 95559,13 (vdsm) is probably the reason behind recent system test
> failures in the "ovirt-master" change queue and needs to be fixed.
>
> This change had been removed from the testing queue. Artifacts build from
> this
> change will not be released until it is fixed.
>
> For further details about the change see:
> https://gerrit.ovirt.org/#/c/95559/13


According to Dafna and Barak, change queue require that all jobs pass, so
we cannot
have flaky job in the build.

I hopefully removed it from stdci v2 here:
https://gerrit.ovirt.org/c/95845/

I don't think we should even enable check-merged again. All tests must run
*before* we
merge. When cannot work with a job that will randomly fail after merge.

Nir
___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/HOTYAHWHTDITNDAP5DCWL2UDSSAKS3IV/

[ovirt-devel] Re: [VDSM] check-merged failing for years - remove it?

2018-11-28 Thread Edward Haas 
On Wed, Nov 28, 2018 at 11:28 AM Marcin Sobczyk  wrote:

> How much value does it add comparing to check-patch?
>
> If we can hold for a while with pulling the plug, I can try to split it
> into substages in stdci v2 and see if things stabilize a bit.
>

I would prefer we first work with stdci v2 in order to move the functional
tests there (or at least play with it).
Then we can remove it.


> Marcin
> On 11/28/18 5:48 AM, Dan Kenigsberg wrote:
>
>
>
> On Tue, 27 Nov 2018, 22:49 Nir Soffer 
>> vdsm check-merged job takes 1.5 hours, and fails 80% of the time.
>>
>> https://jenkins.ovirt.org/job/vdsm_master_check-merged-el7-x86_64/buildTimeTrend
>>
>> Nobody checks these failures or care about them. We are abusing CI
>> resources for
>> no benefit.
>>
>> Can we remove this job?
>>
>
> I fought for it quite a lot, but now is the time for me to declare defeat.
>
> Unless someone here volunteers to maintain it, we should put the plug out.
>
>
>> Nir
>>
>>
___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/AHIXVC2C4VQQEQVVENMUGB2SSMNKA2GK/

[ovirt-devel] Re: [VDSM] check-merged failing for years - remove it?

2018-11-28 Thread Marcin Sobczyk 

How much value does it add comparing to check-patch?

If we can hold for a while with pulling the plug, I can try to split it 
into substages in stdci v2 and see if things stabilize a bit.


Marcin

On 11/28/18 5:48 AM, Dan Kenigsberg wrote:



On Tue, 27 Nov 2018, 22:49 Nir Soffer  wrote:


vdsm check-merged job takes 1.5 hours, and fails 80% of the time.

https://jenkins.ovirt.org/job/vdsm_master_check-merged-el7-x86_64/buildTimeTrend

Nobody checks these failures or care about them. We are abusing CI
resources for
no benefit.

Can we remove this job?


I fought for it quite a lot, but now is the time for me to declare defeat.

Unless someone here volunteers to maintain it, we should put the plug out.


Nir

___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/CSGWP7EJXVOWZUK24HL5BWQNHDWUE6NV/

[ovirt-devel] Re: [VDSM] check-merged failing for years - remove it?

2018-11-27 Thread Dan Kenigsberg 
On Tue, 27 Nov 2018, 22:49 Nir Soffer  vdsm check-merged job takes 1.5 hours, and fails 80% of the time.
>
> https://jenkins.ovirt.org/job/vdsm_master_check-merged-el7-x86_64/buildTimeTrend
>
> Nobody checks these failures or care about them. We are abusing CI
> resources for
> no benefit.
>
> Can we remove this job?
>

I fought for it quite a lot, but now is the time for me to declare defeat.

Unless someone here volunteers to maintain it, we should put the plug out.


> Nir
>
>
___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/7GQACJYPFOCI2YWIW6LJA4UQKFE3DHDZ/