[ovirt-devel] Re: Announcing 'COVERAGE' option in OST

[Francesco Romani]

On 12/12/18 9:42 PM, Marcin Sobczyk wrote:

Hi,

I've been working on adding coverage report for VDSM in OST
recently, and I'm happy to announce, that the first batch of patches 
is merged!


To run a suite with coverage, look for 'COVERAGE' drop-down on OST's
build parameters page. If you run OST locally, pass a '--coverage' 
argument to 'run_suite.sh'.


Currently, coverage works only for VDSM in basic-suite-master, but adding
VDSM support for other suites is now a no-brainer. More patches are on 
the way!


Since the option is named 'COVERAGE', and not 'VDSM_COVERAGE', other 
projects

are welcome to implement their coverage reports on top of it.

Cheers, Marcin



Kudos!

very nice and very helpful addition.


--
Francesco Romani
Senior SW Eng., Virtualization R
Red Hat
IRC: fromani github: @fromanirh
___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/LENCKYBECVR5W3O3SI3YH5SGCFJIJ7OO/

[ovirt-devel] Re: Announcing 'COVERAGE' option in OST

[Sandro Bonazzola]

Thanks Marcin! Yuval, Didi, when you have time can you look if it's easy to
enable coverage for node and otopi related runs using this feature?
Thanks

Il giorno mer 12 dic 2018 alle ore 21:44 Marcin Sobczyk 
ha scritto:

> Hi,
>
> I've been working on adding coverage report for VDSM in OST
> recently, and I'm happy to announce, that the first batch of patches is
> merged!
>
> To run a suite with coverage, look for 'COVERAGE' drop-down on OST's
> build parameters page. If you run OST locally, pass a '--coverage'
> argument to 'run_suite.sh'.
>
> Currently, coverage works only for VDSM in basic-suite-master, but adding
> VDSM support for other suites is now a no-brainer. More patches are on the
> way!
>
> Since the option is named 'COVERAGE', and not 'VDSM_COVERAGE', other
> projects
> are welcome to implement their coverage reports on top of it.
>
> Cheers, Marcin
>
> ___
> Devel mailing list -- devel@ovirt.org
> To unsubscribe send an email to devel-le...@ovirt.org
> Privacy Statement: https://www.ovirt.org/site/privacy-policy/
> oVirt Code of Conduct:
> https://www.ovirt.org/community/about/community-guidelines/
> List Archives:
> https://lists.ovirt.org/archives/list/devel@ovirt.org/message/UDHD4SQLIGELWYZDBNEDC223DX36L6RT/
>


-- 

SANDRO BONAZZOLA

MANAGER, SOFTWARE ENGINEERING, EMEA R RHV

Red Hat EMEA 

sbona...@redhat.com

___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/ROIIPPQGS7SI7IBZFGXZGXULULQ4L3ZM/

[ovirt-devel] Re: Announcing 'COVERAGE' option in OST

[Eyal Edri]

Thanks for submitting it! it's really a great addition to the value OST
gives, it can help prioritize which tests
should be added in the future and also great timing, especially after the
VDSM functional tests on check-merged were removed/pending removal
in favor of running it on OST.

On Wed, Dec 12, 2018 at 10:44 PM Marcin Sobczyk  wrote:

> Hi,
>
> I've been working on adding coverage report for VDSM in OST
> recently, and I'm happy to announce, that the first batch of patches is
> merged!
>
> To run a suite with coverage, look for 'COVERAGE' drop-down on OST's
> build parameters page. If you run OST locally, pass a '--coverage'
> argument to 'run_suite.sh'.
>
> Currently, coverage works only for VDSM in basic-suite-master, but adding
> VDSM support for other suites is now a no-brainer. More patches are on the
> way!
>
> Since the option is named 'COVERAGE', and not 'VDSM_COVERAGE', other
> projects
> are welcome to implement their coverage reports on top of it.
>
> Cheers, Marcin
>
> ___
> Devel mailing list -- devel@ovirt.org
> To unsubscribe send an email to devel-le...@ovirt.org
> Privacy Statement: https://www.ovirt.org/site/privacy-policy/
> oVirt Code of Conduct:
> https://www.ovirt.org/community/about/community-guidelines/
> List Archives:
> https://lists.ovirt.org/archives/list/devel@ovirt.org/message/UDHD4SQLIGELWYZDBNEDC223DX36L6RT/
>


-- 

Eyal edri


MANAGER

RHV/CNV DevOps

EMEA VIRTUALIZATION R


Red Hat EMEA 
 TRIED. TESTED. TRUSTED. 
phone: +972-9-7692018
irc: eedri (on #tlv #rhev-dev #rhev-integ)
___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/LWRFLFUGPWF7HPEBILHVSJELPE3TGIFF/

[ovirt-devel] Re: Announcing 'COVERAGE' option in OST

[Piotr Kliczewski]

Awsome job! Thank you!

śr., 12 gru 2018, 22:41: Dan Kenigsberg  napisał(a):

>
>
> On Wed, 12 Dec 2018, 22:42 Marcin Sobczyk 
>> Hi,
>>
>> I've been working on adding coverage report for VDSM in OST
>> recently, and I'm happy to announce, that the first batch of patches is
>> merged!
>>
>> To run a suite with coverage, look for 'COVERAGE' drop-down on OST's
>> build parameters page. If you run OST locally, pass a '--coverage'
>> argument to 'run_suite.sh'.
>>
>> Currently, coverage works only for VDSM in basic-suite-master, but adding
>> VDSM support for other suites is now a no-brainer. More patches are on
>> the way!
>>
>> Since the option is named 'COVERAGE', and not 'VDSM_COVERAGE', other
>> projects
>> are welcome to implement their coverage reports on top of it.
>>
>> Cheers, Marcin
>>
>
> Awesome indeed. I was not aware there's a way to add such parameters to
> suites. It could come up handy elsewhere (e.g. choosing ovs for cluster
> switchtype)
>
> I think it is important to explain why it's so important.
>
> Unfortunately, much of vdsm functionalily is not covered by proper vdsm
> unit tests. We depend on OST to define what is a "working" ovirt.
>
> Here's a message for us vdsm developers: if you care for your code and the
> time you've invested into it, make sure that it shows up green on the likes
> of
> https://jenkins.ovirt.org/view/oVirt%20system%20tests/job/ovirt-system-tests_manual/3754/artifact/exported-artifacts/coverage/vdsm/html/index.html
>
> The total number - 59% - is not brilliant, but not as bad as I assumed.
>
> Please go over the report. There are glaring missing pieces (e.g gluster,
> fencing) but also less obvious ones (almost half of vm.py).
>
> It should give you ideas about tests you need to add, or code you can drop.
>
>
___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/KH7WUU4G43W2HCNUFGC4F2DNIHAVOTTF/

[ovirt-devel] Re: Announcing 'COVERAGE' option in OST

[Dan Kenigsberg]

On Wed, 12 Dec 2018, 22:42 Marcin Sobczyk  Hi,
>
> I've been working on adding coverage report for VDSM in OST
> recently, and I'm happy to announce, that the first batch of patches is
> merged!
>
> To run a suite with coverage, look for 'COVERAGE' drop-down on OST's
> build parameters page. If you run OST locally, pass a '--coverage'
> argument to 'run_suite.sh'.
>
> Currently, coverage works only for VDSM in basic-suite-master, but adding
> VDSM support for other suites is now a no-brainer. More patches are on the
> way!
>
> Since the option is named 'COVERAGE', and not 'VDSM_COVERAGE', other
> projects
> are welcome to implement their coverage reports on top of it.
>
> Cheers, Marcin
>

Awesome indeed. I was not aware there's a way to add such parameters to
suites. It could come up handy elsewhere (e.g. choosing ovs for cluster
switchtype)

I think it is important to explain why it's so important.

Unfortunately, much of vdsm functionalily is not covered by proper vdsm
unit tests. We depend on OST to define what is a "working" ovirt.

Here's a message for us vdsm developers: if you care for your code and the
time you've invested into it, make sure that it shows up green on the likes
of
https://jenkins.ovirt.org/view/oVirt%20system%20tests/job/ovirt-system-tests_manual/3754/artifact/exported-artifacts/coverage/vdsm/html/index.html

The total number - 59% - is not brilliant, but not as bad as I assumed.

Please go over the report. There are glaring missing pieces (e.g gluster,
fencing) but also less obvious ones (almost half of vm.py).

It should give you ideas about tests you need to add, or code you can drop.
___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/LHKILZ4BKUCR7U7Y6GYQSKPIPWPS45JZ/

[ovirt-devel] Re: Announcing 'COVERAGE' option in OST

[Martin Perina]

Great work, Marcin, thanks a lot!


On Wed, 12 Dec 2018, 22:05 Edward Haas  Thank you Marcin, this is very nice.
>
> Thanks,
> Edy.
>
> On Wed, Dec 12, 2018 at 9:59 PM Nir Soffer  wrote:
>
>> On Wed, Dec 12, 2018 at 3:42 PM Marcin Sobczyk 
>> wrote:
>>
>>> Hi,
>>>
>>> I've been working on adding coverage report for VDSM in OST
>>> recently, and I'm happy to announce, that the first batch of patches is
>>> merged!
>>>
>>> To run a suite with coverage, look for 'COVERAGE' drop-down on OST's
>>> build parameters page. If you run OST locally, pass a '--coverage'
>>> argument to 'run_suite.sh'.
>>>
>>> Currently, coverage works only for VDSM in basic-suite-master, but adding
>>> VDSM support for other suites is now a no-brainer. More patches are on
>>> the way!
>>>
>>> Since the option is named 'COVERAGE', and not 'VDSM_COVERAGE', other
>>> projects
>>> are welcome to implement their coverage reports on top of it.
>>>
>>> Cheers, Marcin
>>>
>>
>> Awesome, thanks for the update!
>>
>> Nir
>>
>
___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/TLR545QSPMFYBCEJ7DKSO55JHIKO7RAG/

[ovirt-devel] Re: Announcing 'COVERAGE' option in OST

[Edward Haas]

Thank you Marcin, this is very nice.

Thanks,
Edy.

On Wed, Dec 12, 2018 at 9:59 PM Nir Soffer  wrote:

> On Wed, Dec 12, 2018 at 3:42 PM Marcin Sobczyk 
> wrote:
>
>> Hi,
>>
>> I've been working on adding coverage report for VDSM in OST
>> recently, and I'm happy to announce, that the first batch of patches is
>> merged!
>>
>> To run a suite with coverage, look for 'COVERAGE' drop-down on OST's
>> build parameters page. If you run OST locally, pass a '--coverage'
>> argument to 'run_suite.sh'.
>>
>> Currently, coverage works only for VDSM in basic-suite-master, but adding
>> VDSM support for other suites is now a no-brainer. More patches are on
>> the way!
>>
>> Since the option is named 'COVERAGE', and not 'VDSM_COVERAGE', other
>> projects
>> are welcome to implement their coverage reports on top of it.
>>
>> Cheers, Marcin
>>
>
> Awesome, thanks for the update!
>
> Nir
>
___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/ULSXRX4QJJHGPT6HHO24PJLPTRON7TF3/

[ovirt-devel] Re: Announcing 'COVERAGE' option in OST

[Nir Soffer]

On Wed, Dec 12, 2018 at 3:42 PM Marcin Sobczyk  wrote:

> Hi,
>
> I've been working on adding coverage report for VDSM in OST
> recently, and I'm happy to announce, that the first batch of patches is
> merged!
>
> To run a suite with coverage, look for 'COVERAGE' drop-down on OST's
> build parameters page. If you run OST locally, pass a '--coverage'
> argument to 'run_suite.sh'.
>
> Currently, coverage works only for VDSM in basic-suite-master, but adding
> VDSM support for other suites is now a no-brainer. More patches are on the
> way!
>
> Since the option is named 'COVERAGE', and not 'VDSM_COVERAGE', other
> projects
> are welcome to implement their coverage reports on top of it.
>
> Cheers, Marcin
>

Awesome, thanks for the update!

Nir
___
Devel mailing list -- devel@ovirt.org
To unsubscribe send an email to devel-le...@ovirt.org
Privacy Statement: https://www.ovirt.org/site/privacy-policy/
oVirt Code of Conduct: 
https://www.ovirt.org/community/about/community-guidelines/
List Archives: 
https://lists.ovirt.org/archives/list/devel@ovirt.org/message/U3O3CA423JPNRIQWYKVI4U5QIGUQBJS3/