Re: [ovirt-devel] [VDSM] build-artifacts failing on master

[Barak Korren]

>
> I'm not sure I understand your point. RPM spec files have %check section
> for pre-build tests. Should we, or should we not, strive to use them?

AFAIK the %check section is only relevant for DS builds, as in US we
have many other places to run tests from (e.g check_patch.sh).

AFAIK by its nature %check only allows for source-level tests (since
you don't have an RPM yet). Source-level tests can and should run
before a patch is merged. The DS build, however, happens long after
the patch is merged, and by the time it does, all source-level issues
should have been checked for.
Therefore, I think making tests run in %check should not be a high priority.

-- 
Barak Korren
bkor...@redhat.com
RHEV-CI Team
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [VDSM] build-artifacts failing on master

[Dan Kenigsberg]

On Thu, Sep 15, 2016 at 01:15:29PM +0300, Barak Korren wrote:
> >
> > I love running tests on the build systems - its gives another layer of
> > assurance that we are going to build a good package for the relevant
> > system/architecture.
> >
> > However, the offending patch makes it impossible on el7-based build
> > system. Can we instead skip the test (on such systems) if the right nose
> > version is not installed?
> >
> > We should file a bug to fix nose on el7.
> >
> 
> IMO test requirements != build req != runtime req.
> 
> It is perfectly valid to use virtualenv and pip to enable using the
> latest and graetest testing tools, but those should __only__ be used
> in a testing environment. Those should not be used in a build
> environment which is designed to be reproducible and hence is
> typically devoid of network access.

That's clear.

> Deploy requirements should be tested, but by their nature those tests
> need to run post-build and hence are better left to integration tests
> like ovirt-system-tests.

I'm not sure I understand your point. RPM spec files have %check section
for pre-build tests. Should we, or should we not, strive to use them?
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [VDSM] build-artifacts failing on master

[Barak Korren]

>
> I love running tests on the build systems - its gives another layer of
> assurance that we are going to build a good package for the relevant
> system/architecture.
>
> However, the offending patch makes it impossible on el7-based build
> system. Can we instead skip the test (on such systems) if the right nose
> version is not installed?
>
> We should file a bug to fix nose on el7.
>

IMO test requirements != build req != runtime req.

It is perfectly valid to use virtualenv and pip to enable using the
latest and graetest testing tools, but those should __only__ be used
in a testing environment. Those should not be used in a build
environment which is designed to be reproducible and hence is
typically devoid of network access.
Deploy requirements should be tested, but by their nature those tests
need to run post-build and hence are better left to integration tests
like ovirt-system-tests.

-- 
Barak Korren
bkor...@redhat.com
RHEV-CI Team
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [VDSM] build-artifacts failing on master

[Barak Korren]

On 14 September 2016 at 22:31, Eyal Edri  wrote:
> Its actually a good question to know if standard CI supports versions of
> RPMs.
> Barak - do you know if we can specify in build-artifacts.packages file a
> version requirement?
>
> for e.g python-nose >= 1.3.7
>

You can only use the syntax supported by yum.
Since yum always installs latest by default, a '>=' syntax would not
be useful with it.


-- 
Barak Korren
bkor...@redhat.com
RHEV-CI Team
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [VDSM] build-artifacts failing on master

[Dan Kenigsberg]

On Wed, Sep 14, 2016 at 11:28:05PM +0300, Nir Soffer wrote:
> On Wed, Sep 14, 2016 at 10:43 PM, Nir Soffer  wrote:
> > On Wed, Sep 14, 2016 at 10:40 PM, Irit Goihman  wrote:
> >> I think that what's missing in build-artifacts.sh is the following commands
> >> that exist in check-patch.sh:
> >>
> >> easy_install pip
> >> pip install -U nose==1.3.7
> >
> > We cannot do this in brew/koji, you can use only packages from the 
> > distribution
> > when running make rpm.
> 
> The best way to avoid such issues is to remove the "make tests"
> from the %check section in the spec.
> 
> This allows using latest and greatest development tools which are not 
> available
> in brew or koji.
> 
> Here is a quick patch, please review:
> https://gerrit.ovirt.org/63966

I love running tests on the build systems - its gives another layer of
assurance that we are going to build a good package for the relevant
system/architecture.

However, the offending patch makes it impossible on el7-based build
system. Can we instead skip the test (on such systems) if the right nose
version is not installed?

We should file a bug to fix nose on el7.

> 
> >> This should install the right version for nose (that doesn't exist in rhel
> >> yum repos)
> >>
> >> On Wed, Sep 14, 2016 at 10:31 PM, Eyal Edri  wrote:
> >>>
> >>> Its actually a good question to know if standard CI supports versions of
> >>> RPMs.
> >>> Barak - do you know if we can specify in build-artifacts.packages file a
> >>> version requirement?
> >>>
> >>> for e.g python-nose >= 1.3.7
> >>>
> >>> On Wed, Sep 14, 2016 at 10:21 PM, Nir Soffer  wrote:
> 
>  The build-artifacts job is failing on master now with this error:
> 
>  19:09:23 Error: NOSE is too old, please install NOSE 1.3.7 or later
>  19:09:23 make[1]: *** [tests] Error 1
>  19:09:23 make[1]: Leaving directory
> 
>  `/home/jenkins/workspace/vdsm_master_build-artifacts-el7-x86_64/vdsm/rpmbuild/BUILD/vdsm-4.18.999'
>  19:09:23 error: Bad exit status from /var/tmp/rpm-tmp.LQXOfm (%check)
>  19:09:23
>  19:09:23
>  19:09:23 RPM build errors:
>  19:09:23 Bad exit status from /var/tmp/rpm-tmp.LQXOfm (%check)
> 
>  Looks like this patch is the cause:
> 
>  commit 4e729ddd2b243d0953e2de5d31c42fc59859bf23
>  Author: Edward Haas 
>  Date:   Sun Sep 11 14:10:01 2016 +0300
> 
>  build tests: Require NOSE 1.3.7 and up for running tests
> 
>  On RHEL7/Centos7 the provided NOSE version is 1.3.0.
>  CI runs the tests with 1.3.7.
> 
>  To be consistent and avoid different behaviours, assure that the
>  tests
>  are running with a minimum nose version of 1.3.7.
> 
>  Specifically, between 1.3.0 and 1.3.7 a bug has been resolved
>  regarding
>  test labeling and its support with test class inheritance.
> 
>  Change-Id: If79d8624cee1c14a21840e4a08000fc33abb58e5
>  Signed-off-by: Edward Haas 
>  Reviewed-on: https://gerrit.ovirt.org/63638
>  Continuous-Integration: Jenkins CI
>  Reviewed-by: Petr Horáček 
>  Reviewed-by: Irit Goihman 
>  Reviewed-by: Yaniv Bronhaim 
>  Reviewed-by: Piotr Kliczewski 
> 
>  I did not check the details, but it seems we need to revert this patch.
> 
>  Please check and fix.
> 
>  Cheers,
>  Nir
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [VDSM] build-artifacts failing on master

[Nir Soffer]

On Wed, Sep 14, 2016 at 10:43 PM, Nir Soffer  wrote:
> On Wed, Sep 14, 2016 at 10:40 PM, Irit Goihman  wrote:
>> I think that what's missing in build-artifacts.sh is the following commands
>> that exist in check-patch.sh:
>>
>> easy_install pip
>> pip install -U nose==1.3.7
>
> We cannot do this in brew/koji, you can use only packages from the 
> distribution
> when running make rpm.

The best way to avoid such issues is to remove the "make tests"
from the %check section in the spec.

This allows using latest and greatest development tools which are not available
in brew or koji.

Here is a quick patch, please review:
https://gerrit.ovirt.org/63966

>> This should install the right version for nose (that doesn't exist in rhel
>> yum repos)
>>
>> On Wed, Sep 14, 2016 at 10:31 PM, Eyal Edri  wrote:
>>>
>>> Its actually a good question to know if standard CI supports versions of
>>> RPMs.
>>> Barak - do you know if we can specify in build-artifacts.packages file a
>>> version requirement?
>>>
>>> for e.g python-nose >= 1.3.7
>>>
>>> On Wed, Sep 14, 2016 at 10:21 PM, Nir Soffer  wrote:

 The build-artifacts job is failing on master now with this error:

 19:09:23 Error: NOSE is too old, please install NOSE 1.3.7 or later
 19:09:23 make[1]: *** [tests] Error 1
 19:09:23 make[1]: Leaving directory

 `/home/jenkins/workspace/vdsm_master_build-artifacts-el7-x86_64/vdsm/rpmbuild/BUILD/vdsm-4.18.999'
 19:09:23 error: Bad exit status from /var/tmp/rpm-tmp.LQXOfm (%check)
 19:09:23
 19:09:23
 19:09:23 RPM build errors:
 19:09:23 Bad exit status from /var/tmp/rpm-tmp.LQXOfm (%check)

 Looks like this patch is the cause:

 commit 4e729ddd2b243d0953e2de5d31c42fc59859bf23
 Author: Edward Haas 
 Date:   Sun Sep 11 14:10:01 2016 +0300

 build tests: Require NOSE 1.3.7 and up for running tests

 On RHEL7/Centos7 the provided NOSE version is 1.3.0.
 CI runs the tests with 1.3.7.

 To be consistent and avoid different behaviours, assure that the
 tests
 are running with a minimum nose version of 1.3.7.

 Specifically, between 1.3.0 and 1.3.7 a bug has been resolved
 regarding
 test labeling and its support with test class inheritance.

 Change-Id: If79d8624cee1c14a21840e4a08000fc33abb58e5
 Signed-off-by: Edward Haas 
 Reviewed-on: https://gerrit.ovirt.org/63638
 Continuous-Integration: Jenkins CI
 Reviewed-by: Petr Horáček 
 Reviewed-by: Irit Goihman 
 Reviewed-by: Yaniv Bronhaim 
 Reviewed-by: Piotr Kliczewski 

 I did not check the details, but it seems we need to revert this patch.

 Please check and fix.

 Cheers,
 Nir
 ___
 Infra mailing list
 in...@ovirt.org
 http://lists.ovirt.org/mailman/listinfo/infra


>>>
>>>
>>>
>>> --
>>> Eyal Edri
>>> Associate Manager
>>> RHV DevOps
>>> EMEA ENG Virtualization R
>>> Red Hat Israel
>>>
>>> phone: +972-9-7692018
>>> irc: eedri (on #tlv #rhev-dev #rhev-integ)
>>>
>>> ___
>>> Devel mailing list
>>> Devel@ovirt.org
>>> http://lists.ovirt.org/mailman/listinfo/devel
>>
>>
>>
>>
>> --
>> Irit Goihman
>> Software Engineer
>> Red Hat Israel Ltd.
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [VDSM] build-artifacts failing on master

[Nir Soffer]

On Wed, Sep 14, 2016 at 10:40 PM, Irit Goihman  wrote:
> I think that what's missing in build-artifacts.sh is the following commands
> that exist in check-patch.sh:
>
> easy_install pip
> pip install -U nose==1.3.7

We cannot do this in brew/koji, you can use only packages from the distribution
when running make rpm.

>
> This should install the right version for nose (that doesn't exist in rhel
> yum repos)
>
> On Wed, Sep 14, 2016 at 10:31 PM, Eyal Edri  wrote:
>>
>> Its actually a good question to know if standard CI supports versions of
>> RPMs.
>> Barak - do you know if we can specify in build-artifacts.packages file a
>> version requirement?
>>
>> for e.g python-nose >= 1.3.7
>>
>> On Wed, Sep 14, 2016 at 10:21 PM, Nir Soffer  wrote:
>>>
>>> The build-artifacts job is failing on master now with this error:
>>>
>>> 19:09:23 Error: NOSE is too old, please install NOSE 1.3.7 or later
>>> 19:09:23 make[1]: *** [tests] Error 1
>>> 19:09:23 make[1]: Leaving directory
>>>
>>> `/home/jenkins/workspace/vdsm_master_build-artifacts-el7-x86_64/vdsm/rpmbuild/BUILD/vdsm-4.18.999'
>>> 19:09:23 error: Bad exit status from /var/tmp/rpm-tmp.LQXOfm (%check)
>>> 19:09:23
>>> 19:09:23
>>> 19:09:23 RPM build errors:
>>> 19:09:23 Bad exit status from /var/tmp/rpm-tmp.LQXOfm (%check)
>>>
>>> Looks like this patch is the cause:
>>>
>>> commit 4e729ddd2b243d0953e2de5d31c42fc59859bf23
>>> Author: Edward Haas 
>>> Date:   Sun Sep 11 14:10:01 2016 +0300
>>>
>>> build tests: Require NOSE 1.3.7 and up for running tests
>>>
>>> On RHEL7/Centos7 the provided NOSE version is 1.3.0.
>>> CI runs the tests with 1.3.7.
>>>
>>> To be consistent and avoid different behaviours, assure that the
>>> tests
>>> are running with a minimum nose version of 1.3.7.
>>>
>>> Specifically, between 1.3.0 and 1.3.7 a bug has been resolved
>>> regarding
>>> test labeling and its support with test class inheritance.
>>>
>>> Change-Id: If79d8624cee1c14a21840e4a08000fc33abb58e5
>>> Signed-off-by: Edward Haas 
>>> Reviewed-on: https://gerrit.ovirt.org/63638
>>> Continuous-Integration: Jenkins CI
>>> Reviewed-by: Petr Horáček 
>>> Reviewed-by: Irit Goihman 
>>> Reviewed-by: Yaniv Bronhaim 
>>> Reviewed-by: Piotr Kliczewski 
>>>
>>> I did not check the details, but it seems we need to revert this patch.
>>>
>>> Please check and fix.
>>>
>>> Cheers,
>>> Nir
>>> ___
>>> Infra mailing list
>>> in...@ovirt.org
>>> http://lists.ovirt.org/mailman/listinfo/infra
>>>
>>>
>>
>>
>>
>> --
>> Eyal Edri
>> Associate Manager
>> RHV DevOps
>> EMEA ENG Virtualization R
>> Red Hat Israel
>>
>> phone: +972-9-7692018
>> irc: eedri (on #tlv #rhev-dev #rhev-integ)
>>
>> ___
>> Devel mailing list
>> Devel@ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/devel
>
>
>
>
> --
> Irit Goihman
> Software Engineer
> Red Hat Israel Ltd.
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [VDSM] build-artifacts failing on master

[Nir Soffer]

On Wed, Sep 14, 2016 at 10:31 PM, Eyal Edri  wrote:
> Its actually a good question to know if standard CI supports versions of
> RPMs.
> Barak - do you know if we can specify in build-artifacts.packages file a
> version requirement?
>
> for e.g python-nose >= 1.3.7

This can be worse, we build on centos, which may have this version,
but the package may not be available on rhel, failing the build in brew.

Can we do a scratch build in brew?

>
> On Wed, Sep 14, 2016 at 10:21 PM, Nir Soffer  wrote:
>>
>> The build-artifacts job is failing on master now with this error:
>>
>> 19:09:23 Error: NOSE is too old, please install NOSE 1.3.7 or later
>> 19:09:23 make[1]: *** [tests] Error 1
>> 19:09:23 make[1]: Leaving directory
>>
>> `/home/jenkins/workspace/vdsm_master_build-artifacts-el7-x86_64/vdsm/rpmbuild/BUILD/vdsm-4.18.999'
>> 19:09:23 error: Bad exit status from /var/tmp/rpm-tmp.LQXOfm (%check)
>> 19:09:23
>> 19:09:23
>> 19:09:23 RPM build errors:
>> 19:09:23 Bad exit status from /var/tmp/rpm-tmp.LQXOfm (%check)
>>
>> Looks like this patch is the cause:
>>
>> commit 4e729ddd2b243d0953e2de5d31c42fc59859bf23
>> Author: Edward Haas 
>> Date:   Sun Sep 11 14:10:01 2016 +0300
>>
>> build tests: Require NOSE 1.3.7 and up for running tests
>>
>> On RHEL7/Centos7 the provided NOSE version is 1.3.0.
>> CI runs the tests with 1.3.7.
>>
>> To be consistent and avoid different behaviours, assure that the tests
>> are running with a minimum nose version of 1.3.7.
>>
>> Specifically, between 1.3.0 and 1.3.7 a bug has been resolved
>> regarding
>> test labeling and its support with test class inheritance.
>>
>> Change-Id: If79d8624cee1c14a21840e4a08000fc33abb58e5
>> Signed-off-by: Edward Haas 
>> Reviewed-on: https://gerrit.ovirt.org/63638
>> Continuous-Integration: Jenkins CI
>> Reviewed-by: Petr Horáček 
>> Reviewed-by: Irit Goihman 
>> Reviewed-by: Yaniv Bronhaim 
>> Reviewed-by: Piotr Kliczewski 
>>
>> I did not check the details, but it seems we need to revert this patch.
>>
>> Please check and fix.
>>
>> Cheers,
>> Nir
>> ___
>> Infra mailing list
>> in...@ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/infra
>>
>>
>
>
>
> --
> Eyal Edri
> Associate Manager
> RHV DevOps
> EMEA ENG Virtualization R
> Red Hat Israel
>
> phone: +972-9-7692018
> irc: eedri (on #tlv #rhev-dev #rhev-integ)
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [VDSM] build-artifacts failing on master

[Irit Goihman]

I think that what's missing in build-artifacts.sh is the following commands
that exist in check-patch.sh:

easy_install pip

pip install -U nose==1.3.7

This should install the right version for nose (that doesn't exist in rhel
yum repos)

On Wed, Sep 14, 2016 at 10:31 PM, Eyal Edri  wrote:

> Its actually a good question to know if standard CI supports versions of
> RPMs.
> Barak - do you know if we can specify in build-artifacts.packages file a
> version requirement?
>
> for e.g python-nose >= 1.3.7
>
> On Wed, Sep 14, 2016 at 10:21 PM, Nir Soffer  wrote:
>
>> The build-artifacts job is failing on master now with this error:
>>
>> 19:09:23 Error: NOSE is too old, please install NOSE 1.3.7 or later
>> 19:09:23 make[1]: *** [tests] Error 1
>> 19:09:23 make[1]: Leaving directory
>> `/home/jenkins/workspace/vdsm_master_build-artifacts-el7-x86
>> _64/vdsm/rpmbuild/BUILD/vdsm-4.18.999'
>> 19:09:23 error: Bad exit status from /var/tmp/rpm-tmp.LQXOfm (%check)
>> 19:09:23
>> 19:09:23
>> 19:09:23 RPM build errors:
>> 19:09:23 Bad exit status from /var/tmp/rpm-tmp.LQXOfm (%check)
>>
>> Looks like this patch is the cause:
>>
>> commit 4e729ddd2b243d0953e2de5d31c42fc59859bf23
>> Author: Edward Haas 
>> Date:   Sun Sep 11 14:10:01 2016 +0300
>>
>> build tests: Require NOSE 1.3.7 and up for running tests
>>
>> On RHEL7/Centos7 the provided NOSE version is 1.3.0.
>> CI runs the tests with 1.3.7.
>>
>> To be consistent and avoid different behaviours, assure that the tests
>> are running with a minimum nose version of 1.3.7.
>>
>> Specifically, between 1.3.0 and 1.3.7 a bug has been resolved
>> regarding
>> test labeling and its support with test class inheritance.
>>
>> Change-Id: If79d8624cee1c14a21840e4a08000fc33abb58e5
>> Signed-off-by: Edward Haas 
>> Reviewed-on: https://gerrit.ovirt.org/63638
>> Continuous-Integration: Jenkins CI
>> Reviewed-by: Petr Horáček 
>> Reviewed-by: Irit Goihman 
>> Reviewed-by: Yaniv Bronhaim 
>> Reviewed-by: Piotr Kliczewski 
>>
>> I did not check the details, but it seems we need to revert this patch.
>>
>> Please check and fix.
>>
>> Cheers,
>> Nir
>> ___
>> Infra mailing list
>> in...@ovirt.org
>> http://lists.ovirt.org/mailman/listinfo/infra
>>
>>
>>
>
>
> --
> Eyal Edri
> Associate Manager
> RHV DevOps
> EMEA ENG Virtualization R
> Red Hat Israel
>
> phone: +972-9-7692018
> irc: eedri (on #tlv #rhev-dev #rhev-integ)
>
> ___
> Devel mailing list
> Devel@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/devel
>



-- 
Irit Goihman
Software Engineer
Red Hat Israel Ltd.
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel

Re: [ovirt-devel] [VDSM] build-artifacts failing on master

[Eyal Edri]

Its actually a good question to know if standard CI supports versions of
RPMs.
Barak - do you know if we can specify in build-artifacts.packages file a
version requirement?

for e.g python-nose >= 1.3.7

On Wed, Sep 14, 2016 at 10:21 PM, Nir Soffer  wrote:

> The build-artifacts job is failing on master now with this error:
>
> 19:09:23 Error: NOSE is too old, please install NOSE 1.3.7 or later
> 19:09:23 make[1]: *** [tests] Error 1
> 19:09:23 make[1]: Leaving directory
> `/home/jenkins/workspace/vdsm_master_build-artifacts-el7-
> x86_64/vdsm/rpmbuild/BUILD/vdsm-4.18.999'
> 19:09:23 error: Bad exit status from /var/tmp/rpm-tmp.LQXOfm (%check)
> 19:09:23
> 19:09:23
> 19:09:23 RPM build errors:
> 19:09:23 Bad exit status from /var/tmp/rpm-tmp.LQXOfm (%check)
>
> Looks like this patch is the cause:
>
> commit 4e729ddd2b243d0953e2de5d31c42fc59859bf23
> Author: Edward Haas 
> Date:   Sun Sep 11 14:10:01 2016 +0300
>
> build tests: Require NOSE 1.3.7 and up for running tests
>
> On RHEL7/Centos7 the provided NOSE version is 1.3.0.
> CI runs the tests with 1.3.7.
>
> To be consistent and avoid different behaviours, assure that the tests
> are running with a minimum nose version of 1.3.7.
>
> Specifically, between 1.3.0 and 1.3.7 a bug has been resolved regarding
> test labeling and its support with test class inheritance.
>
> Change-Id: If79d8624cee1c14a21840e4a08000fc33abb58e5
> Signed-off-by: Edward Haas 
> Reviewed-on: https://gerrit.ovirt.org/63638
> Continuous-Integration: Jenkins CI
> Reviewed-by: Petr Horáček 
> Reviewed-by: Irit Goihman 
> Reviewed-by: Yaniv Bronhaim 
> Reviewed-by: Piotr Kliczewski 
>
> I did not check the details, but it seems we need to revert this patch.
>
> Please check and fix.
>
> Cheers,
> Nir
> ___
> Infra mailing list
> in...@ovirt.org
> http://lists.ovirt.org/mailman/listinfo/infra
>
>
>


-- 
Eyal Edri
Associate Manager
RHV DevOps
EMEA ENG Virtualization R
Red Hat Israel

phone: +972-9-7692018
irc: eedri (on #tlv #rhev-dev #rhev-integ)
___
Devel mailing list
Devel@ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel