[PATCH] testsuite: Merge all fstests into a single Makefile.am.

2018-04-04 Thread Chris Johns
This change is part of refactoring the testsuite's build system to remove nested make builds for every test. Update #3382 --- c/src/make/leaf.cfg| 15 +- testsuites/aclocal/rtems-test-check.m4 | 31 ++ testsuites/fstests/Makefile.am

[PATCH v2] testsuite: Merge all fstests into a single Makefile.am.

2018-04-04 Thread Chris Johns
This change is part of refactoring the testsuite's build system to remove nested make builds for every test. Update #3382 --- c/src/make/leaf.cfg| 15 +- testsuites/aclocal/rtems-test-check.m4 | 31 ++ testsuites/fstests/Makefile.am

[PATCH 2/6] bsps: Move VME support to bsps

2018-04-04 Thread Sebastian Huber
The VME support is only used by powerpc BSPs. This patch is a part of the BSP source reorganization. Update #3285. --- bsps/headers.am| 5 - bsps/powerpc/headers.am| 5 + bsps/{ =>

Re: error while running rtems-test with coverage

2018-04-04 Thread Vijay Kumar Banerjee
I got the rtems-test running I found that get_item_names(section, err) in configuration.py was returning an empty list to the item_names in load(bsp,opts) for config.py this was giving out the error mandatory item not found . I have attached the patch file . current status : rtems-test is

Re: [PATCH v2 2/5] bsps: Add shared-sources.am

2018-04-04 Thread Sebastian Huber
On 04/04/18 13:45, Chris Johns wrote: On 4/4/18 6:14 pm, Sebastian Huber wrote: include $(top_srcdir)/../../../../automake/local.am +include $(srcdir)/../../../../../../bsps/shared/shared-sources.am include $(srcdir)/../../../../../../bsps/arm/altera-cyclone-v/headers.am diff --git

Re: [PATCH v2 2/5] bsps: Add shared-sources.am

2018-04-04 Thread Chris Johns
On 4/4/18 6:14 pm, Sebastian Huber wrote: > include $(top_srcdir)/../../../../automake/local.am > +include $(srcdir)/../../../../../../bsps/shared/shared-sources.am > include $(srcdir)/../../../../../../bsps/arm/altera-cyclone-v/headers.am > diff --git a/c/src/lib/libbsp/arm/atsam/Makefile.am >

Re: [PATCH 4/6] bsps: Move version.c and use bspopts.h

2018-04-04 Thread Chris Johns
On 4/4/18 6:21 pm, Sebastian Huber wrote: > On 04/04/18 10:10, Chris Johns wrote: >> On 04/04/2018 18:03, Sebastian Huber wrote: >>> On 04/04/18 09:55, Chris Johns wrote: > I think we need only three Makefile.am and two configure.ac: > > configure.ac > Makefile.am (builds also

Re: error while running rtems-test with coverage

2018-04-04 Thread Chris Johns
On 4/4/18 8:18 pm, Vijay Kumar Banerjee wrote: > I got the rtems-test running  > > I found that get_item_names(section, err) in configuration.py  was returning > an > empty list to the  > item_names in load(bsp,opts) for config.py this was giving out the error > mandatory item not found . > > I

Re: [PATCH v2] testsuite: Merge all fstests into a single Makefile.am.

2018-04-04 Thread Sebastian Huber
The patch looks good. I just have some general questions. On 05/04/18 05:20, Chris Johns wrote: This change is part of refactoring the testsuite's build system to remove nested make builds for every test. Update #3382 [...] diff --git a/c/src/make/leaf.cfg b/c/src/make/leaf.cfg index

[PATCH] testsuite/samples: Merge all samples into a single Makefile.am.

2018-04-04 Thread Chris Johns
This change is part of refactoring the testsuite's build system to remove nested make builds for every test. Update #3382 --- testsuites/samples/Makefile.am | 156 ++--- testsuites/samples/base_mp/Makefile.am | 5 - .../samples/base_mp/{node1 =>

[PATCH] testsuites/rhealstone: Merge rhealstone into a single Makefile.am

2018-04-04 Thread Chris Johns
This change is part of refactoring the testsuite's build system to remove nested make builds for every test. Update #3382 --- testsuites/rhealstone/Makefile.am | 67 ++--- testsuites/rhealstone/configure.ac | 19 +++

[PATCH] testsuites/benchmarks: Merge benchmarks into a single Makefile.am

2018-04-04 Thread Chris Johns
This change is part of refactoring the testsuite's build system to remove nested make builds for every test. Update #3382 --- testsuites/benchmarks/Makefile.am | 50 ++--- testsuites/benchmarks/configure.ac | 13

[PATCH 3/6] bsps: Move shmdr to bsps

2018-04-04 Thread Sebastian Huber
This patch is a part of the BSP source reorganization. Update #3285. --- bsps/shared/shared-sources.am| 16 {c/src/libchip => bsps/shared}/shmdr/README | 0 .../shmdr/addlq.c => bsps/shared/shmdr/shmdr-addlq.c | 0

[PATCH 6/6] build: Remove DISTCLEANFILES

2018-04-04 Thread Sebastian Huber
A "make distclean" is not supported. So, it makes no sense to have pure "make distclean" related stuff in the Makefile.am. --- c/src/Makefile.am | 5 - c/src/lib/libbsp/arm/altera-cyclone-v/Makefile.am | 1 - c/src/lib/libbsp/arm/atsam/Makefile.am

[PATCH 1/6] bsp: Move umon support to bsps

2018-04-04 Thread Sebastian Huber
The umon support is only used by the csb337 BSP. This patch is a part of the BSP source reorganization. Update #3285. --- {c/src/lib/libbsp/shared => bsps/arm/csb337}/umon/README | 0 {c/src/lib/libbsp/shared => bsps/arm/csb337}/umon/doxygen.h | 0 {c/src/lib/libbsp/shared =>

Re: [PATCH v2] testsuite: Merge all fstests into a single Makefile.am.

2018-04-04 Thread Chris Johns
On 05/04/2018 15:25, Sebastian Huber wrote: > The patch looks good. Thanks, and it works with 1.16.1 as well as the automake version we are using. > I just have some general questions. > > On 05/04/18 05:20, Chris Johns wrote: >> This change is part of refactoring the testsuite's build system

[PATCH 5/6] bsps: Move generic IRQ support to bsps

2018-04-04 Thread Sebastian Huber
This patch is a part of the BSP source reorganization. Update #3285. --- bsps/shared/irq-sources.am | 5 + .../shared/src => bsps/shared/irq}/irq-default-handler.c | 0 {c/src/lib/libbsp/shared/src => bsps/shared/irq}/irq-generic.c | 0

Re: [PATCH 4/6] bsps: Move version.c and use bspopts.h

2018-04-04 Thread Sebastian Huber
On 04/04/18 13:06, Chris Johns wrote: You need to be sure the build rules are as simple as you say when you start. It may pay to be more conservative and group at a lower level and then merge if you can do this. Having said this a large single file is a conflict hot spot when many people are

Re: [PATCH v2 1/2] waf: Support building from libbsd.py directly from waf.

2018-04-04 Thread Chris Johns
On 04/04/2018 15:51, Christian Mauderer wrote: > Am 04.04.2018 um 07:28 schrieb Chris Johns: >> On 04/04/2018 00:43, Christian Mauderer wrote: >>> Am 27.03.2018 um 09:56 schrieb Christian Mauderer: Am 27.03.2018 um 09:00 schrieb Christian Mauderer: > Am 26.03.2018 um 14:59 schrieb

Re: [PATCH v2 1/2] waf: Support building from libbsd.py directly from waf.

2018-04-04 Thread Christian Mauderer
Am 04.04.2018 um 08:20 schrieb Chris Johns: > On 04/04/2018 15:51, Christian Mauderer wrote: >> Am 04.04.2018 um 07:28 schrieb Chris Johns: >>> On 04/04/2018 00:43, Christian Mauderer wrote: Am 27.03.2018 um 09:56 schrieb Christian Mauderer: > Am 27.03.2018 um 09:00 schrieb Christian

Re: [PATCH v2 1/2] waf: Support building from libbsd.py directly from waf.

2018-04-04 Thread Christian Mauderer
Am 04.04.2018 um 09:00 schrieb Chris Johns: > On 04/04/2018 16:35, Christian Mauderer wrote: >> Am 04.04.2018 um 08:20 schrieb Chris Johns: >>> On 04/04/2018 15:51, Christian Mauderer wrote: Am 04.04.2018 um 07:28 schrieb Chris Johns: > On 04/04/2018 00:43, Christian Mauderer wrote:

Re: [PATCH 4/6] bsps: Move version.c and use bspopts.h

2018-04-04 Thread Sebastian Huber
On 04/04/18 04:23, Chris Johns wrote: Hi Sebastian, I do like the use of shared.am to add sources to a BSP. It hides what is being built and at this point in time I actually feel a clear view in one place is better than another level of indirection. Do you have more sources you wish to add

Re: [PATCH 4/6] bsps: Move version.c and use bspopts.h

2018-04-04 Thread Sebastian Huber
On 04/04/18 10:10, Chris Johns wrote: On 04/04/2018 18:03, Sebastian Huber wrote: On 04/04/18 09:55, Chris Johns wrote: I think we need only three Makefile.am and two configure.ac: configure.ac Makefile.am (builds also cpukit, uses AM_CONDITIONAL for cpukit/score/cpu/*) testsuites/Makefile.am

Re: [PATCH v2 1/2] waf: Support building from libbsd.py directly from waf.

2018-04-04 Thread Chris Johns
On 04/04/2018 16:35, Christian Mauderer wrote: > Am 04.04.2018 um 08:20 schrieb Chris Johns: >> On 04/04/2018 15:51, Christian Mauderer wrote: >>> Am 04.04.2018 um 07:28 schrieb Chris Johns: On 04/04/2018 00:43, Christian Mauderer wrote: >>> Every module then would get >>> this list and would

Re: [PATCH v2 1/2] waf: Support building from libbsd.py directly from waf.

2018-04-04 Thread Christian Mauderer
Am 04.04.2018 um 09:36 schrieb Chris Johns: > On 04/04/2018 17:14, Christian Mauderer wrote: >> Am 04.04.2018 um 09:00 schrieb Chris Johns: >>> On 04/04/2018 16:35, Christian Mauderer wrote: Am 04.04.2018 um 08:20 schrieb Chris Johns: > On 04/04/2018 15:51, Christian Mauderer wrote:

Re: [PATCH 4/6] bsps: Move version.c and use bspopts.h

2018-04-04 Thread Sebastian Huber
On 04/04/18 09:55, Chris Johns wrote: If you can restrict yourself to just automake defined functionality you stand a chance, if you cannot you step into implementation issues. Please review the patch below. [...] An example of a breakage with the latest automake is: diff --git

[PATCH v2 3/5] bsps: Move version.c and use bspopts.h

2018-04-04 Thread Sebastian Huber
This patch is a part of the BSP source reorganization. Update #3285. Update #3375. --- c/src/support/version.c => bsps/shared/rtems-version.c | 5 - bsps/shared/shared-sources.am | 1 + c/src/configure.ac | 2 --

[PATCH v2 2/5] bsps: Add shared-sources.am

2018-04-04 Thread Sebastian Huber
This patch is a part of the BSP source reorganization. Update #3285. --- bsps/shared/shared-sources.am | 0 c/src/lib/libbsp/arm/altera-cyclone-v/Makefile.am | 1 + c/src/lib/libbsp/arm/atsam/Makefile.am| 1 + c/src/lib/libbsp/arm/beagle/Makefile.am

[PATCH v2 1/5] bsps: Add RTEMS_BSP to bspopts.h

2018-04-04 Thread Sebastian Huber
This patch is a part of the BSP source reorganization. Update #3285. --- c/src/aclocal/bsp-configure.m4 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/c/src/aclocal/bsp-configure.m4 b/c/src/aclocal/bsp-configure.m4 index 6f560fd3f5..394d64acbc 100644 --- a/c/src/aclocal/bsp-configure.m4

Re: [PATCH 4/6] bsps: Move version.c and use bspopts.h

2018-04-04 Thread Sebastian Huber
On 04/04/18 09:55, Chris Johns wrote: I think we need only three Makefile.am and two configure.ac: configure.ac Makefile.am (builds also cpukit, uses AM_CONDITIONAL for cpukit/score/cpu/*) testsuites/Makefile.am (uses AM_CONDITIONAL for each test) 500+ tests in the one file? Really? I hope

Re: [PATCH 4/6] bsps: Move version.c and use bspopts.h

2018-04-04 Thread Chris Johns
On 04/04/2018 18:07, Sebastian Huber wrote: > > Sorry, Chris. I cannot review this Autoconf/Automake stuff. I have no idea how > it works internally. I work with trial and error mostly in this domain. > Is there any other way to work with this stuff, if there is please let me know? ;) Chris

Re: [PATCH 4/6] bsps: Move version.c and use bspopts.h

2018-04-04 Thread Chris Johns
On 04/04/2018 17:23, Sebastian Huber wrote: > On 04/04/18 04:23, Chris Johns wrote: >> Hi Sebastian, >> >> I do like the use of shared.am to add sources to a BSP. It hides what is >> being >> built and at this point in time I actually feel a clear view in one place is >> better than another level

Re: [PATCH 4/6] bsps: Move version.c and use bspopts.h

2018-04-04 Thread Chris Johns
On 04/04/2018 18:03, Sebastian Huber wrote: > On 04/04/18 09:55, Chris Johns wrote: >>> I think we need only three Makefile.am and two configure.ac: >>> >>> configure.ac >>> Makefile.am (builds also cpukit, uses AM_CONDITIONAL for cpukit/score/cpu/*) >>> testsuites/Makefile.am (uses AM_CONDITIONAL

Re: [PATCH v2 1/2] waf: Support building from libbsd.py directly from waf.

2018-04-04 Thread Chris Johns
On 04/04/2018 17:14, Christian Mauderer wrote: > Am 04.04.2018 um 09:00 schrieb Chris Johns: >> On 04/04/2018 16:35, Christian Mauderer wrote: >>> Am 04.04.2018 um 08:20 schrieb Chris Johns: On 04/04/2018 15:51, Christian Mauderer wrote: > Am 04.04.2018 um 07:28 schrieb Chris Johns: