Re: [PATCH 13/18] config: Add _Thread_Idle_body

2020-02-15 Thread Sebastian Huber
On 16/02/2020 05:31, Gedare Bloom wrote: On Sat, Feb 15, 2020 at 4:36 PM Chris Johns > wrote: On 2020-02-15 03:02, Sebastian Huber wrote: > Move the idle thread body configuration constant out of the > configuration table. > > Provide a default

Re: [PATCH 10/18] config: Add _Watchdog_Microseconds_per_tick

2020-02-15 Thread Sebastian Huber
On 16/02/2020 00:25, Chris Johns wrote: On 2020-02-15 03:02, Sebastian Huber wrote: Move the microseconds per tick configuration constant out of the configuration table. This is necessary to split up the confdefs.h file in easier to review pieces. Add WATCHDOG_MICROSECONDS_PER_TICK_DEFAULT

Re: [PATCH v3 2/2] bsp/raspberrypi: Mini UART driver

2020-02-15 Thread G. S. Niteesh
Hii, This is a reminder message since this patch has been unnoticed for a while. I have tested it on Raspberry Pi 3 and it works fine. There is also another patch https://lists.rtems.org/pipermail/devel/2020-February/057194.html, please do have a look at these. Thank you. Niteesh On Mon, Feb 10,

Re: [PATCH 07/18] config: Bring back RTEMS 4.11 configuration table

2020-02-15 Thread Sebastian Huber
On 16/02/2020 00:30, Chris Johns wrote: On 2020-02-15 03:02, Sebastian Huber wrote: This improves API backward compatibility of RTEMS 5.1 to previous versions. What is the purpose of this change? How does a user wanting backward compatibility use this change? There may be applications

Re: [PATCH 13/18] config: Add _Thread_Idle_body

2020-02-15 Thread Gedare Bloom
On Sat, Feb 15, 2020 at 4:36 PM Chris Johns wrote: > On 2020-02-15 03:02, Sebastian Huber wrote: > > Move the idle thread body configuration constant out of the > > configuration table. > > > > Provide a default definition of the idle thread body constant. > > May be I am missing something

Re: [PATCH 13/18] config: Add _Thread_Idle_body

2020-02-15 Thread Sebastian Huber
On 16/02/2020 00:36, Chris Johns wrote: On 2020-02-15 03:02, Sebastian Huber wrote: Move the idle thread body configuration constant out of the configuration table. Provide a default definition of the idle thread body constant. May be I am missing something simple here. How would I provide

Re: [PATCH 6/6] config: Remove CONFIGURE_DISABLE_SMP_CONFIGURATION

2020-02-15 Thread Joel Sherrill
Another historical detail for the commit message is that even in SMP builds, uniprocesor tests used a uniprocesor schedule. It took us a while to decide that the uniprocesor tests should behave the same with the proper SMP scheduler. This is a pretty fundamental realisation and probably is worth

Re: [PATCH v4] doc/raspberrypi: Added instructions for raspberrypi

2020-02-15 Thread G. S. Niteesh
Another remainder. Can someone please push this? Thanks, Niteesh On Thu, Feb 13, 2020 at 11:19 PM G. S. Niteesh wrote: > On Thu, Feb 13, 2020 at 11:16 PM Alan Cudmore > wrote: > >> "set scheduler-locking on" in GDB works! I was able to run RPI2 hello.exe >> >> So I consider your instructions

Re: Ticket #1977

2020-02-15 Thread Joel Sherrill
On Sat, Feb 15, 2020, 6:20 AM Eshan Dhawan wrote: > Also, I wanted to know if there were test suites to check it? > Not yet since there is no functionality to test > On Sat, Feb 15, 2020 at 5:48 PM Eshan Dhawan > wrote: > >> Hi, >> As I was going through the ticket I wanted to know the main

Re: [PATCH 18/18] config: Add

2020-02-15 Thread Joel Sherrill
On Sat, Feb 15, 2020, 2:38 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > On 15/02/2020 05:22, Gedare Bloom wrote: > > > This makes sense. Is there any reason for the ordering? > It should be alphabetically sorted. > > > > If possible, I think grouping by obsoleted version or

Re: [PATCH] first commit

2020-02-15 Thread Joel Sherrill
I got the screenshot in a private email before I saw this. Looks good. What kind of projects are you interested in? On Sat, Feb 15, 2020, 1:41 AM suyash singh wrote: > Hello I am Suyash Singh and this is my first commit. I am from India and > currently in 2nd year of BTech Computer Science

Re: [PATCH 18/18] config: Add

2020-02-15 Thread Gedare Bloom
On Sat, Feb 15, 2020 at 7:16 AM Joel Sherrill wrote: > > > On Sat, Feb 15, 2020, 2:38 AM Sebastian Huber < > sebastian.hu...@embedded-brains.de> wrote: > >> On 15/02/2020 05:22, Gedare Bloom wrote: >> >> > This makes sense. Is there any reason for the ordering? >> It should be alphabetically

Re: [PATCH 18/18] config: Add

2020-02-15 Thread Sebastian Huber
On 15/02/2020 05:22, Gedare Bloom wrote: This makes sense. Is there any reason for the ordering? It should be alphabetically sorted. If possible, I think grouping by obsoleted version or alphabetical ordering would be a good idea. Maybe I should add a comment like this to the top of the

[PATCH 6/6] config: Remove CONFIGURE_DISABLE_SMP_CONFIGURATION

2020-02-15 Thread Sebastian Huber
The CONFIGURE_DISABLE_SMP_CONFIGURATION configuration option and rtems_configuration_is_smp_enabled() were added during the SMP support development cycle as a workaround to fix some testsuite failures in SMP configurations. All use cases were replaced with tests for specific conditions. The

Re: Ticket #1977

2020-02-15 Thread Eshan Dhawan
Also, I wanted to know if there were test suites to check it? On Sat, Feb 15, 2020 at 5:48 PM Eshan Dhawan wrote: > Hi, > As I was going through the ticket I wanted to know the main arguments that > are to be passed in mode and how they are to be processed in the mq_open. > >

[PATCH 5/6] rtems: Change timer server task mode setting

2020-02-15 Thread Sebastian Huber
Use the non-preempt mode only in uni-processor configurations. Update #3876. --- cpukit/rtems/src/timerserver.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/cpukit/rtems/src/timerserver.c b/cpukit/rtems/src/timerserver.c index 2ebceca1ba..1a332b89ec 100644 ---

[PATCH 0/6] Remove CONFIGURE_DISABLE_SMP_CONFIGURATION

2020-02-15 Thread Sebastian Huber
The CONFIGURE_DISABLE_SMP_CONFIGURATION configuration option and rtems_configuration_is_smp_enabled() were added during the SMP support development cycle as a workaround to fix some testsuite failures in SMP configurations. Replace all use cases with tests for specific conditions. The

[PATCH 4/6] score: _Scheduler_Is_non_preempt_mode_supported()

2020-02-15 Thread Sebastian Huber
If the non-preempt mode for threads is supported depends on the scheduler implementation. Add _Scheduler_Is_non_preempt_mode_supported() to indicate this. Update #3876. --- cpukit/include/rtems/scheduler.h | 16 cpukit/include/rtems/score/scheduler.h | 8

[PATCH 1/6] score: Add _SMP_Need_inter_processor_interrupts()

2020-02-15 Thread Sebastian Huber
Test for the proper system condition instead of using the rtems_configuration_is_smp_enabled() workaround. Update #3876. --- cpukit/include/rtems/score/smpimpl.h | 15 +++ cpukit/rtems/src/taskmode.c | 3 ++- cpukit/score/src/threaddispatch.c| 2 +-

[PATCH 3/6] config: CONFIGURE_INIT_TASK_INITIAL_MODES

2020-02-15 Thread Sebastian Huber
Determine the default for CONFIGURE_INIT_TASK_INITIAL_MODES depeding on whether RTEMS_SMP is defined or not. In the tests, use CONFIGURE_INIT_TASK_INITIAL_MODES to explicitly request RTEMS_NO_PREEMPT mode if necessary. Update #3876. --- cpukit/include/rtems/confdefs.h | 2 +-

[PATCH 2/6] bsps/clock: Use _SMP_Get_processor_maximum()

2020-02-15 Thread Sebastian Huber
Use a specific test to enable the fast idle mode instead of using the rtems_configuration_is_smp_enabled() workaround. Update #3876. --- bsps/shared/dev/clock/clockimpl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bsps/shared/dev/clock/clockimpl.h

Ticket #1977

2020-02-15 Thread Eshan Dhawan
Hi, As I was going through the ticket I wanted to know the main arguments that are to be passed in mode and how they are to be processed in the mq_open. ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH v4] doc/raspberrypi: Added instructions for raspberrypi

2020-02-15 Thread Christian Mauderer
Hello Niteesh, thanks. I pushed it: https://git.rtems.org/rtems-docs/commit/?id=5763454b307afae6f5feb7e6d3d3d780f05f83ab Best regards Christian On 15/02/2020 15:20, G. S. Niteesh wrote: > Another remainder. > Can someone please push this? > > Thanks, > Niteesh > > On Thu, Feb 13, 2020 at

Re: [PATCH 18/18] config: Add

2020-02-15 Thread Sebastian Huber
On 15/02/2020 15:16, Joel Sherrill wrote: And note when perhaps with a version when an option was deemed obsolete. You might be able to get that from git blame in the future but for now we just destroyed all that info for blame by creating a new file. I tried to do that, for some options I

Re: [PATCH v2] config: Add

2020-02-15 Thread Gedare Bloom
Thanks looks good to me. On Sat, Feb 15, 2020 at 10:58 AM Sebastian Huber < sebastian.hu...@embedded-brains.de> wrote: > Unify handling of obsolete configuration options. Change license to > BSD-2-Clause. > > Update #3053. > Update #3875. > --- > cpukit/header-dirs.am| 2

[PATCH v2] config: Add

2020-02-15 Thread Sebastian Huber
Unify handling of obsolete configuration options. Change license to BSD-2-Clause. Update #3053. Update #3875. --- cpukit/header-dirs.am| 2 + cpukit/headers.am| 1 + cpukit/include/rtems/confdefs.h | 167 +-

Re: [PATCH 6/6] config: Remove CONFIGURE_DISABLE_SMP_CONFIGURATION

2020-02-15 Thread Sebastian Huber
Hello Joel, On 15/02/2020 15:12, Joel Sherrill wrote: Another historical detail for the commit message is that even in SMP builds, uniprocesor tests used a uniprocesor schedule. It took us a while to decide that the uniprocesor tests should behave the same with the proper SMP scheduler.

Re: [PATCH 13/18] config: Add _Thread_Idle_body

2020-02-15 Thread Chris Johns
On 2020-02-15 03:02, Sebastian Huber wrote: Move the idle thread body configuration constant out of the configuration table. Provide a default definition of the idle thread body constant. May be I am missing something simple here. How would I provide an custom IDLE task? Is it by providing

Re: [PATCH 07/18] config: Bring back RTEMS 4.11 configuration table

2020-02-15 Thread Chris Johns
On 2020-02-15 03:02, Sebastian Huber wrote: This improves API backward compatibility of RTEMS 5.1 to previous versions. What is the purpose of this change? How does a user wanting backward compatibility use this change? How long do we maintain this interface? We clearly document users

Re: [PATCH 10/18] config: Add _Watchdog_Microseconds_per_tick

2020-02-15 Thread Chris Johns
On 2020-02-15 03:02, Sebastian Huber wrote: Move the microseconds per tick configuration constant out of the configuration table. Add WATCHDOG_MICROSECONDS_PER_TICK_DEFAULT and use it to provide a default definition of the watchdog ticks constants. What is the purpose and/or use for this