Re: Rtems-test with qemu integration for pc386

2014-06-26 Thread Gedare Bloom
On Thu, Jun 26, 2014 at 5:26 PM, Chris Johns chr...@rtems.org wrote: On 27/06/2014 4:09 am, Joel Sherrill wrote: See pc386/configure.ac for this RTEMS_BSP_CLEANUP_OPTIONS(1, 1) dnlargument 1 indicates the default value for BSP_PRESS_KEY_FOR_RESET dnlargument 2 indicates the

Re: Adding capture support to score

2014-07-09 Thread Gedare Bloom
Hi, On Tue, Jul 8, 2014 at 3:19 PM, Jennifer Averett jennifer.aver...@oarcorp.com wrote: The attached patches are a starting point for discussions for adding capture support to core objects. We started to write notes based on our discussions but the text was harder to follow than just

Re: Problem with ticker.exe for or1ksim/OpenRISC BSP

2014-07-18 Thread Gedare Bloom
On Fri, Jul 18, 2014 at 1:35 AM, Hesham Moustafa heshamelmat...@gmail.com wrote: On Thu, Jul 17, 2014 at 3:10 PM, Joel Sherrill joel.sherr...@oarcorp.com wrote: This definitely sounds like not handling the context switch necessary part of the IRQ processing properly so always returning to

Re: [PATCH] cpukit/cpu/i386: RTEMS_PARAVIRT guards, functionality and virt.layer

2014-07-18 Thread Gedare Bloom
On Fri, Jul 18, 2014 at 11:37 AM, Philipp Eppelt philipp.epp...@mailbox.tu-dresden.de wrote: --- This is an updated version of an earlier unmerged patch, which extends the cpukit/score/cpu/i386/ model with guards to distinguish between paravirtualized (--enable-paravirt) and native

Re: capture engine use of workspace_allocate

2014-07-21 Thread Gedare Bloom
Either account for it in workspace sizing or use malloc. On principle, I guess any dynamic allocated memory that isn't mandatory to get RTEMS to work should come from malloc. -Gedare On Mon, Jul 21, 2014 at 10:41 AM, Jennifer Averett jennifer.aver...@oarcorp.com wrote: The capture engine

Re: [PATCH 1/3] rbtree: Format

2014-07-21 Thread Gedare Bloom
One issue with rbtree formatting is in some places if/while conditional expressions are put on the same line as the conditional statement. We should prefer to put them explicitly on separate lines, since that is the prevailing style of score and I have added such a convention to our style wiki

Re: [PATCH 1/3] rbtree: Format

2014-07-22 Thread Gedare Bloom
/2014 10:23 PM, Gedare Bloom wrote: /* TODO: Error message? */ - if (!the_rbtree) return; + if ( !the_rbtree ) return; Like here. Ok, this is not an uncrustify bug. It was already a one-liner (like the other). Unfortunately there is no option to wipe out one-liner. I found

Re: [PATCH] (2 commits squashed into one) Beagle BSP for review

2014-07-24 Thread Gedare Bloom
Hi Ben, Great work. I have a few comments. I skipped the i2c.h and i2c.c files. Most of my comments are about style and a few requests to refactor some of the larger files. The refactoring can be added to your TODO if you like. Please fix the style issues if it is not a burden. +++

Re: MMU/Cache analysis for OpenRISC

2014-07-28 Thread Gedare Bloom
On Mon, Jul 28, 2014 at 1:20 PM, Hesham Moustafa heshamelmat...@gmail.com wrote: Hi, I have read about MMU and Caches in OpenRISC to start implementing related managers in the new or1k port. Before beginning to write the code, I would like to introduce some of the architecture details

Re: [PATCH 1/3] Add and use RTEMS_CONTAINER_OF()

2014-08-04 Thread Gedare Bloom
Thanks, two style comments below. On Sun, Aug 3, 2014 at 8:45 AM, Sebastian Huber sebastian.hu...@embedded-brains.de wrote: --- cpukit/libblock/src/bdbuf.c| 4 +- cpukit/posix/include/rtems/posix/keyimpl.h | 3 ++ cpukit/posix/src/key.c

Re: [PATCH] Add support for OpenRISC architecture.

2014-08-11 Thread Gedare Bloom
On Mon, Aug 11, 2014 at 8:03 AM, Hesham ALMatary heshamelmat...@gmail.com wrote: This work is based on the old or32 port (that has been removed back in 2005) authored by Chris Ziomkowski. The patch includes the basic functions every port should implement like: context switch, exception

Re: [PATCH] Add support for OpenRISC - Fixed issues

2014-08-12 Thread Gedare Bloom
OK from me. On Tue, Aug 12, 2014 at 11:57 AM, Hesham ALMatary heshamelmat...@gmail.com wrote: This work is based on the old or32 port (that has been removed back in 2005) authored by Chris Ziomkowski. The patch includes the basic functions every port should implement like: context switch,

Re: Using rtl-host in covor - some questions

2014-08-13 Thread Gedare Bloom
On Wed, Aug 13, 2014 at 4:48 PM, Joel Sherrill joel.sherr...@oarcorp.com wrote: On 8/13/2014 3:28 PM, Chris Johns wrote: Hi, Sorry about not responding before now. It had dropped of my list and I had forgotten about it. On 12/08/2014 9:58 pm, Krzysztof Mięsowicz wrote: Hi, I'm currently

Re: Using rtl-host in covor - some questions

2014-08-14 Thread Gedare Bloom
On Wed, Aug 13, 2014 at 11:17 PM, Chris Johns chr...@rtems.org wrote: On 14/08/2014 6:58 am, Gedare Bloom wrote: We need to decide if we want 1 repo per tool or a consolidated tools repo. My opinion is to add the rtl-host and rtems-coverage as git-submodules within another repo the project

Re: [PATCH] BSP for TMS570LS31x Hercules Development Kit from TI (TMS570LS3137)

2014-08-14 Thread Gedare Bloom
On Thu, Aug 14, 2014 at 4:53 AM, Pavel Pisa p...@cmp.felk.cvut.cz wrote: Hello Sebastian, On Thursday 14 of August 2014 10:07:06 Sebastian Huber wrote: On 14/08/14 09:48, Pavel Pisa wrote: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch

Re: [GSoC2014] arinc653 on rtems (using pok) patches

2014-08-18 Thread Gedare Bloom
If you're using git for your development, you can use 'git format-patch' to convert a set of commits into a set of patches. Some properly formatted git patches can make it easier to review and merge your code. Some other notes follow. virtualpok_arinc653.patch: * it seems the only part of this

Re: [PATCH] (2 commits squashed into one) Beagle BSP for review

2014-08-20 Thread Gedare Bloom
. On Thu, Jul 24, 2014 at 4:45 PM, Gedare Bloom ged...@rtems.org wrote: Hi Ben, Great work. I have a few comments. I skipped the i2c.h and i2c.c files. Most of my comments are about style and a few requests to refactor some of the larger files. The refactoring can be added to your TODO if you

Re: arm/nds - cache_manager.c build failure

2014-08-22 Thread Gedare Bloom
On Fri, Aug 22, 2014 at 10:45 AM, Joel Sherrill joel.sherr...@oarcorp.com wrote: On 8/22/2014 9:38 AM, Gedare Bloom wrote: Looks like this function needs a guard on #if defined(CPU_INSTRUCTION_CACHE_ALIGNMENT) see rtems_cache_invalidate_multiple_instruction_lines

Re: [PATCH 1/2] rtems: Inline rtems_clock_get_ticks_since_boot()

2014-08-22 Thread Gedare Bloom
On Fri, Aug 22, 2014 at 11:12 AM, Sebastian Huber sebastian.hu...@embedded-brains.de wrote: Update documentation. --- cpukit/rtems/Makefile.am| 1 - cpukit/rtems/include/rtems/rtems/clock.h| 14 +-- cpukit/rtems/src/clockgettickssinceboot.c | 31

Re: [PATCH 2/2] rtems: Add more clock tick functions

2014-08-22 Thread Gedare Bloom
On Fri, Aug 22, 2014 at 11:12 AM, Sebastian Huber sebastian.hu...@embedded-brains.de wrote: Add rtems_clock_ticks_later(), rtems_clock_ticks_later_us() and rtems_clock_ticks_later_us(). FIXME: Patch is incomplete. Documentation and tests are missing. Just for API review. ---

Re: [PATCH 1/2] rtems: Inline rtems_clock_get_ticks_since_boot()

2014-08-22 Thread Gedare Bloom
On Fri, Aug 22, 2014 at 11:22 AM, Joel Sherrill joel.sherr...@oarcorp.com wrote: On 8/22/2014 10:18 AM, Gedare Bloom wrote: On Fri, Aug 22, 2014 at 11:12 AM, Sebastian Huber sebastian.hu...@embedded-brains.de wrote: Update documentation. --- cpukit/rtems/Makefile.am

Re: [PATCH 01/23] raspberrypi: Use shared bspreset.c

2014-09-04 Thread Gedare Bloom
On Thu, Sep 4, 2014 at 12:16 PM, Gedare Bloom ged...@rtems.org wrote: On Wed, Sep 3, 2014 at 11:25 AM, Joel Sherrill joel.sherr...@oarcorp.com wrote: --- c/src/lib/libbsp/arm/csb337/startup/bspreset.c | 1 + c/src/lib/libbsp/arm/raspberrypi/Makefile.am | 2 +- .../lib/libbsp/arm

Re: [PATCH 14/23] mprotect.c: Remove warning for no prototype

2014-09-04 Thread Gedare Bloom
On Thu, Sep 4, 2014 at 1:10 PM, Joel Sherrill joel.sherr...@oarcorp.com wrote: On 9/4/2014 11:19 AM, Gedare Bloom wrote: On Wed, Sep 3, 2014 at 11:26 AM, Joel Sherrill joel.sherr...@oarcorp.com wrote: --- cpukit/posix/src/mprotect.c | 23 ++- 1 file changed, 14

Re: Automate RTEMS test results?

2014-09-06 Thread Gedare Bloom
See tester in rtems-tools.git it is designed for exactly what you ask. You probably need to modify an existing script to run or1ksim. On Sep 6, 2014 2:58 PM, Hesham Moustafa heshamelmat...@gmail.com wrote: Hi, Given that I am able to run qemu-or1k from sim-scripts (I will push the script

Re: [PATCH 3/3] or1ksim: update README.

2014-09-07 Thread Gedare Bloom
OK to commit these 3 from me. On Fri, Sep 5, 2014 at 11:11 AM, Hesham ALMatary heshamelmat...@gmail.com wrote: or1ksim simulator built from RSB that builds from latest or1ksim/github repo generates or1k-elf-sim executable and not or32-elf-sim anymore. --- c/src/lib/libbsp/or1k/or1ksim/README

Re: or1k test was .. Re: [PATCH] or1k: New cache manager.

2014-09-16 Thread Gedare Bloom
On Tue, Sep 16, 2014 at 5:08 PM, Joel Sherrill joel.sherr...@oarcorp.com wrote: Gedare.. cc'ed you for help in spotting an empty rbtree in gdb. See below. On 9/16/2014 2:45 PM, Hesham Moustafa wrote: Breakpoint 2, 0x0600 in _unalign () (gdb) bt #0 0x0600 in _unalign () #1

Re: [stm32f4] status of the bsp

2014-09-19 Thread Gedare Bloom
On Fri, Sep 19, 2014 at 12:26 PM, Chris Nott chr...@vl.com.au wrote: Interrupts working yes. No I don't mind. It's a bit of a mess though, I was in the process of doing another cleaner USB device implementation for BeagleBone Black, which I was then going to backport to STM32F4 and eventually

Re: rtems-tld update.

2014-09-21 Thread Gedare Bloom
Thanks Chris. If you have any ideas on useful ways to visualize these traces, I think it could make a good open project for a student. -Gedare On Sun, Sep 21, 2014 at 12:51 AM, Chris Johns chr...@rtems.org wrote: Hello, I have pushed updates to rtems-tld to rtems-tools.git plus changes to

Re: [rtems commit] m68k: Use CPU_TIMESTAMP_USE_STRUCT_TIMESPEC

2014-09-23 Thread Gedare Bloom
On Tue, Sep 23, 2014 at 11:38 AM, Joel Sherrill joel.sherr...@oarcorp.com wrote: The code is m68k and the comment is PowerPC. Any guidance for the porting guide on what constitutes too expensive? There should be some general guidelines regarding when to pick a format bases on that. Also..

Re: [rtems commit] libmisc/shell: Remove the need for -lm when linking from the ping command.

2014-10-03 Thread Gedare Bloom
On Fri, Oct 3, 2014 at 6:48 PM, Chris Johns chr...@rtems.org wrote: Module:rtems Branch:master Commit:56ed56a641b69be42f5a38046307b33096014c84 Changeset: http://git.rtems.org/rtems/commit/?id=56ed56a641b69be42f5a38046307b33096014c84 Author:Chris Johns chr...@rtems.org

Re: [PATCH 1/2] libcsupport: Add realpath.

2014-10-04 Thread Gedare Bloom
Just a comment, is there already code in the filesystem path evaluation that implements similar functionality? Would it make sense to replace with a call to this? -Gedare On Sat, Oct 4, 2014 at 1:14 AM, Chris Johns chr...@rtems.org wrote: --- cpukit/libcsupport/Makefile.am| 2 +-

Re: [PATCH 04/52] gdbv850sim/console/console-io.c: Fix warnings

2014-10-08 Thread Gedare Bloom
On Wed, Oct 8, 2014 at 3:15 PM, Joel Sherrill joel.sherr...@oarcorp.com wrote: --- c/src/lib/libbsp/v850/gdbv850sim/console/console-io.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/c/src/lib/libbsp/v850/gdbv850sim/console/console-io.c

Re: [PATCH 18/52] arm/shared/abort/abort.c: Fix warnings and clean up

2014-10-08 Thread Gedare Bloom
On Wed, Oct 8, 2014 at 3:16 PM, Joel Sherrill joel.sherr...@oarcorp.com wrote: --- c/src/lib/libbsp/arm/shared/abort/abort.c | 44 +++ 1 file changed, 27 insertions(+), 17 deletions(-) diff --git a/c/src/lib/libbsp/arm/shared/abort/abort.c

Re: [PATCH 48/52] samples/unlimited: Fix printf() warning and clean up

2014-10-08 Thread Gedare Bloom
On Wed, Oct 8, 2014 at 3:16 PM, Joel Sherrill joel.sherr...@oarcorp.com wrote: --- testsuites/samples/unlimited/init.c | 23 ++- testsuites/samples/unlimited/system.h | 2 +- testsuites/samples/unlimited/test1.c | 2 +- testsuites/samples/unlimited/test2.c | 28

Re: [PATCH 1/2] libcpu/or1k: Fix warnings.

2014-10-10 Thread Gedare Bloom
Just one note, I prefer to see addresses cast to uintptr_t. On Fri, Oct 10, 2014 at 12:44 PM, Hesham ALMatary heshamelmat...@gmail.com wrote: --- c/src/lib/libcpu/or1k/shared/cache/cache.c | 16 c/src/lib/libcpu/or1k/shared/cache/cache_.h | 1 + 2 files changed, 9

sparc64 warnings fixed

2014-10-13 Thread Gedare Bloom
Hi, I have pushed some commits to fix sparc64-specific warnings. The remaining warnings that are only seen on sparc64 builds are caused by 64-bit problems mostly related to integer/pointer conversions. I don't have the time to hunt all these down myself. Most of them are in jffs2, capture, or

[PATCH] rfs: fix pointer conversion warnings

2014-10-13 Thread Gedare Bloom
--- cpukit/libfs/src/rfs/rtems-rfs-rtems-dev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cpukit/libfs/src/rfs/rtems-rfs-rtems-dev.c b/cpukit/libfs/src/rfs/rtems-rfs-rtems-dev.c index 28e4739..48a6737 100644 --- a/cpukit/libfs/src/rfs/rtems-rfs-rtems-dev.c +++

Re: [PATCH] rfs: fix pointer conversion warnings

2014-10-13 Thread Gedare Bloom
On Mon, Oct 13, 2014 at 10:54 PM, Joel Sherrill joel.sherr...@oarcorp.com wrote: On October 13, 2014 9:46:50 PM CDT, Gedare Bloom ged...@rtems.org wrote: --- cpukit/libfs/src/rfs/rtems-rfs-rtems-dev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cpukit/libfs/src/rfs

Re: [PATCH] rfs: explicitly cast to dev_t

2014-10-13 Thread Gedare Bloom
This fixes a warning about conversion to int without a cast. On Tue, Oct 14, 2014 at 12:04 AM, Gedare Bloom ged...@rtems.org wrote: --- cpukit/libfs/src/rfs/rtems-rfs-rtems.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpukit/libfs/src/rfs/rtems-rfs-rtems.c b/cpukit

New rule no prototypes in C sources Was: Re: Batch of Patches from Joel

2014-10-14 Thread Gedare Bloom
On Tue, Oct 14, 2014 at 2:29 AM, Sebastian Huber sebastian.hu...@embedded-brains.de wrote: On 13/10/14 17:48, Joel Sherrill wrote: On 10/13/2014 10:43 AM, Sebastian Huber wrote: On 10/13/2014 05:18 PM, Joel Sherrill wrote: NOTE: For defaults for weak symbols, I am just adding a prototype

Re: [PATCH] rfs: fix pointer conversion warnings

2014-10-15 Thread Gedare Bloom
I did not commit this one, because it has the problem of assuming uintptr_t is at least 32-bits wide. On Tue, Oct 14, 2014 at 12:03 AM, Gedare Bloom ged...@rtems.org wrote: On Mon, Oct 13, 2014 at 10:54 PM, Joel Sherrill joel.sherr...@oarcorp.com wrote: On October 13, 2014 9:46:50 PM CDT

Re: [PATCH] do_it: Create build directory and its parents for Nano-X

2014-10-19 Thread Gedare Bloom
Committed, thanks. On Fri, Oct 17, 2014 at 4:17 AM, Jan Dolezal dolez...@fel.cvut.cz wrote: prevents possible mkdir and cd error when parents of build directory are missing --- do_it | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/do_it b/do_it index

Re: PowerPC Cache Warning Help Request

2014-10-20 Thread Gedare Bloom
Cache manager implementations are a perennial open project. On Mon, Oct 20, 2014 at 11:19 AM, Joel Sherrill joel.sherr...@oarcorp.com wrote: On 10/20/2014 10:08 AM, Sebastian Huber wrote: On 20/10/14 16:58, Joel Sherrill wrote: On October 20, 2014 9:41:57 AM CDT, Sebastian Huber

Re: [PATCH 1/2] dosfs: Support ctime and mtime

2014-10-20 Thread Gedare Bloom
What does it mean as far as possible? On Mon, Oct 20, 2014 at 10:24 AM, Sebastian Huber sebastian.hu...@embedded-brains.de wrote: Implement ctime and mtime updates according to POSIX as far as possible. The ctime is mapped to the FAT create time and date. The mtime is mapped to the FAT last

Re: PowerPC Cache Warning Help Request

2014-10-20 Thread Gedare Bloom
If you do the legwork now, they could make reasonable GCI tasks if we decide to participate and are accepted. -Gedare On Mon, Oct 20, 2014 at 1:20 PM, Joel Sherrill joel.sherr...@oarcorp.com wrote: On 10/20/2014 12:09 PM, Gedare Bloom wrote: Cache manager implementations are a perennial open

Re: x86 interpreter and NOVA hypervisor - Was: [PATCH] do_it

2014-10-20 Thread Gedare Bloom
On Mon, Oct 20, 2014 at 10:55 AM, Pavel Pisa p...@cmp.felk.cvut.cz wrote: Hello Gedare and others, On Sunday 19 of October 2014 15:01:08 Gedare Bloom wrote: On Sun, Oct 19, 2014 at 7:48 AM, Pavel Pisa p...@control.felk.cvut.cz ... set interpreter in RTEMS which would allow to run BIOS

Re: __assert.c Wpointer-to-int-cast

2014-10-20 Thread Gedare Bloom
On Tue, Oct 14, 2014 at 2:21 AM, Sebastian Huber sebastian.hu...@embedded-brains.de wrote: On 14/10/14 04:21, Gedare Bloom wrote: cpukit/libcsupport/src/__assert.c52:43: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] rtems_fatal( RTEMS_FATAL_SOURCE_ASSERT

Re: PowerPC Cache Warning Help Request

2014-10-20 Thread Gedare Bloom
On Mon, Oct 20, 2014 at 5:11 PM, Peter Dufault dufa...@hda.com wrote: On Oct 20, 2014, at 16:47 , Joel Sherrill joel.sherr...@oarcorp.com wrote: However, should unimplemented versions return an error instead of being a NOP? That would force one to visit code that makes assumptions. If this

Re: PowerPC Cache Warning Help Request

2014-10-23 Thread Gedare Bloom
We might consider removing the cache manager in favor of making dcache flush/invalidate and icache invalidate lines part of the score/cpu port (are they the same across cpu's in the same arch family?) -Gedare On Thu, Oct 23, 2014 at 12:10 PM, Peter Dufault dufa...@hda.com wrote: On Oct 23,

Re: PowerPC Cache Warning Help Request

2014-10-24 Thread Gedare Bloom
On Fri, Oct 24, 2014 at 1:36 AM, Sebastian Huber sebastian.hu...@embedded-brains.de wrote: On 23/10/14 19:41, Gedare Bloom wrote: We might consider removing the cache manager in favor of making dcache flush/invalidate and icache invalidate lines part of the score/cpu port (are they the same

Re: MSc (by research) involving RTEMS | University of York

2014-10-27 Thread Gedare Bloom
On Mon, Oct 27, 2014 at 4:43 PM, Hesham Moustafa heshamelmat...@gmail.com wrote: On Mon, Oct 27, 2014 at 2:30 PM, Joel Sherrill joel.sherr...@oarcorp.com wrote: On October 27, 2014 3:04:26 AM PDT, Hesham Moustafa heshamelmat...@gmail.com wrote: Hi all, This year, I am studying MSc

Re: Redundant Logging on User Extensions

2014-10-29 Thread Gedare Bloom
On Wed, Oct 29, 2014 at 2:42 PM, Joel Sherrill joel.sherr...@oarcorp.com wrote: Hi As Jennifer has reviewed the output from an SMP capture test, it is clear that something which was no big deal in the old fixed record uniprocessor version is now an issue. Most extensions have an actor and

Re: [rtems commit] libmisc: Add top to cpuusage.

2014-10-30 Thread Gedare Bloom
I missed reviewing this patch earlier, but there are some style problems with it, please fix them on the head. On Tue, Oct 28, 2014 at 11:17 AM, Jennifer Averett jenni...@rtems.org wrote: Module:rtems Branch:master Commit:6031da438d219c6ec5d9d48f1df2aef91710cce3 Changeset:

Re: [rtems commit] libmisc: Add top to cpuusage.

2014-10-30 Thread Gedare Bloom
The email address came from VC, so it is a problem in the commit setup I guess. On Thu, Oct 30, 2014 at 10:55 AM, Joel Sherrill joel.sherr...@oarcorp.com wrote: FWIW she is jennifer.aver...@rtems.org not jennifer@. --joel On 10/30/2014 9:53 AM, Gedare Bloom wrote: I missed reviewing

Re: 4.11 Branching To Do

2014-10-30 Thread Gedare Bloom
On Thu, Oct 30, 2014 at 6:31 AM, Sebastian Huber sebastian.hu...@embedded-brains.de wrote: On 29/10/14 22:49, Joel Sherrill wrote: Very desirable = + x86 context switch SMP handoff logic For someone with good enough x86 assembly skills, this should be fairly simple. You just

Re: [rtems commit] libmisc: Add top to cpuusage.

2014-10-30 Thread Gedare Bloom
The problem may be a setup issue on git.rtems.org, where it converts from user login to email, I think it might be doing something dumb like just taking login-name @rtems.org On Thu, Oct 30, 2014 at 11:03 AM, Joel Sherrill joel.sherr...@oarcorp.com wrote: On 10/30/2014 9:55 AM, Gedare Bloom

Re: libdl: rtems.git dependence on rtems-tools.git

2014-10-30 Thread Gedare Bloom
On Thu, Oct 30, 2014 at 3:32 PM, Chris Johns chr...@rtems.org wrote: Hi, Libdl tests in the testsuite depend on tools in rtems-tools.git/linkers. Should I raise a configure error if the tools are not found or not build the tests ? Raising an error is my preferred option because libdl for

Re: libdl: rtems.git dependence on rtems-tools.git

2014-10-30 Thread Gedare Bloom
On Thu, Oct 30, 2014 at 3:40 PM, Gedare Bloom ged...@rtems.org wrote: On Thu, Oct 30, 2014 at 3:32 PM, Chris Johns chr...@rtems.org wrote: Hi, Libdl tests in the testsuite depend on tools in rtems-tools.git/linkers. Should I raise a configure error if the tools are not found or not build

Re: libdl: rtems.git dependence on rtems-tools.git

2014-10-30 Thread Gedare Bloom
On Thu, Oct 30, 2014 at 7:13 PM, Chris Johns chr...@rtems.org wrote: On 31/10/2014 6:42 am, Gedare Bloom wrote: On Thu, Oct 30, 2014 at 3:40 PM, Gedare Bloom ged...@rtems.org wrote: On Thu, Oct 30, 2014 at 3:32 PM, Chris Johns chr...@rtems.org wrote: Hi, Libdl tests in the testsuite

Re: ARM bsp warnings ( shared/abort.c vs. shared/simple_abort.c )

2014-11-01 Thread Gedare Bloom
On Sat, Nov 1, 2014 at 1:12 PM, Alan Cudmore alan.cudm...@gmail.com wrote: There are two warnings in the raspberry pi BSP due to the lack of prototypes in simple_abort.c the rtl22xx BSP has the same warnings because it also uses simple_abort.c. Many of the other ARM BSPs use abort.c, which

Re: [PATCH] (2 commits squashed into one) Beagle BSP for review

2014-11-03 Thread Gedare Bloom
is so linux-only. Stay tuned. On Wed, Aug 20, 2014 at 4:20 PM, Gedare Bloom ged...@rtems.org wrote: Ben, As far as getting this merged, all of my comments can be done as a follow-on commit. -Gedare On Thu, Jul 24, 2014 at 4:28 PM, Ben Gras b...@shrike-systems.com wrote: Thanks

Re: [PATCH] top: Resolve compile errors.

2014-11-03 Thread Gedare Bloom
On Mon, Nov 3, 2014 at 7:58 AM, Jennifer Averett jennifer.aver...@oarcorp.com wrote: --- cpukit/libmisc/cpuuse/cpuusagetop.c | 83 - 1 file changed, 63 insertions(+), 20 deletions(-) diff --git a/cpukit/libmisc/cpuuse/cpuusagetop.c

Re: [PATCH 2/4] capture: Add SMP support.

2014-11-04 Thread Gedare Bloom
I was reviewing this code and lost my spot. There are some notes below, but I have no more time to weed through. I'd recommend splitting this patch into more pieces: 1) Moving code into capture_support. 2) Adding SMP support. 3) Fixing formatting/style/documentation issues in legacy portions.

Re: [PATCH] Add GPIO, I2C and SPI support for the RPi BSP

2014-11-04 Thread Gedare Bloom
On Tue, Nov 4, 2014 at 6:29 PM, Joel Sherrill joel.sherr...@oarcorp.com wrote: On November 4, 2014 5:27:51 PM CST, Andre Marques andre.lousa.marq...@gmail.com wrote: On 11/04/14 23:16, Joel Sherrill wrote: On 11/4/2014 5:01 PM, Andre Marques wrote: Hi gedare, will send a new version of

Re: 4.11 Branching To Do

2014-11-06 Thread Gedare Bloom
On Thu, Nov 6, 2014 at 1:53 AM, Sebastian Huber sebastian.hu...@embedded-brains.de wrote: Hello, I have a new item for the list: Very desirable == + Since red-black trees are now used to implement the priority queues and they will play an important part in future SMP

Re: Test failures on arm/realview_pbx_a9_qemu

2014-11-06 Thread Gedare Bloom
On Thu, Nov 6, 2014 at 7:48 AM, Sebastian Huber sebastian.hu...@embedded-brains.de wrote: On 06/11/14 13:42, Joel Sherrill wrote: I think it is preferable to turn this top test into a non-interactive test. Have you run it? There is no way to automate checking the output. In theory you

Re: 4.11 Branching To Do

2014-11-06 Thread Gedare Bloom
On Thu, Nov 6, 2014 at 10:58 AM, Pavel Pisa ppisa4li...@pikron.com wrote: On Thursday 06 of November 2014 14:57:18 Gedare Bloom wrote: Pavel posted about a generic tree framework: http://permalink.gmane.org/gmane.os.rtems.devel/1327 I had some trouble getting inlining to work in the way

Re: [PATCH] libbsp ARM: create abort.h to eliminate warnings Created libbsp/arm/shared/abort/abort.h Edited abort.c and simple_abort.c to include abort.h Changed Raspberry Pi BSP to use abort.c instea

2014-11-08 Thread Gedare Bloom
On Sat, Nov 8, 2014 at 11:50 AM, Alan Cudmore alan.cudm...@gmail.com wrote: On 11/5/2014 9:39 AM, Sebastian Huber wrote: On 05/11/14 15:35, Alan Cudmore wrote: If the ARM BSPs that do not use the shared start.S include the code, but never call it, I can remove it, if that is what is best.

Re: Proposed RTEMS Community Code of Conduct

2014-11-12 Thread Gedare Bloom
On Wed, Nov 12, 2014 at 8:47 AM, Ralf Corsepius ralf.corsep...@rtems.org wrote: On 11/10/2014 06:11 PM, Joel Sherrill wrote: While at the GSOC Mentor Summit, I heard a story from another organization about some inappropriate behavior by someone. They were fairly easily able to deal with this

Re: [PATCH 3/3] smpschedaffinity05: Change semaphore attributes.

2014-11-12 Thread Gedare Bloom
Are there still tests for when the lock would be held despite the context switch? Just want to make sure we're not removing some test-case. On Wed, Nov 12, 2014 at 9:48 AM, Jennifer Averett jennifer.aver...@oarcorp.com wrote: Change semaphore attributes to resolve problem where semaphore is not

Re: [PATCH 1/6] i386/pc386: configurable size of descriptor tables

2014-11-12 Thread Gedare Bloom
On Wed, Nov 12, 2014 at 10:07 AM, Jan Dolezal dolez...@fel.cvut.cz wrote: --- c/src/lib/libbsp/i386/pc386/Makefile.am | 1 + c/src/lib/libbsp/i386/pc386/configure.ac | 5 + c/src/lib/libbsp/i386/pc386/include/bsp.h | 6 ++

Re: [PATCH 4/6] i386/shared/int16: real mode interrupt interface

2014-11-12 Thread Gedare Bloom
On Wed, Nov 12, 2014 at 10:07 AM, Jan Dolezal dolez...@fel.cvut.cz wrote: --- c/src/lib/libbsp/i386/pc386/Makefile.am| 2 + c/src/lib/libbsp/i386/pc386/preinstall.am | 4 + c/src/lib/libbsp/i386/shared/int16/int16.c | 397 +

Re: [PATCH 5/6] i386/pc386/include: header files for VESA BIOS EXTENSIONS and VESA Extended Display Identification Data

2014-11-12 Thread Gedare Bloom
Just a couple high-level comments: Is this code entirely written by you? If the code is i386-specific, I'd like to see it put into i386 namespace. The use of bitfields worries me, especially if the code might be ported to other architectures. I can see now why you put __packed__ on all your

Re: [PATCH 6/6] i386/pc386: VESA based frame buffer utilizing real mode interrupt 10h

2014-11-12 Thread Gedare Bloom
On Wed, Nov 12, 2014 at 10:07 AM, Jan Dolezal dolez...@fel.cvut.cz wrote: --- c/src/lib/libbsp/i386/pc386/Makefile.am | 5 + c/src/lib/libbsp/i386/pc386/configure.ac | 13 + c/src/lib/libbsp/i386/pc386/console/fb_vesa_rm.c | 851 +++

Re: [PATCH 5/6] i386/pc386/include: header files for VESA BIOS EXTENSIONS and VESA Extended Display Identification Data

2014-11-13 Thread Gedare Bloom
On Thu, Nov 13, 2014 at 6:45 PM, Pavel Pisa p...@cmp.felk.cvut.cz wrote: Hello Gedare, the first thanks much for fast and valuable review. I expect that Jan Dolezal prepares new patch series next week (or two in the worst case). On Wednesday 12 of November 2014 17:04:04 Gedare Bloom wrote

Re: [PATCH 4/6] i386/shared/int16: real mode interrupt interface

2014-11-13 Thread Gedare Bloom
On Thu, Nov 13, 2014 at 7:27 PM, Pavel Pisa p...@cmp.felk.cvut.cz wrote: Hello Gedare and others, On Wednesday 12 of November 2014 16:54:07 Gedare Bloom wrote: On Wed, Nov 12, 2014 at 10:07 AM, Jan Dolezal dolez...@fel.cvut.cz wrote: --- c/src/lib/libbsp/i386/pc386/Makefile.am| 2

Re: [PATCH 2/9] Add SHA256 and SHA512 support

2014-11-14 Thread Gedare Bloom
The test case name SHA 1 is misleading, as there exists a SHA-1 algorithm On Fri, Nov 14, 2014 at 8:46 AM, Sebastian Huber sebastian.hu...@embedded-brains.de wrote: --- cpukit/Makefile.am| 2 - cpukit/libmd/Makefile.am | 13 +- cpukit/libmd/preinstall.am

Re: Access Control for RTEMS Shell

2014-11-18 Thread Gedare Bloom
Could you briefly explain a bit more context about the goals for implementing access control? That is, is it for compliance to some standard, to address a security need, or something else? Thanks, Gedare On Tue, Nov 18, 2014 at 9:37 AM, Sebastian Huber sebastian.hu...@embedded-brains.de wrote:

Re: [PATCH 1/6] i386/pc386: configurable size of descriptor tables

2014-11-18 Thread Gedare Bloom
On Tue, Nov 18, 2014 at 10:46 AM, Jan Dolezal dolez...@fel.cvut.cz wrote: Hello Gedare, thank you very much for fast and valuable response. I made most of the changes you suggested. On 12.11.2014 16:20, Gedare Bloom wrote: On Wed, Nov 12, 2014 at 10:07 AM, Jan Dolezal dolez

Re: [PATCH 3/6] i386: global descriptor table manipulation functions

2014-11-18 Thread Gedare Bloom
On Tue, Nov 18, 2014 at 10:46 AM, Jan Dolezal dolez...@fel.cvut.cz wrote: On 12.11.2014 16:42, Gedare Bloom wrote: On Wed, Nov 12, 2014 at 10:07 AM, Jan Dolezal dolez...@fel.cvut.cz wrote: --- c/src/lib/libbsp/i386/shared/irq/idt.c | 147 + c/src/lib

Re: [PATCH 4/4] SPARC: optimize IRQ enable disable

2014-11-19 Thread Gedare Bloom
This one needs a release note as it may impede some applications if they assumed they could use these trap vectors. Also, do these changes complicate the paravirtualization efforts done with sparc32 for xtratum? Otherwise, quick skim of the patch series looked good. On Wed, Nov 19, 2014 at

Re: [PATCH] more data structures public in mongoose.h

2014-11-19 Thread Gedare Bloom
Hi Ben, Due to the license change, we can consider our version of Mongoose as RTEMS Project maintained for now. I don't know if anyone is maintaining a fork with an appropriate license. Moving the struct definitions to the header file is sensible, although the usual caveat is that users might

Re: [PATCH 2/4] sys/mman.h: New file. Clean up and add supporting stubs

2014-11-19 Thread Gedare Bloom
Is this the same one that Chris has had in use before? (I think that is who had one in use..) -Gedare On Wed, Nov 19, 2014 at 2:59 PM, Joel Sherrill joel.sherr...@oarcorp.com wrote: * Makefile.am updated and preinstall.am regenerated. * mprotect.c had a prototype removed now

Re: [PATCH] more data structures public in mongoose.h

2014-11-19 Thread Gedare Bloom
wrote: On 11/19/2014 1:24 PM, Gedare Bloom wrote: Hi Ben, Due to the license change, we can consider our version of Mongoose as RTEMS Project maintained for now. I don't know if anyone is maintaining a fork with an appropriate license. There is a fork with the appropriate license. https

Re: [PATCH 2/4] sys/mman.h: New file. Clean up and add supporting stubs

2014-11-19 Thread Gedare Bloom
OK great On Wed, Nov 19, 2014 at 5:04 PM, Joel Sherrill joel.sherr...@oarcorp.com wrote: On 11/19/2014 2:55 PM, Gedare Bloom wrote: Is this the same one that Chris has had in use before? (I think that is who had one in use..) Yes. You wanted it in rtems to avoid me having to add a prototype

Re: [PATCH 4/4] libtests/malloctest/init.c: Fix warning

2014-11-19 Thread Gedare Bloom
I'd prefer to see it hidden behind a macro, like other compiler-specific stuff (e.g. attributes). It could go in tmacros also, since it should be restricted to testing. I will oppose any #pragma within cpukit or c subdirectories. -Gedare On Wed, Nov 19, 2014 at 5:45 PM, Joel Sherrill

Re: Coverity Issue with bdbuf.c

2014-11-19 Thread Gedare Bloom
I'm more concerned with the hard-coded cache alignment value, than I am with the dead code. -Gedare On Wed, Nov 19, 2014 at 6:10 PM, Joel Sherrill joel.sherr...@oarcorp.com wrote: Hi Coverity ID: 1255327 I think this looks like a legitimately flagged piece of code : 1537 * For

Re: [PATCH 4/4] libtests/malloctest/init.c: Fix warning

2014-11-19 Thread Gedare Bloom
On Wed, Nov 19, 2014 at 9:35 PM, Joel Sherrill joel.sherr...@oarcorp.com wrote: On November 19, 2014 8:34:23 PM CST, Gedare Bloom ged...@rtems.org wrote: I'd prefer to see it hidden behind a macro, like other compiler-specific stuff (e.g. attributes). It could go in tmacros also, since

Re: [PATCHv2/RFC 0/8] i386 VESA framebuffer support

2014-11-20 Thread Gedare Bloom
to Gedare Bloom and Pavel Pisa Jan Dolezal (8): i386/pc386: configurable size of descriptor tables score: i386: functions converting real mode pointer to physical address and back i386: GDTR manipulation functions parameters changed to use explicit width types cpukit: basedefs

Re: Rehosting Update

2014-11-20 Thread Gedare Bloom
On Thu, Nov 20, 2014 at 10:54 AM, Joel Sherrill joel.sherr...@oarcorp.com wrote: Hi https://devel.rtems.org/ is now up with our Trac instance. As mentioned in a previous update, this merges Bugzilla and Mediawiki. All the old content is there but it has likely moved around. If you spot

Re: Rehosting Update

2014-11-20 Thread Gedare Bloom
It should be working now. On Thu, Nov 20, 2014 at 11:17 AM, Cláudio Silva claudiodcsi...@gmail.com wrote: Hi, Password recovery is working correctly, but I can't access any patch attached to a ticket. This feature seems to be broken. Cláudio On Thu Nov 20 2014 at 15:54:58 Joel Sherrill

Re: anyone else see sparc-rtems4.11 not building with RSB

2014-11-21 Thread Gedare Bloom
I built a toolchain yesterday for sparc32. Check the build-log for the error message, the tail of the make is insufficient information. On Fri, Nov 21, 2014 at 1:53 PM, Joel Sherrill joel.sherr...@oarcorp.com wrote: Hi RSB report has: make[1]: Leaving directory

Re: mmap implementation was Re: [PATCH 2/4] sys/mman.h: New file. Clean up and add supporting stubs

2014-11-21 Thread Gedare Bloom
On Fri, Nov 21, 2014 at 10:09 AM, Joel Sherrill joel.sherr...@oarcorp.com wrote: Chris, Gedate.. please fill in gaps. On 11/21/2014 4:06 AM, Thomas Kim wrote: Dear Joel, I am sorry. please let me know how to download these patch codes(source code, makefile.am, pre-install.am, etc) for

Trac Ticket Management

2014-11-23 Thread Gedare Bloom
Hi, TL;DR: Trac tickets are in a good state. We need to close or bump the 4.11 milestones before release. I'd like to discuss a proposal to organize the Trac Tickets better. One of the appeals of Trac is that it is simple.There are a six ways I'd like to see our use of trac ticket management

Re: [RTEMS Project] #2175: C++ Exception Catch Handler Crash on Sparc ERC32 Simulator(SIS)

2014-11-23 Thread Gedare Bloom
Is this fixed? On Sun, Nov 23, 2014 at 10:13 AM, RTEMS trac t...@rtems.org wrote: #2175: C++ Exception Catch Handler Crash on Sparc ERC32 Simulator(SIS) --+- Reporter: jbkim | Owner: ralf.corsepius Type: defect|

Re: [PATCH 2/2] sparc/leon2: LEON_Is_interrupt_masked for Leon2 in leon.h wrongly defined

2014-11-24 Thread Gedare Bloom
Daniel commit these if you agree with the assessment. On Sun, Nov 23, 2014 at 4:53 PM, Jiri Gaisler j...@gaisler.se wrote: Condition needs to be inverted, as a 1 in the mask register means that the interrupt is enabled. Solves ticket #1959 in trac. ---

Re: coverity i2c Issue

2014-11-25 Thread Gedare Bloom
On Tue, Nov 25, 2014 at 2:03 PM, Joel Sherrill joel.sherr...@oarcorp.com wrote: Hi These appear to be easy to address. I would appreciate someone addressing these: i2c/eeprom.c: 221 1. Condition address_bytes 4, taking false branch 2. cond_at_most: Checking address_bytes 4 implies

Re: Please review RTEMS JFFS2 Adapter Issue

2014-11-25 Thread Gedare Bloom
Sebastian will have to comment, but it looks like the inner path is not expected to be taken the first time through, i.e. you might add: assert(root_i-i_count 0); -Gedare On Tue, Nov 25, 2014 at 2:30 PM, Joel Sherrill joel.sherr...@oarcorp.com wrote: Hi Coverity Id 1255348 in fs-rtems.c

Re: Please review RTEMS JFFS2 Adapter Issue

2014-11-25 Thread Gedare Bloom
On Tue, Nov 25, 2014 at 2:48 PM, Gedare Bloom ged...@rtems.org wrote: Sebastian will have to comment, but it looks like the inner path is not expected to be taken the first time through, i.e. you might add: assert(root_i-i_count 0); P.S. the function has a FIXME at the top suggesting

Re: [PATCH 05/20] libchip/serial/z85c30.c: Remove redundant assignment

2014-11-26 Thread Gedare Bloom
In the future, please add more in the comment to explain for example that the same variable initialization happens earlier. I had to go look at the code to see why it was OK to delete this line. -Gedare On Tue, Nov 25, 2014 at 6:02 PM, Joel Sherrill joel.sherr...@oarcorp.com wrote: From: Josh

  1   2   3   4   5   6   7   8   9   10   >