Re: [PATCH] drvmgr: Fix determination of prefix in grlib uart driver

2020-02-20 Thread Sebastian Huber 

On 20/02/2020 17:34, Gedare Bloom wrote:

Yes, I'll push in the next few minutes.


Thanks, I forwarded the patch to Gaisler more than a week ago, but 
didn't receive an answer.


--
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail  : sebastian.hu...@embedded-brains.de
PGP : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH] drvmgr: Fix determination of prefix in grlib uart driver

2020-02-20 Thread Gedare Bloom 
Yes, I'll push in the next few minutes.

On Thu, Feb 20, 2020 at 1:41 AM  wrote:
>
> Hello,
>
> Could someone please push this change?
> There has been a lot of activity on this list recently, and I fear I will 
> lose track at some point.
>
> Cheers,
>
>Jan
>
> > -Ursprüngliche Nachricht-
> > Von: devel [mailto:devel-boun...@rtems.org] Im Auftrag von Jan Sommer
> > Gesendet: Mittwoch, 12. Februar 2020 15:10
> > An: devel@rtems.org
> > Betreff: [PATCH] drvmgr: Fix determination of prefix in grlib uart driver
> >
> > From: Dennis Pfau 
> >
> > drvmgr_get_dev_prefix returns 0 if a prefix was found.
> > Therefore the if condition needs to check for 0, i.e. DRVMGR_OK.
> > ---
> >  bsps/shared/grlib/uart/apbuart_cons.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/bsps/shared/grlib/uart/apbuart_cons.c
> > b/bsps/shared/grlib/uart/apbuart_cons.c
> > index ee635e6944..e4d026a4cc 100644
> > --- a/bsps/shared/grlib/uart/apbuart_cons.c
> > +++ b/bsps/shared/grlib/uart/apbuart_cons.c
> > @@ -321,7 +321,7 @@ int apbuart_init1(struct drvmgr_dev *dev)
> >   priv->condev.fsname = NULL;
> >   /* Get Filesystem name prefix */
> >   prefix[0] = '\0';
> > - if (drvmgr_get_dev_prefix(dev, prefix)) {
> > + if (drvmgr_get_dev_prefix(dev, prefix) == DRVMGR_OK) {
> >   /* Got special prefix, this means we have a bus prefix
> >* And we should use our "bus minor"
> >*/
> > --
> > 2.17.1
> >
> > ___
> > devel mailing list
> > devel@rtems.org
> > http://lists.rtems.org/mailman/listinfo/devel
> ___
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

AW: [PATCH] drvmgr: Fix determination of prefix in grlib uart driver

2020-02-20 Thread Jan.Sommer 
Hello,

Could someone please push this change?
There has been a lot of activity on this list recently, and I fear I will lose 
track at some point.

Cheers,

   Jan

> -Ursprüngliche Nachricht-
> Von: devel [mailto:devel-boun...@rtems.org] Im Auftrag von Jan Sommer
> Gesendet: Mittwoch, 12. Februar 2020 15:10
> An: devel@rtems.org
> Betreff: [PATCH] drvmgr: Fix determination of prefix in grlib uart driver
> 
> From: Dennis Pfau 
> 
> drvmgr_get_dev_prefix returns 0 if a prefix was found.
> Therefore the if condition needs to check for 0, i.e. DRVMGR_OK.
> ---
>  bsps/shared/grlib/uart/apbuart_cons.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/bsps/shared/grlib/uart/apbuart_cons.c
> b/bsps/shared/grlib/uart/apbuart_cons.c
> index ee635e6944..e4d026a4cc 100644
> --- a/bsps/shared/grlib/uart/apbuart_cons.c
> +++ b/bsps/shared/grlib/uart/apbuart_cons.c
> @@ -321,7 +321,7 @@ int apbuart_init1(struct drvmgr_dev *dev)
>   priv->condev.fsname = NULL;
>   /* Get Filesystem name prefix */
>   prefix[0] = '\0';
> - if (drvmgr_get_dev_prefix(dev, prefix)) {
> + if (drvmgr_get_dev_prefix(dev, prefix) == DRVMGR_OK) {
>   /* Got special prefix, this means we have a bus prefix
>* And we should use our "bus minor"
>*/
> --
> 2.17.1
> 
> ___
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH] drvmgr: Fix determination of prefix in grlib uart driver

2020-02-12 Thread Jan Sommer 
From: Dennis Pfau 

drvmgr_get_dev_prefix returns 0 if a prefix was found.
Therefore the if condition needs to check for 0, i.e. DRVMGR_OK.
---
 bsps/shared/grlib/uart/apbuart_cons.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bsps/shared/grlib/uart/apbuart_cons.c 
b/bsps/shared/grlib/uart/apbuart_cons.c
index ee635e6944..e4d026a4cc 100644
--- a/bsps/shared/grlib/uart/apbuart_cons.c
+++ b/bsps/shared/grlib/uart/apbuart_cons.c
@@ -321,7 +321,7 @@ int apbuart_init1(struct drvmgr_dev *dev)
priv->condev.fsname = NULL;
/* Get Filesystem name prefix */
prefix[0] = '\0';
-   if (drvmgr_get_dev_prefix(dev, prefix)) {
+   if (drvmgr_get_dev_prefix(dev, prefix) == DRVMGR_OK) {
/* Got special prefix, this means we have a bus prefix
 * And we should use our "bus minor"
 */
-- 
2.17.1

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

[PATCH] drvmgr: Fix determination of prefix in grlib uart driver

2019-04-04 Thread Jan.Sommer 
Hi,

A collegue of mine stumbled upon this small bug.

Best regards,

   Jan



Deutsches Zentrum für Luft- und Raumfahrt e. V. (DLR)
German Aerospace Center
Simulation and Software Technology | Software for Space Systems and Interactive 
Visualization | Lilienthalplatz 7 | 38108 Braunschweig | Germany

Jan Sommer
Telephone +49 531 295-2494 | Telefax 0531 295-2767 | jan.som...@dlr.de
DLR.de/SC



0001-drvmgr-Fix-determination-of-prefix-in-grlib-uart-dri.patch
Description: 0001-drvmgr-Fix-determination-of-prefix-in-grlib-uart-dri.patch
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel