Re: [PATCH RTEMS] bsps/beagle: Refactored i2c driver

2021-04-08 Thread Christian MAUDERER
Hello Vijay and Niteesh, Am 08.04.21 um 04:17 schrieb Vijay Kumar Banerjee: On Wed, Apr 7, 2021 at 7:56 PM Niteesh G. S. wrote: Hello Vijay, On Sun, Mar 28, 2021 at 1:42 AM Vijay Kumar Banerjee wrote: Hi Niteesh, Thanks for the patch. I have some questions below. On Mon, Mar 22, 2021

Re: [PATCH RTEMS] bsps/beagle: Refactored i2c driver

2021-04-07 Thread Vijay Kumar Banerjee
On Wed, Apr 7, 2021 at 7:56 PM Niteesh G. S. wrote: > > Hello Vijay, > > On Sun, Mar 28, 2021 at 1:42 AM Vijay Kumar Banerjee wrote: >> >> Hi Niteesh, >> >> Thanks for the patch. I have some questions below. >> >> On Mon, Mar 22, 2021 at 11:48 AM G S Niteesh Babu >> wrote: >> > >> > Refactored

Re: [PATCH RTEMS] bsps/beagle: Refactored i2c driver

2021-04-07 Thread Niteesh G. S.
Hello Vijay, On Sun, Mar 28, 2021 at 1:42 AM Vijay Kumar Banerjee wrote: > Hi Niteesh, > > Thanks for the patch. I have some questions below. > > On Mon, Mar 22, 2021 at 11:48 AM G S Niteesh Babu > wrote: > > > > Refactored the i2c driver to parse register values from the device > > tree

Re: [PATCH RTEMS] bsps/beagle: Refactored i2c driver

2021-03-27 Thread Vijay Kumar Banerjee
Hi Niteesh, Thanks for the patch. I have some questions below. On Mon, Mar 22, 2021 at 11:48 AM G S Niteesh Babu wrote: > > Refactored the i2c driver to parse register values from the device > tree rather than hardcoding them. But still the clocks have to > initialized manually. > --- >

Re: [PATCH RTEMS] bsps/beagle: Refactored i2c driver

2021-03-22 Thread Niteesh G. S.
Hii, I have tested this patch by reading out the values from the EEPROM in i2c-0 and also reading out data from a sensor connected to i2c-1. For reading data from the sensor, I used RTEMS Shell with i2cget and i2cset. All this was done on a PocketBeagle. Thanks, Niteesh. On Mon, Mar 22, 2021 at

[PATCH RTEMS] bsps/beagle: Refactored i2c driver

2021-03-22 Thread G S Niteesh Babu
Refactored the i2c driver to parse register values from the device tree rather than hardcoding them. But still the clocks have to initialized manually. --- bsps/arm/beagle/i2c/bbb-i2c.c | 100 -- bsps/arm/beagle/include/bsp.h | 4 ++