Re: [PATCH 1/2] barrier: Remove leftover semaphore remnants

2019-10-11 Thread Martin Erik Werner
On Wed, 2019-10-02 at 17:00 -0500, Joel Sherrill wrote: > > > On Wed, Oct 2, 2019 at 2:52 PM Martin Erik Werner < > martinerikwer...@gmail.com> wrote: (...) > > On Tue, 2019-10-01 at 18:02 -0500, Joel Sherrill wrote: > > > > > > > > > On Tue, Oct 1, 2019, 5:07 PM Gedare Bloom > > wrote: > > >

Re: [PATCH 1/2] barrier: Remove leftover semaphore remnants

2019-10-02 Thread Joel Sherrill
On Wed, Oct 2, 2019 at 2:52 PM Martin Erik Werner < martinerikwer...@gmail.com> wrote: > Thanks for the review! Discussion regarding suggested rewording and > cleanup are inline below. > > One minor thing that I also noticed was in the background section there > is a "cticket" which looks like a

Re: [PATCH 1/2] barrier: Remove leftover semaphore remnants

2019-10-02 Thread Martin Erik Werner
Thanks for the review! Discussion regarding suggested rewording and cleanup are inline below. One minor thing that I also noticed was in the background section there is a "cticket" which looks like a typo in "Similarly, cticket holders gather at the gates of arenas [...]". Unless it's some

Re: [PATCH 1/2] barrier: Remove leftover semaphore remnants

2019-10-01 Thread Joel Sherrill
On Tue, Oct 1, 2019, 5:07 PM Gedare Bloom wrote: > On Tue, Oct 1, 2019 at 3:53 PM Gedare Bloom wrote: > > > > On Wed, Sep 4, 2019 at 3:36 PM Martin Erik Werner > > wrote: > > > > > > Remove various incorrect references to "lock" and "obtain" and to an > > > option set which is not part of the

Re: [PATCH 1/2] barrier: Remove leftover semaphore remnants

2019-10-01 Thread Gedare Bloom
On Tue, Oct 1, 2019 at 3:53 PM Gedare Bloom wrote: > > On Wed, Sep 4, 2019 at 3:36 PM Martin Erik Werner > wrote: > > > > Remove various incorrect references to "lock" and "obtain" and to an > > option set which is not part of the barrier interface. > > > > It looks like the barrier

Re: [PATCH 1/2] barrier: Remove leftover semaphore remnants

2019-10-01 Thread Gedare Bloom
On Wed, Sep 4, 2019 at 3:36 PM Martin Erik Werner wrote: > > Remove various incorrect references to "lock" and "obtain" and to an > option set which is not part of the barrier interface. > > It looks like the barrier documentation was started based on a copy of > the semaphore documentation and