Re: [PATCH rtems6 - v1 05/16] FIX: Add missing default case

[Kinsey Moore]

On Thu, Jan 4, 2024 at 2:24 PM Bernd Moessner 
wrote:

> Dear Kinsey,
>
> sry for the stupid question. What is the correct way to reference the issue
>
> [#4981  rtems6 - v1 05/16] FIX: Add
> missing default case
>
> or
>
> [PATCH rtems6 - v1 05/16] #4981 
> FIX: Add missing default case
>

A fair question. It goes in the body of the commit message:
Updates #4981

You can see it in other commits. When you use the tag properly, pushing the
commit will update the ticket with the commit information.

Kinsey
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH rtems6 - v1 05/16] FIX: Add missing default case

[Joel Sherrill]

https://docs.rtems.org/branches/master/eng/vc-users.html#commit-message-guidance

If that is missing something, please ask questions and we can address the
Software Engineering Guide.

--joel

On Thu, Jan 4, 2024 at 2:24 PM Bernd Moessner 
wrote:

> Dear Kinsey,
>
> sry for the stupid question. What is the correct way to reference the issue
>
> [#4981  rtems6 - v1 05/16] FIX: Add
> missing default case
>
> or
>
> [PATCH rtems6 - v1 05/16] #4981 
> FIX: Add missing default case
>
> ?
>
>
>
>
> On 04.01.2024 19:48, Kinsey Moore wrote:
> > All of the patches here need an issue reference. Beyond that, this
> > patch is good to go in. I'm still reviewing the remainder of the set
> > and I'll leave the renaming discussion to Aaron.
> >
> > Kinsey
> >
> > On Thu, Jan 4, 2024 at 12:35 PM  wrote:
> >
> > From: Bernd Moessner 
> >
> > ---
> >  cpukit/dev/flash/flashdev.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/cpukit/dev/flash/flashdev.c
> b/cpukit/dev/flash/flashdev.c
> > index 27edead968..8bd3d11246 100644
> > --- a/cpukit/dev/flash/flashdev.c
> > +++ b/cpukit/dev/flash/flashdev.c
> > @@ -390,6 +390,8 @@ static int rtems_flashdev_ioctl(
> >  case RTEMS_FLASHDEV_IOCTL_GET_WRITE_BLOCK_SIZE:
> >err = rtems_flashdev_ioctl_get_write_block_size( flash, arg );
> >break;
> > +default:
> > +  err = EINVAL;
> >}
> >
> >rtems_flashdev_release( flash );
> > --
> > 2.34.1
> >
> > ___
> > devel mailing list
> > devel@rtems.org
> > http://lists.rtems.org/mailman/listinfo/devel
> >
> ___
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH rtems6 - v1 05/16] FIX: Add missing default case

[Joel Sherrill]

On Thu, Jan 4, 2024 at 12:49 PM Kinsey Moore 
wrote:

> All of the patches here need an issue reference. Beyond that, this patch
> is good to go in. I'm still reviewing the remainder of the set and I'll
> leave the renaming discussion to Aaron.
>

I have only gotten this far into the patch set but I agree with Kinsey that
they look ok.

Aaron should ack though. Hopefully that won't take long.

>
> Kinsey
>
> On Thu, Jan 4, 2024 at 12:35 PM  wrote:
>
>> From: Bernd Moessner 
>>
>> ---
>>  cpukit/dev/flash/flashdev.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/cpukit/dev/flash/flashdev.c b/cpukit/dev/flash/flashdev.c
>> index 27edead968..8bd3d11246 100644
>> --- a/cpukit/dev/flash/flashdev.c
>> +++ b/cpukit/dev/flash/flashdev.c
>> @@ -390,6 +390,8 @@ static int rtems_flashdev_ioctl(
>>  case RTEMS_FLASHDEV_IOCTL_GET_WRITE_BLOCK_SIZE:
>>err = rtems_flashdev_ioctl_get_write_block_size( flash, arg );
>>break;
>> +default:
>> +  err = EINVAL;
>>}
>>
>>rtems_flashdev_release( flash );
>> --
>> 2.34.1
>>
>> ___
>> devel mailing list
>> devel@rtems.org
>> http://lists.rtems.org/mailman/listinfo/devel
>>
> ___
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH rtems6 - v1 05/16] FIX: Add missing default case

[Bernd Moessner]

Dear Kinsey,

sry for the stupid question. What is the correct way to reference the issue

[#4981  rtems6 - v1 05/16] FIX: Add 
missing default case


or

[PATCH rtems6 - v1 05/16] #4981  
FIX: Add missing default case


?




On 04.01.2024 19:48, Kinsey Moore wrote:
All of the patches here need an issue reference. Beyond that, this 
patch is good to go in. I'm still reviewing the remainder of the set 
and I'll leave the renaming discussion to Aaron.


Kinsey

On Thu, Jan 4, 2024 at 12:35 PM  wrote:

From: Bernd Moessner 

---
 cpukit/dev/flash/flashdev.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/cpukit/dev/flash/flashdev.c b/cpukit/dev/flash/flashdev.c
index 27edead968..8bd3d11246 100644
--- a/cpukit/dev/flash/flashdev.c
+++ b/cpukit/dev/flash/flashdev.c
@@ -390,6 +390,8 @@ static int rtems_flashdev_ioctl(
     case RTEMS_FLASHDEV_IOCTL_GET_WRITE_BLOCK_SIZE:
       err = rtems_flashdev_ioctl_get_write_block_size( flash, arg );
       break;
+    default:
+      err = EINVAL;
   }

   rtems_flashdev_release( flash );
-- 
2.34.1


___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel


___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Re: [PATCH rtems6 - v1 05/16] FIX: Add missing default case

[Kinsey Moore]

All of the patches here need an issue reference. Beyond that, this patch is
good to go in. I'm still reviewing the remainder of the set and I'll leave
the renaming discussion to Aaron.

Kinsey

On Thu, Jan 4, 2024 at 12:35 PM  wrote:

> From: Bernd Moessner 
>
> ---
>  cpukit/dev/flash/flashdev.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/cpukit/dev/flash/flashdev.c b/cpukit/dev/flash/flashdev.c
> index 27edead968..8bd3d11246 100644
> --- a/cpukit/dev/flash/flashdev.c
> +++ b/cpukit/dev/flash/flashdev.c
> @@ -390,6 +390,8 @@ static int rtems_flashdev_ioctl(
>  case RTEMS_FLASHDEV_IOCTL_GET_WRITE_BLOCK_SIZE:
>err = rtems_flashdev_ioctl_get_write_block_size( flash, arg );
>break;
> +default:
> +  err = EINVAL;
>}
>
>rtems_flashdev_release( flash );
> --
> 2.34.1
>
> ___
> devel mailing list
> devel@rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
>
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel