Re: [PATCH v2 2/2] i386: Remove unneeded include header files
On Wed, Jun 9, 2021 at 1:02 PM wrote: > > > > > -Original Message- > > From: Gedare Bloom > > Sent: Wednesday, June 9, 2021 8:33 PM > > To: Sommer, Jan > > Cc: Amar Takhar ; Chris Johns ; > > devel@rtems.org > > Subject: Re: [PATCH v2 2/2] i386: Remove unneeded include header files > > > > On Wed, Jun 9, 2021 at 12:27 PM Gedare Bloom wrote: > > > > > > On Wed, Jun 9, 2021 at 12:21 PM Gedare Bloom > > wrote: > > > > > > > > It is helpful. there should be > > > > remote: 3: update trac > > > > > > > ok, actually what's missing is > > > 0: init > > > > > > I think the hooks need to be updated for rtems-libbsd. without running > > > init, the TMP_REV is not generated, so there's nothing to send to > > > trac. > > > > > > I'm going to update the hooks, and we'll see if it works next time. > > > You'll need to manually close the ticket(s) for 5. > > > > > It seems like tickets were being closed for the 6-freebsd-12 branch, so now > > I'm not actually sure this is the right fix, or why they were working > > without > > the init step. We may need to do some testing. > > > I didn't create ticket for the 6-freebsd-12 branch. Should I have? > The output of git push looks quite similar: > > $ git push upstream HEAD~:6-freebsd-12 > Counting objects: 4, done. > Delta compression using up to 8 threads. > Compressing objects: 100% (4/4), done. > Writing objects: 100% (4/4), 627 bytes | 627.00 KiB/s, done. > Total 4 (delta 3), reused 0 (delta 0) > remote: 1: mail v...@rtems.org > remote: 2: update github > remote: 4: IRC > remote: usage: > remote: 5: Buildbot > To ssh://dispatch.rtems.org/data/git/rtems-libbsd.git >34862dd273..1ca0dc7309 HEAD~ -> 6-freebsd-12 > I can't speak directly to the libbsd patch/ticket management. I think it's allowed to not have tickets on 6-freebsd-12 though, because it is an open branch. I looked at for example https://devel.rtems.org/ticket/4405 It got tagged by commits to master and 6-freebsd-12, but not 5-freebsd-12. I'm suspicious that this worked only by chance though. > > > > now we need to find out why. seems the problem really is on git side. > > > > > > > > On Wed, Jun 9, 2021 at 12:03 PM wrote: > > > > > > > > > > That`s the output I got. > > > > > Not sure if it is helpful: > > > > > > > > > > $ git push upstream HEAD~:5-freebsd-12 Counting objects: 4, done. > > > > > Delta compression using up to 8 threads. > > > > > Compressing objects: 100% (4/4), done. > > > > > Writing objects: 100% (4/4), 658 bytes | 658.00 KiB/s, done. > > > > > Total 4 (delta 3), reused 0 (delta 0) > > > > > remote: 1: mail v...@rtems.org > > > > > remote: 2: update github > > > > > remote: 4: IRC > > > > > remote: usage: > > > > > remote: 5: Buildbot > > > > > To ssh://dispatch.rtems.org/data/git/rtems-libbsd.git > > > > >a2bc8eba46..9edb1201f6 HEAD~ -> 5-freebsd-12 > > > > > > > > > > $ git push upstream HEAD:5-freebsd-12 Counting objects: 7, done. > > > > > Delta compression using up to 8 threads. > > > > > Compressing objects: 100% (6/6), done. > > > > > Writing objects: 100% (7/7), 567 bytes | 567.00 KiB/s, done. > > > > > Total 7 (delta 4), reused 0 (delta 0) > > > > > remote: 1: mail v...@rtems.org > > > > > remote: 2: update github > > > > > remote: 4: IRC > > > > > remote: usage: > > > > > remote: 5: Buildbot > > > > > To ssh://dispatch.rtems.org/data/git/rtems-libbsd.git > > > > >9edb1201f6..5c1b99e4d2 HEAD -> 5-freebsd-12 > > > > > > > > > > > -Original Message- > > > > > > From: Gedare Bloom > > > > > > Sent: Wednesday, June 9, 2021 7:59 PM > > > > > > To: Sommer, Jan ; Amar Takhar > > > > > > > > > > > > Cc: Chris Johns ; devel@rtems.org > > > > > > Subject: Re: [PATCH v2 2/2] i386: Remove unneeded include header > > > > > > files > > > > > > > > > > > > On Wed, Jun 9, 2021 at 10:51 AM wrote: > > > > > > > > > > > > > > Thanks. Pushed to master, 5-freebsd-12 and 6-freebsd-12. > > > > > > > Short question: Does the
RE: [PATCH v2 2/2] i386: Remove unneeded include header files
> -Original Message- > From: Gedare Bloom > Sent: Wednesday, June 9, 2021 8:33 PM > To: Sommer, Jan > Cc: Amar Takhar ; Chris Johns ; > devel@rtems.org > Subject: Re: [PATCH v2 2/2] i386: Remove unneeded include header files > > On Wed, Jun 9, 2021 at 12:27 PM Gedare Bloom wrote: > > > > On Wed, Jun 9, 2021 at 12:21 PM Gedare Bloom > wrote: > > > > > > It is helpful. there should be > > > remote: 3: update trac > > > > > ok, actually what's missing is > > 0: init > > > > I think the hooks need to be updated for rtems-libbsd. without running > > init, the TMP_REV is not generated, so there's nothing to send to > > trac. > > > > I'm going to update the hooks, and we'll see if it works next time. > > You'll need to manually close the ticket(s) for 5. > > > It seems like tickets were being closed for the 6-freebsd-12 branch, so now > I'm not actually sure this is the right fix, or why they were working without > the init step. We may need to do some testing. > I didn't create ticket for the 6-freebsd-12 branch. Should I have? The output of git push looks quite similar: $ git push upstream HEAD~:6-freebsd-12 Counting objects: 4, done. Delta compression using up to 8 threads. Compressing objects: 100% (4/4), done. Writing objects: 100% (4/4), 627 bytes | 627.00 KiB/s, done. Total 4 (delta 3), reused 0 (delta 0) remote: 1: mail v...@rtems.org remote: 2: update github remote: 4: IRC remote: usage: remote: 5: Buildbot To ssh://dispatch.rtems.org/data/git/rtems-libbsd.git 34862dd273..1ca0dc7309 HEAD~ -> 6-freebsd-12 > > > now we need to find out why. seems the problem really is on git side. > > > > > > On Wed, Jun 9, 2021 at 12:03 PM wrote: > > > > > > > > That`s the output I got. > > > > Not sure if it is helpful: > > > > > > > > $ git push upstream HEAD~:5-freebsd-12 Counting objects: 4, done. > > > > Delta compression using up to 8 threads. > > > > Compressing objects: 100% (4/4), done. > > > > Writing objects: 100% (4/4), 658 bytes | 658.00 KiB/s, done. > > > > Total 4 (delta 3), reused 0 (delta 0) > > > > remote: 1: mail v...@rtems.org > > > > remote: 2: update github > > > > remote: 4: IRC > > > > remote: usage: > > > > remote: 5: Buildbot > > > > To ssh://dispatch.rtems.org/data/git/rtems-libbsd.git > > > >a2bc8eba46..9edb1201f6 HEAD~ -> 5-freebsd-12 > > > > > > > > $ git push upstream HEAD:5-freebsd-12 Counting objects: 7, done. > > > > Delta compression using up to 8 threads. > > > > Compressing objects: 100% (6/6), done. > > > > Writing objects: 100% (7/7), 567 bytes | 567.00 KiB/s, done. > > > > Total 7 (delta 4), reused 0 (delta 0) > > > > remote: 1: mail v...@rtems.org > > > > remote: 2: update github > > > > remote: 4: IRC > > > > remote: usage: > > > > remote: 5: Buildbot > > > > To ssh://dispatch.rtems.org/data/git/rtems-libbsd.git > > > >9edb1201f6..5c1b99e4d2 HEAD -> 5-freebsd-12 > > > > > > > > > -Original Message- > > > > > From: Gedare Bloom > > > > > Sent: Wednesday, June 9, 2021 7:59 PM > > > > > To: Sommer, Jan ; Amar Takhar > > > > > > > > > > Cc: Chris Johns ; devel@rtems.org > > > > > Subject: Re: [PATCH v2 2/2] i386: Remove unneeded include header > > > > > files > > > > > > > > > > On Wed, Jun 9, 2021 at 10:51 AM wrote: > > > > > > > > > > > > Thanks. Pushed to master, 5-freebsd-12 and 6-freebsd-12. > > > > > > Short question: Does the buildbot recognize the pushes to > > > > > > rtems-libbsd/5- > > > > > freebsd-12 and update the ticket? > > > > > > I added the ticket number to the commit description, but the > > > > > > ticket has not > > > > > been updated. > > > > > > > > > > > Do you still have the terminal output from running git-push? > > > > > > > > > > The git side looks ok, but I can't check the trac end. > > > > > > > > > > > Best regards, > > > > > > > > > > > > Jan > > > > > > > > > > > > > -Original Message- > > > > > > > From: Chris Johns > > > > > > > Sent: Wednesday, June 9, 2021 12:13 PM > > > > > > > To: Sommer, Jan ; ged...@rtems.org > > > > > > > Cc: devel@rtems.org > > > > > > > Subject: Re: [PATCH v2 2/2] i386: Remove unneeded include > > > > > > > header files > > > > > > > > > > > > > > On 8/6/21 11:52 pm, jan.som...@dlr.de wrote: > > > > > > > > I would also like to backport this to 5-freebsd-12 to > > > > > > > > solve this issue > > > > > there as > > > > > > > well. > > > > > > > > I created a corresponding ticket: > > > > > > > https://devel.rtems.org/ticket/4452#ticket > > > > > > > > > > > > > > OK for 5. > > > > > > > > > > > > > > Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: [PATCH v2 2/2] i386: Remove unneeded include header files
On Wed, Jun 9, 2021 at 12:27 PM Gedare Bloom wrote: > > On Wed, Jun 9, 2021 at 12:21 PM Gedare Bloom wrote: > > > > It is helpful. there should be > > remote: 3: update trac > > > ok, actually what's missing is > 0: init > > I think the hooks need to be updated for rtems-libbsd. without running > init, the TMP_REV is not generated, so there's nothing to send to > trac. > > I'm going to update the hooks, and we'll see if it works next time. > You'll need to manually close the ticket(s) for 5. > It seems like tickets were being closed for the 6-freebsd-12 branch, so now I'm not actually sure this is the right fix, or why they were working without the init step. We may need to do some testing. > > now we need to find out why. seems the problem really is on git side. > > > > On Wed, Jun 9, 2021 at 12:03 PM wrote: > > > > > > That`s the output I got. > > > Not sure if it is helpful: > > > > > > $ git push upstream HEAD~:5-freebsd-12 > > > Counting objects: 4, done. > > > Delta compression using up to 8 threads. > > > Compressing objects: 100% (4/4), done. > > > Writing objects: 100% (4/4), 658 bytes | 658.00 KiB/s, done. > > > Total 4 (delta 3), reused 0 (delta 0) > > > remote: 1: mail v...@rtems.org > > > remote: 2: update github > > > remote: 4: IRC > > > remote: usage: > > > remote: 5: Buildbot > > > To ssh://dispatch.rtems.org/data/git/rtems-libbsd.git > > >a2bc8eba46..9edb1201f6 HEAD~ -> 5-freebsd-12 > > > > > > $ git push upstream HEAD:5-freebsd-12 > > > Counting objects: 7, done. > > > Delta compression using up to 8 threads. > > > Compressing objects: 100% (6/6), done. > > > Writing objects: 100% (7/7), 567 bytes | 567.00 KiB/s, done. > > > Total 7 (delta 4), reused 0 (delta 0) > > > remote: 1: mail v...@rtems.org > > > remote: 2: update github > > > remote: 4: IRC > > > remote: usage: > > > remote: 5: Buildbot > > > To ssh://dispatch.rtems.org/data/git/rtems-libbsd.git > > >9edb1201f6..5c1b99e4d2 HEAD -> 5-freebsd-12 > > > > > > > -Original Message- > > > > From: Gedare Bloom > > > > Sent: Wednesday, June 9, 2021 7:59 PM > > > > To: Sommer, Jan ; Amar Takhar > > > > > > > > Cc: Chris Johns ; devel@rtems.org > > > > Subject: Re: [PATCH v2 2/2] i386: Remove unneeded include header files > > > > > > > > On Wed, Jun 9, 2021 at 10:51 AM wrote: > > > > > > > > > > Thanks. Pushed to master, 5-freebsd-12 and 6-freebsd-12. > > > > > Short question: Does the buildbot recognize the pushes to > > > > > rtems-libbsd/5- > > > > freebsd-12 and update the ticket? > > > > > I added the ticket number to the commit description, but the ticket > > > > > has not > > > > been updated. > > > > > > > > > Do you still have the terminal output from running git-push? > > > > > > > > The git side looks ok, but I can't check the trac end. > > > > > > > > > Best regards, > > > > > > > > > > Jan > > > > > > > > > > > -Original Message- > > > > > > From: Chris Johns > > > > > > Sent: Wednesday, June 9, 2021 12:13 PM > > > > > > To: Sommer, Jan ; ged...@rtems.org > > > > > > Cc: devel@rtems.org > > > > > > Subject: Re: [PATCH v2 2/2] i386: Remove unneeded include header > > > > > > files > > > > > > > > > > > > On 8/6/21 11:52 pm, jan.som...@dlr.de wrote: > > > > > > > I would also like to backport this to 5-freebsd-12 to solve this > > > > > > > issue > > > > there as > > > > > > well. > > > > > > > I created a corresponding ticket: > > > > > > https://devel.rtems.org/ticket/4452#ticket > > > > > > > > > > > > OK for 5. > > > > > > > > > > > > Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: [PATCH v2 2/2] i386: Remove unneeded include header files
On Wed, Jun 9, 2021 at 12:21 PM Gedare Bloom wrote: > > It is helpful. there should be > remote: 3: update trac > ok, actually what's missing is 0: init I think the hooks need to be updated for rtems-libbsd. without running init, the TMP_REV is not generated, so there's nothing to send to trac. I'm going to update the hooks, and we'll see if it works next time. You'll need to manually close the ticket(s) for 5. > now we need to find out why. seems the problem really is on git side. > > On Wed, Jun 9, 2021 at 12:03 PM wrote: > > > > That`s the output I got. > > Not sure if it is helpful: > > > > $ git push upstream HEAD~:5-freebsd-12 > > Counting objects: 4, done. > > Delta compression using up to 8 threads. > > Compressing objects: 100% (4/4), done. > > Writing objects: 100% (4/4), 658 bytes | 658.00 KiB/s, done. > > Total 4 (delta 3), reused 0 (delta 0) > > remote: 1: mail v...@rtems.org > > remote: 2: update github > > remote: 4: IRC > > remote: usage: > > remote: 5: Buildbot > > To ssh://dispatch.rtems.org/data/git/rtems-libbsd.git > >a2bc8eba46..9edb1201f6 HEAD~ -> 5-freebsd-12 > > > > $ git push upstream HEAD:5-freebsd-12 > > Counting objects: 7, done. > > Delta compression using up to 8 threads. > > Compressing objects: 100% (6/6), done. > > Writing objects: 100% (7/7), 567 bytes | 567.00 KiB/s, done. > > Total 7 (delta 4), reused 0 (delta 0) > > remote: 1: mail v...@rtems.org > > remote: 2: update github > > remote: 4: IRC > > remote: usage: > > remote: 5: Buildbot > > To ssh://dispatch.rtems.org/data/git/rtems-libbsd.git > >9edb1201f6..5c1b99e4d2 HEAD -> 5-freebsd-12 > > > > > -Original Message----- > > > From: Gedare Bloom > > > Sent: Wednesday, June 9, 2021 7:59 PM > > > To: Sommer, Jan ; Amar Takhar > > > > > > Cc: Chris Johns ; devel@rtems.org > > > Subject: Re: [PATCH v2 2/2] i386: Remove unneeded include header files > > > > > > On Wed, Jun 9, 2021 at 10:51 AM wrote: > > > > > > > > Thanks. Pushed to master, 5-freebsd-12 and 6-freebsd-12. > > > > Short question: Does the buildbot recognize the pushes to > > > > rtems-libbsd/5- > > > freebsd-12 and update the ticket? > > > > I added the ticket number to the commit description, but the ticket has > > > > not > > > been updated. > > > > > > > Do you still have the terminal output from running git-push? > > > > > > The git side looks ok, but I can't check the trac end. > > > > > > > Best regards, > > > > > > > > Jan > > > > > > > > > -Original Message- > > > > > From: Chris Johns > > > > > Sent: Wednesday, June 9, 2021 12:13 PM > > > > > To: Sommer, Jan ; ged...@rtems.org > > > > > Cc: devel@rtems.org > > > > > Subject: Re: [PATCH v2 2/2] i386: Remove unneeded include header files > > > > > > > > > > On 8/6/21 11:52 pm, jan.som...@dlr.de wrote: > > > > > > I would also like to backport this to 5-freebsd-12 to solve this > > > > > > issue > > > there as > > > > > well. > > > > > > I created a corresponding ticket: > > > > > https://devel.rtems.org/ticket/4452#ticket > > > > > > > > > > OK for 5. > > > > > > > > > > Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: [PATCH v2 2/2] i386: Remove unneeded include header files
It is helpful. there should be remote: 3: update trac now we need to find out why. seems the problem really is on git side. On Wed, Jun 9, 2021 at 12:03 PM wrote: > > That`s the output I got. > Not sure if it is helpful: > > $ git push upstream HEAD~:5-freebsd-12 > Counting objects: 4, done. > Delta compression using up to 8 threads. > Compressing objects: 100% (4/4), done. > Writing objects: 100% (4/4), 658 bytes | 658.00 KiB/s, done. > Total 4 (delta 3), reused 0 (delta 0) > remote: 1: mail v...@rtems.org > remote: 2: update github > remote: 4: IRC > remote: usage: > remote: 5: Buildbot > To ssh://dispatch.rtems.org/data/git/rtems-libbsd.git >a2bc8eba46..9edb1201f6 HEAD~ -> 5-freebsd-12 > > $ git push upstream HEAD:5-freebsd-12 > Counting objects: 7, done. > Delta compression using up to 8 threads. > Compressing objects: 100% (6/6), done. > Writing objects: 100% (7/7), 567 bytes | 567.00 KiB/s, done. > Total 7 (delta 4), reused 0 (delta 0) > remote: 1: mail v...@rtems.org > remote: 2: update github > remote: 4: IRC > remote: usage: > remote: 5: Buildbot > To ssh://dispatch.rtems.org/data/git/rtems-libbsd.git >9edb1201f6..5c1b99e4d2 HEAD -> 5-freebsd-12 > > > -Original Message- > > From: Gedare Bloom > > Sent: Wednesday, June 9, 2021 7:59 PM > > To: Sommer, Jan ; Amar Takhar > > > > Cc: Chris Johns ; devel@rtems.org > > Subject: Re: [PATCH v2 2/2] i386: Remove unneeded include header files > > > > On Wed, Jun 9, 2021 at 10:51 AM wrote: > > > > > > Thanks. Pushed to master, 5-freebsd-12 and 6-freebsd-12. > > > Short question: Does the buildbot recognize the pushes to rtems-libbsd/5- > > freebsd-12 and update the ticket? > > > I added the ticket number to the commit description, but the ticket has > > > not > > been updated. > > > > > Do you still have the terminal output from running git-push? > > > > The git side looks ok, but I can't check the trac end. > > > > > Best regards, > > > > > > Jan > > > > > > > -Original Message- > > > > From: Chris Johns > > > > Sent: Wednesday, June 9, 2021 12:13 PM > > > > To: Sommer, Jan ; ged...@rtems.org > > > > Cc: devel@rtems.org > > > > Subject: Re: [PATCH v2 2/2] i386: Remove unneeded include header files > > > > > > > > On 8/6/21 11:52 pm, jan.som...@dlr.de wrote: > > > > > I would also like to backport this to 5-freebsd-12 to solve this issue > > there as > > > > well. > > > > > I created a corresponding ticket: > > > > https://devel.rtems.org/ticket/4452#ticket > > > > > > > > OK for 5. > > > > > > > > Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
RE: [PATCH v2 2/2] i386: Remove unneeded include header files
That`s the output I got. Not sure if it is helpful: $ git push upstream HEAD~:5-freebsd-12 Counting objects: 4, done. Delta compression using up to 8 threads. Compressing objects: 100% (4/4), done. Writing objects: 100% (4/4), 658 bytes | 658.00 KiB/s, done. Total 4 (delta 3), reused 0 (delta 0) remote: 1: mail v...@rtems.org remote: 2: update github remote: 4: IRC remote: usage: remote: 5: Buildbot To ssh://dispatch.rtems.org/data/git/rtems-libbsd.git a2bc8eba46..9edb1201f6 HEAD~ -> 5-freebsd-12 $ git push upstream HEAD:5-freebsd-12 Counting objects: 7, done. Delta compression using up to 8 threads. Compressing objects: 100% (6/6), done. Writing objects: 100% (7/7), 567 bytes | 567.00 KiB/s, done. Total 7 (delta 4), reused 0 (delta 0) remote: 1: mail v...@rtems.org remote: 2: update github remote: 4: IRC remote: usage: remote: 5: Buildbot To ssh://dispatch.rtems.org/data/git/rtems-libbsd.git 9edb1201f6..5c1b99e4d2 HEAD -> 5-freebsd-12 > -Original Message- > From: Gedare Bloom > Sent: Wednesday, June 9, 2021 7:59 PM > To: Sommer, Jan ; Amar Takhar > > Cc: Chris Johns ; devel@rtems.org > Subject: Re: [PATCH v2 2/2] i386: Remove unneeded include header files > > On Wed, Jun 9, 2021 at 10:51 AM wrote: > > > > Thanks. Pushed to master, 5-freebsd-12 and 6-freebsd-12. > > Short question: Does the buildbot recognize the pushes to rtems-libbsd/5- > freebsd-12 and update the ticket? > > I added the ticket number to the commit description, but the ticket has not > been updated. > > > Do you still have the terminal output from running git-push? > > The git side looks ok, but I can't check the trac end. > > > Best regards, > > > > Jan > > > > > -Original Message- > > > From: Chris Johns > > > Sent: Wednesday, June 9, 2021 12:13 PM > > > To: Sommer, Jan ; ged...@rtems.org > > > Cc: devel@rtems.org > > > Subject: Re: [PATCH v2 2/2] i386: Remove unneeded include header files > > > > > > On 8/6/21 11:52 pm, jan.som...@dlr.de wrote: > > > > I would also like to backport this to 5-freebsd-12 to solve this issue > there as > > > well. > > > > I created a corresponding ticket: > > > https://devel.rtems.org/ticket/4452#ticket > > > > > > OK for 5. > > > > > > Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: [PATCH v2 2/2] i386: Remove unneeded include header files
On Wed, Jun 9, 2021 at 10:51 AM wrote: > > Thanks. Pushed to master, 5-freebsd-12 and 6-freebsd-12. > Short question: Does the buildbot recognize the pushes to > rtems-libbsd/5-freebsd-12 and update the ticket? > I added the ticket number to the commit description, but the ticket has not > been updated. > Do you still have the terminal output from running git-push? The git side looks ok, but I can't check the trac end. > Best regards, > > Jan > > > -Original Message- > > From: Chris Johns > > Sent: Wednesday, June 9, 2021 12:13 PM > > To: Sommer, Jan ; ged...@rtems.org > > Cc: devel@rtems.org > > Subject: Re: [PATCH v2 2/2] i386: Remove unneeded include header files > > > > On 8/6/21 11:52 pm, jan.som...@dlr.de wrote: > > > I would also like to backport this to 5-freebsd-12 to solve this issue > > > there as > > well. > > > I created a corresponding ticket: > > https://devel.rtems.org/ticket/4452#ticket > > > > OK for 5. > > > > Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
RE: [PATCH v2 2/2] i386: Remove unneeded include header files
Thanks. Pushed to master, 5-freebsd-12 and 6-freebsd-12. Short question: Does the buildbot recognize the pushes to rtems-libbsd/5-freebsd-12 and update the ticket? I added the ticket number to the commit description, but the ticket has not been updated. Best regards, Jan > -Original Message- > From: Chris Johns > Sent: Wednesday, June 9, 2021 12:13 PM > To: Sommer, Jan ; ged...@rtems.org > Cc: devel@rtems.org > Subject: Re: [PATCH v2 2/2] i386: Remove unneeded include header files > > On 8/6/21 11:52 pm, jan.som...@dlr.de wrote: > > I would also like to backport this to 5-freebsd-12 to solve this issue > > there as > well. > > I created a corresponding ticket: > https://devel.rtems.org/ticket/4452#ticket > > OK for 5. > > Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
Re: [PATCH v2 2/2] i386: Remove unneeded include header files
On 8/6/21 11:52 pm, jan.som...@dlr.de wrote: > I would also like to backport this to 5-freebsd-12 to solve this issue there > as well. > I created a corresponding ticket: https://devel.rtems.org/ticket/4452#ticket OK for 5. Chris ___ devel mailing list devel@rtems.org http://lists.rtems.org/mailman/listinfo/devel
RE: [PATCH v2 2/2] i386: Remove unneeded include header files
Thanks, I would also like to backport this to 5-freebsd-12 to solve this issue there as well. I created a corresponding ticket: https://devel.rtems.org/ticket/4452#ticket Best regards, Jan > -Original Message- > From: Chris Johns > Sent: Tuesday, June 8, 2021 4:59 AM > To: Gedare Bloom ; Sommer, Jan > > Cc: devel@rtems.org > Subject: Re: [PATCH v2 2/2] i386: Remove unneeded include header files > > I agree this is the way to solve this issue. > > Chris > > On 8/6/21 3:09 am, Gedare Bloom wrote: > > This looks like a much better solution :) If no one complains by > > Thursday go ahead and push it. > > > > On Mon, Jun 7, 2021 at 2:53 AM Jan Sommer wrote: > >> > >> --- > >> .../sys/i386/include/machine/intr_machdep.h |6 - > >> rtemsbsd/include/x86/bus.h| 1109 > >> rtemsbsd/include/x86/specialreg.h | 1143 - > >> 3 files changed, 2258 deletions(-) > >> delete mode 100644 freebsd/sys/i386/include/machine/intr_machdep.h > >> delete mode 100644 rtemsbsd/include/x86/bus.h > >> delete mode 100644 rtemsbsd/include/x86/specialreg.h > >> > >> diff --git a/freebsd/sys/i386/include/machine/intr_machdep.h > b/freebsd/sys/i386/include/machine/intr_machdep.h > >> deleted file mode 100644 > >> index a0b28387.. > >> --- a/freebsd/sys/i386/include/machine/intr_machdep.h > >> +++ /dev/null > >> @@ -1,6 +0,0 @@ > >> -/*- > >> - * This file is in the public domain. > >> - */ > >> -/* $FreeBSD$ */ > >> - > >> -#include > >> diff --git a/rtemsbsd/include/x86/bus.h b/rtemsbsd/include/x86/bus.h > >> deleted file mode 100644 > >> index 2427ae51.. > >> --- a/rtemsbsd/include/x86/bus.h > >> +++ /dev/null > >> @@ -1,1109 +0,0 @@ > >> -/*- > >> - * SPDX-License-Identifier: BSD-3-Clause AND BSD-2-Clause-NetBSDE > >> - * > >> - * Copyright (c) KATO Takenori, 1999. > >> - * > >> - * All rights reserved. Unpublished rights reserved under the copyright > >> - * laws of Japan. > >> - * > >> - * Redistribution and use in source and binary forms, with or without > >> - * modification, are permitted provided that the following conditions > >> - * are met: > >> - * > >> - * 1. Redistributions of source code must retain the above copyright > >> - *notice, this list of conditions and the following disclaimer as > >> - *the first lines of this file unmodified. > >> - * 2. Redistributions in binary form must reproduce the above copyright > >> - *notice, this list of conditions and the following disclaimer in the > >> - *documentation and/or other materials provided with the > distribution. > >> - * 3. The name of the author may not be used to endorse or promote > products > >> - *derived from this software without specific prior written > >> permission. > >> - * > >> - * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY > EXPRESS OR > >> - * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE > IMPLIED WARRANTIES > >> - * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE > DISCLAIMED. > >> - * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, > INDIRECT, > >> - * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES > (INCLUDING, BUT > >> - * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR > SERVICES; LOSS OF USE, > >> - * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED > AND ON ANY > >> - * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR > TORT > >> - * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT > OF THE USE OF > >> - * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH > DAMAGE. > >> - * > >> - * $FreeBSD$ > >> - */ > >> - > >> -/* $NetBSD: bus.h,v 1.12 1997/10/01 08:25:15 fvdl Exp $*/ > >> - > >> -/*- > >> - * Copyright (c) 1996, 1997 The NetBSD Foundation, Inc. > >> - * All rights reserved. > >> - * > >> - * This code is derived from software contributed to The NetBSD > Foundation > >> - * by Jason R. Thorpe of the Numerical Aerospace Simulation Facility, > >> - * NASA Ames Research Center. > >> - * > >> - * Redistribution and use in source and binary forms, with or without > >> - * modification, are permitted provided that the following conditio
Re: [PATCH v2 2/2] i386: Remove unneeded include header files
I agree this is the way to solve this issue. Chris On 8/6/21 3:09 am, Gedare Bloom wrote: > This looks like a much better solution :) If no one complains by > Thursday go ahead and push it. > > On Mon, Jun 7, 2021 at 2:53 AM Jan Sommer wrote: >> >> --- >> .../sys/i386/include/machine/intr_machdep.h |6 - >> rtemsbsd/include/x86/bus.h| 1109 >> rtemsbsd/include/x86/specialreg.h | 1143 - >> 3 files changed, 2258 deletions(-) >> delete mode 100644 freebsd/sys/i386/include/machine/intr_machdep.h >> delete mode 100644 rtemsbsd/include/x86/bus.h >> delete mode 100644 rtemsbsd/include/x86/specialreg.h >> >> diff --git a/freebsd/sys/i386/include/machine/intr_machdep.h >> b/freebsd/sys/i386/include/machine/intr_machdep.h >> deleted file mode 100644 >> index a0b28387.. >> --- a/freebsd/sys/i386/include/machine/intr_machdep.h >> +++ /dev/null >> @@ -1,6 +0,0 @@ >> -/*- >> - * This file is in the public domain. >> - */ >> -/* $FreeBSD$ */ >> - >> -#include >> diff --git a/rtemsbsd/include/x86/bus.h b/rtemsbsd/include/x86/bus.h >> deleted file mode 100644 >> index 2427ae51.. >> --- a/rtemsbsd/include/x86/bus.h >> +++ /dev/null >> @@ -1,1109 +0,0 @@ >> -/*- >> - * SPDX-License-Identifier: BSD-3-Clause AND BSD-2-Clause-NetBSDE >> - * >> - * Copyright (c) KATO Takenori, 1999. >> - * >> - * All rights reserved. Unpublished rights reserved under the copyright >> - * laws of Japan. >> - * >> - * Redistribution and use in source and binary forms, with or without >> - * modification, are permitted provided that the following conditions >> - * are met: >> - * >> - * 1. Redistributions of source code must retain the above copyright >> - *notice, this list of conditions and the following disclaimer as >> - *the first lines of this file unmodified. >> - * 2. Redistributions in binary form must reproduce the above copyright >> - *notice, this list of conditions and the following disclaimer in the >> - *documentation and/or other materials provided with the distribution. >> - * 3. The name of the author may not be used to endorse or promote products >> - *derived from this software without specific prior written permission. >> - * >> - * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR >> - * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES >> - * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. >> - * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, >> - * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT >> - * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, >> - * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY >> - * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT >> - * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF >> - * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. >> - * >> - * $FreeBSD$ >> - */ >> - >> -/* $NetBSD: bus.h,v 1.12 1997/10/01 08:25:15 fvdl Exp $*/ >> - >> -/*- >> - * Copyright (c) 1996, 1997 The NetBSD Foundation, Inc. >> - * All rights reserved. >> - * >> - * This code is derived from software contributed to The NetBSD Foundation >> - * by Jason R. Thorpe of the Numerical Aerospace Simulation Facility, >> - * NASA Ames Research Center. >> - * >> - * Redistribution and use in source and binary forms, with or without >> - * modification, are permitted provided that the following conditions >> - * are met: >> - * 1. Redistributions of source code must retain the above copyright >> - *notice, this list of conditions and the following disclaimer. >> - * 2. Redistributions in binary form must reproduce the above copyright >> - *notice, this list of conditions and the following disclaimer in the >> - *documentation and/or other materials provided with the distribution. >> - * >> - * THIS SOFTWARE IS PROVIDED BY THE NETBSD FOUNDATION, INC. AND CONTRIBUTORS >> - * ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT >> LIMITED >> - * TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A >> PARTICULAR >> - * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE FOUNDATION OR CONTRIBUTORS >> - * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR >> - * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF >> - * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS >> - * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN >> - * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) >> - * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF >> THE >> - * POSSIBILITY OF SUCH DAMAGE. >> - */ >> - >> -/*- >> - * Copyright (c) 1996 Charles M. Hannum. All rights reserved. >> - * Copyright (c) 1996 Christopher G. Demetriou. All rights
Re: [PATCH v2 2/2] i386: Remove unneeded include header files
This looks like a much better solution :) If no one complains by Thursday go ahead and push it. On Mon, Jun 7, 2021 at 2:53 AM Jan Sommer wrote: > > --- > .../sys/i386/include/machine/intr_machdep.h |6 - > rtemsbsd/include/x86/bus.h| 1109 > rtemsbsd/include/x86/specialreg.h | 1143 - > 3 files changed, 2258 deletions(-) > delete mode 100644 freebsd/sys/i386/include/machine/intr_machdep.h > delete mode 100644 rtemsbsd/include/x86/bus.h > delete mode 100644 rtemsbsd/include/x86/specialreg.h > > diff --git a/freebsd/sys/i386/include/machine/intr_machdep.h > b/freebsd/sys/i386/include/machine/intr_machdep.h > deleted file mode 100644 > index a0b28387.. > --- a/freebsd/sys/i386/include/machine/intr_machdep.h > +++ /dev/null > @@ -1,6 +0,0 @@ > -/*- > - * This file is in the public domain. > - */ > -/* $FreeBSD$ */ > - > -#include > diff --git a/rtemsbsd/include/x86/bus.h b/rtemsbsd/include/x86/bus.h > deleted file mode 100644 > index 2427ae51.. > --- a/rtemsbsd/include/x86/bus.h > +++ /dev/null > @@ -1,1109 +0,0 @@ > -/*- > - * SPDX-License-Identifier: BSD-3-Clause AND BSD-2-Clause-NetBSDE > - * > - * Copyright (c) KATO Takenori, 1999. > - * > - * All rights reserved. Unpublished rights reserved under the copyright > - * laws of Japan. > - * > - * Redistribution and use in source and binary forms, with or without > - * modification, are permitted provided that the following conditions > - * are met: > - * > - * 1. Redistributions of source code must retain the above copyright > - *notice, this list of conditions and the following disclaimer as > - *the first lines of this file unmodified. > - * 2. Redistributions in binary form must reproduce the above copyright > - *notice, this list of conditions and the following disclaimer in the > - *documentation and/or other materials provided with the distribution. > - * 3. The name of the author may not be used to endorse or promote products > - *derived from this software without specific prior written permission. > - * > - * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR > - * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES > - * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. > - * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT, > - * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT > - * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, > - * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY > - * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > - * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF > - * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > - * > - * $FreeBSD$ > - */ > - > -/* $NetBSD: bus.h,v 1.12 1997/10/01 08:25:15 fvdl Exp $*/ > - > -/*- > - * Copyright (c) 1996, 1997 The NetBSD Foundation, Inc. > - * All rights reserved. > - * > - * This code is derived from software contributed to The NetBSD Foundation > - * by Jason R. Thorpe of the Numerical Aerospace Simulation Facility, > - * NASA Ames Research Center. > - * > - * Redistribution and use in source and binary forms, with or without > - * modification, are permitted provided that the following conditions > - * are met: > - * 1. Redistributions of source code must retain the above copyright > - *notice, this list of conditions and the following disclaimer. > - * 2. Redistributions in binary form must reproduce the above copyright > - *notice, this list of conditions and the following disclaimer in the > - *documentation and/or other materials provided with the distribution. > - * > - * THIS SOFTWARE IS PROVIDED BY THE NETBSD FOUNDATION, INC. AND CONTRIBUTORS > - * ``AS IS'' AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > LIMITED > - * TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR > - * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE FOUNDATION OR CONTRIBUTORS > - * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR > - * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF > - * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS > - * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN > - * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) > - * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE > - * POSSIBILITY OF SUCH DAMAGE. > - */ > - > -/*- > - * Copyright (c) 1996 Charles M. Hannum. All rights reserved. > - * Copyright (c) 1996 Christopher G. Demetriou. All rights reserved. > - * > - * Redistribution and use in source and binary forms, with or without > - * modification, are permitted provided that the following conditions > - * are met: > - * 1. Redistributions of source
