Re: [RTEMS][PATCH v2 0/2] riscv: add freedom E310 Arty A7

2019-09-11 Thread Hesham Almatary
On Wed, 11 Sep 2019 at 15:12, Hesham Almatary wrote: > > On Wed, 11 Sep 2019 at 14:07, Pragnesh Patel > wrote: > > > > Fredom E310 Arty has a support for FDT but right now, u-boot (or any > > bootloader) will not copy FDT address into CPU register (a1 for RISCV) > > instead we have given FDT

Re: [RTEMS][PATCH v2 0/2] riscv: add freedom E310 Arty A7

2019-09-11 Thread Hesham Almatary
On Wed, 11 Sep 2019 at 14:07, Pragnesh Patel wrote: > > Fredom E310 Arty has a support for FDT but right now, u-boot (or any > bootloader) will not copy FDT address into CPU register (a1 for RISCV) > instead we have given FDT address manually as shown below: > On FPGA/hardware, a bootrom (part of

Re: [RTEMS][PATCH v2 0/2] riscv: add freedom E310 Arty A7

2019-09-11 Thread Sebastian Huber
On 11/09/2019 15:07, Pragnesh Patel wrote: Fredom E310 Arty has a support for FDT but right now, u-boot (or any bootloader) will not copy FDT address into CPU register (a1 for RISCV) instead we have given FDT address manually as shown below: Qemu does this an I guess U-Boot does it also. How

Re: [RTEMS][PATCH v2 0/2] riscv: add freedom E310 Arty A7

2019-09-11 Thread Pragnesh Patel
Fredom E310 Arty has a support for FDT but right now, u-boot (or any bootloader) will not copy FDT address into CPU register (a1 for RISCV) instead we have given FDT address manually as shown below: bsps/riscv/shared/start/start.S #ifdef BSP_START_COPY_FDT_FROM_U_BOOT + LADDR a1,

Re: [RTEMS][PATCH v2 0/2] riscv: add freedom E310 Arty A7

2019-09-11 Thread Sebastian Huber
On 11/09/2019 10:43, Pragnesh Patel wrote: Ok understood. If i will add Freedom E310 related code in bsp/riscv/riscv directory then there are some code changes related to "console, btimer and other minor things" so can i add this changes under new #define let's say #define

Re: [RTEMS][PATCH v2 0/2] riscv: add freedom E310 Arty A7

2019-09-11 Thread Pragnesh Patel
Ok understood. If i will add Freedom E310 related code in bsp/riscv/riscv directory then there are some code changes related to "console, btimer and other minor things" so can i add this changes under new #define let's say #define RISCV_ENABLE_FRDME310_SUPPORT ? I am planning to add this #define

Re: [RTEMS][PATCH v2 0/2] riscv: add freedom E310 Arty A7

2019-09-11 Thread Sebastian Huber
On 11/09/2019 09:27, Pragnesh Patel wrote: Thanks for the clarification. i am also agree with your comments but let's say in future, we want to add I2C and SPI for Freedom E310 then what's your suggestion? Future I2C and SPI drivers should be added to:

Re: [RTEMS][PATCH v2 0/2] riscv: add freedom E310 Arty A7

2019-09-11 Thread Pragnesh Patel
Hello Hesham, Thanks for the clarification. i am also agree with your comments but let's say in future, we want to add I2C and SPI for Freedom E310 then what's your suggestion? - Pragnesh On Tue, Sep 10, 2019 at 4:13 PM Hesham Almatary wrote: > > Hi Pragnesh, > > Thanks for the v2 update. I

Re: [RTEMS][PATCH v2 0/2] riscv: add freedom E310 Arty A7

2019-09-10 Thread Hesham Almatary
Hi Pragnesh, Thanks for the v2 update. I guess our question/comment on the previous v1 patch was about the addition of bsps/riscv/frdme310arty/ directory at all. That is, you might be able to just use bsps/riscv/riscv already. Are there any significant changes that prevent you from just using