Re: Test Failures on erc32 (sis)

2016-12-02 Thread Chris Johns
On 2/12/16 8:25 pm, Sebastian Huber wrote:
> 
> Should we add some warning message for non-SMP SPARC that this test
> intentionally fails?
> 

I think we need to have something in the testsuite to manage expected
fails. I think adding specific BSP checks into tests is the wrong way to go.

Chris
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel


Re: Test Failures on erc32 (sis)

2016-12-02 Thread Sebastian Huber



On 02/12/16 11:10, Jiri Gaisler wrote:


On 01/12/16 17:43, Joel Sherrill wrote:

Hi

erc32 has a couple of test failures on master:


*** BEGIN OF TEST PSXSPIN 1 ***
pthread_spin_init( &spinlock, PTHREAD_PROCESS_PRIVATE ) -- OK
pthread_spin_destroy( &spinlock ) -- OK
pthread_spin_init( &spinlock, PTHREAD_PROCESS_SHARED ) -- OK
pthread_spin_destroy( &spinlock ) -- OK
pthread_spin_init( &spinlock, 0x1234 ) -- OK
pthread_spin_init( &spinlock2, 0 ) -- OK
pthread_spin_lock( &spinlock ) -- OK
Unexpected trap ( 9) at address 0x02008758
data access exception at 0x0008


*** BEGIN OF TEST SPCONTEXT 1 ***
Test configuration N N N... done
Test configuration N N F...
../../../../../../../rtems/c/src/../../testsuites/sptests/spcontext01/init.c:
44 0

I have not had a chance to check other BSPs yet.

Thanks.

--joel


Could it be a gcc/binutils problem? Software trap 5 is called to set/get
the interrupt level of a spinlock, but RTEMS's sparc.h does not mention
this trap at all. In old SunOS, software trap 5 (0x85) was 'range
check', whatever that meant ...


No, this was a NULL pointer access:

https://git.rtems.org/rtems/commit/?id=aadd318cd92e42839cf86260e1085f2953113180

GCC generates a trap 5 instruction in case it detects certain kinds of 
undefined behaviour, e.g.


void f(void)
{
  int *i = 0;
  *i = 0;
}

sparc-rtems4.12-gcc -S -O2 -o - test.c
.file   "test.c"
.section".text"
.align 4
.global f
.type   f, #function
.proc   020
f:
st  %g0, [%g0+0]
ta  5
.size   f, .-f
.ident  "GCC: (GNU) 6.1.1 20160526"

--
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail  : sebastian.hu...@embedded-brains.de
PGP : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel


Re: Test Failures on erc32 (sis)

2016-12-02 Thread Jiri Gaisler


On 01/12/16 17:43, Joel Sherrill wrote:
> Hi
>
> erc32 has a couple of test failures on master:
>
>
> *** BEGIN OF TEST PSXSPIN 1 ***
> pthread_spin_init( &spinlock, PTHREAD_PROCESS_PRIVATE ) -- OK
> pthread_spin_destroy( &spinlock ) -- OK
> pthread_spin_init( &spinlock, PTHREAD_PROCESS_SHARED ) -- OK
> pthread_spin_destroy( &spinlock ) -- OK
> pthread_spin_init( &spinlock, 0x1234 ) -- OK
> pthread_spin_init( &spinlock2, 0 ) -- OK
> pthread_spin_lock( &spinlock ) -- OK
> Unexpected trap ( 9) at address 0x02008758
> data access exception at 0x0008
>
>
> *** BEGIN OF TEST SPCONTEXT 1 ***
> Test configuration N N N... done
> Test configuration N N F...
> ../../../../../../../rtems/c/src/../../testsuites/sptests/spcontext01/init.c:
> 44 0
>
> I have not had a chance to check other BSPs yet.
>
> Thanks.
>
> --joel
>

Could it be a gcc/binutils problem? Software trap 5 is called to set/get
the interrupt level of a spinlock, but RTEMS's sparc.h does not mention
this trap at all. In old SunOS, software trap 5 (0x85) was 'range
check', whatever that meant ...


 2008750:81 c3 e0 08 retl
 2008754:90 10 20 00 clr  %o0
the_spinlock->interrupt_state = level;
 2008758:c0 20 20 08 clr  [ 8 ]
 200875c:91 d0 20 05 ta  5

02008760 :
{
  POSIX_Spinlock_Control *the_spinlock;
  ISR_Level   level;

  the_spinlock = _POSIX_Spinlock_Get( lock );
  level = the_spinlock->interrupt_state;
 2008760:c2 00 20 08 ld  [ 8 ], %g1
 2008764:91 d0 20 05 ta  5

Jiri.

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel


Re: Test Failures on erc32 (sis)

2016-12-02 Thread Sebastian Huber

On 01/12/16 17:43, Joel Sherrill wrote:

Hi

erc32 has a couple of test failures on master:


*** BEGIN OF TEST PSXSPIN 1 ***
pthread_spin_init( &spinlock, PTHREAD_PROCESS_PRIVATE ) -- OK
pthread_spin_destroy( &spinlock ) -- OK
pthread_spin_init( &spinlock, PTHREAD_PROCESS_SHARED ) -- OK
pthread_spin_destroy( &spinlock ) -- OK
pthread_spin_init( &spinlock, 0x1234 ) -- OK
pthread_spin_init( &spinlock2, 0 ) -- OK
pthread_spin_lock( &spinlock ) -- OK
Unexpected trap ( 9) at address 0x02008758
data access exception at 0x0008


Sorry, I fixed this.




*** BEGIN OF TEST SPCONTEXT 1 ***
Test configuration N N N... done
Test configuration N N F... 
../../../../../../../rtems/c/src/../../testsuites/sptests/spcontext01/init.c: 
44 0


This is:

https://lists.rtems.org/pipermail/devel/2015-October/012729.html

Should we add some warning message for non-SMP SPARC that this test 
intentionally fails?




I have not had a chance to check other BSPs yet.

Thanks.

--joel


___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel


--
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail  : sebastian.hu...@embedded-brains.de
PGP : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.

___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel


Test Failures on erc32 (sis)

2016-12-01 Thread Joel Sherrill
Hi

erc32 has a couple of test failures on master:


*** BEGIN OF TEST PSXSPIN 1 ***
pthread_spin_init( &spinlock, PTHREAD_PROCESS_PRIVATE ) -- OK
pthread_spin_destroy( &spinlock ) -- OK
pthread_spin_init( &spinlock, PTHREAD_PROCESS_SHARED ) -- OK
pthread_spin_destroy( &spinlock ) -- OK
pthread_spin_init( &spinlock, 0x1234 ) -- OK
pthread_spin_init( &spinlock2, 0 ) -- OK
pthread_spin_lock( &spinlock ) -- OK
Unexpected trap ( 9) at address 0x02008758
data access exception at 0x0008


*** BEGIN OF TEST SPCONTEXT 1 ***
Test configuration N N N... done
Test configuration N N F...
../../../../../../../rtems/c/src/../../testsuites/sptests/spcontext01/init.c:
44 0

I have not had a chance to check other BSPs yet.

Thanks.

--joel
___
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel