[developer] Re: [openzfs/openzfs] 8648 Fix range locking in ZIL commit codepath (#462)

2017-09-11 Thread Jorgen Lundman
It is probably not related, and perhaps not even worth mentioning. But due to deadlocks in OsX version from zget and rangelock in `zfs_get_data()` we now call both zget and rangelock in `zil_lwb_commit()` before passing them into `zilog->zl_get_data()`. But I don't think you are dealing with

[developer] Re: [openzfs/openzfs] 7584 Improve 'zpool labelclear' command (#424)

2017-09-11 Thread Matthew Ahrens
@martymac I'll take a look at your latest changes. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/424#issuecomment-328663255 --

[developer] Re: [openzfs/openzfs] 7584 Improve 'zpool labelclear' command (#424)

2017-09-11 Thread Ganael Laplanche
Compilation warnings have been fixed and all checks have passed. @ahrens @rmustacc @yuripv Do you have additional comments regarding that PR ? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[developer] Re: [openzfs/openzfs] 8648 Fix range locking in ZIL commit codepath (#462)

2017-09-11 Thread Andriy Gapon
CC @amotin -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/462#issuecomment-328561141 -- openzfs-developer Archives:

[developer] Re: [openzfs/openzfs] 8520 lzc_rollback_to should support rolling back to origin (#434)

2017-09-11 Thread Andriy Gapon
avg-I commented on this pull request. > + * See if the snapshot is a snapshot of the filesystem +* or the snapshot is an origin of the filesystem. +*/ + if (snapds->ds_dir == ds->ds_dir || +

[developer] Re: [openzfs/openzfs] 8648 Fix range locking in ZIL commit codepath (#462)

2017-09-11 Thread Prakash Surya
I just pushed a new revision, and want to make the folks aware of the differences between this revision and the Linux patch (this is copied from the commit message): 1. This port doesn't pull over the new "zfstest" test that was added to Linux. I wasn't able to get the test script to

[developer] Re: [openzfs/openzfs] 8520 lzc_rollback_to should support rolling back to origin (#434)

2017-09-11 Thread Andriy Gapon
avg-I commented on this pull request. - dsl_dataset_name(ds->ds_prev, namebuf); - if (strcmp(namebuf, ddra->ddra_tosnap) != 0) - return (SET_ERROR(EXDEV)); + /* Check if the target snapshot exists at all. */ + error =

[developer] Re: [openzfs/openzfs] 8372 sync and async zio-s share the same task queues (#438)

2017-09-11 Thread Andriy Gapon
avg-I commented on this pull request. > @@ -1417,6 +1417,13 @@ zio_taskq_dispatch(zio_t *zio, zio_taskq_type_t q, > boolean_t cutinline) spa_t *spa = zio->io_spa; zio_type_t t = zio->io_type; int flags = (cutinline ? TQ_FRONT : 0); + zio_priority_t p =

Re: [developer] Re: [openzfs/openzfs] 0000 Fix range locking in ZIL commit codepath (#462)

2017-09-11 Thread Igor Kozhukhov
it is the same with mine on DilOS with non-DEBUG build. -Igor > On Sep 11, 2017, at 4:37 PM, Prakash Surya wrote: > > here's some info from a crash on a non-debug delphix/illumos system (i.e. > with ASSERTs turned off): > {noformat} > > ::status > debugging crash

[developer] Re: [openzfs/openzfs] Merge remote-tracking branch 'illumos/master' into illumos-sync (#463)

2017-09-11 Thread Prakash Surya
prakashsurya approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/463#pullrequestreview-61819748 -- openzfs-developer

[developer] Re: [openzfs/openzfs] 0000 Fix range locking in ZIL commit codepath (#462)

2017-09-11 Thread LOLi
I'm sorry, i forgot to report here that "_panic: allocating allocated segment_" is the same bug happening on non-debug builds. I only have a debug build of Illumos, but the troubleshooting was originally done to fix https://github.com/zfsonlinux/zfs/issues/6315 which is a non-debug ZFSonLinux

[developer] Re: [openzfs/openzfs] 0000 Fix range locking in ZIL commit codepath (#462)

2017-09-11 Thread Andriy Gapon
I have a report from a FreeBSD user that 7578 caused a problem for him and that the change in this PR fixes it. His panic was different from what was reported here. He got "zfs: allocating allocated segment" in this stack: ``` (kgdb) backtrace #0 doadump (textdump=1) at pcpu.h:222 #1

[developer] neext help with CTF

2017-09-11 Thread Igor Kozhukhov
Hi All, i need help wirth CTF All worked well - i checked my older builds by gcc5 and i was able to see data in: echo "::spa" | mdb -k but right now it is failed with: root@dilos-t2:/export# echo "::spa" | mdb -k ADDR STATE NAME