[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-04-10 Thread Jorgen Lundman
@lundman pushed 1 commit. bf72974 Correct manpage for --raw -- You are receiving this because you are subscribed to this thread. View it on GitHub: https://github.com/openzfs/openzfs/pull/489/files/097d997308675d4d2387d5bb8a786fb09a189dfc..bf72974e371a6b1d097024f7cb567e9ea78fa65b

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-04-10 Thread Jorgen Lundman
Not sure I'm seeing it. The difference to ZOL is that they have `zfs_main.c` add ``` #include "libzfs_impl.h" ``` But I can not add that to IllumOS, as none of the -I paths include `libzfs_impl.h` nor `sys/zio.h` - are you suggesting I change Makefiles to add the include path? As for existing

[developer] Re: [openzfs/openzfs] 5882 Temporary Pool Names (#600)

2018-04-10 Thread Matthew Ahrens
How about adding the tests from ZoL? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/600#issuecomment-380263327 -- openzfs: openzfs-developer

[developer] Re: [openzfs/openzfs] 5882 Temporary Pool Names (#600)

2018-04-10 Thread Matthew Ahrens
ahrens approved this pull request. > @@ -136,6 +136,8 @@ zpool_prop_init(void) PROP_READONLY, ZFS_TYPE_POOL, "NAME"); zprop_register_hidden(ZPOOL_PROP_MAXBLOCKSIZE, "maxblocksize", PROP_TYPE_NUMBER, PROP_READONLY, ZFS_TYPE_POOL, "MAXBLOCKSIZE"); +

[developer] Re: [openzfs/openzfs] 9324 zfs-recv can be broken by some ZFS-ioctls (PROPOSAL) (#595)

2018-04-10 Thread Roman Strashkin
Do you mean somehow avoid owning of the corresponding dataset by the IOCTLs that do zfsvfs_create() ? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/595#issuecomment-380171454

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-04-10 Thread Matthew Ahrens
Well, there's an unfortunate precedent of userland (at least libzfs) including sys/zfs headers directly, so we could probably just try to include them here. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[developer] Re: [openzfs/openzfs] 9324 zfs-recv can be broken by some ZFS-ioctls (PROPOSAL) (#595)

2018-04-10 Thread Matthew Ahrens
I just had time for a quick look. Retry with delay is not a great solution. I would want to exhaust all other options before doing that. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[developer] Re: [openzfs/openzfs] 9324 zfs-recv can be broken by some ZFS-ioctls (PROPOSAL) (#595)

2018-04-10 Thread Roman Strashkin
No one is interested? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/595#issuecomment-380120217 -- openzfs: openzfs-developer Permalink:

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-04-10 Thread Jorgen Lundman
Hmm that's defined in `zio.h` but the `cmd`'s tend not to include the sys/zfs* headers directly? Should they be in `zfs_context`? -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[developer] Re: [openzfs/openzfs] 8727 Native data and metadata encryption for zfs (#489)

2018-04-10 Thread GernotS
Problem with 097d997: zfs_main.c: In function 'share_mount_one': zfs_main.c:6072: error: 'ZIO_CRYPT_OFF' undeclared (first use in this function) zfs_main.c:6072: error: (Each undeclared identifier is reported only once zfs_main.c:6072: error: for each function it appears in.) -- You are