@avg-I pushed 1 commit.
d1cd233 ashift seems to be a valid pool property in ZoL but not here
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@avg-I pushed 1 commit.
2d827de perhaps ZoL allows to specify pool name before options but we do not
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
zpool_create_tempname failure is obvious and I am pushing a fix. It seems that
ZoL allows placing a pool name on zpool create command line before options.
E.g., zpool create newpool -o xxx ...
import_rewind_device_replaced is not obvious and I am not sure if it's related
to this merge
Two test failures:
```
Tests with results other than PASS that are unexpected:
FAIL cli_root/zpool_create/zpool_create_tempname (expected PASS)
FAIL cli_root/zpool_import/import_rewind_device_replaced (expected PASS)
```
--
You are receiving this because you are subscribed to this
Most likely yes.
I will test.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/600#issuecomment-387482483
--
openzfs: openzfs-developer
Does this also need to pull in https://github.com/zfsonlinux/zfs/pull/7509 ?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/600#issuecomment-387477230
good idea in general: kill studio lint :) because this one eat a lot of RAM +
swap :)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/600#issuecomment-381636138
@ikozhukhov Thanks. That sounds like a good idea in general; I opened #624 to
do this.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/600#issuecomment-381632061
hey - you have to move TMPDIR to another place from /tmp by:
export TMPDIR=/var/tmp
because /tmp=swapfs and it is depend on SWAP size.
also - add more space to swap
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@avg-I I kicked of another run, and started a run using our internal tests.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/600#issuecomment-381626704
`../port/regex/regcomp.c:1783: fatal error: error writing to
/tmp/nightly.tmpdir.2594/ccLaaq0L.s: No space left on device`
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@avg-I I believe I've fixed the CI failure. Can you rebase onto the latest
master to pick up the fix and trigger a new build/test run?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
How about adding the tests from ZoL?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/600#issuecomment-380263327
--
openzfs: openzfs-developer
ahrens approved this pull request.
> @@ -136,6 +136,8 @@ zpool_prop_init(void)
PROP_READONLY, ZFS_TYPE_POOL, "NAME");
zprop_register_hidden(ZPOOL_PROP_MAXBLOCKSIZE, "maxblocksize",
PROP_TYPE_NUMBER, PROP_READONLY, ZFS_TYPE_POOL, "MAXBLOCKSIZE");
+
Yes, I’ll take a look next week.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/600#issuecomment-379260180
--
openzfs: openzfs-developer
@avg-I pushed 1 commit.
7806e35 address feedback from Steven Hartland
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/openzfs/openzfs/pull/600/files/639a1ca0aedcdcb1931d6c837b3028539b7f9d26..7806e35fe7d016c27e03ca5693a0f7fcef067905
@avg-I pushed 1 commit.
639a1ca fix add_prop_list_default to not ignore poolprop
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
@prakashsurya thank you for the report.
Hmm, the code is this way in ZoL too.
I see two ways of fixing it:
1. remove the parameter
1. pass through the parameter to `add_prop_list` instead of the currently
hardcoded `B_TRUE`
Both approaches should work as all callers of `add_prop_list_default`
@avg-I this is failing lint:
```
"zpool_main.c", line 494: warning: argument unused in function: poolprop in
add_prop_list_default (E_FUNC_ARG_UNUSED)
```
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
@prakashsurya Prakash, no problem and thank you.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/600#issuecomment-378881501
--
openzfs:
20 matches
Mail list logo
