Closed #591 via 61cfa6ec9acd6e55a45409f30b8d921e99e20c57.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/591#event-1577258558
--
openzfs:
I think we can also count @dweeezil and @behlendorf as reviewers.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/591#issuecomment-379005974
--
@ahrens pushed 2 commits.
68c70cf Don't clear ranges beyond end of spacemap
5e8c86f Reasonably limit fault injection mayhem
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
Some minor changes to address feedback from @grwilson, @prashks, and Sara
Hartse.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/591#issuecomment-377409083
@ahrens pushed 2 commits.
998ce25 comments
b5b707e removing vdev can be resilvered
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
behlendorf approved this pull request.
I like it, thanks.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/591#pullrequestreview-107505918
--
I added 2 more commits, which address feedback from @sdimitro and @behlendorf.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/591#issuecomment-376707957
behlendorf requested changes on this pull request.
> + * vdevs. In either case, we try every combination. This ensures that if
+ * a mirror has small silent errors on all of its children, we can still
+ * reconstruct the correct data, as long as those errors are at
+ * sufficiently-separated
@ahrens pushed 1 commit.
5014732 post event
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/openzfs/openzfs/pull/591/files/1f9502999027b1be7e252690a2f179f0e5c59ff4..501473238cfd705ee2ed4b6b3f8c2c0983399eb7
I've added another commit to this which addresses an additional problem with
device removal and mirrors:
Now that we support device removal with mirrors, it's reasonable to change the
pool config while a removal is in progress. E.g. to "zpool attach", "zpool
detach", or automatic spare in /
@ahrens pushed 1 commit.
0e2e20f no repair when readonly
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/openzfs/openzfs/pull/591/files/51e5ea3e26b27f2007876718ae5b6664fa017e2c..0e2e20fd09a283f1e4157f229fd82f462caa411e
ahrens commented on this pull request.
> + if (is->is_child[is->is_good_child].ic_data == NULL) {
+ ret = EIO;
+ goto next;
+ }
+
+ abd_copy_off(zio->io_abd,
+
dweeezil commented on this pull request.
So far, looks good (in the port to ZoL) except for the repair writes happening
for read-only pools.
> + if (is->is_child[is->is_good_child].ic_data == NULL) {
+ ret = EIO;
+
@ahrens I'll look it over and try to get this into the ZoL device evacuation
port this weekend.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/591#issuecomment-373924421
@allanjude @dweeezil Thanks for looking at the previous iteration of this. The
new and improved fix is much more comprehensive but the code is almost entirely
different. Could I ask that you take a look at this too?
--
You are receiving this because you are subscribed to this thread.
Reply
15 matches
Mail list logo
