[developer] Re: [openzfs/openzfs] 9861 Harden ZFS receive against out-of-bounds property values (#630)

2018-10-08 Thread Matthew Ahrens
@allanjude If you click on `Details` next to the failed test, you'll see the error: `"../../common/fs/zfs/dmu_send.c", line 2722: warning: variable may be used before set: drrwr (E_VAR_USED_BEFORE_SET)` -- You are receiving this because you are subscribed to this thread. Reply to this email

[developer] Re: [openzfs/openzfs] 9861 Harden ZFS receive against out-of-bounds property values (#630)

2018-10-02 Thread Allan Jude
Sorry for the build error, it seemed to have crept in when I refactored this -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/630#issuecomment-426450196

[developer] Re: [openzfs/openzfs] 9861 Harden ZFS receive against out-of-bounds property values (#630)

2018-10-02 Thread Allan Jude
allanjude commented on this pull request. > @@ -2669,6 +2678,18 @@ receive_read_record(struct receive_arg *ra) case DRR_WRITE: { struct drr_write *drrw = >rrd->header.drr_u.drr_write; + if (drrw->drr_compressiontype >= ZIO_COMPRESS_FUNCTIONS) +

[developer] Re: [openzfs/openzfs] 9861 Harden ZFS receive against out-of-bounds property values (#630)

2018-10-01 Thread Matthew Ahrens
ahrens approved this pull request. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/630#pullrequestreview-160563120 -- openzfs:

[developer] Re: [openzfs/openzfs] 9861 Harden ZFS receive against out-of-bounds property values (#630)

2018-10-01 Thread Matthew Ahrens
ahrens requested changes on this pull request. > @@ -2644,6 +2644,17 @@ receive_read_record(struct receive_arg *ra) uint32_t size = P2ROUNDUP(drro->drr_bonuslen, 8); void *buf = kmem_zalloc(size, KM_SLEEP); dmu_object_info_t doi; + +

[developer] Re: [openzfs/openzfs] 9861 Harden ZFS receive against out-of-bounds property values (#630)

2018-10-01 Thread Allan Jude
> @allanjude can you open an illumos bug for this? https://www.illumos.org/issues/9861 -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/openzfs/openzfs/pull/630#issuecomment-426119431