[developer] Re: [openzfs/openzfs] 8414 Implemented zpool scrub pause/resume (#407)

2017-07-06 Thread Serapheim Dimitropoulos
sdimitro commented on this pull request. - if (zfs_ioctl(hdl, ZFS_IOC_POOL_SCAN, ) == 0 || - (errno == ENOENT && func != POOL_SCAN_NONE)) + /* ECANCELED on a scrub means we resumed a paused scrub */ Yeah I figured that was the case. I just wanted to ask first. Thank you

[developer] Re: [openzfs/openzfs] 8414 Implemented zpool scrub pause/resume (#407)

2017-07-06 Thread Alek P
alek-p commented on this pull request. > .\" -.Dd Oct 2, 2016 +.Dd June 21, 2016 Thanks, I'll fix that in a couple min. -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub:

[developer] Re: [openzfs/openzfs] 8414 Implemented zpool scrub pause/resume (#407)

2017-07-06 Thread Alek P
alek-p commented on this pull request. - if (zfs_ioctl(hdl, ZFS_IOC_POOL_SCAN, ) == 0 || - (errno == ENOENT && func != POOL_SCAN_NONE)) + /* ECANCELED on a scrub means we resumed a paused scrub */ I agree with you that using errno here isn't the cleanest way to do this.

[developer] Re: [openzfs/openzfs] 8414 Implemented zpool scrub pause/resume (#407)

2017-07-06 Thread Serapheim Dimitropoulos
sdimitro commented on this pull request. LGTM overall. I just have one question and a small nit. > .\" -.Dd Oct 2, 2016 +.Dd June 21, 2016 [nit] 2017 - if (zfs_ioctl(hdl, ZFS_IOC_POOL_SCAN, ) == 0 || - (errno == ENOENT && func != POOL_SCAN_NONE)) + /* ECANCELED on a