ikozhukhov approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/564#pullrequestreview-99154096
--
openzfs-developer
Looks good to me.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/564#issuecomment-368339063
--
openzfs-developer
Archives:
@prakashsurya pushed 1 commit.
58cca80 Require BUILD_VERSION in nightly-build.sh
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
I can live with this.
Rather than having 3 userspace taskq implementations (the one in libzpool,
libfakekernel and libutaskq) we now have 2 (one in libfakekernel and one in
libzfs). That's an improvement.
--
You are receiving this because you are subscribed to this thread.
Reply to this
Thanks @gwr.
I was planning to have libzpool continue to use the taskq implementation in
libfakekernel, and only have libzfs use this new implementation (since we don't
want libzfs to use the libfakekernel one). Does that sound OK to you?
I appreciate the input. I'll try and get a cleaned up
gwr commented on this pull request.
I didn't look in detail, but the approach looks reasonable.
Is utaskq.c also used in libzpool? Or was you plan to use it both places? I
don't see changes for that.
--
You are receiving this because you are subscribed to this thread.
Reply to this email
You can view, comment on, or merge this pull request online at:
https://github.com/openzfs/openzfs/pull/574
-- Commit Summary --
* Reboot and verify kernel version after upgrade
-- File Changes --
M Jenkinsfile (13)
M jenkins/pipelines/verify_illumos_commits.groovy (6)
M
