Closed #435.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/435#event-1239343195
--
openzfs-developer
Archives:
```
22:35:26.71 NOTE: Create a volume device of desired sizes: 2eb
```
I don't think the output
buffer is too small, and if it is, substituting the longer string ``
wouldn't be the right solution :-)
It looks like it's trying to create a 2EB pool, and your code is handling up to
`E`, so it
Hmm.. some reason my original comment didn't get posted. I found the error, I
just need to figure out what the values were that triggered the overflow (I'll
dig into the test itself this afternoon and see what I can figure out on that).
I suspect what might be happening is that the output
```
22:35:27.19 testpool 872K - 0% 0%
1.00x ONLINE -
```
That seems like a change in behavior that you'll need to investigate. IIRC,
the zfs_nicenum() just takes a uint64_t, so it shouldn't be possible for it to
overflow.
--
You are receiving this because you are
generally, I only worry about the tests listed in the last section; i.e.
```
Tests with results other than PASS that are unexpected:
FAIL largest_pool/largest_pool_001_pos (expected PASS)
```
if there's any tests listed here, it'll cause the test to report a failure; the
other sections are
The output is somewhat confusing -- it suggests there are a number of tests
that are passing that it expected it not to pass?? Does that mean all of those
are a problem?
There does look to be one test that's failing - FAIL
largest_pool/largest_pool_001_pos (expected PASS)
-- but I cannot find
@jasonbking that's exactly what you had to do, no need for new PR.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/435#issuecomment-319090181
--
I've rebased it off openzfs/master and pushed it back to my fork (had to push
-f though) -- though I'm not sure what needs to happen (if anything) for the PR
to update (or if I'd need to just create a new one).
--
You are receiving this because you are subscribed to this thread.
Reply to this
@jasonbking can you rebase (e.g. using `git rebase`) or merge (e.g. using `git
merge`) these patches with the openzfs codebase? we maintain a `jenkins`
directory in the openzfs repository that doesn't exist in illumos-gate, and the
lack of that directory is causing the build/test failure.
I
