Closed #222 via 468008cba949f0fe6a2c79e7510a9cd230bd0e1d.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/222#event-1334183945
--
prakashsurya approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/222#pullrequestreview-71054599
--
openzfs-developer
Any idea when this tiny patch will be merged ?
Thank you very much
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/222#issuecomment-338464850
Thank you Matt
I'm really glad :)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/222#issuecomment-324652140
--
openzfs-developer
Archives:
benrubson commented on this pull request.
> @@ -347,6 +347,12 @@ boolean_t dbuf_is_metadata(dmu_buf_impl_t *db);
(dbuf_is_metadata(_db) && \
((_db)->db_objset->os_secondary_cache == ZFS_CACHE_METADATA)))
Not sure then I really see how to
ahrens approved this pull request.
It would be nice to clean up DBUF_IS_L2CACHEABLE so that the logic isn't
duplicated with DBUF_IS_L2CACHEABLE_IMPL, but I won't make that a requirement.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view
> l2arc_noprefetch=0 is useless because prefetched buffers are not
> ARC_FLAG_L2CACHE flagged
If a buffer is prefetched but not hit, it will not be L2ARC eligible, because
it will not be flagged accordingly, so l2arc_noprefetch=0 has no effect on this
buffer here
I agree; I'll accept this PR
ahrens commented on this pull request.
> @@ -347,6 +347,12 @@ boolean_t dbuf_is_metadata(dmu_buf_impl_t *db);
(dbuf_is_metadata(_db) && \
((_db)->db_objset->os_secondary_cache == ZFS_CACHE_METADATA)))
I guess that doesn't really work (it
Test passed, thank you for having launched it @prakashsurya
I'm pretty convinced prefetched buffers should be `ARC_FLAG_L2CACHE` flagged
(what this PR currently does), as `l2arc_noprefetch` user tunable will then
control whether or not these buffers can be L2 backed.
This gives a nice
@prakashsurya could you restart the test please ? Many thx
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/222#issuecomment-322043862
--
10 matches
Mail list logo
