Re: [developer] Fix for "illumos#3821 Race in rollback, zil close, and zil flush" is incomplete

2017-08-21 Thread Prakash Surya
Sounds good. I'll sync up with George. Thanks! On Mon, Aug 21, 2017 at 8:02 AM, Jerry Jelinek wrote: > Hi Prakash, > > We have only seen this panic one time since the original fix was > integrated into illumos. I have no way to properly test your new change or >

Re: [developer] Fix for "illumos#3821 Race in rollback, zil close, and zil flush" is incomplete

2017-08-21 Thread Jerry Jelinek
Hi Prakash, We have only seen this panic one time since the original fix was integrated into illumos. I have no way to properly test your new change or reproduce the problem from this bug. I have been working with George Wilson to try to get him access to the dump for debugging. Maybe the best

Re: [developer] Fix for "illumos#3821 Race in rollback, zil close, and zil flush" is incomplete

2017-08-21 Thread Prakash Surya
Hi Jerry, Would it be possible for you to try out the patch contained here: https://github.com/openzfs/openzfs/pull/421 ? A direct link to the diff (as opposed the review/comments) is here: https://patch-diff.githubusercontent.com/raw/openzfs/openzfs/pull/421.diff When developing that change, I

[developer] Fix for "illumos#3821 Race in rollback, zil close, and zil flush" is incomplete

2017-08-11 Thread Jerry Jelinek
I just opened the following bug on illumos: https://www.illumos.org/issues/8574 I don't have enough zfs knowledge to know if the fix we had been using for this bug prior to the integration of illumos#3821 is the best way forward here, or if there is something better. I'd be interested to hear