This is not ready to go yet.
I still haven't updated the code with the restructuring from ZoL. There is a
kstat memory leak that I need to narrow down in the new code before updating
this. Sorry for the delay.
--
You are receiving this because you are subscribed to this thread.
Reply to this
ahrens commented on this pull request.
> @@ -92,124 +93,146 @@
* growth all other writers and readers must be excluded.
sure thing.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
ahrens commented on this pull request.
> - */
- if (new->r_type == RL_APPEND)
- new->r_off = zp->z_size;
-
- /*
-* If we need to grow the block size then grab the whole
-
@ahrens pushed 1 commit.
ce2975a add comments
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/openzfs/openzfs/pull/680/files/0aef34ea20590747caece45b2aa12c3e71a9d2a4..ce2975a02af44d8eb198703b1978f123a4af4bd0
@waikontse pushed 1 commit.
c36b758 Update code formatting and comments
--
You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/openzfs/openzfs/pull/685/files/bbc5f9c450496aacd33228c59a5e9c3addaa216c..c36b7580a0a0875ad8f7548099b47898cdfbf891
ahrens approved this pull request.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/685#pullrequestreview-160900425
--
openzfs:
At this year's OpenZFS Developer Conference, we decided we should have more
regular meetings to coordinate activities across all the platforms. The
first meeting will be held *October 9th, 1:00-1:30pm Pacific time*, and we
plan to hold this every 4 weeks thereafter. Everyone is welcome to attend
allanjude commented on this pull request.
> @@ -2669,6 +2678,18 @@ receive_read_record(struct receive_arg *ra)
case DRR_WRITE:
{
struct drr_write *drrw = >rrd->header.drr_u.drr_write;
+ if (drrw->drr_compressiontype >= ZIO_COMPRESS_FUNCTIONS)
+
Sorry for the build error, it seemed to have crept in when I refactored this
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/openzfs/openzfs/pull/630#issuecomment-426450196
Thanks @behlendorf. I think the potential issue with cv_destroy() is out of
scope for this change, which isn't really touching that (just renaming the cv
that it's operating on). I agree that if conflicting changes were made in ZoL,
you'll want to keep the ZoL version and just change the
behlendorf approved this pull request.
Looks good. While reviewing I took the opportunity to [port this to
Linux](https://github.com/zfsonlinux/zfs/pull/7980).
My only concern is the use of the `cv_broadcast(); cv_destroy();` construct.
This was always dodgy because once `cv_destroy()` was
internal tests:
http://platform.jenkins.delphix.com/job/devops-gate/job/master/job/zfs-precommit/3784/flowGraphTable/
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
I've updated the code to pull in
https://github.com/zfsonlinux/zfs/commit/1258bd778e8279a4cd051543827f333fe2daed76.
@sdimitro could you take another look at this?
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
sdimitro approved this pull request.
I just found one minor nit. Code LGTM.
Are there any plans of doing any extra testing for this in illumos?
> - * majority of segment copies are good. This allows all the segment copies to
- * participate fairly in the reconstruction and prevents the repeated
@brad-lewis I've addressed the code review feedback and rebased this. If you
need to update your branch, be sure to pull down the new version first.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
waikontse commented on this pull request.
> @@ -392,6 +392,22 @@ static int
dump_freeobjects(dmu_sendarg_t *dsp, uint64_t firstobj, uint64_t numobjs)
{
struct drr_freeobjects *drrfo = &(dsp->dsa_drr->drr_u.drr_freeobjects);
+ uint64_t maxobj = DNODES_PER_BLOCK *
+
16 matches
Mail list logo
